Re: [PATCH 3/3] test: add emacs test for hiding a message following an HTML part

On Mon, 03 Oct 2011 14:39:36 +0200, Thomas Jost schno...@schnouki.net wrote: Non-text part: multipart/signed About adding prereqs to the test suite -- in my private branch I have a rebased and fixed version of the patch series sent by Pieter Praet [1]. It worked fine last time I tested it on

[PATCH 01/13] test: define a helper function for defining prereqs on executables

While test_expect_success could be used to define these prereqs, this is probably not a good idea: if a prereq is not available, using test_expect_success would result in a test being reported as FAILED at the end of the test suite (and its dependencies as skipped). On the contrary, when using

[PATCH 00/13] Test prereqs and screen-based Emacs tests

Here it is: a rebased version of Pieter's patch series adding prereqs for the emacs and crypto tests [1], and Dmitry's patches for running emacs inside screen in the test suite [2]. (Please note that this one also includes fixes to improve hidden signatures handling in

[PATCH 02/13] test: add 'GnuPG' prereq to dependent 'crypto' tests

From: Pieter Praet pie...@praet.org Adds a new test that checks for the presence of 'gpg', and adds that test as a prereq to all subsequent tests that rely on GnuPG. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet pie...@praet.org --- test/crypto | 35

[PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests

From: Pieter Praet pie...@praet.org Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet pie...@praet.org --- test/emacs | 71

[PATCH 03/13] test: add 'Emacs' prereq to dependent 'crypto' tests

From: Pieter Praet pie...@praet.org Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Right now, all crypto tests do depend on Emacs, because it is used to

[PATCH 05/13] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests

From: Pieter Praet pie...@praet.org Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet pie...@praet.org ---

[PATCH 06/13] test: run emacs inside screen

From: Dmitry Kurochkin dmitry.kuroch...@gmail.com Before the change, emacs run in daemon mode without any visible buffers. Turns out that this affects emacs behavior in some cases. In particular, `window-end' function returns `point-max' instead of the last visible position. That makes it hard

[PATCH 07/13] test: avoid using screen(1) configuration files

From: Dmitry Kurochkin dmitry.kuroch...@gmail.com Set SCREENRC and SYSSCREENRC environment variables to /dev/null as suggested by Jim Paris to avoid potential problems with screen(1) configuration files. --- test/test-lib.sh |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

Re: [PATCH v1 1/1] lib: make find_message{, by_filename) report errors

Austin Clements yazmış: All of the code looks good to me (and improving error handling is always a good thing). Some style nits are inline below. Thanks for the review, comments below and a new set of patches follow... The changes to _resolve_message_id_to_thread_id and

[PATCH v2 0/2] Better error handling

From: Ali Polatel a...@exherbo.org New set of patches addressing the issues in the mail id:20111003174308.gd17...@mit.edu Ali Polatel (2): lib: destroy message object after message removal lib: make find_message{,by_filename) report errors lib/database.cc | 95

[PATCH v2 1/2] lib: destroy message object after message removal

From: Ali Polatel a...@exherbo.org notmuch_database_remove_message() must call notmuch_message_destroy() once it is done handling message removal. --- lib/database.cc |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index

Re: [PATCH v2 0/2] Better error handling

Ali Polatel yazmış: From: Ali Polatel a...@exherbo.org New set of patches addressing the issues in the mail id:20111003174308.gd17...@mit.edu You may also find the commits in my notmuch repository: git://github.com/alip/notmuch.git branch: find_message-v2 Ali Polatel (2): lib: destroy

Re: [PATCH v2 0/2] Better error handling

LGTM. Quoth Ali Polatel on Oct 03 at 11:40 pm: From: Ali Polatel a...@exherbo.org New set of patches addressing the issues in the mail id:20111003174308.gd17...@mit.edu Ali Polatel (2): lib: destroy message object after message removal lib: make find_message{,by_filename) report

Re: [RFC/PATCH] notmuch link

Ali Polatel yazmış: From: Ali Polatel a...@exherbo.org Hello, I have been working on a new notmuch command namely 'link'. This command aims to help integrating notmuch with different mail agents. Basically it (sym)links messages matching the given search terms to the specified target maildir.

Re: [PATCH] lib: make find_message{,by_filename) report errors

On Sat, 1 Oct 2011 11:12:23 +0300, Ali Polatel pola...@gmail.com wrote: From: Ali Polatel a...@exherbo.org Looks like the patch did not make it correctly the first time. Resending using git-send-email™ You may also find the commit in my notmuch repository:

Re: [PATCH] lib: make find_message{,by_filename) report errors

David Bremner yazmış: On Sat, 1 Oct 2011 11:12:23 +0300, Ali Polatel pola...@gmail.com wrote: From: Ali Polatel a...@exherbo.org Looks like the patch did not make it correctly the first time. Resending using git-send-email™ You may also find the commit in my notmuch repository:

[PATCH v3 0/2] Better error handling

From: Ali Polatel a...@exherbo.org New set of patches addressing the issues in the mail id:8739f9muhp.fsf@zancas.localnet You may also find the commits in my notmuch repository: git://github.com/alip/notmuch.git branch: find_message-v3 Ali Polatel (2): lib: destroy message object after

[PATCH v3 1/2] lib: destroy message object after message removal

From: Ali Polatel a...@exherbo.org notmuch_database_remove_message() must call notmuch_message_destroy() once it is done handling message removal. --- lib/database.cc |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index

notmuch and git

I know that having an exclude option for notmuch has been discussed a number of times. I have wanted such a feature to be able to ignore the .git directroy, since I keep my mail in a git repository. I recently discovered a workaround. If you make .git a text file containing = .git

Re: [PATCH v1 1/1] lib: make find_message{,by_filename) report errors

All of the code looks good to me (and improving error handling is always a good thing). Some style nits are inline below. The changes to _resolve_message_id_to_thread_id and _notmuch_database_link_message_to_parents seem like just plain better error handling and unrelated to the find_message API

[PATCH v3 2/2] lib: make find_message{,by_filename) report errors

From: Ali Polatel a...@exherbo.org Previously, the functions notmuch_database_find_message() and notmuch_database_find_message_by_filename() functions did not properly report error condition to the library user. For more information, read the thread on the notmuch mailing list starting with my

Re: [PATCH v3 0/2] Better error handling

On Tue, 4 Oct 2011 08:06:07 +0300, Ali Polatel pola...@gmail.com wrote: From: Ali Polatel a...@exherbo.org New set of patches addressing the issues in the mail id:8739f9muhp.fsf@zancas.localnet You may also find the commits in my notmuch repository: git://github.com/alip/notmuch.git

[PATCH 08/13] test: do not set frame width in emacs

From: Dmitry Kurochkin dmitry.kuroch...@gmail.com No need for `set-frame-width' in emacs tests since it runs in screen now. --- test/test-lib.el |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/test/test-lib.el b/test/test-lib.el index a783936..97ae593 100644 ---

[PATCH 09/13] test: `notmuch-show-advance-and-archive' with invisible signature

From: Dmitry Kurochkin dmitry.kuroch...@gmail.com Add Emacs test to check that `notmuch-show-advance-and-archive' works for the last message in thread with invisible signature. --- test/emacs | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/test/emacs

[PATCH 10/13] emacs: improve hidden signatures handling in notmuch-show-advance-and-archive

From: Dmitry Kurochkin dmitry.kuroch...@gmail.com Use `previous-single-char-property-change' instead of going through each character by hand and testing it's visibility. This fixes `notmuch-show-advance-and-archive' to work for the last message in thread with hidden signature. ---

[PATCH 11/13] emacs: remove no longer used functions from notmuch-show.el

From: Dmitry Kurochkin dmitry.kuroch...@gmail.com Remove `notmuch-show-move-past-invisible-backward' and `notmuch-show-move-past-invisible-forward' functions which are unused. --- emacs/notmuch-show.el |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git

[PATCH 12/13] emacs: remove unused `point-invisible-p' function

From: Dmitry Kurochkin dmitry.kuroch...@gmail.com `point-invisible-p' does not work correctly when `invisible' property is a list. There are standard `invisible-p' and related functions that should be used instead. --- emacs/notmuch-lib.el | 15 --- 1 files changed, 0

0.9 release plans

Hi All; I originally tagged 0.9~rc1 on the idea of getting back to a first of the month release for 0.9, but that didn't happen because I wanted to get the notmuch_database_find_message* API changes from alip in. So let's try for a freeze this Friday and a release around Oct. 10 (Canadian

Re: Concerns regarding some library functions

On Thu, 29 Sep 2011 16:15:36 -0400, Austin Clements amdra...@mit.edu wrote: With symbol versioning we'd still provide the old function (presumably re-implemented in terms of the new function). Both would wind up in the .so and old binaries would still link against the old symbol. It doesn't

[PATCH 13/13] test: make smtp-dummy work with Emacs 24

In Emacs 24, a space is expected after a SMTP response code. If we don't respect that, smtpmail-send-it will wait forever. --- test/smtp-dummy.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/smtp-dummy.c b/test/smtp-dummy.c index 9da8202..021af11 100644 ---

[PATCH v1 0/1] lib: make find_message{,by_filename) report errors

Here is an updated patch fixing style issues addressed by amdragon on IRC. I plan to submit a patch documenting how to configure VIM to code using notmuch's style guidelines as well. You may also find the commit in my notmuch repository: git://github.com/alip/notmuch.git branch: find_message-v1

Re: Concerns regarding some library functions

On Tue 04 Oct 2011 14:18, David Bremner da...@tethera.net writes: So I've pushed the ABI changes, making it more urgent to do something about this. At this point I'm inclined to bump the soname in order to unbreak things, unless someone wants to come up with a convincing set of patches to

Re: notmuch and git

On Mon, Oct 3, 2011 at 11:38, Tom Prince tom.pri...@ualberta.net wrote: I know that having an exclude option for notmuch has been discussed a number of times. I have wanted such a feature to be able to ignore the .git directroy, since I keep my mail in a git repository. I recently discovered a

libnotmuch SONAME bumped

On Tue, 04 Oct 2011 08:18:21 -0300, David Bremner da...@tethera.net wrote: So I've pushed the ABI changes, making it more urgent to do something about this. At this point I'm inclined to bump the soname in order to unbreak things, unless someone wants to come up with a convincing set of

python: unpythonic result of Message.get_replies()

Hi everyone :) I noticed that Message.get_replies() returns a Messages object *or* None. Quoting the documentation: Returns: Messages or None if there are no replies to this message Messages is a class implementing the iterator protocol, so a python programmer would expect to get an iterator

[PATCH v1 1/1] lib: make find_message{, by_filename) report errors

Austin Clements yazm??: >All of the code looks good to me (and improving error handling is >always a good thing). Some style nits are inline below. Thanks for the review, comments below and a new set of patches follow... >The changes to _resolve_message_id_to_thread_id and

[PATCH v2 2/2] lib: make find_message{,by_filename) report errors

From: Ali Polatel Previously, the functions notmuch_database_find_message() and notmuch_database_find_message_by_filename() functions did not properly report error condition to the library user. For more information, read the thread on the notmuch mailing list starting with my

[PATCH v2 1/2] lib: destroy message object after message removal

From: Ali Polatel notmuch_database_remove_message() must call notmuch_message_destroy() once it is done handling message removal. --- lib/database.cc |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index

[PATCH v2 0/2] Better error handling

Ali Polatel yazm??: >From: Ali Polatel > >New set of patches addressing the issues in the mail >"id:20111003174308.GD17905 at mit.edu" You may also find the commits in my notmuch repository: git://github.com/alip/notmuch.git branch: find_message-v2 >Ali Polatel (2): > lib: destroy message

[RFC/PATCH] notmuch link

(-) > create mode 100644 maildir.c > create mode 100644 maildir.h > create mode 100644 notmuch-link.c > >-- >1.7.6.1 > -alip -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111004/61e0610f/attachment.pgp>

[PATCH] lib: make find_message{,by_filename) report errors

s trying to address. Reverted. >David > > -alip -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111004/940ff67d/attachment.pgp>

[PATCH v3 0/2] Better error handling

From: Ali Polatel New set of patches addressing the issues in the mail "id:8739f9muhp.fsf at zancas.localnet" You may also find the commits in my notmuch repository: git://github.com/alip/notmuch.git branch: find_message-v3 Ali Polatel (2): lib: destroy message object after

[PATCH v3 1/2] lib: destroy message object after message removal

From: Ali Polatel notmuch_database_remove_message() must call notmuch_message_destroy() once it is done handling message removal. --- lib/database.cc |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index

[PATCH v3 2/2] lib: make find_message{,by_filename) report errors

From: Ali Polatel Previously, the functions notmuch_database_find_message() and notmuch_database_find_message_by_filename() functions did not properly report error condition to the library user. For more information, read the thread on the notmuch mailing list starting with my

[PATCH v3 0/2] Better error handling

On Tue, 4 Oct 2011 08:06:07 +0300, Ali Polatel wrote: > From: Ali Polatel > > New set of patches addressing the issues in the mail > "id:8739f9muhp.fsf at zancas.localnet" > > You may also find the commits in my notmuch repository: > git://github.com/alip/notmuch.git branch: find_message-v3 >

0.9 release plans

Hi All; I originally tagged 0.9~rc1 on the idea of getting back to a first of the month release for 0.9, but that didn't happen because I wanted to get the notmuch_database_find_message* API changes from alip in. So let's try for a freeze this Friday and a release around Oct. 10 (Canadian

Concerns regarding some library functions

On Thu, 29 Sep 2011 16:15:36 -0400, Austin Clements wrote: > With symbol versioning we'd still provide the old function (presumably > re-implemented in terms of the new function). Both would wind up in > the .so and old binaries would still link against the old symbol. It > doesn't help that

Concerns regarding some library functions

On Tue 04 Oct 2011 14:18, David Bremner writes: > > So I've pushed the ABI changes, making it more urgent to do something > about this. At this point I'm inclined to bump the soname in order to > unbreak things, unless someone wants to come up with a convincing set of > patches to do the symbol

notmuch and git

On Mon, Oct 3, 2011 at 11:38, Tom Prince wrote: > I know that having an exclude option for notmuch has been discussed a > number of times. I have wanted such a feature to be able to ignore the > .git directroy, since I keep my mail in a git repository. I recently > discovered a workaround. > > If

libnotmuch SONAME bumped

On Tue, 04 Oct 2011 08:18:21 -0300, David Bremner wrote: > So I've pushed the ABI changes, making it more urgent to do something > about this. At this point I'm inclined to bump the soname in order to > unbreak things, unless someone wants to come up with a convincing set of > patches to do the