Re: [afew] announcing afew, an universal tagging solution with some fancy features

2011-12-21 Thread Justus Winter
Hey Jamie :) Quoting Jameson Graef Rollins (2011-12-19 18:57:00) On Mon, 19 Dec 2011 15:13:51 +0100, Justus Winter 4win...@informatik.uni-hamburg.de wrote: Is your new tag called 'is:new'? Mine is just called 'new' is: is a search prefix, synonymous with tag: Ah, thanks for the clarification.

Re: [PATCH v2 0/2] emacs: trivial defcustom fixes

2011-12-21 Thread David Edmondson
On Tue, 20 Dec 2011 21:53:12 +0200, Jani Nikula j...@nikula.org wrote: Hi all, v2 of a couple of defcustom fixes. Now with a default value for Custom filter in patch 1/2 as suggested by Dmitry. No other changes. Looks good. dme. -- David Edmondson, http://dme.org pgp6hC3TOkax9.pgp

Re: [afew] announcing afew, an universal tagging solution with some fancy features

2011-12-21 Thread Justus Winter
Hey Pazz, Quoting Patrick Totzke (2011-12-19 19:17:12) Also, should i not get some output when calling afew with -vv ? Yes you should ;). Here's an example run on my box: teythoon@thinkbox ~/repos/afew (git)-[master] % python3.2 bin/afew -vv --tag --new INFO:root:Tagging spam messages

Re: [PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread David Edmondson
On Tue, 20 Dec 2011 16:52:52 -0500, Austin Clements amdra...@mit.edu wrote: Seems like a definite improvement, but perhaps a let* instead of all of the setq's? What would be a lispy approach? I tried: (defun notmuch-subject-to-patch-filename (subject) Convert a typical patch mail subject

patchwork link 404s

2011-12-21 Thread Justus Winter
Hi everyone :) the patchwork instance referenced on notmuchmail.org [0] returns a 404 not found. Cheers, Justus 0: http://patchwork.notmuchmail.org/project/notmuch .signature Description: Binary data ___ notmuch mailing list notmuch@notmuchmail.org

RFC: use the XDG Base Directory Specification for configuration data

2011-12-21 Thread Justus Winter
Hi :) I'd like to propose to store notmuchs configuration in $XDG_CONFIG_HOME/notmuch/config as suggested in the XDG Base Directory Specification [0]. Similarly $XDG_DATA_HOME/nmbug might be a more appropriate location for nmbugs git checkout than ~/.nmbug. Cheers, Justus 0:

Re: RFC: use the XDG Base Directory Specification for configuration data

2011-12-21 Thread David Bremner
On Wed, 21 Dec 2011 12:19:38 +0100, Justus Winter 4win...@informatik.uni-hamburg.de wrote: Hi :) I'd like to propose to store notmuchs configuration in $XDG_CONFIG_HOME/notmuch/config as suggested in the XDG Base Directory Specification [0]. Can you use NOTMUCH_CONFIG to achieve what you

Re: patchwork link 404s

2011-12-21 Thread David Bremner
On Wed, 21 Dec 2011 12:09:50 +0100, Justus Winter 4win...@informatik.uni-hamburg.de wrote: the patchwork instance referenced on notmuchmail.org [0] returns a 404 not found. I'm not sure, maybe Martin retired the patchwork instance. I know that neither Carl nor I used it. If that turns out

Re: S/MIME support in notmuch

2011-12-21 Thread Darren McGuicken
On Wed, 07 Dec 2011 21:58:03 -0500, Dan Bryant dan.bry...@jhuapl.edu wrote: I'd like to report some success on getting S/MIME signature verification working using notmuch and the recently-released GMime 2.6. I specifically tested with notmuch-0.10.2 and gmime-2.6.1. [...] I don't have

Re: [PATCH] emacs: add notmuch-hello-refresh-hook

2011-12-21 Thread David Bremner
On Wed, 21 Dec 2011 02:28:14 +0100, Thomas Jost schno...@schnouki.net wrote: This hook is called every time a notmuch-hello buffer is updated. --- pushed d ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH] emacs: add notmuch-hello-refresh-hook

2011-12-21 Thread David Bremner
On Wed, 21 Dec 2011 02:28:14 +0100, Thomas Jost schno...@schnouki.net wrote: This hook is called every time a notmuch-hello buffer is updated. --- pushed. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: Don't prompt the user to choose from zero matching addresses.

2011-12-21 Thread David Edmondson
If the address matching function generates no matches, don't prompt the user to choose between them (!). Instead, generate a message to report that there were no matches. --- emacs/notmuch-address.el | 21 ++--- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git

Re: python: unpythonic result of Message.get_replies()

2011-12-21 Thread Justus Winter
The attached patch series fixes this problem. Note that the wrapping nature of the notmuch bindings makes it kind of awkward to fix the behavior. I've decided to avoid introducing code to the Messages class to indicate that there are no messages and there is no notmuch object being wrapped, but

[PATCH 2/2] python: make the result of Message.get_replies() more pythonic

2011-12-21 Thread Justus Winter
Formerly Message.get_replies() returned an iterator or None forcing users to check the result before iterating over it leading to strange looking code at the call site. Fix this flaw by adding an EmptyMessagesResult class that behaves like the Messages class but immediatly raises StopIteration if

[PATCH 1/2] python: refactor print_messages into format_messages and print_messages

2011-12-21 Thread Justus Winter
--- bindings/python/notmuch/message.py | 37 +-- 1 files changed, 26 insertions(+), 11 deletions(-) diff --git a/bindings/python/notmuch/message.py b/bindings/python/notmuch/message.py index ce8e718..cc9fc2a 100644 --- a/bindings/python/notmuch/message.py +++

Re: [PATCH] emacs: Don't prompt the user to choose from zero matching addresses.

2011-12-21 Thread Tomi Ollila
On Wed, 21 Dec 2011 12:35:27 +, David Edmondson d...@dme.org wrote: If the address matching function generates no matches, don't prompt the user to choose between them (!). Instead, generate a message to report that there were no matches. --- LGTM emacs/notmuch-address.el | 21

[PATCH 1/2] emacs: rename notmuch-decimal-separator to notmuch-hello-thousands-separator

2011-12-21 Thread Thomas Jost
In 123,456.78, . is the decimal separator, but , is the thousands separator. --- emacs/notmuch-hello.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index f892ff7..ef585ea 100644 --- a/emacs/notmuch-hello.el +++

[PATCH 2/2] emacs: Change the default thousands separator to a space

2011-12-21 Thread Thomas Jost
This had been discussed and decided on IRC. Rationale: Therefore the space is recommended in the SI/ISO 31-0 standard, and the International Bureau of Weights and Measures states that for numbers with many digits the digits may be divided into groups of three by a thin space, in order to

[PATCH] notmuch-addresses: Match on the full name as well as components.

2011-12-21 Thread David Edmondson
--- notmuch_addresses.py |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/notmuch_addresses.py b/notmuch_addresses.py index bf45151..74a743c 100755 --- a/notmuch_addresses.py +++ b/notmuch_addresses.py @@ -164,11 +164,14 @@ class NotmuchAddressMatcher(object):

Re: [PATCH 2/2] emacs: Change the default thousands separator to a space

2011-12-21 Thread Tomi Ollila
On Wed, 21 Dec 2011 14:44:19 +0100, Thomas Jost schno...@schnouki.net wrote: Both patches LGTM. Tomi ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread Austin Clements
I would definitely go with the latter. It might feel less unwieldy with a shorter variable name than filename, since that has to be repeated so many times. (It's also not really a filename in the middle of the replace process.) This is splitting hairs, but in my original suggestion, I was

Re: [PATCH 1/2] emacs: rename notmuch-decimal-separator to notmuch-hello-thousands-separator

2011-12-21 Thread Dmitry Kurochkin
Both patches look good to me. Thanks, Thomas! Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH 1/2] test: add general Emacs hook counter

2011-12-21 Thread Dmitry Kurochkin
Replace `notmuch-hello-mode-hook-counter' with general `hook-counter' and `add-hook-counter' functions to allow counting calls for any hook. --- test/test-lib.el | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/test/test-lib.el b/test/test-lib.el index

[PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

2011-12-21 Thread Dmitry Kurochkin
Test that `notmuch-hello-refresh-hook' is called once when `notmuch-hello' is called and twice when calling `notmuch-hello-update' after that. The tests are very similar to tests for `notmuch-hello-mode-hook'. --- test/emacs | 19 +++ test/test-lib.el |1 + 2 files

Re: [PATCH] test: add tests for `notmuch-hello-refresh-hook'

2011-12-21 Thread Dmitry Kurochkin
Hi Thomas. I think all hook count tests must be consistent. We should either add hook counters in test-lib.el (like it is already done for `notmuch-hello-mode-hook') or use lambdas in individual test cases (like you did in the patch). I believe the former approach is better (that is why I used

Re: patchwork link 404s

2011-12-21 Thread Jameson Graef Rollins
On Wed, 21 Dec 2011 07:46:58 -0400, David Bremner da...@tethera.net wrote: I'm not sure, maybe Martin retired the patchwork instance. I know that neither Carl nor I used it. id:20110630090114.ga10...@albatross.gern.madduck.net ___ notmuch mailing list

Re: RFC: use the XDG Base Directory Specification for configuration data

2011-12-21 Thread Jameson Graef Rollins
On Wed, 21 Dec 2011 07:44:16 -0400, David Bremner da...@tethera.net wrote: On Wed, 21 Dec 2011 12:19:38 +0100, Justus Winter 4win...@informatik.uni-hamburg.de wrote: I'd like to propose to store notmuchs configuration in $XDG_CONFIG_HOME/notmuch/config as suggested in the XDG Base Directory

Re: [PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread Jani Nikula
On Wed, 21 Dec 2011 09:40:08 -0500, Austin Clements amdra...@mit.edu wrote: I would definitely go with the latter. It might feel less unwieldy with a shorter variable name than filename, since that has to be repeated so many times. (It's also not really a filename in the middle of the

Re: [PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

2011-12-21 Thread Thomas Jost
On Wed, 21 Dec 2011 22:18:26 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Test that `notmuch-hello-refresh-hook' is called once when `notmuch-hello' is called and twice when calling `notmuch-hello-update' after that. The tests are very similar to tests for

Re: [PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

2011-12-21 Thread Dmitry Kurochkin
On Wed, 21 Dec 2011 22:49:13 +0100, Thomas Jost schno...@schnouki.net wrote: On Wed, 21 Dec 2011 22:18:26 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Test that `notmuch-hello-refresh-hook' is called once when `notmuch-hello' is called and twice when calling

Re: [PATCH] notmuch: Quiet buildbot warnings.

2011-12-21 Thread Thomas Jost
On Tue, 20 Dec 2011 15:20:04 +, David Edmondson d...@dme.org wrote: Cast away the result of various *write functions. Provide a default value for some variables to avoid use before set warnings. --- The buildbot complains about these, though my own system (Debian testing on amd64) does

Re: [PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

2011-12-21 Thread Thomas Jost
On Thu, 22 Dec 2011 01:54:21 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: On Wed, 21 Dec 2011 22:49:13 +0100, Thomas Jost schno...@schnouki.net wrote: On Wed, 21 Dec 2011 22:18:26 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Test that

[BUG?] Pressing SPACEbar is not doing what's expected.

2011-12-21 Thread Xavier Maillard
Hi, I recently upgraded my notmuch installation here (passing from 0.6 or such to latest 0.10.x series). Problem is now, pressing SPACE in a notmuch-show buffer no longer scroll in the message as it used to do. SPC is bound to run command notmuch-show-advance-and-archive and its docstring says:

Re: [BUG?] Pressing SPACEbar is not doing what's expected.

2011-12-21 Thread Jameson Graef Rollins
On Thu, 22 Dec 2011 00:08:38 +0100, Xavier Maillard x...@gnu.org wrote: What happens here is just what is described in paragraph 2. Although I am in situation described in first paragraph, pressing SPC just advance to next message and never scroll to see the next part of the current message.

[PATCH] emacs: put the last search on top of recent searches in notmuch-hello

2011-12-21 Thread Dmitry Kurochkin
Notmuch-hello stores a list of recent searches. Before the change, if a search from this list is repeated, the recent search list is not changed. The patch makes repeated recent searches move to the head of the list. I.e. the last search is always on top of the recent search list, which is what

Re: have notmuch help call man?

2011-12-21 Thread David Bremner
On Tue, 20 Dec 2011 00:16:47 -0400, David Bremner da...@tethera.net wrote: You can also look at the patches in git://pivot.cs.unb.ca/notmuch branch split-man I made some progress. The man pages are now installed, a notmuch help (built from this branch) uses them. The hacks we added to

Re: have notmuch help call man?

2011-12-21 Thread Jameson Graef Rollins
On Wed, 21 Dec 2011 23:43:09 -0400, David Bremner da...@tethera.net wrote: The man pages are now installed, a notmuch help (built from this branch) uses them. Hey, David this is really great. Thank you so much for working on this. This will make things much easier to maintain down the line. I

Re: [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-21 Thread Austin Clements
I must admit I haven't been following the warnings problem very closely, but perhaps we shouldn't be ignoring these return codes? Quoth David Edmondson on Dec 21 at 9:38 pm: --- The mechanism used here works for me in an isolated test case and no warnings appear when using it as below, but

Re: [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-21 Thread David Edmondson
On Thu, 22 Dec 2011 02:03:45 -0500, Austin Clements amdra...@mit.edu wrote: I must admit I haven't been following the warnings problem very closely, but perhaps we shouldn't be ignoring these return codes? In general I agree, but what would we do if writing an error message to stderr fails?

Re: [PATCH] emacs: put the last search on top of recent searches in notmuch-hello

2011-12-21 Thread Tomi Ollila
On Thu, 22 Dec 2011 04:23:50 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Notmuch-hello stores a list of recent searches. Before the change, if a search from this list is repeated, the recent search list is not changed. The patch makes repeated recent searches move to the head

Re: [BUG?] Pressing SPACEbar is not doing what's expected.

2011-12-21 Thread Xavier Maillard
Hi Jamie, On Wed, 21 Dec 2011 15:19:24 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: On Thu, 22 Dec 2011 00:08:38 +0100, Xavier Maillard x...@gnu.org wrote: What happens here is just what is described in paragraph 2. Although I am in situation described in first paragraph,

[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread Dmitry Kurochkin
Hi Jani. On Tue, 20 Dec 2011 22:05:31 +0200, Jani Nikula wrote: > > Shameless promotion of own patches... I suppose not many use the > notmuch-wash-convert-inline-patch-to-part option, but with this patch > I've actually started to like it better. An actual patch name from > subject instead of

[PATCH] emacs: add notmuch-hello-refresh-hook

2011-12-21 Thread Thomas Jost
This hook is called every time a notmuch-hello buffer is updated. --- Hi Dmitry, I like the idea of having a -mode-hook and a -refresh-hook :) Thanks for your suggestions! Regards, Thomas emacs/notmuch-hello.el |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git

[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

2011-12-21 Thread Thomas Jost
i -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 489 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/ac588e62/attachment.pgp>

[PATCH 2/5] lib: Add a MTIME value to every mail document

2011-12-21 Thread Thomas Jost
l include it -- and possibly some tests too :) Thanks, -- Thomas/Schnouki -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 489 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/bcb3fe45/attachment.pgp>

[PATCH 2/5] lib: Add a MTIME value to every mail document

2011-12-21 Thread Thomas Jost
const char *from, > > const char *subject); > > void > > +_notmuch_message_update_mtime (notmuch_message_t *message); > > + > > +void > > _notmuch_message_sync (notmuch_message_t *message); > > > > notmuch_status_t > > diff --git a/lib/notmuch.h b/lib/notmuch.h > > index 9f23a10..643ebce 100644 > > --- a/lib/notmuch.h > > +++ b/lib/notmuch.h > > @@ -910,6 +910,10 @@ notmuch_message_set_flag (notmuch_message_t *message, > > time_t > > notmuch_message_get_date (notmuch_message_t *message); > > > > +/* Get the mtime of 'message' as a time_t value. */ > > +time_t > > +notmuch_message_get_mtime (notmuch_message_t *message); > > + > > /* Get the value of the specified header from 'message'. > > * > > * The value will be read from the actual message file, not from the -- Thomas/Schnouki -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 489 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/ff024d42/attachment-0001.pgp>

[PATCH] emacs: add notmuch-hello-refresh-hook

2011-12-21 Thread Thomas Jost
This hook is called every time a notmuch-hello buffer is updated. --- Oops, the previous patch had a typo which prevented it to work (":group notmuch" instead of ":group 'notmuch"). Sorry about that. emacs/notmuch-hello.el |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff

[PATCH] emacs: add notmuch-hello-refresh-hook

2011-12-21 Thread Dmitry Kurochkin
Hi Thomas. Looks good to me. We should also add tests for this, similar to those for `notmuch-hello-mode-hook'. Thomas, do you think you can work on it? Regards, Dmitry

[PATCH v3 3/4] emacs: rename notmuch-decimal-separator to notmuch-thousands-separator

2011-12-21 Thread Dmitry Kurochkin
Hi Thomas. On Wed, 21 Dec 2011 01:30:48 +0100, Thomas Jost wrote: > On Fri, 16 Dec 2011 16:34:03 +0400, Dmitry Kurochkin gmail.com> wrote: > > On Fri, 16 Dec 2011 08:29:00 -0400, David Bremner > > wrote: > > > On Fri, 16 Dec 2011 04:59:22 +0400, Dmitry Kurochkin > > gmail.com> wrote: > > >

[afew] announcing afew, an universal tagging solution with some fancy features

2011-12-21 Thread Justus Winter
A non-text attachment was scrubbed... Name: .signature Type: application/octet-stream Size: 17 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/a91dae59/attachment.obj>

[PATCH v2 0/2] emacs: trivial defcustom fixes

2011-12-21 Thread David Edmondson
- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/d33aca75/attachment.pgp>

[afew] announcing afew, an universal tagging solution with some fancy features

2011-12-21 Thread Justus Winter
u don't get any output at all you might try using the strace hammer again. Justus -- next part -- A non-text attachment was scrubbed... Name: .signature Type: application/octet-stream Size: 17 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/8a560052/attachment.obj>

[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread David Edmondson
ngth filename) 50))) ".patch")) dme. -- David Edmondson, http://dme.org -- next part ------ A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/f9b88266/attachment-0001.pgp>

patchwork link 404s

2011-12-21 Thread Justus Winter
: 17 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/26bd1b7b/attachment.obj>

RFC: use the XDG Base Directory Specification for configuration data

2011-12-21 Thread Justus Winter
://standards.freedesktop.org/basedir-spec/latest/ -- next part -- A non-text attachment was scrubbed... Name: .signature Type: application/octet-stream Size: 17 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/83d18ed3/attachment.obj>

RFC: use the XDG Base Directory Specification for configuration data

2011-12-21 Thread David Bremner
On Wed, 21 Dec 2011 12:19:38 +0100, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > Hi :) > > I'd like to propose to store notmuchs configuration in > $XDG_CONFIG_HOME/notmuch/config as suggested in the XDG Base Directory > Specification [0]. Can you use NOTMUCH_CONFIG to achieve

patchwork link 404s

2011-12-21 Thread David Bremner
On Wed, 21 Dec 2011 12:09:50 +0100, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > > the patchwork instance referenced on notmuchmail.org [0] returns a > 404 not found. > I'm not sure, maybe Martin retired the patchwork instance. I know that neither Carl nor I used it. If that

S/MIME support in notmuch

2011-12-21 Thread Darren McGuicken
ture Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/afa2ff1e/attachment.pgp>

[PATCH] emacs: add notmuch-hello-refresh-hook

2011-12-21 Thread David Bremner
On Wed, 21 Dec 2011 02:28:14 +0100, Thomas Jost wrote: > This hook is called every time a notmuch-hello buffer is updated. > --- pushed d

[PATCH] notmuch: Quiet buildbot warnings.

2011-12-21 Thread David Bremner
On Tue, 20 Dec 2011 15:20:04 +, David Edmondson wrote: > Cast away the result of various *write functions. Provide a default > value for some variables to avoid "use before set" warnings. Pushed. It turns out this doesn't quiet 3 of the warnings. Maybe Tom can investigate what is different

[PATCH] emacs: add notmuch-hello-refresh-hook

2011-12-21 Thread David Bremner
On Wed, 21 Dec 2011 02:28:14 +0100, Thomas Jost wrote: > This hook is called every time a notmuch-hello buffer is updated. > --- pushed.

[PATCH] emacs: Don't prompt the user to choose from zero matching addresses.

2011-12-21 Thread David Edmondson
If the address matching function generates no matches, don't prompt the user to choose between them (!). Instead, generate a message to report that there were no matches. --- emacs/notmuch-address.el | 21 ++--- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git

[PATCH] test: add tests for `notmuch-hello-refresh-hook'

2011-12-21 Thread Thomas Jost
Test that it's called once when `notmuch-hello' is called, and twice when calling `notmuch-hello-update' after that. --- Here it is. No broken subtest first since the first patch was already pushed though. Regards, Thomas test/emacs | 23 +++ 1 files changed, 23

python: unpythonic result of Message.get_replies()

2011-12-21 Thread Justus Winter
The attached patch series fixes this problem. Note that the wrapping nature of the notmuch bindings makes it kind of awkward to fix the behavior. I've decided to avoid introducing code to the Messages class to indicate that there are no messages and there is no notmuch object being wrapped, but

[PATCH 2/2] python: make the result of Message.get_replies() more pythonic

2011-12-21 Thread Justus Winter
Formerly Message.get_replies() returned an iterator or None forcing users to check the result before iterating over it leading to strange looking code at the call site. Fix this flaw by adding an EmptyMessagesResult class that behaves like the Messages class but immediatly raises StopIteration if

[PATCH 1/2] python: refactor print_messages into format_messages and print_messages

2011-12-21 Thread Justus Winter
--- bindings/python/notmuch/message.py | 37 +-- 1 files changed, 26 insertions(+), 11 deletions(-) diff --git a/bindings/python/notmuch/message.py b/bindings/python/notmuch/message.py index ce8e718..cc9fc2a 100644 --- a/bindings/python/notmuch/message.py +++

[PATCH] emacs: Don't prompt the user to choose from zero matching addresses.

2011-12-21 Thread Tomi Ollila
On Wed, 21 Dec 2011 12:35:27 +, David Edmondson wrote: > If the address matching function generates no matches, don't prompt > the user to choose between them (!). Instead, generate a message to > report that there were no matches. > --- LGTM > emacs/notmuch-address.el | 21

[PATCH 1/2] emacs: rename notmuch-decimal-separator to notmuch-hello-thousands-separator

2011-12-21 Thread Thomas Jost
In 123,456.78, "." is the decimal separator, but "," is the thousands separator. --- emacs/notmuch-hello.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index f892ff7..ef585ea 100644 --- a/emacs/notmuch-hello.el +++

[PATCH 2/2] emacs: Change the default thousands separator to a space

2011-12-21 Thread Thomas Jost
This had been discussed and decided on IRC. Rationale: Therefore the space is recommended in the SI/ISO 31-0 standard, and the International Bureau of Weights and Measures states that "for numbers with many digits the digits may be divided into groups of three by a thin space, in order to

[PATCH] notmuch-addresses: Match on the full name as well as components.

2011-12-21 Thread David Edmondson
--- notmuch_addresses.py |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/notmuch_addresses.py b/notmuch_addresses.py index bf45151..74a743c 100755 --- a/notmuch_addresses.py +++ b/notmuch_addresses.py @@ -164,11 +164,14 @@ class NotmuchAddressMatcher(object):

[PATCH 2/2] emacs: Change the default thousands separator to a space

2011-12-21 Thread Tomi Ollila
On Wed, 21 Dec 2011 14:44:19 +0100, Thomas Jost wrote: Both patches LGTM. Tomi

[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread Austin Clements
I would definitely go with the latter. It might feel less unwieldy with a shorter variable name than "filename", since that has to be repeated so many times. (It's also not really a filename in the middle of the replace process.) This is splitting hairs, but in my original suggestion, I was

[PATCH 1/2] emacs: rename notmuch-decimal-separator to notmuch-hello-thousands-separator

2011-12-21 Thread Dmitry Kurochkin
Both patches look good to me. Thanks, Thomas! Regards, Dmitry

[PATCH 1/2] test: add general Emacs hook counter

2011-12-21 Thread Dmitry Kurochkin
Replace `notmuch-hello-mode-hook-counter' with general `hook-counter' and `add-hook-counter' functions to allow counting calls for any hook. --- test/test-lib.el | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/test/test-lib.el b/test/test-lib.el index

[PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

2011-12-21 Thread Dmitry Kurochkin
Test that `notmuch-hello-refresh-hook' is called once when `notmuch-hello' is called and twice when calling `notmuch-hello-update' after that. The tests are very similar to tests for `notmuch-hello-mode-hook'. --- test/emacs | 19 +++ test/test-lib.el |1 + 2 files

[PATCH] test: add tests for `notmuch-hello-refresh-hook'

2011-12-21 Thread Dmitry Kurochkin
Hi Thomas. I think all hook count tests must be consistent. We should either add hook counters in test-lib.el (like it is already done for `notmuch-hello-mode-hook') or use lambdas in individual test cases (like you did in the patch). I believe the former approach is better (that is why I used

patchwork link 404s

2011-12-21 Thread Jameson Graef Rollins
On Wed, 21 Dec 2011 07:46:58 -0400, David Bremner wrote: > I'm not sure, maybe Martin retired the patchwork instance. I know that > neither Carl nor I used it. id:"20110630090114.GA10571 at albatross.gern.madduck.net"

RFC: use the XDG Base Directory Specification for configuration data

2011-12-21 Thread Jameson Graef Rollins
t available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/82c0b458/attachment-0001.pgp>

[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-12-21 Thread Jani Nikula
On Wed, 21 Dec 2011 09:40:08 -0500, Austin Clements wrote: > I would definitely go with the latter. > > It might feel less unwieldy with a shorter variable name than > "filename", since that has to be repeated so many times. (It's also > not really a filename in the middle of the replace

[RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-21 Thread David Edmondson
--- The mechanism used here works for me in an isolated test case and no warnings appear when using it as below, but I'm unsure why the original warning that it is intended to address didn't appear when I build. Any thoughts? compat/compat.h |6 ++ notmuch-new.c |2 +-

[PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

2011-12-21 Thread Thomas Jost
unter 'notmuch-hello-refresh-hook) > -- > 1.7.7.3 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch -- Thomas/Schnouki -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 489 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/2776ea32/attachment.pgp>

[PATCH] notmuch: Quiet buildbot warnings.

2011-12-21 Thread Thomas Jost
ytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/057b651c/attachment.pgp>

[PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

2011-12-21 Thread Thomas Jost
> diff --git a/test/test-lib.el b/test/test-lib.el > > > index 83b8a65..3b817c3 100644 > > > --- a/test/test-lib.el > > > +++ b/test/test-lib.el > > > @@ -75,3 +75,4 @@ nothing." > > >(add-hook hook (apply-partially 'hook-counter hook))) &g

[BUG?] Pressing SPACEbar is not doing what's expected.

2011-12-21 Thread Jameson Graef Rollins
t was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/938e1573/attachment.pgp>

have "notmuch help" call man?

2011-12-21 Thread David Bremner
On Tue, 20 Dec 2011 00:16:47 -0400, David Bremner wrote: > You can also look at the patches in git://pivot.cs.unb.ca/notmuch > branch split-man I made some progress. The man pages are now installed, a notmuch help (built from this branch) uses them. The hacks we added to update and check the

have "notmuch help" call man?

2011-12-21 Thread Jameson Graef Rollins
scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111221/d1326858/attachment.pgp>