Re: [PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

2011-12-22 Thread Tomi Ollila
On Wed, 21 Dec 2011 22:18:26 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Test that `notmuch-hello-refresh-hook' is called once when `notmuch-hello' is called and twice when calling `notmuch-hello-update' after that. The tests are very similar to tests for

Re: [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread Dmitry Kurochkin
Hi David. Perhaps I am missing something here. But I do not get any warnings when building with GCC 4.6.2 with -Wall -Werror (-O2 and -O0). I do not like adding any complex hacks to make the build warning-free on old GCC versions. If this happens on the build bot, we should just update it or

Re: have notmuch help call man?

2011-12-22 Thread David Bremner
On Wed, 21 Dec 2011 20:53:08 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: * There are a couple of formatting issues (notmuch.1, notmuch-config.1, notmuch-reply.1). I'm sure there are. Can you be more specific? I suspect I might fix a different set of problems than you

Re: [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread David Edmondson
On Thu, 22 Dec 2011 13:32:15 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Perhaps I am missing something here. But I do not get any warnings when building with GCC 4.6.2 with -Wall -Werror (-O2 and -O0). I do not like adding any complex hacks to make the build warning-free on

Re: [PATCH] emacs: Don't prompt the user to choose from zero matching addresses.

2011-12-22 Thread David Bremner
On Wed, 21 Dec 2011 12:35:27 +, David Edmondson d...@dme.org wrote: If the address matching function generates no matches, don't prompt the user to choose between them (!). Instead, generate a message to report that there were no matches. pushed, d

Re: [PATCH 1/2] emacs: rename notmuch-decimal-separator to notmuch-hello-thousands-separator

2011-12-22 Thread David Bremner
On Wed, 21 Dec 2011 14:44:18 +0100, Thomas Jost schno...@schnouki.net wrote: In 123,456.78, . is the decimal separator, but , is the thousands separator. --- This and the next one are both pushed. d ___ notmuch mailing list notmuch@notmuchmail.org

[RFC][PATCH] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread David Edmondson
The advance/rewind functions had become complex, which made it hard to determine who they are expected to behave. Re-implement them simply in order to poll user-experience and expectation. --- This is intended to be for discussion! The current rewind implementation didn't behave as I expected,

Re: [PATCH 1/2] test: add general Emacs hook counter

2011-12-22 Thread David Bremner
On Wed, 21 Dec 2011 22:18:25 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Replace `notmuch-hello-mode-hook-counter' with general `hook-counter' and `add-hook-counter' functions to allow counting calls for any hook. Pushed, d ___

Re: [PATCH] emacs: put the last search on top of recent searches in notmuch-hello

2011-12-22 Thread David Bremner
On Thu, 22 Dec 2011 04:23:50 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Notmuch-hello stores a list of recent searches. Before the change, if a search from this list is repeated, the recent search list is not changed. The patch makes repeated recent searches move to the head

[RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread David Edmondson
The advance/rewind functions had become complex, which made it hard to determine who they are expected to behave. Re-implement them simply in order to poll user-experience and expectation. --- Re-introduce the detection of invisible trailers. Using `previous-single-char-property-change' just

[RFC][PATCH v3] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread David Edmondson
The advance/rewind functions had become complex, which made it hard to determine who they are expected to behave. Re-implement them simply in order to poll user-experience and expectation. --- This one passes the test suite and, consequently, works better when the last open message in a thread

Re: [alot] announcing v0.2 aka. robot santa

2011-12-22 Thread Patrick Totzke
Hi again, I have merged the packaging stuff to upstream master and moved the debian directory to /packaging. An include file for help2man as well as a generated man page for the upcomming release 0.21 can be found in /docs/man. Let me know if there's anything else I can do, /p

[PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-22 Thread Aaron Ecay
Text properties change between characters; prev-s-c-property-change returns the position after the change. Thus, it is still inside the invisible region. --- emacs/notmuch-show.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-show.el

Re: [RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread Aaron Ecay
David, Would the problem you had with previous-s-c-prop-change be fixed by the patch to the original function I sent in the thread starting at id:m2y5u5cykp@kcals.intra.maillard.im ? -- Aaron Ecay ___ notmuch mailing list notmuch@notmuchmail.org

Re: [alot] Introducing myself, asking various questions

2011-12-22 Thread Felipe Contreras
On Sun, Dec 18, 2011 at 9:32 PM, Patrick Totzke patricktot...@googlemail.com wrote: .. however I have the impression that it may be trying to do too much for my needs, which may be peculiar. I have installed offlineimap+notmuch+alot on a slow laptop running Debian wheezy. I guess most of us use

Re: [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread Austin Clements
Quoth David Edmondson on Dec 22 at 7:21 am: On Thu, 22 Dec 2011 02:03:45 -0500, Austin Clements amdra...@mit.edu wrote: I must admit I haven't been following the warnings problem very closely, but perhaps we shouldn't be ignoring these return codes? In general I agree, but what would we

Re: [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread David Edmondson
On Thu, 22 Dec 2011 14:03:05 -0500, Austin Clements amdra...@mit.edu wrote: In general I agree, but what would we do if writing an error message to stderr fails? This was discussed on IRC, but calls to write(2) should never be bare. I believe it's marked warn_unused_result not because libc

Re: [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread David Edmondson
On Thu, 22 Dec 2011 19:25:59 +, David Edmondson d...@dme.org wrote: if (write(2, msg, sizeof(msg)-1) { Sigh. if (write(2, msg, sizeof(msg)-1) != sizeof(msg)-1) { pgpPz75aviMiw.pgp Description: PGP signature ___ notmuch mailing list

Re: [RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread Austin Clements
Quoth David Edmondson on Dec 22 at 7:25 pm: On Thu, 22 Dec 2011 14:03:05 -0500, Austin Clements amdra...@mit.edu wrote: In general I agree, but what would we do if writing an error message to stderr fails? This was discussed on IRC, but calls to write(2) should never be bare. I

[PATCH] Properly handle short writes in sigint handlers

2011-12-22 Thread Austin Clements
Even if we don't care about errors from write(2), it's still necessary to handle short writes in order to use write correctly. Some versions of glibc even mark write as warn_unused_result because of this, so our previous usage would trigger compiler warnings. --- notmuch-new.c |5 -

Filter one-post thread only ?

2011-12-22 Thread Xavier Maillard
Hi, In order to clean up and to trash out as many posts as possible in several mailing lists I did not check lately, I am trying to find a way to limit the current display to messages matching this requirements: 1. post older than 1 month 2. one-message thread only (a post and no

Re: [PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-22 Thread Xavier Maillard
Hey Aaron, On Thu, 22 Dec 2011 09:24:20 -0500, Aaron Ecay aarone...@gmail.com wrote: Text properties change between characters; prev-s-c-property-change returns the position after the change. Thus, it is still inside the invisible region. This patch works for me (at least on all the messages

Re: [PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-22 Thread Jameson Graef Rollins
On Thu, 22 Dec 2011 09:24:20 -0500, Aaron Ecay aarone...@gmail.com wrote: Text properties change between characters; prev-s-c-property-change returns the position after the change. Thus, it is still inside the invisible region. Thanks Aaron! I just tested this and it does seem to fix the

Re: Filter one-post thread only ?

2011-12-22 Thread Jani Nikula
On Thu, 22 Dec 2011 21:45:14 +0100, Xavier Maillard x...@gnu.org wrote: Hi, In order to clean up and to trash out as many posts as possible in several mailing lists I did not check lately, I am trying to find a way to limit the current display to messages matching this requirements: 1.

[PATCH] emacs: call notmuch-show instead notmuch-search in buttonised id: links

2011-12-22 Thread Jameson Graef Rollins
Since message-ids necessarily match just a single message, there's no reason to do a search for the id before viewing the actual message; the search just becomes an extra screen to click through. Clicking on an id: links now just jumps straight to the message itself. --- emacs/notmuch-show.el |

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-22 Thread Jameson Graef Rollins
Since message-ids necessarily match just a single message, there's no reason to do a search for the id before viewing the actual message; the search just becomes an extra screen to click through. Clicking on an id: links now just jumps straight to the message itself. --- This just fixes the

Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-22 Thread David Edmondson
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Since message-ids necessarily match just a single message, there's no reason to do a search for the id before viewing the actual message; the search just becomes an extra screen to click through.

[PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

2011-12-22 Thread Dmitry Kurochkin
On Wed, 21 Dec 2011 22:49:13 +0100, Thomas Jost wrote: > On Wed, 21 Dec 2011 22:18:26 +0400, Dmitry Kurochkin gmail.com> wrote: > > Test that `notmuch-hello-refresh-hook' is called once when > > `notmuch-hello' is called and twice when calling > > `notmuch-hello-update' after that. > > > > The

[BUG?] Pressing SPACEbar is not doing what's expected.

2011-12-22 Thread Xavier Maillard
Hi, I recently upgraded my notmuch installation here (passing from 0.6 or such to latest 0.10.x series). Problem is now, pressing SPACE in a notmuch-show buffer no longer scroll in the message as it used to do. SPC is bound to run command notmuch-show-advance-and-archive and its docstring says:

[PATCH] emacs: put the last search on top of recent searches in notmuch-hello

2011-12-22 Thread Dmitry Kurochkin
Notmuch-hello stores a list of recent searches. Before the change, if a search from this list is repeated, the recent search list is not changed. The patch makes repeated recent searches move to the head of the list. I.e. the last search is always on top of the recent search list, which is what

[PATCH] emacs: put the last search on top of recent searches in notmuch-hello

2011-12-22 Thread David Edmondson
-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111222/778bbeab/attachment.pgp>

[RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread Austin Clements
I must admit I haven't been following the warnings problem very closely, but perhaps we shouldn't be ignoring these return codes? Quoth David Edmondson on Dec 21 at 9:38 pm: > --- > > The mechanism used here works for me in an isolated test case and no > warnings appear when using it as below,

[RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread David Edmondson
David Edmondson, http://dme.org -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111222/ce550721/attachment-0001.pgp>

[PATCH] emacs: put the last search on top of recent searches in notmuch-hello

2011-12-22 Thread Tomi Ollila
On Thu, 22 Dec 2011 04:23:50 +0400, Dmitry Kurochkin wrote: > Notmuch-hello stores a list of recent searches. Before the change, if > a search from this list is repeated, the recent search list is not > changed. The patch makes repeated recent searches move to the head of > the list. I.e. the

[BUG?] Pressing SPACEbar is not doing what's expected.

2011-12-22 Thread Xavier Maillard
Hi Jamie, On Wed, 21 Dec 2011 15:19:24 -0800, Jameson Graef Rollins wrote: > On Thu, 22 Dec 2011 00:08:38 +0100, Xavier Maillard wrote: > > What happens here is just what is described in paragraph 2. Although I > > am in situation described in first paragraph, pressing SPC just advance > > to

[PATCH 2/2] test: add test for `notmuch-hello-refresh-hook'

2011-12-22 Thread Tomi Ollila
On Wed, 21 Dec 2011 22:18:26 +0400, Dmitry Kurochkin wrote: > Test that `notmuch-hello-refresh-hook' is called once when > `notmuch-hello' is called and twice when calling > `notmuch-hello-update' after that. > > The tests are very similar to tests for `notmuch-hello-mode-hook'. +1 -- both

[RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread Dmitry Kurochkin
Hi David. Perhaps I am missing something here. But I do not get any warnings when building with GCC 4.6.2 with -Wall -Werror (-O2 and -O0). I do not like adding any complex hacks to make the build warning-free on old GCC versions. If this happens on the build bot, we should just update it or

have "notmuch help" call man?

2011-12-22 Thread David Bremner
On Wed, 21 Dec 2011 20:53:08 -0800, Jameson Graef Rollins wrote: > * There are a couple of formatting issues (notmuch.1, notmuch-config.1, > notmuch-reply.1). I'm sure there are. Can you be more specific? I suspect I might fix a different set of problems than you found ;). > * The notmuch

[RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread David Edmondson
crubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111222/0c948532/attachment.pgp>

[PATCH] emacs: Don't prompt the user to choose from zero matching addresses.

2011-12-22 Thread David Bremner
On Wed, 21 Dec 2011 12:35:27 +, David Edmondson wrote: > If the address matching function generates no matches, don't prompt > the user to choose between them (!). Instead, generate a message to > report that there were no matches. pushed, d

[PATCH 1/2] emacs: rename notmuch-decimal-separator to notmuch-hello-thousands-separator

2011-12-22 Thread David Bremner
On Wed, 21 Dec 2011 14:44:18 +0100, Thomas Jost wrote: > In 123,456.78, "." is the decimal separator, but "," is the thousands > separator. > --- This and the next one are both pushed. d

[RFC][PATCH] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread David Edmondson
The advance/rewind functions had become complex, which made it hard to determine who they are expected to behave. Re-implement them simply in order to poll user-experience and expectation. --- This is intended to be for discussion! The current rewind implementation didn't behave as I expected,

[PATCH 1/2] test: add general Emacs hook counter

2011-12-22 Thread David Bremner
On Wed, 21 Dec 2011 22:18:25 +0400, Dmitry Kurochkin wrote: > Replace `notmuch-hello-mode-hook-counter' with general `hook-counter' > and `add-hook-counter' functions to allow counting calls for any hook. Pushed, d

[PATCH] emacs: put the last search on top of recent searches in notmuch-hello

2011-12-22 Thread David Bremner
On Thu, 22 Dec 2011 04:23:50 +0400, Dmitry Kurochkin wrote: > Notmuch-hello stores a list of recent searches. Before the change, if > a search from this list is repeated, the recent search list is not > changed. The patch makes repeated recent searches move to the head of > the list. Pushed.

[PATCH v2 1/2] emacs: Fix notmuch-hello-tag-list-make-query defcustom

2011-12-22 Thread David Bremner
On Tue, 20 Dec 2011 21:53:13 +0200, Jani Nikula wrote: > It was not possible to define custom filters or filter functions because > the types were const. Remove const to allow editing. Pushed both. d

[RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread David Edmondson
The advance/rewind functions had become complex, which made it hard to determine who they are expected to behave. Re-implement them simply in order to poll user-experience and expectation. --- Re-introduce the detection of invisible trailers. Using `previous-single-char-property-change' just

[RFC][PATCH v3] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread David Edmondson
The advance/rewind functions had become complex, which made it hard to determine who they are expected to behave. Re-implement them simply in order to poll user-experience and expectation. --- This one passes the test suite and, consequently, works better when the last open message in a thread

[alot] announcing v0.2 aka. "robot santa"

2011-12-22 Thread Patrick Totzke
Hi again, I have merged the packaging stuff to upstream master and moved the debian directory to /packaging. An include file for help2man as well as a generated man page for the upcomming release 0.21 can be found in /docs/man. Let me know if there's anything else I can do, /p

[PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-22 Thread Aaron Ecay
Text properties change between characters; prev-s-c-property-change returns the position after the change. Thus, it is still inside the invisible region. --- emacs/notmuch-show.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-show.el

[RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread Aaron Ecay
David, Would the problem you had with previous-s-c-prop-change be fixed by the patch to the original function I sent in the thread starting at id:"m2y5u5cykp.fsf at kcals.intra.maillard.im" ? -- Aaron Ecay

[RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread David Edmondson
rrect to everyone else, then I'll argue for a re-write separately. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111222/26c23248/attachment.pgp>

[alot] Introducing myself, asking various questions

2011-12-22 Thread Felipe Contreras
On Sun, Dec 18, 2011 at 9:32 PM, Patrick Totzke wrote: >>.. however I have the >>impression that it may be trying to do too much for my needs, which may >>be peculiar. I have installed offlineimap+notmuch+alot on a slow laptop >>running Debian wheezy. > I guess most of us use offlineimap or

[RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread Austin Clements
Quoth David Edmondson on Dec 22 at 7:21 am: > On Thu, 22 Dec 2011 02:03:45 -0500, Austin Clements > wrote: > > I must admit I haven't been following the warnings problem very > > closely, but perhaps we shouldn't be ignoring these return codes? > > In general I agree, but what would we do if

[RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread David Edmondson
f(msg)-1) { /* Appease the compiler. */; } -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111222/c2441045/attachment.pgp>

[RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread David Edmondson
ure Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111222/95efcc95/attachment.pgp>

[RFC][PATCH] notmuch: Workaround to allow ignoring non-void function return.

2011-12-22 Thread Austin Clements
Quoth David Edmondson on Dec 22 at 7:25 pm: > On Thu, 22 Dec 2011 14:03:05 -0500, Austin Clements > wrote: > > > In general I agree, but what would we do if writing an error message to > > > stderr fails? > > > > This was discussed on IRC, but calls to write(2) should never be bare. > > I

[PATCH] Properly handle short writes in sigint handlers

2011-12-22 Thread Austin Clements
Even if we don't care about errors from write(2), it's still necessary to handle short writes in order to use write correctly. Some versions of glibc even mark write as warn_unused_result because of this, so our previous usage would trigger compiler warnings. --- notmuch-new.c |5 -

Filter one-post thread only ?

2011-12-22 Thread Xavier Maillard
Hi, In order to clean up and to trash out as many posts as possible in several mailing lists I did not check lately, I am trying to find a way to limit the current display to messages matching this requirements: 1. post older than 1 month 2. one-message thread only (a post and no

[PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-22 Thread Xavier Maillard
Hey Aaron, On Thu, 22 Dec 2011 09:24:20 -0500, Aaron Ecay wrote: > Text properties change between characters; prev-s-c-property-change > returns the position after the change. Thus, it is still inside the > invisible region. This patch works for me (at least on all the messages I tested it

[RFC][PATCH v2] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-22 Thread Xavier Maillard
On Thu, 22 Dec 2011 09:29:55 -0500, Aaron Ecay wrote: > Would the problem you had with previous-s-c-prop-change be fixed by the > patch to the original function I sent in the thread starting at > id:"m2y5u5cykp.fsf at kcals.intra.maillard.im" ? AFAIK it does. /Xavier

[PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-22 Thread Jameson Graef Rollins
efinitely +1 for this. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111222/013364ef/attachment.pgp>

[PATCH] emacs: call notmuch-show instead notmuch-search in buttonised id: links

2011-12-22 Thread Jameson Graef Rollins
Since message-ids necessarily match just a single message, there's no reason to do a search for the id before viewing the actual message; the search just becomes an extra screen to click through. Clicking on an id: links now just jumps straight to the message itself. --- emacs/notmuch-show.el |

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-22 Thread Jameson Graef Rollins
Since message-ids necessarily match just a single message, there's no reason to do a search for the id before viewing the actual message; the search just becomes an extra screen to click through. Clicking on an id: links now just jumps straight to the message itself. --- This just fixes the