Re: [PATCH] emacs: call notmuch tag only once when archiving a thread

2012-01-09 Thread David Edmondson
On Sun, 8 Jan 2012 20:12:59 -0500, Austin Clements amdra...@mit.edu wrote: ... so we need to switch Emacs over to using the JSON search format first. Is anyone working on this? I made an attempt ages ago[1], but have not kept it working. Footnotes: [1]

Re: [PATCH v2 0/6] reply to sender

2012-01-09 Thread David Edmondson
On Sun, 8 Jan 2012 23:48:29 +0200, Jani Nikula j...@nikula.org wrote: emacs: add support for replying just to the sender emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all These both look fine to me. pgpfNyC5jXkFy.pgp Description: PGP signature

Re: [PATCH v2] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Edmondson
On Sat, 07 Jan 2012 07:53:54 -0400, David Bremner da...@tethera.net wrote: On Fri, 6 Jan 2012 10:03:19 +, David Edmondson d...@dme.org wrote: --- - Prefix the branch name with 'review/' - Avoid `shell-command', which also results in better error reporting when 'git-am' fails.

Re: [PATCH] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Edmondson
On Sat, 07 Jan 2012 00:56:19 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: What do you think of this approach related to your way cloning the repo and then deleting/creating the branch. Just that developer may mess with the repository contents and then there is tedious working tree cleanup to

Re: [PATCH] emacs: call notmuch tag only once when archiving a thread

2012-01-09 Thread Jani Nikula
On Sun, 8 Jan 2012 20:12:59 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Aaron Ecay on Jan 08 at 7:56 pm: On Thu, 05 Jan 2012 22:32:16 +0200, Jani Nikula j...@nikula.org wrote: [...] In the show view it only modifies the messages that are currently visible. This is to

Re: [PATCH 4/4] emacs: Use the new JSON reply format.

2012-01-09 Thread David Edmondson
On Sun, 8 Jan 2012 00:52:42 -0700, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: +(defun w3m-region (start end)) ;; From `w3m.el'. +(defun notmuch-mua-quote-part (part) + (with-temp-buffer +(insert part) +(message-mode) +(fill-region (point-min) (point-max)) +(goto-char

Re: [PATCH v2 3/6] cli: add support for replying just to the sender in notmuch reply

2012-01-09 Thread Jani Nikula
On Sun, 08 Jan 2012 23:23:15 +, Mark Walters markwalters1...@gmail.com wrote: I like this version (of the whole series) but have two queries. (Note I haven't actually tried it out yet: I have just been reading the code.) + /* Force recipient type in reply-to-sender mode just in case

Re: [PATCH v2] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Bremner
On Mon, 09 Jan 2012 08:23:53 +, David Edmondson d...@dme.org wrote: On Sat, 07 Jan 2012 07:53:54 -0400, David Bremner da...@tethera.net wrote: On Fri, 6 Jan 2012 10:03:19 +, David Edmondson d...@dme.org wrote: --- - Prefix the branch name with 'review/' - Avoid

Re: [PATCH] emacs: call notmuch tag only once when archiving a thread

2012-01-09 Thread Tomi Ollila
On Mon, 09 Jan 2012 08:41:15 +, Jani Nikula j...@nikula.org wrote: On Sun, 8 Jan 2012 20:12:59 -0500, Austin Clements amdra...@mit.edu wrote: Quoth Aaron Ecay on Jan 08 at 7:56 pm: On Thu, 05 Jan 2012 22:32:16 +0200, Jani Nikula j...@nikula.org wrote: [...] In the show

Re: [PATCH] emacs: call notmuch tag only once when archiving a thread

2012-01-09 Thread David Edmondson
On Mon, 09 Jan 2012 12:38:58 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: The downside is that there's still a race condition: you could get new messages between checking the number of messages in the thread and tagging. The window for error would be much smaller than now, but it's still

Re: [PATCH v2 3/6] cli: add support for replying just to the sender in notmuch reply

2012-01-09 Thread Mark Walters
The reply-to-thread is a rare case anyway, regardless of reply-to-all or reply-to-sender, and even the current implementation does not gather all the recipients from all the messages. Try it out, it seems to me it does not quite do what you think it does. IMHO it should use oldest-first

Re: [PATCH v2] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Edmondson
On Mon, 09 Jan 2012 06:38:54 -0400, David Bremner da...@tethera.net wrote: Oh. It's supposed to delete the existing branch. It did in my test. What happens for you? FWIW, I loaded notmuch-dev.el on top of current master. The magit buffer shows $ git --no-pager checkout -b

Re: [PATCH] emacs: call notmuch tag only once when archiving a thread

2012-01-09 Thread Mark Walters
There's been quite a bit of discussion on fixing this properly. See, for example id:CAH-f9WsPj=1Eu=g3soepjgctbfs6hrldlq18xmenj8az00y...@mail.gmail.com. The gist is that we need to include message IDs (or document IDs) in the search output and use these in tagging operations, rather than the

[PATCH] NEWS: add news entry for notmuch reply uninitialized variable bugfix

2012-01-09 Thread Jani Nikula
--- This is against release branch. --- NEWS | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 85ff65b..687154d 100644 --- a/NEWS +++ b/NEWS @@ -1,8 +1,8 @@ Notmuch 0.11 (201x-xx-xx) = -New command-line features

Re: 0.11 is frozen, please update NEWS

2012-01-09 Thread David Bremner
On Mon, 02 Jan 2012 07:58:16 -0400, David Bremner da...@tethera.net wrote: I have tagged 0.11_rc2 and uploaded 0.11~rc2-1 to Debian experimental. This includes only the single non-doc commit, fixing a python bindings segfault. NEWS items are still solicited. OK, I have tagged 0.11_rc3 and

Re: nmbug changes

2012-01-09 Thread Justus Winter
Quoting David Bremner (2012-01-08 23:34:26) On Sun, 08 Jan 2012 16:24:06 -, Justus Winter 4win...@informatik.uni-hamburg.de wrote: I'm having trouble with nmbug, I did follow the instructions in this mail and in the wiki, but nmbug never adds tags to my notmuch database (it is supposed to

[PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging

2012-01-09 Thread Aaron Ecay
On Sun, 08 Jan 2012 18:49:56 -0800, Jameson Graef Rollins wrote: > Thanks so much for the review, Aaron. > > On Sun, 08 Jan 2012 20:08:59 -0500, Aaron Ecay wrote: > > A couple of comments on the arguments: > > - It would be good to make show-next This will enable code > > to call the fn

Python bindings for adoption

2012-01-09 Thread sebast...@sspaeth.de
Hurray, thanks Justus. That is much appreciated. Spaetz David Bremner schrieb: >On Sun, 08 Jan 2012 16:16:06 -, Justus Winter ><4winter at informatik.uni-hamburg.de> wrote: >> >> I've decided to step up as a new maintainer for the libnotmuch python >> bindings. I assume that I'll have to

[PATCH] emacs: call "notmuch tag" only once when archiving a thread

2012-01-09 Thread David Edmondson
at dme.org" -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120109/8468968e/attachment.pgp>

[PATCH v2 0/6] reply to sender

2012-01-09 Thread David Edmondson
. Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120109/97ea1154/attachment.pgp>

[PATCH v2] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Edmondson
the existing branch. It did in my test. What happens for you? -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120109/b8ec2a5a/attachment.pgp>

[PATCH] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Edmondson
Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120109/52699756/attachment.pgp>

[PATCH] emacs: call "notmuch tag" only once when archiving a thread

2012-01-09 Thread Jani Nikula
On Sun, 8 Jan 2012 20:12:59 -0500, Austin Clements wrote: > Quoth Aaron Ecay on Jan 08 at 7:56 pm: > > On Thu, 05 Jan 2012 22:32:16 +0200, Jani Nikula wrote: > > > > [...] > > > > > In the show view it only modifies the messages that are currently > > > visible. This is to make sure you don't

[PATCH 4/4] emacs: Use the new JSON reply format.

2012-01-09 Thread David Edmondson
notmuch-mua-quote-part > (notmuch-mua-parse-html-part part) html-parts))) If you have an 'else' clause, why test '(if (not ..' ? > +(setq body (concat body "\n")) > + If it already ends with a carriage return, why do this? -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120109/f04f6f96/attachment.pgp>

[PATCH v2 3/6] cli: add support for replying just to the sender in "notmuch reply"

2012-01-09 Thread Jani Nikula
On Sun, 08 Jan 2012 23:23:15 +, Mark Walters wrote: > > I like this version (of the whole series) but have two queries. (Note I > haven't actually tried it out yet: I have just been reading the code.) > > > + /* Force recipient type in reply-to-sender mode just in case replying to > > +

[PATCH v2] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Bremner
On Mon, 09 Jan 2012 08:23:53 +, David Edmondson wrote: > On Sat, 07 Jan 2012 07:53:54 -0400, David Bremner > wrote: > > On Fri, 6 Jan 2012 10:03:19 +, David Edmondson wrote: > > > --- > > > > > > - Prefix the branch name with 'review/' > > > - Avoid `shell-command', which also

[PATCH] emacs: call "notmuch tag" only once when archiving a thread

2012-01-09 Thread Tomi Ollila
On Mon, 09 Jan 2012 08:41:15 +, Jani Nikula wrote: > On Sun, 8 Jan 2012 20:12:59 -0500, Austin Clements > wrote: > > Quoth Aaron Ecay on Jan 08 at 7:56 pm: > > > On Thu, 05 Jan 2012 22:32:16 +0200, Jani Nikula > > > wrote: > > > > > > [...] > > > > > > > In the show view it only

[PATCH] emacs: call "notmuch tag" only once when archiving a thread

2012-01-09 Thread David Edmondson
cking... Or another process could change the tags, meaning that the number stayed the same but the set changed. (Wh) -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <

[PATCH 1/3] pep8 fixes

2012-01-09 Thread Patrick Totzke
Quoting Sebastian Spaeth (2012-01-02 16:23:05) >Hi, just tried to apply but it doesn't apply cleanly anymore, can you >update the patch to latest master? no need: you already pushed these three patches on Dec 6, if i'm not mistaken. best, /p

[PATCH v2 3/6] cli: add support for replying just to the sender in "notmuch reply"

2012-01-09 Thread Mark Walters
> > The reply-to-thread is a rare case anyway, regardless of reply-to-all or > reply-to-sender, and even the current implementation does not gather all > the recipients from all the messages. Try it out, it seems to me it does > not quite do what you think it does. > > IMHO it should use

[PATCH v2] emacs: Helpers for notmuch developers.

2012-01-09 Thread David Edmondson
l-dme at dme.org\"") > notmuch-dev-show-review-patch() > call-interactively(notmuch-dev-show-review-patch t nil) > execute-extended-command(nil) > call-interactively(execute-extended-command nil nil) Could you try running (notmuch-dev-delete-branch "review/patch-emacs-don't-signal-an-error-when-reaching-the-end-of-the-search-results") when inside that repository please? -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120109/855010a1/attachment.pgp>

[PATCH] emacs: call "notmuch tag" only once when archiving a thread

2012-01-09 Thread Mark Walters
> There's been quite a bit of discussion on fixing this properly. See, > for example > id:"CAH-f9WsPj=1Eu=g3sOePJgCTBFs6HrLdLq18xMEnJ8aZ00yCEg at mail.gmail.com". > The gist is that we need to include message IDs (or document IDs) in > the search output and use these in tagging operations,

[PATCH] NEWS: add news entry for notmuch reply uninitialized variable bugfix

2012-01-09 Thread Jani Nikula
--- This is against release branch. --- NEWS | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 85ff65b..687154d 100644 --- a/NEWS +++ b/NEWS @@ -1,8 +1,8 @@ Notmuch 0.11 (201x-xx-xx) = -New command-line features

0.11 is frozen, please update NEWS

2012-01-09 Thread David Bremner
On Mon, 02 Jan 2012 07:58:16 -0400, David Bremner wrote: > > > I have tagged 0.11_rc2 and uploaded 0.11~rc2-1 to Debian experimental. > This includes only the single non-doc commit, fixing a python bindings > segfault. NEWS items are still solicited. OK, I have tagged 0.11_rc3 and pushed

is there a default reply function? (was: Re: [PATCH v2 5/6] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all)

2012-01-09 Thread Gregor Zattler
Hi Jeremy, notmuch -developers, * Jeremy Nickurak [08. Jan. 2012]: > On Sun, Jan 8, 2012 at 14:48, Jani Nikula wrote: >> It seemed to me that most people wanted this, and nobody spoke for keeping >> the old binding now that we have reply-to-sender. This as a separate patch >> so it's easy to

nmbug changes

2012-01-09 Thread Justus Winter
Quoting David Bremner (2012-01-08 23:34:26) >On Sun, 08 Jan 2012 16:24:06 -, Justus Winter <4winter at >informatik.uni-hamburg.de> wrote: > >> I'm having trouble with nmbug, I did follow the instructions in this >> mail and in the wiki, but nmbug never adds tags to my notmuch database >> (it

Python bindings for adoption

2012-01-09 Thread Jameson Graef Rollins
s great to hear, Justus. Thanks for stepping up! jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120109/5dc7aa62/attachment.pgp>

[PATCH v2 0/6] reply to sender

2012-01-09 Thread Dmitry Kurochkin
Hi Jani. I prefer to leave the Emacs UI default reply behavior as is. Changing it in CLI would not affect me, but I think the default should be the same as in the Emacs UI. Regards, Dmitry

[PATCH 4/4] emacs: Use the new JSON reply format.

2012-01-09 Thread Adam Wolfe Gordon
On Sun, Jan 8, 2012 at 18:27, Aaron Ecay wrote: >> +(defun w3m-region (start end)) ;; From `w3m.el'. > > What is the purpose of the above line? ?If it is to make the compiler > aware of the function, you should use ?declare-function? instead. ?Defun > will erase the original definition of the

[PATCH] NEWS: add news entry for notmuch reply uninitialized variable bugfix

2012-01-09 Thread David Bremner
On Mon, 9 Jan 2012 11:49:56 +, Jani Nikula wrote: > --- > > This is against release branch. > --- Pushed to release. d

[PATCH] man: add missing SEE ALSO header to notmuch reply man page

2012-01-09 Thread Xavier Maillard
On Sun, 8 Jan 2012 22:57:22 +0200, Jani Nikula wrote: > Signed-off-by: Jani Nikula > --- > man/man1/notmuch-reply.1 |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) +1 /Xavier

[ANNOUNCE] mutt with notmuch support

2012-01-09 Thread Jeremy Nickurak
FWIW, here's the patch I ended up using to play with this: diff --git a/mutt_notmuch.c b/mutt_notmuch.c index 2f21407..a07b1ba 100644 --- a/mutt_notmuch.c +++ b/mutt_notmuch.c @@ -636,11 +636,15 @@ char *nm_uri_from_query(CONTEXT *ctx, char *buf, size_t bufsz) ?static notmuch_message_t

[PATCH 0/4] Quoting HTML-only emails in replies redux

2012-01-09 Thread Adam Wolfe Gordon
Thanks for the suggestions. Specific comments inline: On Sun, Jan 8, 2012 at 18:36, Aaron Ecay wrote: >> There should probably be some customize variables for this in emacs, to >> control >> (for example) whether to quote HTML parts and whether to prefer HTML or >> plaintext parts for quoting.

[PATCH 4/4] emacs: Use the new JSON reply format.

2012-01-09 Thread Adam Wolfe Gordon
Hi David, Thanks for the review. Most of the things you've suggested are easy changes, and I think obvious improvements, so I'll change them for the next version. A bit of discussion on the more involved things below: On Mon, Jan 9, 2012 at 01:50, David Edmondson wrote: > On Sun, ?8 Jan 2012