This controls where comments and other text wraps. 70 is the default
value, so this simply returns it to the default for people who have
overridden it. Most notmuch code already adheres to this.
---
SO here is the patch (still sorry if I did it wrongly and very badly).
.dir-locals.el | 19
Sorry if it is not correct to act like this (did I ever tell how n00b I
am when it comes to git ?).
So I wanted to /amend/ your patch to add some refactoring to it.
I hope this will not hurt :/
/Xavier
On Fri, 13 Jan 2012 11:50:52 +0200, Tomi Ollila wrote:
> On Fri, 13 Jan 2012 08:22:49 +, David Edmondson wrote:
> > On Thu, 12 Jan 2012 23:07:03 +0100, Xavier Maillard
> > wrote:
> > > On Wed, 11 Jan 2012 17:13:35 +0200, Tomi Ollila
> > > wrote:
> > > > Executed
> > > > for f in
---
notmuch-show.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/notmuch-show.c b/notmuch-show.c
index 87a1c90..d14dac9 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -677,7 +677,7 @@ format_part_content_json (GMimeObject *part)
if
Hi David,
Have you planned to cook something about this in notmuch wiki ?
That sounds like something I could use to test patches more easily than
I do currently.
Note: I am totally a dummy when I have to use git :/
Regards
/Xavier
On Thu, 12 Jan 2012 18:17:23 -0500, Austin Clements wrote:
> This controls where comments and other text wraps. 70 is the default
> value, so this simply returns it to the default for people who have
> overridden it. Most notmuch code already adheres to this.
> ---
pushed.
d
On Fri, 13 Jan 2012 09:44:46 +, David Edmondson wrote:
> Add the charset of text/html parts to the JSON output of 'notmuch
> -show' when it is known. Observe the encoding when rendering such
> parts in emacs.
> ---
pushed
On Fri, 13 Jan 2012 18:07:02 -0500, Austin Clements wrote:
> ---
> notmuch-count.c | 53 +
> 1 files changed, 25 insertions(+), 28 deletions(-)
This seems independent of the rest of the series, and kindof obvious by
this point, so I pushed
On Fri, 13 Jan 2012 12:52:48 -0800, Jameson Graef Rollins wrote:
>
> Doesn't everything need to be merged into master eventually anyway? It
> seems to me that unless it's a change that very narrowly targeting an
> issue in a release branch that is not an issue in master, every patch
> will
On Fri, 13 Jan 2012 23:27:11 +0100, Xavier Maillard wrote:
>
> What about doing all of this directly in .dir-locals.el (could be
> considered unsafe though to add an EVAL block).
>
I'm not crazy about this ideas, it sounds like it has the potential to
mix whitespace changes in with out changes
il messages in maildir or mh format. It uses
the Xapian library to provide fast, full-text search with a convenient
search syntax.
For more about notmuch, see http://notmuchmail.org
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: applicatio
Quoth David Edmondson on Jan 13 at 9:44 am:
> Add the charset of text/html parts to the JSON output of 'notmuch
> -show' when it is known. Observe the encoding when rendering such
> parts in emacs.
> ---
>
> Commentary added.
>
> emacs/notmuch-show.el |3 ++-
> notmuch-show.c| 28
This adds a "search" section to the config file and an
"auto_tag_exclusions" setting in that section. The search and count
commands pass tag tags from the configuration to the library.
---
notmuch-client.h |8
notmuch-config.c | 42 ++
This is useful for tags like "deleted" and "spam" that people
generally want to exclude from query results. These exclusions will
be overridden if a tag is explicitly mentioned in a query.
---
lib/notmuch.h |6 ++
lib/query.cc | 35 +++
2 files changed,
---
notmuch-count.c | 53 +
1 files changed, 25 insertions(+), 28 deletions(-)
diff --git a/notmuch-count.c b/notmuch-count.c
index 20ce334..0982f99 100644
--- a/notmuch-count.c
+++ b/notmuch-count.c
@@ -21,6 +21,11 @@
#include
This addresses Jani's comments and improves some of the text and code
comments.
Quoth Xavier Maillard on Jan 13 at 11:42 pm:
>
> This controls where comments and other text wraps. 70 is the default
> value, so this simply returns it to the default for people who have
> overridden it. Most notmuch code already adheres to this.
> ---
> SO here is the patch (still sorry if I
it...
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120113/96186e0c/attachment.pgp>
up has some explanatory text beside it. Did you omit
> that on purpose?
That should be a requirement, I think.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120113/ebde048e/attachment.pgp>
ype: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120113/b825295a/attachment.pgp>
On Fri, 13 Jan 2012 13:42:55 +0100, Xavier Maillard
wrote:
>
> On Fri, 13 Jan 2012 08:23:55 +, David Edmondson wrote:
> > On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet
> > wrote:
> > > Less code, same results, without sacrificing readability.
> >
> > +1, but why not replace
LGTM.
Quoth Tomi Ollila on Jan 13 at 10:17 am:
> emacsclient --eval '(kill-emacs)' makes emacs versions 23.1
> and 23.2 ask user input from running emacs. Redefining
> yes-or-no-p function when kill-emacs is executed for these
> emacs versions in test-lib.el avoids this test problem.
> ---
>
On Fri, 13 Jan 2012 08:23:55 +, David Edmondson wrote:
> On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet wrote:
> > Less code, same results, without sacrificing readability.
>
> +1, but why not replace non-branching `if' with `when' as well?
I tend to use WHEN for case I need to execute
On Thu, 12 Jan 2012 18:17:23 -0500, Austin Clements wrote:
> This controls where comments and other text wraps. 70 is the default
> value, so this simply returns it to the default for people who have
> overridden it. Most notmuch code already adheres to this.
+1
/Xavier
If `notmuch-dev-show-review-patch' is called with a prefix argument,
pull updates for the 'master' branch of the temporary repository.
---
emacs/notmuch-dev.el |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-dev.el b/emacs/notmuch-dev.el
index
Remove {, } and ,.
---
emacs/notmuch-dev.el |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-dev.el b/emacs/notmuch-dev.el
index 871ce3b..465846f 100644
--- a/emacs/notmuch-dev.el
+++ b/emacs/notmuch-dev.el
@@ -75,7 +75,7 @@
(defun notmuch-dev-flatten-title
pplication/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120113/37c845e4/attachment.pgp>
sub group
descriptions, I think this would be a nice cleanup. +1.
jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120
signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120113/e293101b/attachment.pgp>
On Fri, 13 Jan 2012 09:44:46 +, David Edmondson wrote:
> Add the charset of text/html parts to the JSON output of 'notmuch
> -show' when it is known. Observe the encoding when rendering such
> parts in emacs.
> ---
>
> Commentary added.
+1
Tomi
On Fri, 13 Jan 2012 08:22:49 +, David Edmondson wrote:
> On Thu, 12 Jan 2012 23:07:03 +0100, Xavier Maillard
> wrote:
> > On Wed, 11 Jan 2012 17:13:35 +0200, Tomi Ollila
> > wrote:
> > > Executed
> > > for f in emacs/*.el
> > > do emacs -q --batch --eval \
> > > "(progn
`magit-delete-branch' runs "git branch -d ", which refuses to
delete branches that are not fully merged. Given that we don't care
and don't want to be stalled, use "git branch -D " directly.
---
This should address the problems removing un-merged branches.
emacs/notmuch-dev.el |4 +++-
1
emacsclient --eval '(kill-emacs)' makes emacs versions 23.1
and 23.2 ask user input from running emacs. Redefining
yes-or-no-p function when kill-emacs is executed for these
emacs versions in test-lib.el avoids this test problem.
---
Thanks Austin for your comments. Including 'activate' into
next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120113/7e11ae22/attachment.pgp>
Add the charset of text/html parts to the JSON output of 'notmuch
-show' when it is known. Observe the encoding when rendering such
parts in emacs.
---
Commentary added.
emacs/notmuch-show.el |3 ++-
notmuch-show.c| 28 +++-
2 files changed, 25
On Thu, 12 Jan 2012 18:17:23 -0500, Austin Clements wrote:
> This controls where comments and other text wraps. 70 is the default
> value, so this simply returns it to the default for people who have
> overridden it. Most notmuch code already adheres to this.
> ---
+1
Tomi
> .dir-locals.el
On Fri, 13 Jan 2012 10:25:29 +, David Edmondson wrote:
> `magit-delete-branch' runs "git branch -d ", which refuses to
> delete branches that are not fully merged. Given that we don't care
> and don't want to be stalled, use "git branch -D " directly.
> ---
Yes, that seems to fix it.
Two
ion/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120113/5c61402f/attachment-0001.pgp>
d note something about this as a /coding style/ rule ?
How about "Running `indent-region' over the file should produce no
changes" as well?
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 19
On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner wrote:
> On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet wrote:
> > On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner
> > wrote:
>
> > with differing hashes), this has the potential of causing confusion
> > and/or quite some extra work when
emacsclient --eval '(kill-emacs)' makes emacs versions 23.1
and 23.2 ask user input from running emacs. Redefining
yes-or-no-p function when kill-emacs is executed for these
emacs versions in test-lib.el avoids this test problem.
---
Thanks Austin for your comments. Including 'activate' into
On Thu, 12 Jan 2012 23:07:03 +0100, Xavier Maillard xav...@maillard.im wrote:
On Wed, 11 Jan 2012 17:13:35 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
Executed
for f in emacs/*.el
do emacs -q --batch --eval \
(progn (find-file \$f\) (whitespace-cleanup) (save-buffer))
On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet pie...@praet.org wrote:
Less code, same results, without sacrificing readability.
+1, but why not replace non-branching `if' with `when' as well?
pgpuhUlvebeLM.pgp
Description: PGP signature
___
On Thu, 12 Jan 2012 23:46:46 -0400, David Bremner da...@tethera.net wrote:
On Thu, 12 Jan 2012 18:25:38 +0100, Pieter Praet pie...@praet.org wrote:
On Sat, 31 Dec 2011 23:22:46 -0400, David Bremner da...@tethera.net wrote:
with differing hashes), this has the potential of causing confusion
Add the charset of text/html parts to the JSON output of 'notmuch
-show' when it is known. Observe the encoding when rendering such
parts in emacs.
---
Commentary added.
emacs/notmuch-show.el |3 ++-
notmuch-show.c| 28 +++-
2 files changed, 25
On Thu, 12 Jan 2012 18:17:23 -0500, Austin Clements amdra...@mit.edu wrote:
This controls where comments and other text wraps. 70 is the default
value, so this simply returns it to the default for people who have
overridden it. Most notmuch code already adheres to this.
Makes sense.
On Fri, 13 Jan 2012 08:22:49 +, David Edmondson d...@dme.org wrote:
On Thu, 12 Jan 2012 23:07:03 +0100, Xavier Maillard xav...@maillard.im
wrote:
On Wed, 11 Jan 2012 17:13:35 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
Executed
for f in emacs/*.el
do emacs -q --batch
On Fri, 13 Jan 2012 09:44:46 +, David Edmondson d...@dme.org wrote:
Add the charset of text/html parts to the JSON output of 'notmuch
-show' when it is known. Observe the encoding when rendering such
parts in emacs.
---
Commentary added.
+1
Tomi
`magit-delete-branch' runs git branch -d branch, which refuses to
delete branches that are not fully merged. Given that we don't care
and don't want to be stalled, use git branch -D branch directly.
---
This should address the problems removing un-merged branches.
emacs/notmuch-dev.el |4
On Thu, 12 Jan 2012 18:17:23 -0500, Austin Clements amdra...@mit.edu wrote:
This controls where comments and other text wraps. 70 is the default
value, so this simply returns it to the default for people who have
overridden it. Most notmuch code already adheres to this.
+1
/Xavier
On Fri, 13 Jan 2012 08:23:55 +, David Edmondson d...@dme.org wrote:
On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet pie...@praet.org wrote:
Less code, same results, without sacrificing readability.
+1, but why not replace non-branching `if' with `when' as well?
I tend to use WHEN for
On Fri, 13 Jan 2012 13:42:55 +0100, Xavier Maillard xav...@maillard.im wrote:
On Fri, 13 Jan 2012 08:23:55 +, David Edmondson d...@dme.org wrote:
On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet pie...@praet.org wrote:
Less code, same results, without sacrificing readability.
+1,
On Fri, 13 Jan 2012 13:42:55 +0100, Xavier Maillard xav...@maillard.im wrote:
On Fri, 13 Jan 2012 08:23:55 +, David Edmondson d...@dme.org wrote:
On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet pie...@praet.org wrote:
Less code, same results, without sacrificing readability.
+1,
If `notmuch-dev-show-review-patch' is called with a prefix argument,
pull updates for the 'master' branch of the temporary repository.
---
emacs/notmuch-dev.el |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-dev.el b/emacs/notmuch-dev.el
index
On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet pie...@praet.org wrote:
Less code, same results, without sacrificing readability.
Does this change correctly re-indent the line following the if/unless?
pgppn8eS1pTGG.pgp
Description: PGP signature
___
On Thu, 12 Jan 2012 23:31:34 -0400, David Bremner da...@tethera.net wrote:
On Thu, 12 Jan 2012 18:12:16 +0100, Pieter Praet pie...@praet.org wrote:
To allow for expansion whilst keeping everything tidy and organized,
move all defcustom/defface variables to the following subgroups,
defined
On Fri, 13 Jan 2012 11:50:52 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
So, In addition to 'uncrustify.cfg' we need emacs reformatter along lines:
(defun reformat-elisp-buffer ()
(interactice)
(emacs-lisp-mode)
(whitespace-cleanup)
(indent-region (point-min) (point-max)))
And
On Fri, 13 Jan 2012 05:05:35 -0400, David Bremner da...@tethera.net wrote:
I thought about this a bit more, and I agree that at least the release
candidates (basically anything tagged on branch release) ought to be
merged back to master. Since any series of bugfix patches seems to be
cause for
On Thu, 12 Jan 2012 18:12:16 +0100, Pieter Praet pie...@praet.org wrote:
To allow for expansion whilst keeping everything tidy and organized,
move all defcustom/defface variables to the following subgroups,
defined in notmuch-lib.el:
Baring the issue that the Davids brought up about the sub
On Fri, 13 Jan 2012 11:50:52 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
On Fri, 13 Jan 2012 08:22:49 +, David Edmondson d...@dme.org wrote:
On Thu, 12 Jan 2012 23:07:03 +0100, Xavier Maillard xav...@maillard.im
wrote:
On Wed, 11 Jan 2012 17:13:35 +0200, Tomi Ollila
Sorry if it is not correct to act like this (did I ever tell how n00b I
am when it comes to git ?).
So I wanted to /amend/ your patch to add some refactoring to it.
I hope this will not hurt :/
/Xavier
___
notmuch mailing list
This controls where comments and other text wraps. 70 is the default
value, so this simply returns it to the default for people who have
overridden it. Most notmuch code already adheres to this.
---
SO here is the patch (still sorry if I did it wrongly and very badly).
.dir-locals.el | 19
This addresses Jani's comments and improves some of the text and code
comments.
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
This is useful for tags like deleted and spam that people
generally want to exclude from query results. These exclusions will
be overridden if a tag is explicitly mentioned in a query.
---
lib/notmuch.h |6 ++
lib/query.cc | 35 +++
2 files changed, 41
This adds a search section to the config file and an
auto_tag_exclusions setting in that section. The search and count
commands pass tag tags from the configuration to the library.
---
notmuch-client.h |8
notmuch-config.c | 42 ++
Quoth David Edmondson on Jan 13 at 9:44 am:
Add the charset of text/html parts to the JSON output of 'notmuch
-show' when it is known. Observe the encoding when rendering such
parts in emacs.
---
Commentary added.
emacs/notmuch-show.el |3 ++-
notmuch-show.c| 28
Where to obtain notmuch 0.11
===
http://notmuchmail.org/releases/notmuch-0.11.tar.gz
Which can be verified with:
http://notmuchmail.org/releases/notmuch-0.11.tar.gz.sha1
11eb1d967af089ed36f6816f61ebae308bc19339 notmuch-0.11.tar.gz
On Fri, 13 Jan 2012 23:27:11 +0100, Xavier Maillard x...@gnu.org wrote:
What about doing all of this directly in .dir-locals.el (could be
considered unsafe though to add an EVAL block).
I'm not crazy about this ideas, it sounds like it has the potential to
mix whitespace changes in with out
On Fri, 13 Jan 2012 12:52:48 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
Doesn't everything need to be merged into master eventually anyway? It
seems to me that unless it's a change that very narrowly targeting an
issue in a release branch that is not an issue in master,
On Fri, 13 Jan 2012 18:07:02 -0500, Austin Clements amdra...@mit.edu wrote:
---
notmuch-count.c | 53 +
1 files changed, 25 insertions(+), 28 deletions(-)
This seems independent of the rest of the series, and kindof obvious by
this point,
On Fri, 13 Jan 2012 09:44:46 +, David Edmondson d...@dme.org wrote:
Add the charset of text/html parts to the JSON output of 'notmuch
-show' when it is known. Observe the encoding when rendering such
parts in emacs.
---
pushed
___
notmuch
On Thu, 12 Jan 2012 18:17:23 -0500, Austin Clements amdra...@mit.edu wrote:
This controls where comments and other text wraps. 70 is the default
value, so this simply returns it to the default for people who have
overridden it. Most notmuch code already adheres to this.
---
pushed.
d
---
notmuch-show.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/notmuch-show.c b/notmuch-show.c
index 87a1c90..d14dac9 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -677,7 +677,7 @@ format_part_content_json (GMimeObject *part)
if
73 matches
Mail list logo
