---
emacs/notmuch-show.el |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index a07a44a..8d318c9 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1121,6 +1121,7 @@ Refreshes the current view, observing
Very deeply indented content is sometimes difficult to
read (particular for something like patches). Allow the indentation of
the content to be toggled with ''.
Indentation of the header lines is not affected, so it remains
possible to see the structure of the thread.
---
emacs/notmuch-show.el |
The current behaviour (all messages shown, non-matching collapsed)
is retained as the default. Type '!' to switch to showing only
the matching messages - non-matching messages are not available.
'!' will switch back to showing everything.
---
emacs/notmuch-show.el | 18 +-
1
v5:
- more real buffer local variables in patch 1.
- switch truncation toggle binding to 't'.
- add patch 6 to check that the search buffer still exists when
trying to select it.
David Edmondson (6):
emacs: Rework crypto switch toggle.
emacs: Allow `notmuch-show-mode' to display only
Re-work the existing crypto switch toggle to be based on a persistant
buffer-local variable.
To allow this, modify `notmuch-show-refresh-view' to erase and re-draw
in the current buffer rather than killing the current buffer and
creating a new one. (This will also allow more per-buffer behaviour
---
emacs/notmuch-show.el |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 1b31166..895feb5 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1671,7 +1671,7 @@ added.
(interactive P)
(let
With an argument, record and reply the state of the buffer during
`notmuch-show-refresh-view'.
In this context, state is defined as:
- the open/closed state of each message,
- the current message.
Traditional use of refresh with the = key does not retain the
state. The recently introduced
On Tue, 31 Jan 2012 18:28:04 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
A new configuration key 'new.ignore' is used to determine which
files and directories user wants not to be scanned as new mails.
Hi, please find a few drive-by while my code is compiling nitpick
review comments inline. ;)
devel/newssplit.pl splits NEWS file to separate files per release.
In addition to splitting it changes lines starting with '*' to start
with '###' (markdown for h3) and concatenates continuing non-empty
lines to the same line; markdown does now allow (long) header line
to be split into multiple
Quoth Tomi Ollila on Jan 31 at 6:28 pm:
A new configuration key 'new.ignore' is used to determine which
files and directories user wants not to be scanned as new mails.
This work merges my previous attempts and Andreas Amann's work
in id:ylp7hi23mw8@tyndall.ie
See notes in
https://bitbucket.org/spaetz/cnotmuch/issue/1/removing-tags-doesnt-seem-to-be-saving
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
On Wed, 01 Feb 2012 14:37:53 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
On Wed, 01 Feb 2012 12:18:08 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
There are at least these options here
1) go through all ~100 places where test_expect_equal_file is used
and fix the
On Tue, 31 Jan 2012 11:25:06 -0500, Austin Clements amdra...@mit.edu wrote:
Quoth Mark Walters on Jan 31 at 11:45 am:
On Mon, 30 Jan 2012 23:43:52 -0500, Austin Clements amdra...@mit.edu
wrote:
Quoth Mark Walters on Jan 29 at 6:39 pm:
notmuch_message_node_t *iterator;
};
On Wed, 01 Feb 2012 18:06:05 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
On Wed, 01 Feb 2012 14:44:48 +0100, Pieter Praet pie...@praet.org wrote:
On Mon, 30 Jan 2012 12:13:48 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
Hi Pieter.
On Mon, 30 Jan 2012
On Wed, 01 Feb 2012 18:18:55 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
On Wed, 01 Feb 2012 14:51:37 +0100, Pieter Praet pie...@praet.org wrote:
On Wed, 1 Feb 2012 06:49:39 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
Hi Aaron.
Thanks for your work! I
From: Aaron Ecay aarone...@gmail.com
The test is broken at this time; the next commit will introduce a fix.
Edited-by: Pieter Praet pie...@praet.org:
Moved expected output into the actual test and fixed Fcc: line.
---
test/emacs | 21 +
1 files changed, 21 insertions(+),
Thanks to Dmitry Kurochkin dmitry.kuroch...@gmail.com
for pointing this out: id:87d39ymyb4@gmail.com
---
test/emacs |2 +-
test/new |6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/test/emacs b/test/emacs
index 17129b7..9c9d0b4 100755
--- a/test/emacs
+++
Hi Pieter.
On Wed, 01 Feb 2012 21:32:32 +0100, Pieter Praet pie...@praet.org wrote:
On Wed, 01 Feb 2012 18:06:05 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
On Wed, 01 Feb 2012 14:44:48 +0100, Pieter Praet pie...@praet.org wrote:
On Mon, 30 Jan 2012 12:13:48 +0400, Dmitry
Hi Jameson.
On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
On Wed, 01 Feb 2012 14:37:53 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
On Wed, 01 Feb 2012 12:18:08 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
There are at least
Hi all.
This is my second attempt to solve the test_expect_equal_file()
argument issue, based on Tomi's idea [1]. The first attempt and the
following discussion can be found here [2].
Regards,
Dmitry
[1] id:m28vknaq5l@guru.guru-group.fi
[2]
Test_expect_equal_file() function treats the first argument as actual
output file and the second argument as expected output file. When
the test fails, the files are copied for later inspection. The first
files is copied to $testname.output and the second file to
$testname.expected. The
The patch fixes tests which were broken by the new
test_expect_equal_file() argument check. Some tests have correct
filename format, but wrong argument order. Others require files to be
renamed.
---
test/crypto | 10 +-
test/dump-restore| 10 +-
test/hooks
On Thu, 02 Feb 2012 03:42:29 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
Hi Jameson.
On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
On Wed, 01 Feb 2012 14:37:53 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
On
v6:
- add `notmuch-show-only-matching-messages' to allow a user to choose
that as the default behaviour.
- allow a prefix argument to `notmuch-show' to invert the default
value of `notmuch-show-only-matching-messages'.
David Edmondson (8):
emacs: Rework crypto switch toggle.
emacs: Allow
---
emacs/notmuch-show.el |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index a07a44a..8d318c9 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1121,6 +1121,7 @@ Refreshes the current view, observing
Re-work the existing crypto switch toggle to be based on a persistant
buffer-local variable.
To allow this, modify `notmuch-show-refresh-view' to erase and re-draw
in the current buffer rather than killing the current buffer and
creating a new one. (This will also allow more per-buffer behaviour
On Wed, 1 Feb 2012 14:50:00 +0100, Pieter Praet pie...@praet.org wrote:
Less code, same results, without sacrificing readability.
pushed.
d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
I rebased these against branch release (and copied a comment from
aaron's email), but the test fails there, as does the reply within emacs test.
FAIL Reply within emacs
--- emacs.24.expected 2012-02-02 03:55:14.0 +
+++ emacs.24.output 2012-02-02
Very deeply indented content is sometimes difficult to
read (particular for something like patches). Allow the indentation of
the content to be toggled with ''.
Indentation of the header lines is not affected, so it remains
possible to see the structure of the thread.
---
emacs/notmuch-show.el |
The current behaviour (all messages shown, non-matching collapsed)
is retained as the default. Type '!' to switch to showing only
the matching messages - non-matching messages are not available.
'!' will switch back to showing everything.
---
emacs/notmuch-show.el | 18 +-
1
---
emacs/notmuch-show.el |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 1b31166..895feb5 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1671,7 +1671,7 @@ added.
(interactive P)
(let
Allow the user to choose that only matching messages are shown by
default.
---
emacs/notmuch-show.el |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 895feb5..ae7af02 100644
--- a/emacs/notmuch-show.el
+++
With an argument, record and reply the state of the buffer during
`notmuch-show-refresh-view'.
In this context, state is defined as:
- the open/closed state of each message,
- the current message.
Traditional use of refresh with the = key does not retain the
state. The recently introduced
From: Aaron Ecay aarone...@gmail.com
The test is broken at this time; the next commit will introduce a fix.
---
test/emacs| 12
test/emacs.expected-output/quote-mml-in-reply |7 +++
2 files changed, 19 insertions(+), 0 deletions(-)
From: Aaron Ecay aarone...@gmail.com
Emacs message-mode uses certain text strings to indicate how to attach
files to outgoing mail. If these are present in the text of an email,
and a user is tricked into replying to the message, the user’s files
could be exposed.
Using point-max would include
On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
If this is really a problem, I vote for 1. In general, I am not in
favor of making the test suite more complicated than it needs to be.
After listening to the debate, I agree. The documentation should
Add default value to notmuch-search-line-faces to show unread
messages in bold, and flagged messages in blue, to have some visual
indication of important messages in search results. This should be
helpful for new users.
unread tag is quite obvious, and handled specially both in the lib
and emacs
Amann's work
in id:ylp7hi23mw8@tyndall.ie
See notes in id:20120202-new-ignore-1-git-send-email-...@iki.fi
---
Whenever some already existing directory is added to the exclude list
and the parent directory timestamp has not changed, notmuch new will not
notice the directory has gone (as it still
On Thu, 02 Feb 2012 14:33:56 +, David Edmondson d...@dme.org wrote:
On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
If this is really a problem, I vote for 1. In general, I am not in
favor of making the test suite more complicated than it
I've just tried to compile notmuch, after having downloaded it a few
hours back, via: `git clone git://notmuchmail.org/git/notmuch`.
Unfortunately, even though I seem to have all needed dependencies in
place, during the build I ran into the following error:
lib/query.cc: In function 'int
Jumping in here, I have modified the previously posted code here to
provide me with a more complete solution.
With the attach code, I can:
* automatically encrypt mails if all recipients have a *valid* public
key. The previous patch allowed encryption if a key existed but was
revoked,
On Tue, 17 Jan 2012 09:19:51 +, David Edmondson d...@dme.org wrote:
On Mon, 16 Jan 2012 23:48:30 -0500, Antoine Beaupré anar...@anarcat.ath.cx
wrote:
Jumping in here, I have modified the previously posted code here to
provide me with a more complete solution.
This looks good. I'll
On Sun, 22 Jan 2012 12:32:12 +0100, Fabio Zanini fabio.zan...@fastmail.fm
wrote:
Hi!
This is my first message to the list. In 2010 a patch was developed that
enabled notmuch new to ignore certain subdirectories of the mail folder:
http://notmuchmail.org/pipermail/notmuch/2010/003170.html
On Mon, 23 Jan 2012 15:43:08 +0100, Florian Friesdorf f...@chaoflow.net wrote:
With notmuch-0.11 (require 'gnus-art') fixes the void
gnus-inhibit-images error.
This is true, though as Aaron Ecay pointed out in the discussion of this
patch, it does bring in all of gnus. My current workaround to
On Wed, 25 Jan 2012 09:24:46 +, David Edmondson d...@dme.org wrote:
On Wed, 25 Jan 2012 11:19:30 +0200, Tomi Ollila tomi.oll...@iki.fi wrote:
On Wed, 25 Jan 2012 08:52:15 +, David Edmondson d...@dme.org wrote:
`notmuch-show-get-prop' should be declared.
---
How 'bout
not to be scanned as new mails.
Mark the corresponding test as no longer broken
(test from id:1328105573-4626-1-git-send-email-pie...@praet.org ).
This work merges my previous attempts and Andreas Amann's work
in id:ylp7hi23mw8@tyndall.ie
See notes in id:20120202-new-ignore-1-git-send
On Sat, 21 Jan 2012 16:35:10 +0100, Simon Campese notmuchmail_...@campese.de
wrote:
Dear Community,
I've got my own domain and when registering or shopping at some website,
I always use email addresses of the form websiten...@mydomain.org, so
for example I use ama...@mydomain.org when
Here is the latest version of this patch set. I think I have fixed most
of the problems raised in review but there are some remaining issues
detailed below.
Changes and queries:
1) Changed --do-not-exclude option to --no-exclude
2) The api notmuch_query_set_omit_excluded_messages remains:
This option turns off the exclusion so all matching messages are
returned. We do not need to add this to notmuch-show as that does not
(yet) exclude.
---
notmuch-count.c | 17 +++--
notmuch-search.c | 17 +++--
2 files changed, 22 insertions(+), 12 deletions(-)
diff
---
man/man1/notmuch-count.1 |7 +++
man/man1/notmuch-search.1 |7 +++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/man/man1/notmuch-count.1 b/man/man1/notmuch-count.1
index 25fe329..413b405 100644
--- a/man/man1/notmuch-count.1
+++ b/man/man1/notmuch-count.1
Slightly refactor the exclude code to give the callers access to the
exclude query itself. There should be no functional change.
---
lib/query.cc | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/lib/query.cc b/lib/query.cc
index
Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to
notmuch_query_search_threads. Implemented by inspecting the tags
directly in _notmuch_thread_create/_thread_add_message rather than as
a Xapian query for speed reasons.
---
lib/notmuch-private.h |7 +--
lib/query.cc |1 +
This adds the excludes to notmuch-show.c. We do not exclude when only
a single message (or part) is requested. notmuch-show will output the
exclude information when either text or json format is requested. As
this changes the output from notmuch-show it breaks many tests (in a
trivial and expected
On Tue, 24 Jan 2012 20:08:14 +, Clint Adams cl...@debian.org wrote:
I just received an email in RTL script and it was rendered incorrectly
in the emacs interface. Does anyone know what to do about this?
More info please. What is RTL script? Is that right to left? If
so, yikes. I can't
On Thu, 02 Feb 2012 19:26:53 +0200, Jani Nikula j...@nikula.org wrote:
Do you have all those email addresses in the user.other_email
configuration option in your ~/.notmuch-config? It should do the trick,
though I can see that it might get a bit tedious if you use plenty of
email addresses
Amann's work
in id:ylp7hi23mw8@tyndall.ie
See notes in id:20120202-new-ignore-1-git-send-email-...@iki.fi
---
notmuch-client.h |9 +
notmuch-config.c | 30 +-
notmuch-new.c| 45 +
test/new |1
On Fri, 03 Feb 2012 01:07:59 +0200, Jani Nikula j...@nikula.org wrote:
On Thu, 02 Feb 2012 22:27:36 +, Mark Walters markwalters1...@gmail.com
wrote:
On Thu, 02 Feb 2012 23:55:33 +0200, Jani Nikula j...@nikula.org wrote:
Hi Mark -
This is my first look at any version of the
Hi Jameson.
On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
Hey, Dmitry. I'm so sorry I sent my last email on your original patch
before I saw this new series.
No problems.
I do now like your original proposal
better, since it shows the diff
On Wed, 1 Feb 2012 21:37:21 +0100, Pieter Praet wrote:
> Thanks to Dmitry Kurochkin
> for pointing this out: id:"87d39ymyb4.fsf at gmail.com"
> ---
Looks good to me. Minor comments below.
> test/emacs |2 +-
> test/new |6 +++---
> 2 files changed, 4 insertions(+), 4 deletions(-)
Hi Pieter.
On Wed, 01 Feb 2012 21:32:32 +0100, Pieter Praet wrote:
> On Wed, 01 Feb 2012 18:06:05 +0400, Dmitry Kurochkin gmail.com> wrote:
> > On Wed, 01 Feb 2012 14:44:48 +0100, Pieter Praet
> > wrote:
> > > On Mon, 30 Jan 2012 12:13:48 +0400, Dmitry Kurochkin > > gmail.com> wrote:
> > > >
Hi Jameson.
On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins wrote:
> On Wed, 01 Feb 2012 14:37:53 +0400, Dmitry Kurochkin gmail.com> wrote:
> > On Wed, 01 Feb 2012 12:18:08 +0200, Tomi Ollila
> > wrote:
> > >
> > > There are at least these options here
> > >
> > > 1) go through
Hi all.
This is my second attempt to solve the test_expect_equal_file()
argument issue, based on Tomi's idea [1]. The first attempt and the
following discussion can be found here [2].
Regards,
Dmitry
[1] id:"m28vknaq5l.fsf at guru.guru-group.fi"
[2]
Test_expect_equal_file() function treats the first argument as "actual
output file" and the second argument as "expected output file". When
the test fails, the files are copied for later inspection. The first
files is copied to "$testname.output" and the second file to
"$testname.expected". The
The patch fixes tests which were broken by the new
test_expect_equal_file() argument check. Some tests have correct
filename format, but wrong argument order. Others require files to be
renamed.
---
test/crypto | 10 +-
test/dump-restore| 10 +-
test/hooks
On Thu, 02 Feb 2012 03:42:29 +0400, Dmitry Kurochkin wrote:
> Hi Jameson.
>
> On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins finestructure.net> wrote:
> > On Wed, 01 Feb 2012 14:37:53 +0400, Dmitry Kurochkin > gmail.com> wrote:
> > > On Wed, 01 Feb 2012 12:18:08 +0200, Tomi Ollila
I rebased these against branch release (and copied a comment from
aaron's email), but the test fails there, as does the reply within emacs test.
FAIL Reply within emacs
--- emacs.24.expected 2012-02-02 03:55:14.0 +
+++ emacs.24.output 2012-02-02
From: Aaron Ecay
The test is broken at this time; the next commit will introduce a fix.
---
test/emacs| 12
test/emacs.expected-output/quote-mml-in-reply |7 +++
2 files changed, 19 insertions(+), 0 deletions(-)
From: Aaron Ecay
Emacs message-mode uses certain text strings to indicate how to attach
files to outgoing mail. If these are present in the text of an email,
and a user is tricked into replying to the message, the user?s files
could be exposed.
Using point-max would
v6:
- add `notmuch-show-only-matching-messages' to allow a user to choose
that as the default behaviour.
- allow a prefix argument to `notmuch-show' to invert the default
value of `notmuch-show-only-matching-messages'.
David Edmondson (8):
emacs: Rework crypto switch toggle.
emacs: Allow
---
emacs/notmuch-show.el |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index a07a44a..8d318c9 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1121,6 +1121,7 @@ Refreshes the current view, observing
Re-work the existing crypto switch toggle to be based on a persistant
buffer-local variable.
To allow this, modify `notmuch-show-refresh-view' to erase and re-draw
in the current buffer rather than killing the current buffer and
creating a new one. (This will also allow more per-buffer behaviour
Very deeply indented content is sometimes difficult to
read (particular for something like patches). Allow the indentation of
the content to be toggled with '<'.
Indentation of the header lines is not affected, so it remains
possible to see the structure of the thread.
---
emacs/notmuch-show.el
The current behaviour (all messages shown, non-matching collapsed)
is retained as the default. Type '!' to switch to showing only
the matching messages - non-matching messages are not available.
'!' will switch back to showing everything.
---
emacs/notmuch-show.el | 18 +-
1
---
emacs/notmuch-show.el |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 1b31166..895feb5 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1671,7 +1671,7 @@ added."
(interactive "P")
(let
Allow the user to choose that only matching messages are shown by
default.
---
emacs/notmuch-show.el |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 895feb5..ae7af02 100644
--- a/emacs/notmuch-show.el
+++
With an argument, record and reply the state of the buffer during
`notmuch-show-refresh-view'.
In this context, "state" is defined as:
- the open/closed state of each message,
- the current message.
Traditional use of refresh with the = key does not retain the
state. The recently introduced
Allow the user to open a thread with inverted
`notmuch-show-only-matching-messages' behaviour using a prefix
argument.
---
emacs/notmuch-show.el |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index ae7af02..e9aa4e7 100644
pipermail/notmuch/attachments/20120202/9b53e36a/attachment.pgp>
Add default value to notmuch-search-line-faces to show "unread"
messages in bold, and "flagged" messages in blue, to have some visual
indication of important messages in search results. This should be
helpful for new users.
"unread" tag is quite obvious, and handled specially both in the lib
and
s attempts and Andreas Amann's work
in id:"ylp7hi23mw8.fsf at tyndall.ie"
See notes in id:"20120202-new-ignore-1-git-send-email-too at iki.fi"
---
Whenever some already existing directory is added to the exclude list
and the parent directory timestamp has not changed, notmuch new wil
On Thu, 02 Feb 2012 14:33:56 +, David Edmondson wrote:
> On Wed, 01 Feb 2012 09:24:32 -0800, Jameson Graef Rollins finestructure.net> wrote:
> > If this is really a problem, I vote for 1. In general, I am not in
> > favor of making the test suite more complicated than it needs to be.
>
>
On Thu, 2 Feb 2012 16:58:41 +0200, Jani Nikula wrote:
> Add default value to notmuch-search-line-faces to show "unread"
> messages in bold, and "flagged" messages in blue, to have some visual
> indication of important messages in search results. This should be
> helpful for new users.
>
>
wants not to be scanned as new mails.
>
> Mark the corresponding test as no longer broken
> (test from id:"1328105573-4626-1-git-send-email-pieter at praet.org" ).
>
> This work merges my previous attempts and Andreas Amann's work
> in id:"ylp7hi23mw8.fsf at tyndall.ie"
>
On Sat, 21 Jan 2012 16:35:10 +0100, Simon Campese wrote:
> Dear Community,
>
> I've got my own domain and when registering or shopping at some website,
> I always use email addresses of the form "websitename at mydomain.org", so
> for example I use "amazon at mydomain.org" when shopping at
Here is the latest version of this patch set. I think I have fixed most
of the problems raised in review but there are some remaining issues
detailed below.
Changes and queries:
1) Changed --do-not-exclude option to --no-exclude
2) The api notmuch_query_set_omit_excluded_messages remains:
y about all the chatter.
+1
jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120202/99189dc3/attachment.pgp>
This option turns off the exclusion so all matching messages are
returned. We do not need to add this to notmuch-show as that does not
(yet) exclude.
---
notmuch-count.c | 17 +++--
notmuch-search.c | 17 +++--
2 files changed, 22 insertions(+), 12 deletions(-)
diff
---
man/man1/notmuch-count.1 |7 +++
man/man1/notmuch-search.1 |7 +++
2 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/man/man1/notmuch-count.1 b/man/man1/notmuch-count.1
index 25fe329..413b405 100644
--- a/man/man1/notmuch-count.1
+++ b/man/man1/notmuch-count.1
The tests test the new --no-exclude option to search and count.
There were no existing tests for the exclude behaviour for count so
added these too.
---
test/count | 21 +
test/search |5 +
2 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/test/count
Slightly refactor the exclude code to give the callers access to the
exclude query itself. There should be no functional change.
---
lib/query.cc | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/lib/query.cc b/lib/query.cc
index
Add a flag NOTMUCH_MESSAGE_FLAG_EXCLUDED which is set by
notmuch_query_search_messages for excluded messages. Also add an
option omit_excluded_messages to the search that we do not want the
excludes at all.
This exclude flag will be added to notmuch_query_search threads in the
next patch.
---
Add the NOTMUCH_MESSAGE_FLAG_EXCLUDED flag to
notmuch_query_search_threads. Implemented by inspecting the tags
directly in _notmuch_thread_create/_thread_add_message rather than as
a Xapian query for speed reasons.
---
lib/notmuch-private.h |7 +--
lib/query.cc |1 +
The function is
notmuch_thread_get_flag_messages
(notmuch_thread_t *thread, unsigned int flag_mask, unsigned int flags)
and returns the number of messages with the specified flags on flag_mask.
This generalises the existing function
notmuch_thread_get_total_messages and
This adds the excludes to notmuch-show.c. We do not exclude when only
a single message (or part) is requested. notmuch-show will output the
exclude information when either text or json format is requested. As
this changes the output from notmuch-show it breaks many tests (in a
trivial and expected
In all cases of notmuch count/search/show where the results returned
cannot reflect the exclude flag return just the matched not-excluded
results. If the caller wishes to have all the matched results (i.e.,
including the excluded ones) they should call with the
--no-exclude option.
The relevant
Show mode will recognize the exclude flag by not opening excluding
messages by default, and will start at the first matching non-excluded
message. If there are no matching non-excluded messages it will go to
the first matching (necessarily excluded) message.
---
emacs/notmuch-show.el | 18
notmuch show outputs the exclude flag so many tests using notmuch
show failed. This commit adds "excluded:0" or "excluded: false" to
the expected outputs. After this commit there should be no failing
tests.
---
test/crypto|9 -
test/encoding |2 +-
test/json
ication/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120202/d9ce0965/attachment-0001.pgp>
---
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120202/cc8c6038/attachment.pgp>
s attempts and Andreas Amann's work
in id:"ylp7hi23mw8.fsf at tyndall.ie"
See notes in id:"20120202-new-ignore-1-git-send-email-too at iki.fi"
---
notmuch-client.h |9 +
notmuch-config.c | 30 +-
notmuch-new.c| 45 +
1 - 100 of 109 matches
Mail list logo