[PATCH 1/2] NEWS: markup changes to make mdwn->html look slightly better

On Wed, 1 Feb 2012 17:22:49 +0200, Tomi Ollila wrote: > Some formatting in NEWS file has been changed so that it could > be given to markdown processing almost verbatim. > More effort has been put into formatting of version 0.11 (and 0.12) > of notmuch NEWS than previous versions but everything

Bug: emacs 23.2 doesn't like ido-completing-read

On Sat, 04 Feb 2012 12:31:57 +, Mark Walters wrote: > > I hadn't realised before but this also goes wrong if you use the prefix > argument to mail (eg ctrl-u m). The current code seems to mess up the > mini-buffer and even closing the buffer does not get out of it. > > Changing

[PATCH v2 4/4] test: test the new --from option to notmuch-reply

--- test/reply | 69 1 files changed, 69 insertions(+), 0 deletions(-) diff --git a/test/reply b/test/reply index 00f4bea..0bb22bb 100755 --- a/test/reply +++ b/test/reply @@ -138,4 +138,73 @@ References: <${gen_msg_id}> On Tue, 05

[PATCH v2 3/4] emacs: Improve prompting for user address when replying.

This patch uses the new --from option to notmuch reply to allow it to prompt the user for the From: address in cases when the cli does not know the "correct" from address. If the cli does not it either uses the users default address or, if notmuch-always-prompt-for-sender is set, prompts the user.

[PATCH v2 2/4] cli: update man page for notmuch-reply --from:

--- man/man1/notmuch-reply.1 | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/man/man1/notmuch-reply.1 b/man/man1/notmuch-reply.1 index 5160ece..101ed47 100644 --- a/man/man1/notmuch-reply.1 +++ b/man/man1/notmuch-reply.1 @@ -62,6 +62,33 @@

[PATCH v2 1/4] cli: add --from option to reply to restrict guessing of the From: header.

Add an option --from= to notmuch-reply.c to restrict guessing of the From: header. The existing logic looks as the main headers, then at the delivery headers, and finally defaults to the config file address. This patch allows the user to restrict which of these guesses are made. Currently the

[Patch v2 0/4] Control selection of From: header when replying

This is version 2 of the patch set first posted in id:"1328375350-10352-1-git-send-email-markwalters1009 at gmail.com" This fixes the bug Jani pointed out as well as the more minor criticisms. It also has some tests and the man pages are updated. Best wishes Mark

Bug: emacs 23.2 doesn't like ido-completing-read

On Sat, 04 Feb 2012 22:14:25 +0200, Tomi Ollila wrote: > On Sat, 04 Feb 2012 12:31:57 +, Mark Walters gmail.com> wrote: > > > > I hadn't realised before but this also goes wrong if you use the prefix > > argument to mail (eg ctrl-u m). The current code seems to mess up the > > mini-buffer

[PATCH 2/2] emacs: Improve prompting for user address when replying.

On Sat, 4 Feb 2012 17:09:10 +, Mark Walters wrote: > This patch uses the new --from option to notmuch reply to allow it to > prompt the user for the From: address in cases when the cli does not > know the "correct" from address. If the cli does not it either uses > the users default address

[PATCH 1/2] cli: add --from option to reply to restrict guessing of the From: header.

On Sat, 4 Feb 2012 17:09:09 +, Mark Walters wrote: > Add an option --from= to notmuch-reply.c to restrict guessing of the > From: header. The existing logic looks as the main headers, then at > the delivery headers, and finally defaults to the config file address. > > This patch allows the

[PATCH 2/2] emacs: Improve prompting for user address when replying.

On Sat, 04 Feb 2012 20:03:13 +0200, Jani Nikula wrote: > On Sat, 4 Feb 2012 17:09:10 +, Mark Walters gmail.com> wrote: > > This patch uses the new --from option to notmuch reply to allow it to > > prompt the user for the From: address in cases when the cli does not > > know the "correct"

[PATCH 1/2] cli: add --from option to reply to restrict guessing of the From: header.

On Sat, 04 Feb 2012 19:59:58 +0200, Jani Nikula wrote: > On Sat, 4 Feb 2012 17:09:09 +, Mark Walters gmail.com> wrote: > > Add an option --from= to notmuch-reply.c to restrict guessing of the > > From: header. The existing logic looks as the main headers, then at > > the delivery headers,

[PATCH 2/2] emacs: Improve prompting for user address when replying.

This patch uses the new --from option to notmuch reply to allow it to prompt the user for the From: address in cases when the cli does not know the "correct" from address. If the cli does not it either uses the users default address or, if notmuch-always-prompt-for-sender is set, prompts the user.

[PATCH 1/2] cli: add --from option to reply to restrict guessing of the From: header.

Add an option --from= to notmuch-reply.c to restrict guessing of the From: header. The existing logic looks as the main headers, then at the delivery headers, and finally defaults to the config file address. This patch allows the user to restrict which of these guesses are made. Currently the

[PATCH 0/2] Control guessing of the from-address when replying

Hello This patch sets is intended to allow the user more control over the From: address when replying to emails. In notmuch-reply.c the current logic for the From: address looks as the main headers, then at the delivery headers, and finally defaults to the config file address. This means that

[PATCH v2 2/2] show: Simplify new text formatter code

This makes the text formatter take advantage of the new code structure. The previously duplicated header logic is now unified, several things that we used to compute repeatedly across different callbacks are now computed once, and the code is simpler overall and 32% shorter. Unifying the header

[PATCH v2 1/2] show: Convert text format to the new self-recursive style

This is all code movement and a smidgen of glue. This moves the existing text formatter code into one self-recursive function, but doesn't change any of the logic. The next patch will actually take advantage of what the new structure has to offer. Note that this patch retains

[PATCH v2 0/2] Rewrite text show format

v2 * Remove unnecessary braces (id:87lioooj7m.fsf at gmail.com) * Trivial rebase against master

[PATCH 1/2] show: Convert text format to the new self-recursive style

Quoth Dmitry Kurochkin on Jan 31 at 3:26 am: > On Thu, 26 Jan 2012 01:55:25 -0500, Austin Clements > wrote: > > This is all code movement and a smidgen of glue. This moves the > > existing text formatter code into one self-recursive function, but > > doesn't change any of the logic. The next

[RFC PATCH v2] emacs: make show view a/A/x/X key bindings more consistent

On Tue, 31 Jan 2012 19:29:06 +0200, Jani Nikula wrote: > Modify the show view key bindings as follows to make them more > consistent: Last chance for objections... d

For gmail how do you setup notmuch mail ?...

On Sat, 04 Feb 2012 09:15:16 +, David Edmondson wrote: > On Sat, 4 Feb 2012 03:39:23 -0500, don warner saklad gmail.com> wrote: > > a) For gmail how do you setup notmuch mail ?... > > > > b) Any workarounds? > > > > c) Any kludges? I'll describe my own setup for using notmuch with gmail.

Bug: emacs 23.2 doesn't like ido-completing-read

On Mon, 30 Jan 2012 10:21:38 +, Mark Walters wrote: > On Mon, 30 Jan 2012 09:39:32 +, David Edmondson wrote: > > On Sun, 29 Jan 2012 23:17:55 +, Mark Walters > gmail.com> wrote: > > > I have been experimenting with notmuch-always-prompt-for-sender on my > > > debian stable setup

[PATCH v2 2/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

`Notmuch-wash-region-to-button' is the function that creates hidden regions with buttons for signatures, citations and original messages. Before the change, it did not work correctly if the to-be-hidden region started at the beginning of a message: the visibility toggle button was hidden as well.

[PATCH v2 1/2] test: add test for hiding Original Message region at beginning of a message

The test is currently broken and will be fixed by a subsequent patch. The patch adds a new file for tests of Emacs notmuch-show view. Based on patch by David Edmondson [1]. [1] id:"1327562380-12894-4-git-send-email-dme at dme.org" --- test/emacs-show | 28

[PATCH v2 0/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

Changes since v1: * rebase on the current master, just one trivial conflict so no need for another round of review Regards, Dmitry

[PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

On Sat, 04 Feb 2012 00:00:00 +, Mark Walters wrote: > > On Sat, 4 Feb 2012 00:41:08 +0200, Jani Nikula wrote: > > Use the new notmuch argument parser to handle arguments in "notmuch > > show". There are two corner case functional changes: > > > > 1) Also set params.raw = 1 when

[PATCH 1/2] test: add check for filename argument for test_expect_equal_file

On Fri, 03 Feb 2012 18:04:05 +0400, Dmitry Kurochkin wrote: > On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins finestructure.net> wrote: > > Hey, Dmitry. I'm so sorry I sent my last email on your original patch > > before I saw this new series. I do now like your original proposal > >

[PATCH 0/2] Bug and potential fix: forwarded messages

On Fri, 3 Feb 2012 23:01:23 -0700, Adam Wolfe Gordon wrote: > Oh, and I just noticed that Dmitry has already fixed this, probably in > a better way [1] (though I maintain that there still may be a problem > with the approach in general). I clearly haven't been following

[PATCH 0/2] Bug and potential fix: forwarded messages

On Fri, Feb 3, 2012 at 23:10, Dmitry Kurochkin wrote: > Yep, creating buttons for regions at the beginning of message is fixed. > But I like the idea of not hiding the message if there is no text. > Though, I think we should create the button, just not hide the text > initially. > > This change

For gmail how do you setup notmuch mail ?...

mail via Gmail, or have Emacs do the same directly using the smtpmail.el package. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/at

[PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

On Mon, 30 Jan 2012 16:52:20 +, David Edmondson wrote: > The blank line doesn't really change position, but is now considered > to be part of the body rather than part of the headers. This means > that it is visible when the body is visible rather than when the > headers are visible. pushed.

[PATCH] emacs: More address cleaning.

On Mon, 30 Jan 2012 14:59:54 +, David Edmondson wrote: > Remove outer single-quotes from the mailbox part. Allow for multiple > sets of nested single and double quotes. pushed, d

[PATCH 0/2 v2] minor cleanup and improvements

On Mon, 30 Jan 2012 10:15:59 +, David Edmondson wrote: > Address the comments from Mark and Austin: > - Don't assume that `subject' is a string, > - Show [No Subject] in search output pushed, d

[PATCH 3/3] lib: Use talloc to simplify cleanup in notmuch_database_open

On Sun, 29 Jan 2012 00:50:10 -0500, Austin Clements wrote: > Previously, we manually "free"d various pointers in > notmuch_database_open. Use a local talloc context instead to simplify > cleanup and eliminate various NULL pointer initializations and > conditionals. pushed all 3. d

[PATCH] tag: remove unused attribute from notmuch_tag_command() arguments

On Sat, 28 Jan 2012 12:02:33 +0400, Dmitry Kurochkin wrote: > Argc and argv arguments are used in notmuch_tag_command() function. > So unused attribute is not appropriate for them. pushed, d

[PATCH] test: remove ".sh" extension from the recently added Emacs tests

On Sat, 28 Jan 2012 08:47:39 +0400, Dmitry Kurochkin wrote: > All test files, except for the recently added Emacs tests, do not have > ".sh" extension. So remove it from the new test files for consistency. pushed d

[PATCH] configure: update explicit check for glib : >= 2.22

On Fri, 3 Feb 2012 13:12:25 +0100, Pieter Praet wrote: > As of commit b3caef1f, we're using g_array_unref() in 'lib/query.cc', > which was only introduced in glib 2.22, so update the dependency. pushed d

[PATCH v2 0/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

On Sat, 4 Feb 2012 11:36:35 +0400, Dmitry Kurochkin wrote: > Changes since v1: > > * rebase on the current master, just one trivial conflict so no need > for another round of review > pushed, d

For gmail how do you setup notmuch mail ?...

a) For gmail how do you setup notmuch mail ?... b) Any workarounds? c) Any kludges?

[PATCH 2/2] cli: reach previously unreachable cleanup code in "notmuch show"

The last lines of notmuch_show_command() function were unreachable. Fix it by using a variable for return value. Signed-off-by: Jani Nikula --- notmuch-show.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index f93e121..b18e279

[PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

Use the new notmuch argument parser to handle arguments in "notmuch show". There are two corner case functional changes: 1) Also set params.raw = 1 when defaulting to raw format when part is requested but format is not specified. 2) Do not set params.decrypt if crypto context creation fails.

notmuch release 0.11.1 now available

org/pipermail/notmuch/attachments/20120204/07e8e0ff/attachment.pgp>

[PATCH 1/2] cli: convert "notmuch show" to use the new argument parser

On Sat, 4 Feb 2012 00:41:08 +0200, Jani Nikula wrote: > Use the new notmuch argument parser to handle arguments in "notmuch > show". There are two corner case functional changes: > > 1) Also set params.raw = 1 when defaulting to raw format when part is >requested but format is not

For gmail how do you setup notmuch mail ?...

a) For gmail how do you setup notmuch mail ?... b) Any workarounds? c) Any kludges? ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/2] cli: convert notmuch show to use the new argument parser

On Sat, 04 Feb 2012 00:00:00 +, Mark Walters markwalters1...@gmail.com wrote: On Sat, 4 Feb 2012 00:41:08 +0200, Jani Nikula j...@nikula.org wrote: Use the new notmuch argument parser to handle arguments in notmuch show. There are two corner case functional changes: 1) Also set

Re: For gmail how do you setup notmuch mail ?...

On Sat, 4 Feb 2012 03:39:23 -0500, don warner saklad don.sak...@gmail.com wrote: a) For gmail how do you setup notmuch mail ?... b) Any workarounds? c) Any kludges? notmuch wants to be able to access your mail as individual files in the filesystem. That means you need a way to get the

Re: Bug: emacs 23.2 doesn't like ido-completing-read

On Mon, 30 Jan 2012 10:21:38 +, Mark Walters markwalters1...@gmail.com wrote: On Mon, 30 Jan 2012 09:39:32 +, David Edmondson d...@dme.org wrote: On Sun, 29 Jan 2012 23:17:55 +, Mark Walters markwalters1...@gmail.com wrote: I have been experimenting with

Re: For gmail how do you setup notmuch mail ?...

On Sat, 04 Feb 2012 09:15:16 +, David Edmondson d...@dme.org wrote: On Sat, 4 Feb 2012 03:39:23 -0500, don warner saklad don.sak...@gmail.com wrote: a) For gmail how do you setup notmuch mail ?... b) Any workarounds? c) Any kludges? I'll describe my own setup for using notmuch

Re: [PATCH v2 0/2] emacs: fix `notmuch-wash-region-to-button' to work at beginning of buffer

On Sat, 4 Feb 2012 11:36:35 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Changes since v1: * rebase on the current master, just one trivial conflict so no need for another round of review pushed, d ___ notmuch mailing list

Re: [PATCH] test: remove .sh extension from the recently added Emacs tests

On Sat, 28 Jan 2012 08:47:39 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: All test files, except for the recently added Emacs tests, do not have .sh extension. So remove it from the new test files for consistency. pushed d ___ notmuch

Re: [PATCH] tag: remove unused attribute from notmuch_tag_command() arguments

On Sat, 28 Jan 2012 12:02:33 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Argc and argv arguments are used in notmuch_tag_command() function. So unused attribute is not appropriate for them. pushed, d ___ notmuch mailing list

Re: [PATCH 3/3] lib: Use talloc to simplify cleanup in notmuch_database_open

On Sun, 29 Jan 2012 00:50:10 -0500, Austin Clements amdra...@mit.edu wrote: Previously, we manually freed various pointers in notmuch_database_open. Use a local talloc context instead to simplify cleanup and eliminate various NULL pointer initializations and conditionals. pushed all 3. d

Re: [PATCH 0/2 v2] minor cleanup and improvements

On Mon, 30 Jan 2012 10:15:59 +, David Edmondson d...@dme.org wrote: Address the comments from Mark and Austin: - Don't assume that `subject' is a string, - Show [No Subject] in search output pushed, d ___ notmuch mailing list

Re: [PATCH] emacs: More address cleaning.

On Mon, 30 Jan 2012 14:59:54 +, David Edmondson d...@dme.org wrote: Remove outer single-quotes from the mailbox part. Allow for multiple sets of nested single and double quotes. pushed, d ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH] emacs: Move the blank line from the bottom of the headers to the top of the body.

On Mon, 30 Jan 2012 16:52:20 +, David Edmondson d...@dme.org wrote: The blank line doesn't really change position, but is now considered to be part of the body rather than part of the headers. This means that it is visible when the body is visible rather than when the headers are visible.

Re: [PATCH 0/2] Bug and potential fix: forwarded messages

On Fri, Feb 3, 2012 at 23:10, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Yep, creating buttons for regions at the beginning of message is fixed. But I like the idea of not hiding the message if there is no text. Though, I think we should create the button, just not hide the text

[PATCH 1/2] cli: add --from option to reply to restrict guessing of the From: header.

Add an option --from= to notmuch-reply.c to restrict guessing of the From: header. The existing logic looks as the main headers, then at the delivery headers, and finally defaults to the config file address. This patch allows the user to restrict which of these guesses are made. Currently the

Re: [PATCH 2/2] emacs: Improve prompting for user address when replying.

On Sat, 4 Feb 2012 17:09:10 +, Mark Walters markwalters1...@gmail.com wrote: This patch uses the new --from option to notmuch reply to allow it to prompt the user for the From: address in cases when the cli does not know the correct from address. If the cli does not it either uses the

Re: [PATCH v6 3/3] post-merge fixes

On Fri, 3 Feb 2012 11:24:09 +0100, Pieter Praet pie...@praet.org wrote: --- emacs/notmuch-mua.el |2 +- test/emacs |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) split into two commits and pushed, d ___ notmuch mailing

Re: [PATCH 1/2] cli: add --from option to reply to restrict guessing of the From: header.

On Sat, 04 Feb 2012 19:59:58 +0200, Jani Nikula j...@nikula.org wrote: On Sat, 4 Feb 2012 17:09:09 +, Mark Walters markwalters1...@gmail.com wrote: Add an option --from= to notmuch-reply.c to restrict guessing of the From: header. The existing logic looks as the main headers, then at

Re: [PATCH 2/2] emacs: Improve prompting for user address when replying.

On Sat, 04 Feb 2012 20:03:13 +0200, Jani Nikula j...@nikula.org wrote: On Sat, 4 Feb 2012 17:09:10 +, Mark Walters markwalters1...@gmail.com wrote: This patch uses the new --from option to notmuch reply to allow it to prompt the user for the From: address in cases when the cli does

Re: [RFC PATCH v2] emacs: make show view a/A/x/X key bindings more consistent

On Tue, 31 Jan 2012 19:29:06 +0200, Jani Nikula j...@nikula.org wrote: Modify the show view key bindings as follows to make them more consistent: Last chance for objections... d ___ notmuch mailing list notmuch@notmuchmail.org

Re: Bug: emacs 23.2 doesn't like ido-completing-read

On Sat, 04 Feb 2012 12:31:57 +, Mark Walters markwalters1...@gmail.com wrote: I hadn't realised before but this also goes wrong if you use the prefix argument to mail (eg ctrl-u m). The current code seems to mess up the mini-buffer and even closing the buffer does not get out of it.

Re: Bug: emacs 23.2 doesn't like ido-completing-read

On Sat, 04 Feb 2012 22:14:25 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: On Sat, 04 Feb 2012 12:31:57 +, Mark Walters markwalters1...@gmail.com wrote: I hadn't realised before but this also goes wrong if you use the prefix argument to mail (eg ctrl-u m). The current code seems to

[Patch v2 0/4] Control selection of From: header when replying

This is version 2 of the patch set first posted in id:1328375350-10352-1-git-send-email-markwalters1...@gmail.com This fixes the bug Jani pointed out as well as the more minor criticisms. It also has some tests and the man pages are updated. Best wishes Mark

[PATCH v2 1/4] cli: add --from option to reply to restrict guessing of the From: header.

Add an option --from= to notmuch-reply.c to restrict guessing of the From: header. The existing logic looks as the main headers, then at the delivery headers, and finally defaults to the config file address. This patch allows the user to restrict which of these guesses are made. Currently the

[PATCH v2 2/4] cli: update man page for notmuch-reply --from:

--- man/man1/notmuch-reply.1 | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/man/man1/notmuch-reply.1 b/man/man1/notmuch-reply.1 index 5160ece..101ed47 100644 --- a/man/man1/notmuch-reply.1 +++ b/man/man1/notmuch-reply.1 @@ -62,6 +62,33 @@

[PATCH v2 3/4] emacs: Improve prompting for user address when replying.

This patch uses the new --from option to notmuch reply to allow it to prompt the user for the From: address in cases when the cli does not know the correct from address. If the cli does not it either uses the users default address or, if notmuch-always-prompt-for-sender is set, prompts the user.

[PATCH v2 4/4] test: test the new --from option to notmuch-reply

--- test/reply | 69 1 files changed, 69 insertions(+), 0 deletions(-) diff --git a/test/reply b/test/reply index 00f4bea..0bb22bb 100755 --- a/test/reply +++ b/test/reply @@ -138,4 +138,73 @@ References: ${gen_msg_id} On Tue, 05

Re: [PATCH 1/2] show: Convert text format to the new self-recursive style

Quoth Dmitry Kurochkin on Jan 31 at 3:26 am: On Thu, 26 Jan 2012 01:55:25 -0500, Austin Clements amdra...@mit.edu wrote: This is all code movement and a smidgen of glue. This moves the existing text formatter code into one self-recursive function, but doesn't change any of the logic. The

Re: [PATCH v2 1/4] cli: add --from option to reply to restrict guessing of the From: header.

On Sat, 4 Feb 2012 20:45:14 +, Mark Walters markwalters1...@gmail.com wrote: Add an option --from= to notmuch-reply.c to restrict guessing of the From: header. The existing logic looks as the main headers, then at the delivery headers, and finally defaults to the config file address.

Re: [PATCH 1/2] NEWS: markup changes to make mdwn-html look slightly better

On Wed, 1 Feb 2012 17:22:49 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: Some formatting in NEWS file has been changed so that it could be given to markdown processing almost verbatim. More effort has been put into formatting of version 0.11 (and 0.12) of notmuch NEWS than previous versions

Re: [PATCH v3 09/10] random-dump.c: new test-binary to generate dump files

On Sat, 14 Jan 2012 21:40:23 -0400, David Bremner da...@tethera.net wrote: From: David Bremner brem...@debian.org This binary creates a torture test dump file for the new dump format. --- test/Makefile.local |4 ++ test/basic |2 +- test/random-dump.c | 144

Re: [Patch v2 0/4] Control selection of From: header when replying

Hi Mark. I am not sure I like this solution. My concerns are: * New option looks too complex, too specific. * There are more aspects of notmuch reply behavior which users would like to change (e.g. which part to quote). If we add an option for each, we complicate both nomtuch show UI and

Re: [PATCH 1/2] test: auto load elisp tests file in test_emacs if available

Hi David. I think this is a pretty simple change. And there is one +1 for it. So I am going to remove the needs-review tag, please add it back if you disagree. Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH v5 00/12] emacs: more flexible and consistent tagging operations

Changes: v4: * rebased on master, no conflicts so no need for another review v4: * rebased on master after Jameson's archiving changes v3: * merged 3 `notmuch-show-tag-all'-related patches into one * add patch to clean up tagging function argument names * fix other comments from Austin's

[PATCH v5 01/12] emacs: move tag format validation to `notmuch-tag' function

Before the change, tag format validation was done in `notmuch-search-operate-all' function only. The patch moves it down to `notmuch-tag', so that all users of that function get input validation. --- emacs/notmuch.el | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v5 04/12] emacs: make + and - tagging operations in notmuch-show more flexible

Before the change, + and - tagging operations in notmuch-show view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function, which allows to enter multiple tags with + and - prefixes. So after the change, + and - bindings in notmuch-show view

[PATCH v5 03/12] emacs: make + and - tagging operations in notmuch-search more flexible

Before the change, + and - tagging operations in notmuch-search view accepted only a single tag. The patch makes them use the recently added `notmuch-read-tag-changes' function (renamed `notmuch-select-tags-with-completion'), which allows to enter multiple tags with + and - prefixes. So after

[PATCH v5 05/12] test: fix emacs tests after tagging operations changes

After the recent tagging operations changes, functions bound to + and - in notmuch-search and notmuch-show views always read input from the minibuffer. Use kbd macros instead of calling them directly. --- test/emacs | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-)

[PATCH v5 06/12] emacs: rename `notmuch-search-operate-all' to `notmuch-search-tag-all'

`Notmuch-search-tag-all' is more clear and consistent with other tagging function names. --- emacs/notmuch.el |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 1b472dd..1f351a5 100644 --- a/emacs/notmuch.el +++

[PATCH v5 08/12] emacs: separate history for operations which accept single and multiple tags

Some tag-related operations accept a single tag without prefix (`notmuch-select-tag-with-completion'), others accept multiple tags prefixed with '+' or '-' (`notmuch-read-tag-changes'). Before the change, both functions used a single default minibuffer history. This is inconvenient because you

[PATCH v5 09/12] emacs: relax tag syntax check in `notmuch-tag' function

The tag syntax check in `notmuch-tag' function was too strict and did not allow nmbug tags with ::. Since the check is done for all tagging operations in Emacs UI, this basically means that no nmbug tags can be changed. The patch relaxes the tag syntax check to allow any tag names that do not

[PATCH v5 10/12] emacs: accept empty tag list in `notmuch-tag'

Since `notmuch-tag' is a non-interactive function and hence is meant to be invoked programmatically, it should accept zero tags. Also, the tagging operations (bound to *, +, -) would accept empty input without an error. --- emacs/notmuch.el | 10 +- 1 files changed, 5 insertions(+), 5

[PATCH v5 11/12] emacs: s/tags/tag-changes/ for arguments of tagging functions

This makes the argument names more consistent and clear. The following functions changed: `notmuch-tag', `notmuch-search-tag-thread', `notmuch-search-tag-region' and `notmuch-search-tag-all'. --- emacs/notmuch.el | 33 + 1 files changed, 17 insertions(+), 16

[PATCH v5 12/12] NEWS: document Emacs UI tagging operations changes

--- NEWS | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 5c5b645..f449fba 100644 --- a/NEWS +++ b/NEWS @@ -39,6 +39,24 @@ Reply to sender and search modes, 'r' has been bound to reply to sender, replacing reply to all, which now