Re: [PATCH 0/2] Query debug improvements

2012-03-17 Thread Jameson Graef Rollins
On Tue, 13 Mar 2012 22:31:29 -0400, Austin Clements amdra...@mit.edu wrote: Two simple improvements for query debugging. Awesome. These are both great, and I wholeheartedly support easier on-the-fly debugging. LGTM. jamie. pgpsIojgdJqkD.pgp Description: PGP signature

Re: [RFC] http://notmuchmail.org/searching/ [was: Re: Improving notmuch query documentation]

2012-03-17 Thread Andrei POPESCU
On Vi, 16 mar 12, 20:20:17, Austin Clements wrote: It is, quite literally, the manpage. notmuch execs man when you run notmuch help. Aha. This was an intentional change a few releases ago. Previously, we did have separate manpages and internal help documentation and it didn't work very

Re: [PATCH 3/5] cli: move search to the new --exclude= naming scheme.

2012-03-17 Thread Austin Clements
Quoth Mark Walters on Mar 15 at 6:42 pm: This commit replaces the --no-exclude option with a --exclude=(true|false|flag) option. The default is to omit the excluded messages. The flag option only makes sense if output=summary (as otherwise there is nowhere to print the flag). In summary

Fix error reporting in notmuch_database_find_message_by_filename

2012-03-17 Thread Justus Winter
while valgrinding a crashing python process I noticed that the error handling in notmuch_database_find_message_by_filename does not work as advertised in the documentation. I'd love to see this in the 0.12 release ;) Justus ___ notmuch mailing list

[PATCH] Fix error reporting in notmuch_database_find_message_by_filename

2012-03-17 Thread Justus Winter
Formerly it was possible for *message_ret to be left uninitialized. The documentation however clearly states that [o]n any failure or when the message is not found, this function initializes '*message' to NULL. Signed-off-by: Justus Winter 4win...@informatik.uni-hamburg.de --- lib/database.cc |

Re: [PATCH 4/5] cli: move show to the new --exclude= option naming scheme.

2012-03-17 Thread Austin Clements
Quoth Mark Walters on Mar 15 at 6:42 pm: This moves show to the --exclude=(true|false|flag) naming scheme. When `exclude' is false or flag show returns all threads that match including those that only match in an excluded message, the difference being whether excluded messages are flagged

Re: [PATCH 5/5] emacs: make show set --exclude=flag

2012-03-17 Thread Austin Clements
Quoth Mark Walters on Mar 15 at 6:42 pm: Show has to set --exclude=flag to deal with cases where it is asked to show a single excluded message. It uses JSON so it can easily pass the exclude information to the user. --- emacs/notmuch-show.el |6 -- 1 files changed, 4 insertions(+),

Re: [RFC] http://notmuchmail.org/searching/ [was: Re: Improving notmuch query documentation]

2012-03-17 Thread Austin Clements
Quoth Andrei POPESCU on Mar 17 at 4:40 pm: As I see it, the manpage (specifically section 'SEARCH SYNTAX' needs to be expanded somewhat and 'help search-terms' shortened (a lot). I realized that I didn't have a 'SEARCH SYNTAX' section and went digging into notmuch's code history. Are you

Re: [PATCH] Fix error reporting in notmuch_database_find_message_by_filename

2012-03-17 Thread Austin Clements
Quoth Justus Winter on Mar 17 at 5:41 pm: Formerly it was possible for *message_ret to be left uninitialized. The documentation however clearly states that [o]n any failure or when the message is not found, this function initializes '*message' to NULL. Signed-off-by: Justus Winter

Re: [PATCH v7 00/10] Reply enhancements

2012-03-17 Thread Jameson Graef Rollins
On Sun, 11 Mar 2012 22:05:32 -0600, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: * I noticed that reply supports a --decrypt option, and the emacs interface actually does use it. I've documented the option in the reply man page. If someone can test that replying to encrypted messages

Re: buttonizing links in html parts (emacs)

2012-03-17 Thread Jameson Graef Rollins
On Fri, 09 Mar 2012 13:30:49 -0800, Istvan Marko notm...@kismala.com wrote: I get buttonized html parts with working links as long as I have mm-text-html-renderer set to w3m. I already had this set, and it doesn't seem to do what I want. Links are buttonized, but clicking on them doesn't do

Re: [PATCH v7 00/10] Reply enhancements

2012-03-17 Thread Adam Wolfe Gordon
On Sat, Mar 17, 2012 at 13:13, Jameson Graef Rollins jroll...@finestructure.net wrote: The test suite actually includes a test for replying to encrypted messages (see crypto: reply to encrypted message).  That test should run as long as gnupg is available on the test system, and if it passes

Re: [PATCH 3/5] cli: move search to the new --exclude= naming scheme.

2012-03-17 Thread Jameson Graef Rollins
On Sat, 17 Mar 2012 11:50:23 -0400, Austin Clements amdra...@mit.edu wrote: We already have many of these, but it would be good to systematically cover the full gamut of possibilities. agreed. jamie. pgpBYt2qIjIXL.pgp Description: PGP signature ___

Re: [RFC] http://notmuchmail.org/searching/ [was: Re: Improving notmuch query documentation]

2012-03-17 Thread Andrei POPESCU
On Sb, 17 mar 12, 13:16:47, Austin Clements wrote: Quoth Andrei POPESCU on Mar 17 at 4:40 pm: As I see it, the manpage (specifically section 'SEARCH SYNTAX' needs to be expanded somewhat and 'help search-terms' shortened (a lot). I realized that I didn't have a 'SEARCH SYNTAX'

[RFC] http://notmuchmail.org/searching/ [was: Re: Improving notmuch query documentation]

2012-03-17 Thread Andrei POPESCU
n-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 490 bytes Desc: Digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120317/e0bd7337/attachment.pgp>

[PATCH 0/2] Query debug improvements

2012-03-17 Thread Jameson Graef Rollins
On Tue, 13 Mar 2012 22:31:29 -0400, Austin Clements wrote: > Two simple improvements for query debugging. Awesome. These are both great, and I wholeheartedly support easier on-the-fly debugging. LGTM. jamie. -- next part -- A non-text attachment was scrubbed... Name:

[Patch v2 0/3] Add test and fix exclude bug

2012-03-17 Thread Jameson Graef Rollins
On Wed, 14 Mar 2012 12:26:51 +, Mark Walters wrote: > The test in the previous patches > id:"1331551914-28323-1-git-send-email-markwalters1009 at gmail.com" > triggered the bug accidentally. It accidentally set the exclude tags > to be "=" and "deleted" rather than just "deleted". The

[PATCH 0/5] Move --no-exclude to --exclude=(true|false|flag)

2012-03-17 Thread Jameson Graef Rollins
On Thu, 15 Mar 2012 18:42:00 +, Mark Walters wrote: > This series changes the --no-exclude options to count, search and show > to --exclude=(true|false|flag). It also changes the default to true > rather than flag for speed and for uncluttered command line output. > > This series replaces

[RFC] http://notmuchmail.org/searching/ [was: Re: Improving notmuch query documentation]

2012-03-17 Thread Andrei POPESCU
manpage? Kind regards, Andrei -- If you can't explain it simply, you don't understand it well enough. (Albert Einstein) -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 490 bytes Desc: Digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120317/01d0a1b4/attachment-0001.pgp>

[PATCH 3/5] cli: move search to the new --exclude= naming scheme.

2012-03-17 Thread Austin Clements
Quoth Mark Walters on Mar 15 at 6:42 pm: > This commit replaces the --no-exclude option with a > --exclude=(true|false|flag) option. The default is to omit the > excluded messages. > > The flag option only makes sense if output=summary (as otherwise there > is nowhere to print the flag). In

Fix error reporting in notmuch_database_find_message_by_filename

2012-03-17 Thread Justus Winter
while valgrinding a crashing python process I noticed that the error handling in notmuch_database_find_message_by_filename does not work as advertised in the documentation. I'd love to see this in the 0.12 release ;) Justus

[PATCH] Fix error reporting in notmuch_database_find_message_by_filename

2012-03-17 Thread Justus Winter
Formerly it was possible for *message_ret to be left uninitialized. The documentation however clearly states that "[o]n any failure or when the message is not found, this function initializes '*message' to NULL". Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> ---

[PATCH 4/5] cli: move show to the new --exclude= option naming scheme.

2012-03-17 Thread Austin Clements
Quoth Mark Walters on Mar 15 at 6:42 pm: > This moves show to the --exclude=(true|false|flag) naming > scheme. When `exclude' is false or flag show returns all threads > that match including those that only match in an excluded message, the > difference being whether excluded messages are flagged

[PATCH 5/5] emacs: make show set --exclude=flag

2012-03-17 Thread Austin Clements
Quoth Mark Walters on Mar 15 at 6:42 pm: > Show has to set --exclude=flag to deal with cases where it is asked > to show a single excluded message. It uses JSON so it can easily pass > the exclude information to the user. > --- > emacs/notmuch-show.el |6 -- > 1 files changed, 4

[RFC] http://notmuchmail.org/searching/ [was: Re: Improving notmuch query documentation]

2012-03-17 Thread Austin Clements
Quoth Andrei POPESCU on Mar 17 at 4:40 pm: > > > As I see it, the manpage (specifically section 'SEARCH SYNTAX' needs to > > > be expanded somewhat and 'help search-terms' shortened (a lot). I realized that I didn't have a 'SEARCH SYNTAX' section and went digging into notmuch's code history.

[PATCH] Fix error reporting in notmuch_database_find_message_by_filename

2012-03-17 Thread Austin Clements
Quoth Justus Winter on Mar 17 at 5:41 pm: > Formerly it was possible for *message_ret to be left > uninitialized. The documentation however clearly states that "[o]n any > failure or when the message is not found, this function initializes > '*message' to NULL". > > Signed-off-by: Justus Winter

[PATCH v7 00/10] Reply enhancements

2012-03-17 Thread Jameson Graef Rollins
35 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120317/7bc0e5d3/attachment.pgp>

buttonizing links in html parts (emacs)

2012-03-17 Thread Jameson Graef Rollins
extra step. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120317/c9043f14/attachment.pgp>

[PATCH v7 00/10] Reply enhancements

2012-03-17 Thread Adam Wolfe Gordon
On Sat, Mar 17, 2012 at 13:13, Jameson Graef Rollins wrote: > The test suite actually includes a test for replying to encrypted > messages (see crypto: "reply to encrypted message"). ?That test should > run as long as gnupg is available on the test system, and if it passes > you should be good to

[PATCH 3/5] cli: move search to the new --exclude= naming scheme.

2012-03-17 Thread Jameson Graef Rollins
e Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120317/f68e9b73/attachment.pgp>

[RFC] http://notmuchmail.org/searching/ [was: Re: Improving notmuch query documentation]

2012-03-17 Thread Andrei POPESCU
well enough. (Albert Einstein) -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 490 bytes Desc: Digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120317/5694c0b1/attachment.pgp>