On Mon, 09 Jul 2012, Austin Clements amdra...@mit.edu wrote:
This fixes the docstings for notmuch-json-read and notmuch-json-eof as
suggested by Mark. No other changes.
This is a definite +1 from me:
It all seems to work perfectly, and fixes a definite bug (and makes it
easy to fix some
This patch uses the JSON structure printer for notmuch search. The
changes necessary for switching to the structure printer are minor, a
large part of this patch is concerned with keeping the normal
unstructured text output.
---
notmuch-search.c | 278
Currently there is no easy way to add support for different structured
formatters (like JSON). For example, adding support for S-Expressions
would result in code duplication.
This patch series amends the situation by introducing structured
formatters, which allow different implementations of
This patch adds a new type structure_printer, which is used for
structured formatting, e.g. JSON or S-Expressions.
The structure contains the following function pointers:
- initial_state: is called to create a state object, that is passed to
all invocations. This should be used to keep track
This patch adds a structured formatter that prints exactly the same JSON as the
built-in JSON printer. All tests pass without change.
Notice that this formatter could be simpler by changing the whitespace
and line-breaks in the generated JSON.
---
Makefile.local | 1 +
On Tue, Jul 10 2012, Austin Clements amdra...@mit.edu wrote:
This fixes the docstings for notmuch-json-read and notmuch-json-eof as
suggested by Mark. No other changes.
+1
Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
In reformatting the line 111 accidentally indented to one indentation
level too much (happens easily when interactively indenting python
code using emacs). The line now has 4 spacess less indentation, thus
restoring it to the block level it belongs.
---
contrib/nmbug/nmbug-status |5 +++--
1
The initial nmbug-status was pretty consistent in it's whitespacing
but a few lines had some leftover slips. Those are now corrected.
Also, most of the code used ' as quoting char. As in Python one can
use ' and interchangeably some code used instead of '. However
the usage of those were
On Sat, 7 Jul 2012 16:12:55 +0100, Mark Walters markwalters1...@gmail.com
wrote:
Do people have any comments in the current form?
Very nice!
Peter
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Hello
Notmuch pick is an emacs view which displays a threaded view of
messages: each message has its own line and the thread structure is
shown with UTF-8 graphics characters (so it looks vaguely similar to
mutt's threaded view)
Pick was originally written by David Edmondon and posted on irc and
All the actual setup done by the real notmuch-pick is in the function
notmuch-pick-init so that is the only function we need to provide.
---
emacs/Makefile.local |3 ++-
emacs/notmuch-pick.el | 28
2 files changed, 30 insertions(+), 1 deletions(-)
create mode
This adds the stub entry to notmuch-pick.el to notmuch.el. We call
notmuch-pick-init when notmuch starts up; by default this function
does nothing but if the user replaces the file by the proper one
from contrib then this will setup key binding for the various entries
to notmuch-pick.
---
notmuch-pick uses the returned buffer to try and make sure it does not
close the wrong buffer.
---
emacs/notmuch-show.el |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 6335d45..1cabd17 100644
---
The way it works is that notmuch unconditionally calls
notmuch-pick-init when started: in the default case (the stub file)
this does nothing, whereas if the user replaces the stub by the full
file this sets up all the keybinding etc.
In case people are interested the relevant code in the
The initial nmbug-status was pretty consistent in it's whitespacing
but a few lines had some leftover slips. Those are now "corrected".
Also, most of the code used ' as quoting char. As in Python one can
use ' and " interchangeably some code used " instead of '. However
the usage of those were
On Mon, 09 Jul 2012, Austin Clements wrote:
> This fixes the docstings for notmuch-json-read and notmuch-json-eof as
> suggested by Mark. No other changes.
This is a definite +1 from me:
It all seems to work perfectly, and fixes a definite bug (and makes it
easy to fix some other bugs when
This patch uses the JSON structure printer for notmuch search. The
changes necessary for switching to the structure printer are minor, a
large part of this patch is concerned with keeping the normal
unstructured text output.
---
notmuch-search.c | 278
Currently there is no easy way to add support for different structured
formatters (like JSON). For example, adding support for S-Expressions
would result in code duplication.
This patch series amends the situation by introducing structured
formatters, which allow different implementations of
This patch adds a new type structure_printer, which is used for
structured formatting, e.g. JSON or S-Expressions.
The structure contains the following function pointers:
- initial_state: is called to create a state object, that is passed to
all invocations. This should be used to keep track
This patch adds a structured formatter that prints exactly the same JSON as the
built-in JSON printer. All tests pass without change.
Notice that this formatter could be simpler by changing the whitespace
and line-breaks in the generated JSON.
---
Makefile.local | 1 +
On Tue, Jul 10 2012, Austin Clements wrote:
> This fixes the docstings for notmuch-json-read and notmuch-json-eof as
> suggested by Mark. No other changes.
+1
Tomi
The initial nmbug-status was pretty consistent in it's whitespacing
but a few lines had some leftover slips. Those are now "corrected".
Also, most of the code used ' as quoting char. As in Python one can
use ' and " interchangeably some code used " instead of '. However
the usage of those were
On Wed, Jul 11 2012, Tomi Ollila wrote:
> In reformatting the line 111 accidentally indented to one indentation
> level too much (happens easily when interactively indenting python
> code using emacs). The line now has 4 spacess less indentation, thus
> restoring it to the block level it
On Sat, 7 Jul 2012 16:12:55 +0100, Mark Walters
wrote:
>
> Do people have any comments in the current form?
Very nice!
Peter
Hello
Notmuch pick is an emacs view which displays a threaded view of
messages: each message has its own line and the thread structure is
shown with UTF-8 graphics characters (so it looks vaguely similar to
mutt's threaded view)
Pick was originally written by David Edmondon and posted on irc and
All the actual setup done by the real notmuch-pick is in the function
notmuch-pick-init so that is the only function we need to provide.
---
emacs/Makefile.local |3 ++-
emacs/notmuch-pick.el | 28
2 files changed, 30 insertions(+), 1 deletions(-)
create mode
This adds the stub entry to notmuch-pick.el to notmuch.el. We call
notmuch-pick-init when notmuch starts up; by default this function
does nothing but if the user replaces the file by the "proper" one
from contrib then this will setup key binding for the various entries
to notmuch-pick.
---
notmuch-pick uses the returned buffer to try and make sure it does not
close the wrong buffer.
---
emacs/notmuch-show.el |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 6335d45..1cabd17 100644
---
> The way it works is that notmuch unconditionally calls
> notmuch-pick-init when started: in the default case (the stub file)
> this does nothing, whereas if the user replaces the stub by the full
> file this sets up all the keybinding etc.
In case people are interested the relevant code in the
29 matches
Mail list logo
