Re: [PATCH 1/5] emacs: compile and load notmuch-pick.el if present.

2012-07-25 Thread Tomi Ollila
On Wed, Jul 25 2012, Mark Walters markwalters1...@gmail.com wrote: Compile and load notmuch-pick.el if present. All the actual setup of pick is done in the function notmuch-pick-init so we call that in the notmuch init function if it is bound. This function will setup all extra keybinding

Re: [PATCH] configure: check whether shell is capable of parameter substring processing

2012-07-25 Thread David Bremner
Tomi Ollila tomi.oll...@iki.fi writes: 'configure' script uses parameter substring extensively. It is Posix shell feature. Original Bourne shell does not have such features. Some systems still ships such shells as /bin/sh (for compatibility reasons -- shell scripts written on those platforms

Re: [PATCH v2] man: show: update man page for entire-thread and json.

2012-07-25 Thread David Bremner
Mark Walters markwalters1...@gmail.com writes: Previously in notmuch show --format=json implied --entire-thread. This is still the default but it is now possible to disable this. Update the manpage to reflect this. pushed d ___ notmuch mailing list

[PATCH 01/18] cli: add stub for insert command

2012-07-25 Thread Peter Wang
This does nothing yet. --- Makefile.local |1 + notmuch-client.h |3 +++ notmuch-insert.c | 27 +++ notmuch.c|3 +++ 4 files changed, 34 insertions(+), 0 deletions(-) create mode 100644 notmuch-insert.c diff --git a/Makefile.local b/Makefile.local

[PATCH 02/18] insert: open database

2012-07-25 Thread Peter Wang
Open the notmuch configuration file and database. --- notmuch-insert.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index 0e061a0..21424cf 100644 --- a/notmuch-insert.c +++ b/notmuch-insert.c @@ -23,5 +23,21 @@ int

[PATCH 03/18] insert: open Maildir tmp file

2012-07-25 Thread Peter Wang
Open a unique file in the Maildir tmp directory. The new message is not yet copied into the file. --- notmuch-insert.c | 80 +- 1 files changed, 79 insertions(+), 1 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index

[PATCH 04/18] insert: copy stdin to Maildir tmp file

2012-07-25 Thread Peter Wang
Read the new message from standard input into the Maildir tmp file. --- notmuch-insert.c | 51 +-- 1 files changed, 49 insertions(+), 2 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index f01a6f2..340f7e4 100644 ---

[PATCH 05/18] insert: move file from Maildir tmp to new

2012-07-25 Thread Peter Wang
Atomically move the new message file from the Maildir 'tmp' directory to 'new'. --- notmuch-insert.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index 340f7e4..bab1fed 100644 --- a/notmuch-insert.c +++

[PATCH 07/18] insert: add --folder option

2012-07-25 Thread Peter Wang
Allow the new message to be inserted into a folder within the Maildir hierarchy instead of the top-level folder. --- notmuch-insert.c | 21 - 1 files changed, 20 insertions(+), 1 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index dd449bc..6398618 100644 ---

[PATCH 08/18] insert: check folder name

2012-07-25 Thread Peter Wang
Don't accept folder names containing a .. component, to prevent writing outside of the maildir. --- notmuch-insert.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index 6398618..ee51a87 100644 ---

[PATCH 09/18] insert: apply default tags to new message

2012-07-25 Thread Peter Wang
Apply the new.tags to messages added by 'insert'. This mirrors the behaviour if the message were delivered by a separate tool followed by 'notmuch new'. --- notmuch-insert.c | 21 + 1 files changed, 17 insertions(+), 4 deletions(-) diff --git a/notmuch-insert.c

[PATCH 10/18] insert: parse command-line tag operations

2012-07-25 Thread Peter Wang
Parse +tag and -tag on the 'insert' command-line. Issue a warning about ambiguous -tag arguments which don't follow +tag nor an explicit option list terminator. --- notmuch-insert.c | 50 ++ 1 files changed, 50 insertions(+), 0 deletions(-) diff

[PATCH 11/18] insert: apply command-line tag operations

2012-07-25 Thread Peter Wang
Apply the +tag and -tag operations which were specified on the command-line. --- notmuch-insert.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index 6db03e3..5fd79be 100644 --- a/notmuch-insert.c +++

[PATCH 12/18] insert: add copyright line from notmuch-deliver

2012-07-25 Thread Peter Wang
The 'insert' implementation was based partly on notmuch-deliver. --- notmuch-insert.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index 5fd79be..a69dfe6 100644 --- a/notmuch-insert.c +++ b/notmuch-insert.c @@ -2,6 +2,9 @@ * *

[PATCH 14/18] man: document 'insert' command

2012-07-25 Thread Peter Wang
Add initial documentation for notmuch insert command. --- man/Makefile.local|1 + man/man1/notmuch-insert.1 | 50 + 2 files changed, 51 insertions(+), 0 deletions(-) create mode 100644 man/man1/notmuch-insert.1 diff --git

[PATCH 15/18] man: reference notmuch-insert.1

2012-07-25 Thread Peter Wang
Add references to notmuch-insert.1 from other man pages. --- man/man1/notmuch-config.1 |4 ++-- man/man1/notmuch-count.1|4 ++-- man/man1/notmuch-dump.1 |4 ++-- man/man1/notmuch-new.1 |4 ++-- man/man1/notmuch-reply.1|3 ++-

[PATCH 16/18] insert: add --create-folder option

2012-07-25 Thread Peter Wang
Support an option to create a new folder in the maildir. --- notmuch-insert.c | 71 ++ 1 files changed, 71 insertions(+), 0 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index a69dfe6..380c520 100644 --- a/notmuch-insert.c +++

[PATCH 17/18] man: document insert --create-folder option

2012-07-25 Thread Peter Wang
Document the new option. --- man/man1/notmuch-insert.1 |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/man/man1/notmuch-insert.1 b/man/man1/notmuch-insert.1 index 7d281b5..4bd8a35 100644 --- a/man/man1/notmuch-insert.1 +++ b/man/man1/notmuch-insert.1 @@ -36,10

[PATCH 18/18] test: test insert --create-folder

2012-07-25 Thread Peter Wang
Add tests for the new option. --- test/insert | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/test/insert b/test/insert index 3514920..548da58 100755 --- a/test/insert +++ b/test/insert @@ -50,4 +50,28 @@ generate_message \ notmuch insert

Re: [PATCH 01/18] cli: add stub for insert command

2012-07-25 Thread Jameson Graef Rollins
On Wed, Jul 25 2012, Peter Wang noval...@gmail.com wrote: This does nothing yet. Hi, Peter. This commit log is rather terse. Maybe the commit message should explain a bit what this stub is intended to do. This is an interesting series, but let me play devil's advocate for a moment: Why is

Re: [PATCH 03/13] sprinter: Add a string_len method

2012-07-25 Thread Mark Walters
Hi I have read this series (apart from the test changes) and it is both very nice to review and looks good. It builds and all tests pass at all the interesting partial stages and when fully applied. I have a few very minor comments. On Wed, 25 Jul 2012, Austin Clements amdra...@mit.edu wrote:

Re: [PATCH 10/13] show: Convert envelope format_part_json to use sprinter

2012-07-25 Thread Mark Walters
On Wed, 25 Jul 2012, Austin Clements amdra...@mit.edu wrote: --- notmuch-show.c | 57 +--- 1 file changed, 34 insertions(+), 23 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index afbd9d0..fa1e6e9 100644 ---

Re: [PATCH 1/5] emacs: compile and load notmuch-pick.el if present.

2012-07-25 Thread Mark Walters
On Wed, 25 Jul 2012, Tomi Ollila tomi.oll...@iki.fi wrote: On Wed, Jul 25 2012, Mark Walters markwalters1...@gmail.com wrote: Compile and load notmuch-pick.el if present. All the actual setup of pick is done in the function notmuch-pick-init so we call that in the notmuch init function if it

Re: [PATCH 01/18] cli: add stub for insert command

2012-07-25 Thread Peter Wang
On Wed, 25 Jul 2012 10:11:14 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: This is an interesting series, but let me play devil's advocate for a moment: Why is this functionality needed? What can this functionality do that notmuch new can't? My mail is stored on a remote

Re: [PATCH 1/5] emacs: compile and load notmuch-pick.el if present.

2012-07-25 Thread Tomi Ollila
On Thu, Jul 26 2012, Mark Walters markwalters1...@gmail.com wrote: On Wed, 25 Jul 2012, Tomi Ollila tomi.oll...@iki.fi wrote: On Wed, Jul 25 2012, Mark Walters markwalters1...@gmail.com wrote: Compile and load notmuch-pick.el if present. All the actual setup of pick is done in the function

Re: [PATCH 01/13] test: Uniformly canonicalize actual and expected JSON

2012-07-25 Thread Tomi Ollila
On Wed, Jul 25 2012, Austin Clements amdra...@mit.edu wrote: Previously, we used a variety of ad-hoc canonicalizations for JSON output in the test suite, but were ultimately very sensitive to JSON irrelevancies such as whitespace. This introduces a new test comparison function,

[PATCH v2] man: show: update man page for entire-thread and json.

2012-07-25 Thread Austin Clements
LGTM. On Tue, 24 Jul 2012, Mark Walters wrote: > Previously in notmuch show --format=json implied --entire-thread. This > is still the default but it is now possible to disable this. Update > the manpage to reflect this. > --- > > Update the manpage since --format=json and --entire-thread=false

[PATCH 0/5] Notmuch Pick (WIP or contrib)

2012-07-25 Thread Aneesh Kumar K.V
Mark Walters writes: > Hello > > Notmuch pick is an emacs view which displays a threaded view of > messages: each message has its own line and the thread structure is > shown with UTF-8 graphics characters (so it looks vaguely similar to > mutt's threaded view): see

[PATCH 1/5] emacs: compile and load notmuch-pick.el if present.

2012-07-25 Thread Tomi Ollila
On Wed, Jul 25 2012, Mark Walters wrote: > Compile and load notmuch-pick.el if present. > > All the actual setup of pick is done in the function notmuch-pick-init > so we call that in the notmuch init function if it is bound. This > function will setup all extra keybinding etc. Great stuff! See

[PATCH] configure: check whether shell is capable of parameter substring processing

2012-07-25 Thread David Bremner
Tomi Ollila writes: > 'configure' script uses parameter substring extensively. It is Posix shell > feature. Original Bourne shell does not have such features. Some systems > still ships such shells as /bin/sh (for compatibility reasons -- shell > scripts written on those platforms are expected

[PATCH v2] man: show: update man page for entire-thread and json.

2012-07-25 Thread David Bremner
Mark Walters writes: > Previously in notmuch show --format=json implied --entire-thread. This > is still the default but it is now possible to disable this. Update > the manpage to reflect this. pushed d

[PATCH 01/18] cli: add stub for insert command

2012-07-25 Thread Jameson Graef Rollins
ent for individual message insertion. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120725/f1e3ceae/attachment.pgp>

[PATCH 03/13] sprinter: Add a string_len method

2012-07-25 Thread Mark Walters
Hi I have read this series (apart from the test changes) and it is both very nice to review and looks good. It builds and all tests pass at all the interesting partial stages and when fully applied. I have a few very minor comments. On Wed, 25 Jul 2012, Austin Clements wrote: > This method

[PATCH 10/13] show: Convert envelope format_part_json to use sprinter

2012-07-25 Thread Mark Walters
On Wed, 25 Jul 2012, Austin Clements wrote: > --- > notmuch-show.c | 57 > +--- > 1 file changed, 34 insertions(+), 23 deletions(-) > > diff --git a/notmuch-show.c b/notmuch-show.c > index afbd9d0..fa1e6e9 100644 > --- a/notmuch-show.c > +++

[PATCH 1/5] emacs: compile and load notmuch-pick.el if present.

2012-07-25 Thread Mark Walters
On Wed, 25 Jul 2012, Tomi Ollila wrote: > On Wed, Jul 25 2012, Mark Walters wrote: > >> Compile and load notmuch-pick.el if present. >> >> All the actual setup of pick is done in the function notmuch-pick-init >> so we call that in the notmuch init function if it is bound. This >> function will