On Wed, Oct 17 2012, Jani Nikula j...@nikula.org wrote:
Nag nag nag: Commit message. ;)
The custom is to have a man page for each notmuch cli command.
Small nitpicks below.
BR,
Jani.
On Wed, 17 Oct 2012, Ben Gamari bgamari.f...@gmail.com wrote:
---
Makefile.local|1 +
On Wed, Oct 17 2012, Ben Gamari bgamari.f...@gmail.com wrote:
---
configure | 21 -
lib/database.cc | 54 ++
lib/notmuch.h | 14 ++
3 files changed, 88 insertions(+), 1 deletion(-)
diff --git
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes:
This patch, and its predecessors, all look great to me.
But a note: many of the first lines in your commit messages ({show,
hide} message headers) contain tabs. I hate tabs. Is this
On Fri, Oct 12 2012, Ethan Glasser-Camp wrote:
Dmitry Kurochkin dmitry.kuroch...@gmail.com writes:
Actually, we can do both: check file name for consistent diff order
(from expected to actual) and use file names that the caller provides.
Hi! Reviewing the patch queue a little bit here. It
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes:
This requires changing the contents of the crypto tests, as one thread
that was marked read by the earlier tests in test/emacs is no longer
marked read.
pushed.
d
___
notmuch mailing list
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes:
Since $TEST_DIRECTORY is an absolute path, any filenames generated
with it will be complete paths. Only use the basename to generate
suffixes for filenames.
pushed.
d
___
notmuch mailing list
On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila tomi.oll...@iki.fi wrote:
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes:
This patch, and its predecessors, all look great to me.
But a note: many of the first lines in your commit
Adrien Bustany adr...@bustany.org writes:
The code of the patches in unchanged, but the formatting issues are now
hopefully fixed.
These look fine to me, and they're pretty trivial.
Ethan
___
notmuch mailing list
notmuch@notmuchmail.org
c...@webprojekty.cz writes:
Hello, for quite some time my set of scripts just lied in my repo and
waited for polish before release. So tonight I finally managed to update
the docs, remove old stuff, rewrite some unfortunate things etc.
One notable addition is slrn2maildir script which can
Peter Wang noval...@gmail.com writes:
Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can
cover all four values of search --exclude in the cli.
This series looks good to me. It's a nice clean up and a nice new
feature. Patches all apply.
However, I'm getting test failures like:
Le 17/10/2012 18:53, Ethan Glasser-Camp a ?crit :
> Adrien Bustany writes:
>
>> This method explicitly flushes the pending modifications to disk. It is
>> useful if your program has various threads, each with a read only DB and
>> one writer thread with a read/write DB. In that case, you most
The code of the patches in unchanged, but the formatting issues are now
hopefully fixed.
This method explicitly flushes the pending modifications to disk. It is
useful if your program has various threads, each with a read only DB and
one writer thread with a read/write DB. In that case, you most likely
want the writer to sync the changes to disk so that the readers can see
them,
Calling notmuch_database_reopen is needed to refresh the database
contents when the database on disk was modified by another
notmuch_database_t instance, for example in a different thread.
---
lib/database.cc | 17 +
lib/notmuch.h | 8
2 files changed, 25 insertions(+)
On Fri, Oct 12 2012, Ethan Glasser-Camp wrote:
> Since $TEST_DIRECTORY is an absolute path, any filenames generated
> with it will be complete paths. Only use the basename to generate
> suffixes for filenames.
>
> Signed-off-by: Ethan Glasser-Camp
> ---
> Discovered this while reviewing the
On Wed, Oct 17 2012, Jani Nikula wrote:
> Nag nag nag: Commit message. ;)
>
> The custom is to have a man page for each notmuch cli command.
>
> Small nitpicks below.
>
>
> BR,
> Jani.
>
>
> On Wed, 17 Oct 2012, Ben Gamari wrote:
>> ---
>> Makefile.local|1 +
>> notmuch-client.h |
On Wed, Oct 17 2012, Ben Gamari wrote:
> ---
> configure | 21 -
> lib/database.cc | 54 ++
> lib/notmuch.h | 14 ++
> 3 files changed, 88 insertions(+), 1 deletion(-)
>
> diff --git a/configure
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
> Ethan Glasser-Camp writes:
>
>> This patch, and its predecessors, all look great to me.
>
> But a note: many of the first lines in your commit messages ("{show,
> hide} message headers") contain tabs. I hate tabs. Is this intentional?
> I have
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
> Ethan Glasser-Camp writes:
>
>> This patch, and its predecessors, all look great to me.
>
> But a note: many of the first lines in your commit messages ("{show,
Hmm, first lines -- IIRC mailman adds those tabs to the subject line -- and
those are
On Fri, Oct 12 2012, Ethan Glasser-Camp wrote:
> Dmitry Kurochkin writes:
>
>> Actually, we can do both: check file name for consistent diff order
>> (from expected to actual) and use file names that the caller provides.
>
> Hi! Reviewing the patch queue a little bit here. It seems like this
>
On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
> This requires changing the contents of the crypto tests, as one thread
> that was marked read by the earlier tests in test/emacs is no longer
> marked read.
>
> This moves tests for:
>
> - 09d19ac "test: emacs: toggle eliding of non-matching
Ethan Glasser-Camp writes:
> This requires changing the contents of the crypto tests, as one thread
> that was marked read by the earlier tests in test/emacs is no longer
> marked read.
pushed.
d
Ethan Glasser-Camp writes:
> Since $TEST_DIRECTORY is an absolute path, any filenames generated
> with it will be complete paths. Only use the basename to generate
> suffixes for filenames.
pushed.
d
.launchpad.net/mailman/+bug/265915
I guess I can stop complaining about it ;) Patches 1-3 are probably ready
then. Thanks, Tomi.
Ethan
-- next part --
An HTML attachment was scrubbed...
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20121018/291cc76a/attachment.html>
On Thu, Oct 18 2012, Ethan wrote:
> On Thu, Oct 18, 2012 at 5:50 AM, Tomi Ollila wrote:
>
>> On Thu, Oct 18 2012, Ethan Glasser-Camp wrote:
>>
>> > Ethan Glasser-Camp writes:
>> >
>> >> This patch, and its predecessors, all look great to me.
>> >
>> > But a note: many of the first lines in your
25 matches
Mail list logo
