Hi
Do you have some customisation of the notmuch search line
(notmuch-search-result-format) in your .emacs file?
Previously the user specified format for tags was ignored (and
automatically enclosed the tags in brackets). Over the summer Austin
fixed this and many other bugs (with the move to
On Mon, 05 Nov 2012, Blake Jones bla...@foo.net wrote:
+INSTALL=install
+printf Checking for working \install\ program...
+mkdir _tmp_
This doesn't feel like a hot idea.
Out of curiosity, why not?
Note that I'm only referring to creating temp directories like this to
check for the
On Sun, Nov 04 2012, Blake Jones wrote:
Hi Jani,
I'd prefer to use timegm() where available, and the suggested
alternative [1] elsewhere.
[1] http://www.kernel.org/doc/man-pages/online/pages/man3/timegm.3.html
I considered this alternative, but decided against it because it's
completely
On Mon, 05 Nov 2012, Blake Jones bla...@foo.net wrote:
+INSTALL=install
+printf Checking for working \install\ program...
+mkdir _tmp_
This doesn't feel like a hot idea.
Out of curiosity, why not?
Note that I'm only referring to creating temp directories like this to
check
Jani Nikula j...@nikula.org writes:
On Sat, 03 Nov 2012, David Bremner da...@tethera.net wrote:
Offhand I'm not sure of a good method of automatically deciding what is
the same message (with e.g. headers and footer text added by a mailing
list).
Assuming there was good method, what would
Yet another idea for an alternative. Compile by entering 'sh xtimegm.c'
and then run ./xtimegm
Simple cases seems to work. Dst change may (or then may not) give one
hour difference to the expected. The test coverage could be easily
expanded to that ;)
Hmm, I also found this:
Mark Walters markwalters1...@gmail.com writes:
Hi
Do you have some customisation of the notmuch search line
(notmuch-search-result-format) in your .emacs file?
Previously the user specified format for tags was ignored (and
automatically enclosed the tags in brackets). Over the summer
On Mon, Nov 05 2012, Blake Jones wrote:
Yet another idea for an alternative. Compile by entering 'sh xtimegm.c'
and then run ./xtimegm
Simple cases seems to work. Dst change may (or then may not) give one
hour difference to the expected. The test coverage could be easily
expanded to that
The other approaches rely on letting libc do all the hard work of
time zone manipulation, and then reading the tea leaves to find a way
to undo it.
Did you look at the gnu libc version -- I bet it is pretty hairy...
I didn't look at either the GNU or the Solaris libc version. But the
file
Just now I don't have more time to comment and review more, but in the
first 2/3 patches when I tried to compile I got problem NULL not
defined.
Oh! Yes, I should include stdio.h to pull in the definition of NULL.
I'll fix that.
Another thing: you have this
+# Whether the asctime_r
Thanks to Jani Nikula and Tomi Ollila for their comments.
Changes since last version:
- Add feature test for timegm(); move portable implementation of
timegm() into compat/, change libparse-time-string to pull in .o's
from compat/.
- Include stdio.h in compat/check_*.c, to get definition
Add checks to configure to see whether _POSIX_PTHREAD_SEMANTICS needs
to be defined to get the right number of arguments in the prototypes for
getpwuid_r(). Solaris' default implementation conforms to POSIX.1c
Draft 6, rather than the final POSIX.1c spec. The standards-compliant
version can be
Add checks to configure to see whether _POSIX_PTHREAD_SEMANTICS needs
to be defined to get the right number of arguments in the prototypes for
asctime_r(). Solaris' default implementation conforms to POSIX.1c
Draft 6, rather than the final POSIX.1c spec. The standards-compliant
version can be
Add a check to configure to see whether -Wl,-rpath can be used without
--enable-new-dtags. Solaris needs the former and doesn't know about the
latter.
---
configure |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index 9707f11..c9da667 100755
---
Solaris does not ship a version of the strsep() function. This change
adds a check to configure to see whether notmuch needs to provide its
own implementation, and if so, it uses the new version in
compat/strsep.c (which was copied from Mutt, and apparently before
that from glibc).
---
Solaris ships a program called install in /usr/sbin, which performs a
task that's fairly similar to the GNU and BSD install programs but
which uses very different command line arguments. In particular, if it
is invoked without -c, -f, or -n, it will search the target
directory for a file with the
notmuch-config.c has the only use of the function named index() in the
notmuch source. Several other places use the equivalent function
strchr(); this patch just fixes notmuch-config.c to use strchr()
instead. (Solaris needs to include strings.h to get the prototype for
index(), and
The output of nm on Solaris is substantially different from that on
Linux, and the current version of gen-version-script is tied to the
Linux nm output. This patch separates the parts of nm processing
which are dependent on the output format into a couple shell functions,
and makes another shell
Cast the return value of getppid() to int from pid_t in debugger.c,
since it is being passed to sprintf(%d), which wants an int
argument. On Solaris, pid_t is a long for 32-bit programs.
---
debugger.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/debugger.c
The timegm(3) function is a non-standard extension to libc which is
available in GNU libc and on some BSDs. Although SunOS had this
function in its libc, Solaris (unfortunately) removed it. This patch
implements a very simple version of timegm() which is good enough for
parse-time-string.c.
One
On Thu, Sep 15, 2011 at 12:23:17AM +0200, Louis Rilling wrote:
The intent for the fourth patch (detailed in the commit log) is to allow mutt
users to keep using the new status, as long as notmuch can respect the
maildir specification.
The third patch implements a test for the new desired
Antoine Amarilli antoine.amari...@ens.fr writes:
Hello,
The attached message makes python-notmuch crash when trying to access it (see
attached log).
I don't know if the encoding of Subject is valid or not, but it would probably
be better anyway to ignore decoding errors and return some
Daniel qu...@hack.org writes:
On Mon, Nov 21, 2011 at 08:41:42PM -0400, David Bremner wrote:
I pushed the first two patches in this series; the second two need to be
updated for the new broken test framework, and reviewed.
And old one... What came of this patch?
I came across it, having
Peter Wang noval...@gmail.com writes:
This obsoletes the series 1340508470-16606-1-git-send-email-noval...@gmail.com
Only json output is affected now.
Peter Wang (2):
show: include Reply-To header in json output
test: add test for showing Reply-To headers
LGTM. Removed needs-review,
James Vasile ja...@hackervisions.org writes:
What's the best way to submit changes to addrlookup? Right now, it is
out of date vs the latest libnotmuch. The addrlookup repo is vala code
but the wiki [1] points to a generated c file [2].
[1]
Tomi Ollila tomi.oll...@iki.fi writes:
Added FILE, notmuch_show_params_t and sprinter_t to be
types when uncrustifying sources. This affect spacing
when uncrustify is deciding for type declaration instead
of binary multiplication operation.
This looks good to me. If you had plenty of time
On Tue, Nov 06 2012, Ethan Glasser-Camp ethan.glasser.c...@gmail.com wrote:
Tomi Ollila tomi.oll...@iki.fi writes:
Added FILE, notmuch_show_params_t and sprinter_t to be
types when uncrustifying sources. This affect spacing
when uncrustify is deciding for type declaration instead
of binary
On Sat, 03 Nov 2012, David Bremner wrote:
> Eirik Byrkjeflot Anonsen writes:
>
>> That's not what I see. If I search for a term that only appears in
>> one of the "copies", none of the copies are included in the search
>> result.
>
> The offending code is at line 1813 of lib/database.cc; the
We have the mails appearing as below now. Earlier the tags towards the
end used be enclosed in "(" ")"
[21/21] Today 10:57Blake Jones, Jani Nikula, Tomi Ollila[PATCH 05/10]
install: check for non-SysV version (Solaris support) notmuch unread
[5/5] Today 09:58Eirik Byrkjeflot
Hi
Do you have some customisation of the notmuch search line
(notmuch-search-result-format) in your .emacs file?
Previously the user specified format for tags was ignored (and
automatically enclosed the tags in brackets). Over the summer Austin
fixed this and many other bugs (with the move to
On Mon, 05 Nov 2012, Blake Jones wrote:
>> > +INSTALL="install"
>> > +printf "Checking for working \"install\" program... "
>> > +mkdir _tmp_
>>
>> This doesn't feel like a hot idea.
>
> Out of curiosity, why not?
Note that I'm only referring to creating temp directories like this to
check for
On Sun, Nov 04 2012, Blake Jones wrote:
> Hi Jani,
>
>> I'd prefer to use timegm() where available, and the suggested
>> alternative [1] elsewhere.
>>
>> [1] http://www.kernel.org/doc/man-pages/online/pages/man3/timegm.3.html
>
> I considered this alternative, but decided against it because it's
> On Mon, 05 Nov 2012, Blake Jones wrote:
> >> > +INSTALL="install"
> >> > +printf "Checking for working \"install\" program... "
> >> > +mkdir _tmp_
> >>
> >> This doesn't feel like a hot idea.
> >
> > Out of curiosity, why not?
>
> Note that I'm only referring to creating temp directories
Jani Nikula writes:
> On Sat, 03 Nov 2012, David Bremner wrote:
>> Offhand I'm not sure of a good method of automatically deciding what is
>> the same message (with e.g. headers and footer text added by a mailing
>> list).
>
> Assuming there was good method, what would you do with two different
> Yet another idea for an alternative. Compile by entering 'sh xtimegm.c'
> and then run ./xtimegm
>
> Simple cases seems to work. Dst change may (or then may not) give one
> hour difference to the expected. The test "coverage" could be easily
> expanded to that ;)
>
> Hmm, I also found this:
>
Mark Walters writes:
> Hi
>
> Do you have some customisation of the notmuch search line
> (notmuch-search-result-format) in your .emacs file?
>
> Previously the user specified format for tags was ignored (and
> automatically enclosed the tags in brackets). Over the summer Austin
> fixed this and
On Mon, Nov 05 2012, Blake Jones wrote:
>> Yet another idea for an alternative. Compile by entering 'sh xtimegm.c'
>> and then run ./xtimegm
>>
>> Simple cases seems to work. Dst change may (or then may not) give one
>> hour difference to the expected. The test "coverage" could be easily
>>
>> The other approaches rely on letting libc do all the hard work of
>> time zone manipulation, and then reading the tea leaves to find a way
>> to undo it.
>
> Did you look at the gnu libc version -- I bet it is pretty hairy...
I didn't look at either the GNU or the Solaris libc version. But
> Just now I don't have more time to comment and review more, but in the
> first 2/3 patches when I tried to compile I got problem NULL not
> defined.
Oh! Yes, I should include to pull in the definition of NULL.
I'll fix that.
> Another thing: you have this
>
> +# Whether the asctime_r
Thanks to Jani Nikula and Tomi Ollila for their comments.
Changes since last version:
- Add feature test for timegm(); move portable implementation of
timegm() into compat/, change libparse-time-string to pull in .o's
from compat/.
- Include in compat/check_*.c, to get definition of NULL.
Add checks to "configure" to see whether _POSIX_PTHREAD_SEMANTICS needs
to be defined to get the right number of arguments in the prototypes for
getpwuid_r(). Solaris' default implementation conforms to POSIX.1c
Draft 6, rather than the final POSIX.1c spec. The standards-compliant
version can be
Add checks to "configure" to see whether _POSIX_PTHREAD_SEMANTICS needs
to be defined to get the right number of arguments in the prototypes for
asctime_r(). Solaris' default implementation conforms to POSIX.1c
Draft 6, rather than the final POSIX.1c spec. The standards-compliant
version can be
Add a check to "configure" to see whether -lnsl is needed for programs
that are using gethostbyname(). This change also adds the file
"compat/check_ghbn.c", which configure uses to perform its check.
---
compat/check_ghbn.c |9 +
configure | 17 -
2 files
Add a check to "configure" to see whether -Wl,-rpath can be used without
--enable-new-dtags. Solaris needs the former and doesn't know about the
latter.
---
configure |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index 9707f11..c9da667 100755
Solaris does not ship a version of the strsep() function. This change
adds a check to "configure" to see whether notmuch needs to provide its
own implementation, and if so, it uses the new version in
"compat/strsep.c" (which was copied from Mutt, and apparently before
that from glibc).
---
Solaris ships a program called "install" in /usr/sbin, which performs a
task that's fairly similar to the GNU and BSD "install" programs but
which uses very different command line arguments. In particular, if it
is invoked without "-c", "-f", or "-n", it will search the target
directory for a
notmuch-config.c has the only use of the function named "index()" in the
notmuch source. Several other places use the equivalent function
"strchr()"; this patch just fixes notmuch-config.c to use strchr()
instead. (Solaris needs to include to get the prototype for
index(), and notmuch-config.c
The output of "nm" on Solaris is substantially different from that on
Linux, and the current version of gen-version-script is tied to the
Linux "nm" output. This patch separates the parts of "nm" processing
which are dependent on the output format into a couple shell functions,
and makes another
Cast the return value of getppid() to "int" from "pid_t" in debugger.c,
since it is being passed to sprintf("%d"), which wants an "int"
argument. On Solaris, "pid_t" is a "long" for 32-bit programs.
---
debugger.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
The timegm(3) function is a non-standard extension to libc which is
available in GNU libc and on some BSDs. Although SunOS had this
function in its libc, Solaris (unfortunately) removed it. This patch
implements a very simple version of timegm() which is good enough for
parse-time-string.c.
One
Antoine Amarilli writes:
> Hello,
>
> The attached message makes python-notmuch crash when trying to access it (see
> attached log).
>
> I don't know if the encoding of Subject is valid or not, but it would probably
> be better anyway to ignore decoding errors and return some approximation of
>
Sebastian Spaeth writes:
> On Wed, 09 Nov 2011 08:46:02 +, Jani Nikula wrote:
>> It's unrelated, but looking at the above also made me check something
>> I've suspected before: notmuch allows you to have empty or zero length
>> tags "", which is probably not intentional.
>
> I had reported
Daniel writes:
> On Mon, Nov 21, 2011 at 08:41:42PM -0400, David Bremner wrote:
>> I pushed the first two patches in this series; the second two need to be
>> updated for the new "broken test" framework, and reviewed.
>
> And old one... What came of this patch?
>
> I came across it, having been
Peter Wang writes:
> This obsoletes the series 1340508470-16606-1-git-send-email-novalazy at
> gmail.com
> Only json output is affected now.
>
> Peter Wang (2):
> show: include Reply-To header in json output
> test: add test for showing Reply-To headers
LGTM. Removed needs-review, added
James Vasile writes:
> What's the best way to submit changes to addrlookup? Right now, it is
> out of date vs the latest libnotmuch. The addrlookup repo is vala code
> but the wiki [1] points to a generated c file [2].
>
> [1]
Tomi Ollila writes:
> Added FILE, notmuch_show_params_t and sprinter_t to be
> types when uncrustifying sources. This affect spacing
> when uncrustify is deciding for type declaration instead
> of binary multiplication operation.
This looks good to me. If you had plenty of time and no more
56 matches
Mail list logo
