Re: [PATCH 1/8] packaging: fedora: update

Felipe Contreras felipe.contre...@gmail.com writes: Name: notmuch -Version:0.4 +Version:0.15.2 Release:1%{?dist} Summary:Not much of an email program It might be good in the future do some kind of automated update of the version. The python

Re: [PATCH 0/8] packaging: fedora: general updates

Felipe Contreras felipe.contre...@gmail.com writes: On Sat, May 25, 2013 at 7:41 AM, David Bremner da...@tethera.net wrote: At this point we wait for somebody (else) with Fedora expertise to review the patches. Like who? I though the reason these were never updated is that there wasn't

Re: [PATCH] contrib: pick: use the sexp parser

Mark Walters markwalters1...@gmail.com writes: This just converts notmuch-pick to use the sexp parser. --- Pushed. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] emacs: replace (funcall 'foo ...) with (foo ...)

From: David Bremner brem...@debian.org I can't see any benefit to the funcall, and it looks like the result of cut-and-paste from some code that actually used a variable for the function to call. --- Mark and I were discussing some style issues in the context of pick, and it seems to me that

Re: [PATCH] contrib: pick: bugfix: use notmuch-show-mark-read-tags instead of unread

On Sun, Jun 02 2013, Mark Walters markwalters1...@gmail.com wrote: Previously pick removed the unread tag from its tag display: since the tag change is now customisable use the customised variable. This only affected the tags displayed, not the tags in the database as notmuch-show (in the

[PATCH 4/4] debian: update .gitignore

From: David Bremner brem...@debian.org Several packages have been added or renamed, but their build detritus not yet ignored. --- debian/.gitignore | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/debian/.gitignore b/debian/.gitignore index 9f09f22..31aa2bb 100644 ---

[PATCH 2/4] emacs: update .gitignore

From: David Bremner brem...@debian.org Start a seperate .gitignore for emacs stuff, move .elc rule there. --- .gitignore | 1 - emacs/.gitignore | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 emacs/.gitignore diff --git a/.gitignore b/.gitignore index

[PATCH 3/4] bindings/go: ignore downloaded source from github.com

From: David Bremner brem...@debian.org Start a .gitignore for go bindings. --- bindings/go/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 bindings/go/.gitignore diff --git a/bindings/go/.gitignore b/bindings/go/.gitignore new file mode 100644 index 000..a2670c1 ---

[PATCH] emacs: remove hardcoded defaults values from docstrings

From: David Bremner brem...@debian.org These functions refer to default values of variables, but it seems less confusing and less likely to get out of date to just allow the user to follow the help cross-reference links. --- emacs/notmuch-show.el | 14 ++ 1 file changed, 6

[PATCH] emacs: add `notmuch-archive-tags' cross references in docstrings

From: David Bremner brem...@debian.org Several function docstrings refer to behaviour in docstrings that is really controlled by notmuch-archive-tags. Add cross references, and replace hardcoding. --- emacs/notmuch-show.el | 4 ++-- emacs/notmuch.el | 27 --- 2

Re: [PATCH] emacs: replace (funcall 'foo ...) with (foo ...)

On Sun, Jun 02 2013, da...@tethera.net wrote: From: David Bremner brem...@debian.org I can't see any benefit to the funcall, and it looks like the result of cut-and-paste from some code that actually used a variable for the function to call. --- Looks sensible to me. Tomi Mark and I

Re: [PATCH] contrib: pick: bugfix. use notmuch-show-only-matching-messages rather than prefix

On Sun, Jun 02 2013, Mark Walters markwalters1...@gmail.com wrote: Previously pick set a prefix argument prior to calling show in the message pane to tell show to only show matching messages. This sets notmuch-show-only-matching-messages instead which is much cleaner and will work even if the

[PATCH] emacs: replace setq + let with let*

From: David Bremner brem...@debian.org I found several places where a setq is immediately followed by a let or a let*. This seems to be the pessimal combination, with the implicit scope of the setq combined with the extra indentation of the let. I combined these cases into a single let* which I

Re: [PATCH v3 0/6] Make Emacs search use sexp format

On Sat, Jun 01 2013, David Bremner da...@tethera.net wrote: Austin Clements amdra...@mit.edu writes: This is v3 of id:1369934016-22308-1-git-send-email-amdra...@mit.edu. This tweaks the shell invocation as suggested by Tomi and fixes two comment typos pointed out by Mark. It also adds a NEWS

Re: [PATCH] emacs: replace setq + let with let*

On Sun, 02 Jun 2013, da...@tethera.net wrote: From: David Bremner brem...@debian.org I found several places where a setq is immediately followed by a let or a let*. This seems to be the pessimal combination, with the implicit scope of the setq combined with the extra indentation of the let.

[PATCH] NEWS: key bindings for next/previous thread

--- NEWS |5 + 1 file changed, 5 insertions(+) diff --git a/NEWS b/NEWS index 9237e5a..6f09cdb 100644 --- a/NEWS +++ b/NEWS @@ -99,6 +99,11 @@ No Emacs 22 support period of time. After being incomplete for roughly 2 years the code in question was now removed from this release.

Re: [PATCH] NEWS: key bindings for next/previous thread

Jani Nikula j...@nikula.org writes: --- NEWS |5 + 1 file changed, 5 insertions(+) pushed, d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: replace setq + let with let*

Mark Walters markwalters1...@gmail.com writes: -(setq search (notmuch-hello-trim search)) -(let ((history-delete-duplicates t)) +(let* ((search (notmuch-hello-trim search)) + (history-delete-duplicates t)) (add-to-history 'notmuch-search-history search)))

Re: [PATCH] emacs: remove hardcoded defaults values from docstrings

Mark Walters markwalters1...@gmail.com writes: both of these LGTM +1. Note there are still some (an?) occurrences of this: eg notmuch-search-archive-thread, and there is one in pick. But these might as well go in anyway. pushed both, d ___

Re: [PATCH 4/4] debian: update .gitignore

da...@tethera.net writes: From: David Bremner brem...@debian.org Several packages have been added or renamed, but their build detritus not yet ignored. Pushed the non-bindings patches in the series. I'll wait for comment from go/python people on the other two. d

Re: [PATCH 3/3] build: pass CPPFLAGS to C and C++ compilers

da...@tethera.net writes: From: David Bremner brem...@debian.org This is used in particular by hardening flags. I pushed all three. I assume someone will let me know if I broke the build system for them... d ___ notmuch mailing list

Re: [PATCH] contrib: pick: bugfix. use notmuch-show-only-matching-messages rather than prefix

Mark Walters markwalters1...@gmail.com writes: Previously pick set a prefix argument prior to calling show in the message pane to tell show to only show matching messages. This sets notmuch-show-only-matching-messages instead which is much cleaner and will work even if the user has configured

Re: [PATCH] contrib: pick: bugfix: use notmuch-show-mark-read-tags instead of unread

Mark Walters markwalters1...@gmail.com writes: Previously pick removed the unread tag from its tag display: since the tag change is now customisable use the customised variable. This only affected the tags displayed, not the tags in the database as notmuch-show (in the view pane) did the

[PATCH] debian: build notmuch-vim again

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- debian/control | 15 +++ 1 file changed, 15 insertions(+) diff --git a/debian/control b/debian/control index 08071be..273a5a7 100644 --- a/debian/control +++ b/debian/control @@ -120,6 +120,21 @@ Description: thread-based

Re: the future of notmuch-vim?

On Fri, Apr 5, 2013 at 5:30 AM, Charlie Allom char...@mediasp.com wrote: If Felipe is interested in maintaining the Vim plugin, I vote it should be replaced with his Ruby version. I've pushed the new vim plugin to the 'master' branch. Cheers. -- Felipe Contreras

New notmuch vim plugin pushed to master

Hi, The old plugin has been deprecated and moving to contrib. The new plugin has much better support and should replace it for all intents and purposes. I've pushed the changes and hopefully the packages will be updated accordingly. -- Felipe Contreras

Re: [PATCH] debian: build notmuch-vim again

Felipe Contreras felipe.contre...@gmail.com writes: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- debian/control | 15 +++ 1 file changed, 15 insertions(+) Hi Felipe; What about the bugs from the old plugin, are they fixed by the new one?

Re: [PATCH] debian: build notmuch-vim again

On Sun, Jun 2, 2013 at 8:14 PM, David Bremner brem...@debian.org wrote: Felipe Contreras felipe.contre...@gmail.com writes: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- debian/control | 15 +++ 1 file changed, 15 insertions(+) Hi Felipe; What about the

[PATCH] contrib: pick: use the sexp parser

On Sat, Jun 01 2013, Mark Walters wrote: > This just converts notmuch-pick to use the sexp parser. > --- These trivial changes look good -- is sexp already supported in show ? Tomi > > contrib/notmuch-pick/notmuch-pick.el |5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > >

[PATCH 1/8] packaging: fedora: update

Felipe Contreras writes: > Name: notmuch > -Version:0.4 > +Version:0.15.2 > Release:1%{?dist} > Summary:Not much of an email program It might be good in the future do some kind of automated update of the version. The python bindings version is

[PATCH 0/8] packaging: fedora: general updates

Felipe Contreras writes: > On Sat, May 25, 2013 at 7:41 AM, David Bremner wrote: > >> At this point we wait for somebody (else) with Fedora expertise to >> review the patches. > > Like who? I though the reason these were never updated is that there > wasn't anybody else. Hmm. Somehow I missed

[PATCH] contrib: pick: use the sexp parser

Mark Walters writes: > This just converts notmuch-pick to use the sexp parser. > --- Pushed. d

[PATCH] contrib: pick: use the sexp parser

Tomi Ollila writes: > These trivial changes look good -- is sexp already supported in show ? At the moment sexp is not supported in show (despite that using synchronous command so it is much easier). I posted a (not good) at id:1354975891-24663-1-git-send-email-markwalters1009 at gmail.com and

[PATCH] emacs: replace (funcall 'foo ...) with (foo ...)

From: David Bremner I can't see any benefit to the funcall, and it looks like the result of cut-and-paste from some code that actually used a variable for the function to call. --- Mark and I were discussing some style issues in the context of pick, and it seems to me that

[PATCH] contrib: pick: bugfix: use notmuch-show-mark-read-tags instead of unread

On Sun, Jun 02 2013, Mark Walters wrote: > Previously pick removed the unread tag from its tag display: since the > tag change is now customisable use the customised variable. > > This only affected the tags displayed, not the tags in the database as > notmuch-show (in the view pane) did the

[PATCH 1/4] bindings/python: ignore build subdirectory.

From: David Bremner Update .gitignore to make git status less noisy --- bindings/python/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/bindings/python/.gitignore b/bindings/python/.gitignore index 1fbea8a..da0732e 100644 --- a/bindings/python/.gitignore +++

[PATCH 4/4] debian: update .gitignore

From: David Bremner Several packages have been added or renamed, but their build detritus not yet ignored. --- debian/.gitignore | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/debian/.gitignore b/debian/.gitignore index 9f09f22..31aa2bb 100644

[PATCH 2/4] emacs: update .gitignore

From: David Bremner Start a seperate .gitignore for emacs stuff, move .elc rule there. --- .gitignore | 1 - emacs/.gitignore | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 emacs/.gitignore diff --git a/.gitignore b/.gitignore index

[PATCH 3/4] bindings/go: ignore downloaded source from github.com

From: David Bremner Start a .gitignore for go bindings. --- bindings/go/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 bindings/go/.gitignore diff --git a/bindings/go/.gitignore b/bindings/go/.gitignore new file mode 100644 index 000..a2670c1 ---

[PATCH] emacs: remove hardcoded defaults values from docstrings

From: David Bremner These functions refer to default values of variables, but it seems less confusing and less likely to get out of date to just allow the user to follow the help cross-reference links. --- emacs/notmuch-show.el | 14 ++ 1 file changed, 6

[PATCH] emacs: add `notmuch-archive-tags' cross references in docstrings

From: David Bremner Several function docstrings refer to behaviour in docstrings that is really controlled by notmuch-archive-tags. Add cross references, and replace hardcoding. --- emacs/notmuch-show.el | 4 ++-- emacs/notmuch.el | 27 --- 2

[PATCH] emacs: replace (funcall 'foo ...) with (foo ...)

On Sun, Jun 02 2013, david at tethera.net wrote: > From: David Bremner > > I can't see any benefit to the funcall, and it looks like the result > of cut-and-paste from some code that actually used a variable for the > function to call. > --- Looks sensible to me. Tomi > > Mark and I were

[PATCH] emacs: remove hardcoded defaults values from docstrings

On Sun, Jun 02 2013, david at tethera.net wrote: > From: David Bremner > > These functions refer to default values of variables, but it seems > less confusing and less likely to get out of date to just allow the > user to follow the help cross-reference links. > --- LGTM. Tomi >

[PATCH] contrib: pick: bugfix. use notmuch-show-only-matching-messages rather than prefix

On Sun, Jun 02 2013, Mark Walters wrote: > Previously pick set a prefix argument prior to calling show in the > message pane to tell show to only show matching messages. This sets > notmuch-show-only-matching-messages instead which is much cleaner and > will work even if the user has configured

[PATCH] emacs: replace setq + let with let*

From: David Bremner I found several places where a setq is immediately followed by a let or a let*. This seems to be the pessimal combination, with the implicit scope of the setq combined with the extra indentation of the let. I combined these cases into a single let* which I

[PATCH v3 0/6] Make Emacs search use sexp format

ot modified during this process. Let me know if I can help provide any more info. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pi

[PATCH] emacs: replace setq + let with let*

On Sun, 02 Jun 2013, david at tethera.net wrote: > From: David Bremner > > I found several places where a setq is immediately followed by a let > or a let*. This seems to be the pessimal combination, with the > implicit scope of the setq combined with the extra indentation of the let. > I

[PATCH] emacs: replace (funcall 'foo ...) with (foo ...)

This looks good to me +1 Mark On Sun, 02 Jun 2013, david at tethera.net wrote: > From: David Bremner > > I can't see any benefit to the funcall, and it looks like the result > of cut-and-paste from some code that actually used a variable for the > function to call. > --- > > Mark and I were

[PATCH] NEWS: key bindings for next/previous thread

--- NEWS |5 + 1 file changed, 5 insertions(+) diff --git a/NEWS b/NEWS index 9237e5a..6f09cdb 100644 --- a/NEWS +++ b/NEWS @@ -99,6 +99,11 @@ No Emacs 22 support period of time. After being incomplete for roughly 2 years the code in question was now removed from this release.

[PATCH] emacs: remove hardcoded defaults values from docstrings

both of these LGTM +1. Note there are still some (an?) occurrences of this: eg notmuch-search-archive-thread, and there is one in pick. But these might as well go in anyway. Best wishes Mark On Sun, 02 Jun 2013, david at tethera.net wrote: > From: David Bremner > > These functions refer to

[PATCH] NEWS: key bindings for next/previous thread

Jani Nikula writes: > --- > NEWS |5 + > 1 file changed, 5 insertions(+) pushed, d

[PATCH] emacs: replace setq + let with let*

Mark Walters writes: >> -(setq search (notmuch-hello-trim search)) >> -(let ((history-delete-duplicates t)) >> +(let* ((search (notmuch-hello-trim search)) >> + (history-delete-duplicates t)) >>(add-to-history 'notmuch-search-history search))) >>(notmuch-search

[PATCH] emacs: remove hardcoded defaults values from docstrings

Mark Walters writes: > both of these LGTM +1. > > Note there are still some (an?) occurrences of this: eg > notmuch-search-archive-thread, and there is one in pick. But these might > as well go in anyway. pushed both, d

[PATCH 4/4] debian: update .gitignore

david at tethera.net writes: > From: David Bremner > > Several packages have been added or renamed, but their build detritus > not yet ignored. Pushed the non-bindings patches in the series. I'll wait for comment from go/python people on the other two. d

[PATCH 3/3] build: pass CPPFLAGS to C and C++ compilers

david at tethera.net writes: > From: David Bremner > > This is used in particular by hardening flags. I pushed all three. I assume someone will let me know if I broke the build system for them... d

[PATCH] contrib: pick: bugfix. use notmuch-show-only-matching-messages rather than prefix

Mark Walters writes: > Previously pick set a prefix argument prior to calling show in the > message pane to tell show to only show matching messages. This sets > notmuch-show-only-matching-messages instead which is much cleaner and > will work even if the user has configured show to default to

[PATCH] contrib: pick: bugfix: use notmuch-show-mark-read-tags instead of unread

Mark Walters writes: > Previously pick removed the unread tag from its tag display: since the > tag change is now customisable use the customised variable. > > This only affected the tags displayed, not the tags in the database as > notmuch-show (in the view pane) did the actual tag changes. >

[PATCH] debian: build notmuch-vim again

Signed-off-by: Felipe Contreras --- debian/control | 15 +++ 1 file changed, 15 insertions(+) diff --git a/debian/control b/debian/control index 08071be..273a5a7 100644 --- a/debian/control +++ b/debian/control @@ -120,6 +120,21 @@ Description: thread-based email index, search and

the future of notmuch-vim?

On Fri, Apr 5, 2013 at 5:30 AM, Charlie Allom wrote: > If Felipe is interested in maintaining the Vim plugin, I vote it should > be replaced with his Ruby version. I've pushed the new vim plugin to the 'master' branch. Cheers. -- Felipe Contreras

[PATCH] debian: build notmuch-vim again

Felipe Contreras writes: > Signed-off-by: Felipe Contreras > --- > debian/control | 15 +++ > 1 file changed, 15 insertions(+) > Hi Felipe; What about the bugs from the old plugin, are they fixed by the new one?

[PATCH] debian: build notmuch-vim again

On Sun, Jun 2, 2013 at 8:14 PM, David Bremner wrote: > Felipe Contreras writes: > >> Signed-off-by: Felipe Contreras >> --- >> debian/control | 15 +++ >> 1 file changed, 15 insertions(+) >> > > Hi Felipe; > > What about the bugs from the old plugin, are they fixed by the new one?