This is version 5 of this patch set. Version 4 is at
id:1370074547-24677-1-git-send-email-markwalters1009 at gmail.com.
This version fixes the two bugs pointed out in Austin's review
id:20130610023952.GC22196 at mit.edu.
I decided to add the :notmuch-part text property separately from
Previously each of the part insertion handlers inserted the part
button themselves. Move this up into
notmuch-show-insert-bodypart. Since a small number of the handlers
modify the button (the encryption/signature ones) we need to pass the
header button as an argument into the individual part
Now that the bodypart code has the button we can pass that to
create-overlays and simplify that.
---
emacs/notmuch-show.el | 31 +++
1 files changed, 15 insertions(+), 16 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index c69456a..0a0451b
Previously, whether a part was hidden or shown was recorded in the
invisibility/visibility of the part overlay. Since we are going to
have lazily rendered parts with no overlay store the hidden/shown
state in the part button itself.
Additionally, in preparation for the invisible part handling
This separates out the adding of the :notmuch-part text property to a
separate function to simplify calling from the lazy part insertion
code.
---
emacs/notmuch-show.el | 39 ++-
1 files changed, 22 insertions(+), 17 deletions(-)
diff --git
This adds the actual code to do the lazy insertion of hidden parts.
We use a memory inefficient but simple method: when we come to insert
the part if it is hidden we just store all of the arguments to the
part insertion function as a button property. This means when we want
to show the part we
LGTM.
Quoth Mark Walters on Jun 10 at 5:57 am:
> This is version 5 of this patch set. Version 4 is at
> id:1370074547-24677-1-git-send-email-markwalters1009 at gmail.com.
>
> This version fixes the two bugs pointed out in Austin's review
> id:20130610023952.GC22196 at mit.edu.
>
> I decided to
On Mon, Jun 10 2013, Austin Clements wrote:
> Quoth Mark Walters on Jun 09 at 10:16 am:
>>
>> Both of these patches look good to me +1. I was able to reproduce both
>> bugs pretty reliably (the first one always unless masked by the second
>> one which occurred about half the time). With these
On Mon, Jun 10 2013, Mark Walters wrote:
> This is version 5 of this patch set. Version 4 is at
> id:1370074547-24677-1-git-send-email-markwalters1009 at gmail.com.
>
> This version fixes the two bugs pointed out in Austin's review
> id:20130610023952.GC22196 at mit.edu.
>
> I decided to add the
On Sun, Jun 09 2013, Jani Nikula wrote:
> v2 of id:cover.1368467532.git.jani at nikula.org
>
> The only change is switching to 1-based indexing for --duplicate=N
> option.
The code looks good to me. Mark's comment about showing duplicate file
from another folder than mentioned in query string
On Mon, Jun 03 2013, Jani Nikula wrote:
> ---
LGTM.
Tomi
> emacs/notmuch-lib.el |7 ++-
> emacs/notmuch.el | 13 ++---
> 2 files changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index 28f78e0..c43d5a9 100644
> ---
On Tue, Jun 04 2013, Mark Walters wrote:
> Copy the recent changes in show to use just notmuch-archive-tags (as a
> link) rather than saying '(defaults to "inbox")'.
> ---
LGTM. For consistency...
Tomi
> contrib/notmuch-pick/notmuch-pick.el |7 +++
> 1 files changed, 3
On Sun, Jun 9, 2013 at 10:57 PM, Mark Walters
wrote:
> This is version 5 of this patch set. Version 4 is at
> id:1370074547-24677-1-git-send-email-markwalters1009 at gmail.com.
I've been using version 4 for a few days, and works great. The version
of the code I reviewed LGTM.
Since this series
Effective with --output=files, output the Nth filename associated with
each message matching the query (N is 1-based). If N is greater than
the number of files associated with the message, don't print anything.
---
v3: fix commit message, no other changes
---
notmuch-search.c | 18
LGTM. Though, I wonder, why not *just* -perm -100? That isn't quite
a correct test of whether the user can execute it: e.g., if the file
is owned by some other user and a group the current user isn't in,
then -perm -1 is the correct test, though unless the file has some
unusual permissions,
---
v3: clarify dupe vs. folder prefix per Mark's suggestion
---
man/man1/notmuch-search.1 | 20
1 file changed, 20 insertions(+)
diff --git a/man/man1/notmuch-search.1 b/man/man1/notmuch-search.1
index 1c1e049..957b24b 100644
--- a/man/man1/notmuch-search.1
+++
---
man/man7/notmuch-search-terms.7 |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/man/man7/notmuch-search-terms.7 b/man/man7/notmuch-search-terms.7
index eb417ba..359bb3c 100644
--- a/man/man7/notmuch-search-terms.7
+++ b/man/man7/notmuch-search-terms.7
@@ -102,9
On Sun, 09 Jun 2013, Mark Walters wrote:
> Sorry about that: I meant to cancel the message rather than sending it.
>
> What I was wondering was whether we should change the wording of the
> manpage to make it clear that notmuch search --output=files returns all
> filenames where any of the copies
On Sun, 09 Jun 2013, Mark Walters wrote:
> Overall I like this series and am happy to give it a +1 as is but have a
> few comments which might be worth considering.
>
> Is the order of filenames clear? eg is it the order that notmuch new met
> them? In particular is duplicate=1 the oldest and
LGTM +1
Mark
On Mon, 03 Jun 2013, Jani Nikula wrote:
> ---
> emacs/notmuch-lib.el |7 ++-
> emacs/notmuch.el | 13 ++---
> 2 files changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index 28f78e0..c43d5a9 100644
> ---
20 matches
Mail list logo
