Would anyone be able to review (or just test) this pair of patches: they
are smaller and simpler than the diffstat suggests: the second patch is
just 3 extra lines of code (with some whitespace change and commments).
This pair of patches does remove the worst piece of code in pick: a
sleep loop
Actually I will post a new version as this version doesn't apply anymore
(the context which overlaps an unrelated function has changed)
Best wishes
Mark
On Sun, 30 Jun 2013, Mark Walters wrote:
> Would anyone be able to review (or just test) this pair of patches: they
> are smaller and
---
contrib/notmuch-pick/notmuch-pick.el |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/contrib/notmuch-pick/notmuch-pick.el
b/contrib/notmuch-pick/notmuch-pick.el
index 16f8d15..ef16ca7 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++
This is a trivial rebase of
id:1369551008-30697-1-git-send-email-markwalters1009 at gmail.com to
current master. I have included the dependent patch
id:1369550458-30562-1-git-send-email-markwalters1009 at gmail.com
As I said in id:87sj00xapn.fsf at qmul.ac.uk this removes the worst piece
of code
The function notmuch-pick-refresh-result (used to update tag changes)
was not quite correct: sometimes it got the choice between the subject
and " ..." wrong. This was always true but the new code often calls
this (when opening a message in the message pane to remove the unread
tag) while the
This function was a horrible hack (sleeping while waiting for the
correct message). The new target code can just open the message in the
message window when it arrives.
---
contrib/notmuch-pick/notmuch-pick.el | 37 +++---
1 files changed, 12 insertions(+), 25
Hi!
Today I ditched mutt(-kz) in favour of a notmuch/isync setup. I
compiled bower, because it's able to use a remote notmuch instance.
My issue is a follows: I start bower, and I see an unsorted selection
of mails (300 newest).
How can I navigate by folders/tags?
- A search like folder:Inbox
Peter Wang writes:
> Add tests for new 'insert' command.
> ---
I have pushed the first 6 patches in this series.
d
Mark Walters writes:
> - (let ((msg-id (notmuch-id-to-query (plist-get msg :id
> -(when (string= msg-id notmuch-pick-target-msg)
> + (let ((msg-id (notmuch-id-to-query (plist-get msg :id)))
> + (target notmuch-pick-target-msg))
> +(when (or (and (not target) (plist-get msg
Mark Walters writes:
> +(defvar notmuch-pick-open-target nil)
> +(make-variable-buffer-local 'notmuch-pick-open-target)
What do people think about adding a code style suggestion/requirement
for elisp that all variables have docstrings, even if intended for
internal use? It's true the existing
Mark Walters writes:
> The function notmuch-pick-refresh-result (used to update tag changes)
> was not quite correct: sometimes it got the choice between the subject
> and " ..." wrong. This was always true but the new code often calls
> this (when opening a message in the message pane to remove
ication/pgp-signature
Size: 1027 bytes
Desc: OpenPGP digital signature
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20130630/799be475/attachment.pgp>
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20130630/4fee3d35/attachment.pgp>
Hi
Many thanks for the review!
On Sun, 30 Jun 2013, David Bremner wrote:
> Mark Walters writes:
>
>> +(defvar notmuch-pick-open-target nil)
>> +(make-variable-buffer-local 'notmuch-pick-open-target)
>
> What do people think about adding a code style suggestion/requirement
> for elisp that all
---
contrib/notmuch-pick/notmuch-pick.el | 14 +-
1 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/contrib/notmuch-pick/notmuch-pick.el
b/contrib/notmuch-pick/notmuch-pick.el
index 26966e6..a42491e 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++
15 matches
Mail list logo
