Re: [PATCH 1/2] lib: fix byte order test in libsha1.c

2013-11-25 Thread Tomi Ollila
On Sun, Nov 24 2013, da...@tethera.net wrote: From: David Bremner da...@tethera.net Previously PLATFORM_BYTE_ORDER and IS_LITTLE_ENDIAN were not defined, so the little endian code was always compiled in. This will have the effect that the SHA1s on big endian architectures will change (i.e.

[PATCH 2/3] test: print empty line at the beginning of test script, not at end

2013-11-25 Thread Tomi Ollila
In preparation for quiet mode print empty line before writing the test description. This is done now in function designed for it -- it will also be called when test fails. --- test/notmuch-test | 1 + test/test-lib.sh | 12 +---

[PATCH 3/3] test: implement and document NOTMUCH_TEST_QUIET variable usage

2013-11-25 Thread Tomi Ollila
When NOTMUCH_TEST_QUIET environment variable is set to non-null value messages when new test script starts and when test PASSes are disabled. This eases picking the cases when tests FAIL (as those are still printed). --- test/README | 8 test/basic | 4 ++-- test/test-lib.sh

[PATCH 1/3] test: resolve `basename $0 .sh` once for all in test-lib.sh

2013-11-25 Thread Tomi Ollila
test-lib.sh sometimes did equivalent of `basename $0 .sh`, sometimes skipping the basename part and sometimes .sh part. This worked as we never had path components in $0 (more than ./) nor .sh ending. Now the equivalent of `basename $0 .sh` is done once and used everywhere. In the future we may

emacs compatibility?

2013-11-25 Thread Daniel Kahn Gillmor
i notice that in the current master, debian/notmuch-emacs.README.Debian contains the following stanza: * This package currently works only with emacs 23. Users of pre-release snapshots of emacs 24 can expect problems. I'm using notmuch (and notmuch-emacs) 0.16 with

[PATCH 1/2] lib: fix byte order test in libsha1.c

2013-11-25 Thread Tomi Ollila
On Sun, Nov 24 2013, david at tethera.net wrote: > From: David Bremner > > Previously PLATFORM_BYTE_ORDER and IS_LITTLE_ENDIAN were not defined, > so the little endian code was always compiled in. > > This will have the effect that the "SHA1s" on big endian architectures > will change (i.e.

[PATCH 2/3] test: print empty line at the beginning of test script, not at end

2013-11-25 Thread Tomi Ollila
In preparation for quiet mode print empty line before writing the test description. This is done now in function designed for it -- it will also be called when test fails. --- test/notmuch-test | 1 + test/test-lib.sh | 12 +---

[PATCH 3/3] test: implement and document NOTMUCH_TEST_QUIET variable usage

2013-11-25 Thread Tomi Ollila
When NOTMUCH_TEST_QUIET environment variable is set to non-null value messages when new test script starts and when test PASSes are disabled. This eases picking the cases when tests FAIL (as those are still printed). --- test/README | 8 test/basic | 4 ++-- test/test-lib.sh

[PATCH 1/3] test: resolve `basename "$0" .sh` once for all in test-lib.sh

2013-11-25 Thread Tomi Ollila
test-lib.sh sometimes did equivalent of `basename "$0" .sh`, sometimes skipping the basename part and sometimes .sh part. This worked as we never had path components in $0 (more than ./) nor .sh ending. Now the equivalent of `basename "$0" .sh` is done once and used everywhere. In the future we

emacs compatibility?

2013-11-25 Thread Daniel Kahn Gillmor
: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20131125/3680baa5/attachment.pgp>