Re: [PATCH 2/2] cli/count: apply uncrustify changes
David Bremner writes:
> Tomi Ollila writes:
>
>>>
>>> if (exclude == EXCLUDE_TRUE) {
>>> search_exclude_tags = notmuch_config_get_search_exclude_tags
>>> - (config, &search_exclude_tags_length);
>>> + (config, &search_exclude_tags_length);
>>
>> With the first 2 uncrustify does a good job, but this last one it disagrees
>> how emacs(1) indents (and how it is currently indented in other notmuch
>> source files) -- I'd leave the last (3rd) change out.
>
> I actually think the uncrustify version is better, but I agree there is
> not much point having a standard that isn't easily achievable with
> emacs. After a short struggle trying to understand CC-mode indentation,
> I give up.
Pushed these two, amended as Tomi suggested.
d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Re: muchsync files renames
Thank you David B. for explanation. I think that everything is clear now. David M., what about updating your website on that? I think it's important to warn about possible files moves between new/ and cur/. And what I can do is to prepare patches for afew to handle it appropriately. -- Amadeusz Żołnowski signature.asc Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 2/2] cli/count: apply uncrustify changes
Tomi Ollila writes:
>>
>> if (exclude == EXCLUDE_TRUE) {
>> search_exclude_tags = notmuch_config_get_search_exclude_tags
>> -(config, &search_exclude_tags_length);
>> + (config, &search_exclude_tags_length);
>
> With the first 2 uncrustify does a good job, but this last one it disagrees
> how emacs(1) indents (and how it is currently indented in other notmuch
> source files) -- I'd leave the last (3rd) change out.
I actually think the uncrustify version is better, but I agree there is
not much point having a standard that isn't easily achievable with
emacs. After a short struggle trying to understand CC-mode indentation,
I give up.
d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
