Re: [PATCH v4 5/5] notmuch-emacs-mua: do not create a frame by default with --client

[Tomi Ollila]

On Tue, Sep 29 2015, Tomi Ollila  wrote:

> On Mon, Sep 28 2015, David Bremner  wrote:
>
>> Tomi Ollila  writes:
>>
>>
>>> if [ -n "$AUTO_DAEMON" -a -z "$CREATE_FRAME" ]; then
>>> echo "$0: --auto-daemon is only applicable with --create-frame." >&2
>>> exit 1   
>>> fi
>>>
>>> without this one may execute ./notmuch-emacs-mua --client --auto-daemon
>>> which yields starting emacs in daemon mode (in this example it is expected
>>> emacs is not running; otherwise --auto-daemon has no use in this example)
>>> -- but no ui to that newly-running emacs is provided. Similar behaviour
>>> can be observed by the following
>>>
>>
>> I think what you propose is fine for a followup patch; note that the
>> scenario you worry about also needs --client to be a problem. Apparently
>> nothing is uncontroversial here, but if auto-daemon only works with
>> create frame, then perhaps the followup would be to have auto-daemon
>> imply create-frame
>
> Without --client --auto-daemon is no-op (as it is no-op in case emacs
> server is already running). I am (only) concerned about user experience
> when one runs --client --auto-daemon and user gets nothing (i.e. emacs
> server is running in the background w/o any clients connected to it.
>
> We could make --auto-daemon imply --create-frame, but then 
>
> ./notmuch-emacs-mua --auto-daemon (i.e. w/o --client) starts new mail
> compose window to separate frame (even though user did not request
> it w/ --create-frame)

Hmm, a few more tests. it now looks like in case the command line is

./notmuch-emacs-mua --client --auto-daemon

Then the --create-frame should be implied. w/o --client --create-frame
would ... well, create that (only) emacs frame anyways... oh, the
combinations; for reference I just paste from my history...


1  07:57  0:01  ccd notmuch
2  07:57  0:06  git pull --rebase
3  07:57  0:01  git log
4  07:57  0:04  tig
5  07:58  0:10  ./notmuch-emacs-mua --auto-daemon
6  07:58  0:00  ps ax
8  07:58  0:00  emacs &
9  07:58  0:07  ./notmuch-emacs-mua --auto-daemon
   10  07:59  0:01  ./notmuch-emacs-mua --client --auto-daemon
   12  08:01  0:03  ./notmuch-emacs-mua --auto-daemon
   13  08:02  0:00  ps ax
   14  08:02  0:00  ls /tmp/emacs1001
   15  08:02  0:00  ./notmuch-emacs-mua -nw --auto-daemon
   16  08:02  0:04  DISPLAY= ./notmuch-emacs-mua  --auto-daemon
   17  08:02  0:05  tig
   18  08:03  0:02  DISPLAY= ./notmuch-emacs-mua --auto-daemon
   19  08:04  0:01  DISPLAY= ./notmuch-emacs-mua --client --auto-daemon
   20  08:04  0:00  ps ax
   21  08:04  0:00  kill 1860
   22  08:04  0:00  ps ax
   23  08:06  0:00   ./notmuch-emacs-mua --client --auto-daemon
   24  08:06  0:00  ps ax
   25  08:06  0:00  kill 1875
   26  08:06  0:00   ./notmuch-emacs-mua --client --auto-daemon
   27  08:06  0:00  ps ax
   28  08:06  0:00  kill 1926
   29  08:06  0:06  ./notmuch-emacs-mua --client --auto-daemon --create-frame
   30  08:07  0:28  ./notmuch-emacs-mua --auto-daemon --create-frame
   31  08:08  0:00  ps x
   32  08:08  0:00  h

So. I'm going w/ the suggestion making --auto-daemon imply --create-frame


>
> (actually I already did the 'imply' option (easy, one line in script,
> another in namual), just that testing it gave this thought...
>
> ... therefore I'd rather make ./notmuch-emacs-mua --auto-daemon
> spit an error and exit -- but I can be convinced otherwise :)
>
> Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH] notmuch-emacs-mua: make --auto-daemon imply --create-frame

[Tomi Ollila]

Before this change with --auto-daemon but without --create-frame
emacs server was started but no clients stay connected to it
(in both graphical and terminal displays).

Note that this changes how --client --auto-daemon works on
graphical display; New emacs frame is now created for the
message (and message-exit-actions hook appended).
---
 doc/man1/notmuch-emacs-mua.rst | 3 ++-
 notmuch-emacs-mua  | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/doc/man1/notmuch-emacs-mua.rst b/doc/man1/notmuch-emacs-mua.rst
index c3689eb82c8a..7c5729047173 100644
--- a/doc/man1/notmuch-emacs-mua.rst
+++ b/doc/man1/notmuch-emacs-mua.rst
@@ -43,7 +43,8 @@ Supported options for **notmuch-emacs-mua** include
 
 ``--auto-daemon``
 Automatically start Emacs in daemon mode, if the Emacs server
-is not running. Applicable with ``--client``.
+is not running. Applicable with ``--client``. Implies
+``--create-frame``.
 
 ``--create-frame``
 Create a new frame instead of trying to use the current Emacs
diff --git a/notmuch-emacs-mua b/notmuch-emacs-mua
index b51d8d0e2c5b..016fa12613c4 100755
--- a/notmuch-emacs-mua
+++ b/notmuch-emacs-mua
@@ -108,6 +108,7 @@ while getopts :s:c:b:i:h opt; do
;;
--auto-daemon)
AUTO_DAEMON="--alternate-editor="
+   CREATE_FRAME="-c"
;;
--create-frame)
CREATE_FRAME="-c"
-- 
2.0.0

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] notmuch-emacs-mua: make --auto-daemon imply --create-frame

[David Bremner]

Tomi Ollila  writes:

> Before this change with --auto-daemon but without --create-frame
> emacs server was started but no clients stay connected to it
> (in both graphical and terminal displays).
>
> Note that this changes how --client --auto-daemon works on
> graphical display; New emacs frame is now created for the
> message (and message-exit-actions hook appended).

this change is OK for me.

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] notmuch-emacs-mua: make --auto-daemon imply --create-frame

[Jani Nikula]

On Wed, 30 Sep 2015, David Bremner  wrote:
> Tomi Ollila  writes:
>
>> Before this change with --auto-daemon but without --create-frame
>> emacs server was started but no clients stay connected to it
>> (in both graphical and terminal displays).
>>
>> Note that this changes how --client --auto-daemon works on
>> graphical display; New emacs frame is now created for the
>> message (and message-exit-actions hook appended).
>
> this change is OK for me.

I'm fine with this as well.

BR,
Jani.



>
> d
> ___
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: correct way to search for only PDF attachments

[Xu Wang]

On Tue, Sep 29, 2015 at 9:48 AM, David Bremner  wrote:
> Suvayu Ali  writes:
>
>> On Tue, Sep 29, 2015 at 08:00:18AM -0300, David Bremner wrote:
>>>
>>> Of course it is getting pretty big, I don't know what to do about
>>> that.
>>
>> How about an overview in notmuch-search-terms with more detailed docs in
>> an info page?  coreutils does this.  I don't think this will add any new
>> build dependencies either, as sphinx supports info pages.  I see
>> texinfo_documents is already defined in doc/conf.py.  Maybe that is an
>> option?
>>
>
> I'm not really in favour of requiring anyone who is not already using
> emacs to use info.  Of course we could provide the same long form docs
> in other formats (most likely html).  I don't know if splitting into
> shorter man pages plus a longer manual would really help, but it's
> likely we could take better advantage of sphinx. I know that Patrick
> Totzke started a rework of the docs
>
>https://github.com/pazz/notmuch/tree/docs
>
> I don't think that's really in a state to contemplate merging (for one
> thing it hasn't kept up with doc changes in master); but maybe somebody
> wants to pick up where Patrick left off.
>
> d
> ___
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Thank you everyone for all of the information and for walking me in
through the example!

I will study more in depth and look at the detailed documentation.

Kind regards,

Xu
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch