Re: NEWS patches v2

2015-10-18 Thread Jani Nikula 
On Sun, 18 Oct 2015, Tomi Ollila  wrote:
> On Sat, Oct 17 2015, David Bremner  wrote:
>
>> I had a series in progress more or less at the same time as Jani, so
>> of course there were all kinds of silly conflicts.
>>
>> I rebased the two series together, and tried to get most of Tomi's
>> formatting comments.
>
> From the formatting point of view this series looks good -- with luck
> I don't have to do post-release NEWS formatting tunes this time(*) ;)
>
> Jani: the tool to "check" formatting is devel/news2wiki.pl

Oh, but it doesn't complain on what I wrote, and then you have to check
whether the markdown output is all right or not... which is roughly
equivalent of manually checking the input?

BR,
Jani.

>
> (*) perhaps this time I have a chance (i.e. remember) to run
> devel/news2wiki.pl *before* release.
>
> Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [WIP] tests: add test for case insensitive Content-Disposition

2015-10-18 Thread Jani Nikula 
On Tue, 06 Oct 2015, David Bremner  wrote:
> These broken now, but will be fixed in the next commit
> ---
>
> The first test is OK, but the second one currently fails. It isn't
> clear to me if content dispositions permit RFC2047 style
> encoding. GMime does not decode them automatically (hence this test is
> failing). What is true is that the RFC states "Unrecognized
> disposition types should be treated as `attachment'". So maybe the
> logic in patch 1 should be reversed to check != 'inline'.

> +Content-Type: text/plain
> +Content-Disposition: =?utf-8?b?YXR0YWNobWVudDsgZmlsZW5hbWU9ImJlZ3LDvMOfdW5n?=
> + =?utf-8?b?LnBkZiI=?=
> +Content-Description: this is a very exciting file

Did you handcraft the example, or did some program actually produce
this? I don't think this is [RFC 2231] compliant. IIUC only the content
disposition parameter values may contain encoded words with
charset/language specification. Like this,

Content-Disposition: attachment; filename="=?utf-8?B?cMOkw6RtaWVz?="

We currently handle that correctly, and UTF-8 searches with attachment:
prefix work. It's just that the disposition-type (usually "attachment"
or "inline") should be interpreted case insensitive, which we currently
fail at.

What should we do about malformed content-disposition fields then? I
think I'd just defer this to gmime.

Sadly email seems to be a prime example of rampant robustness principle
abuse. It has degenerated into, "Be liberal in what you send, be liberal
in what you accept", which is getting dangerously close to the GIGO
principle.


BR,
Jani.


[RFC 2231] https://tools.ietf.org/html/rfc2231
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [WIP] tests: add test for case insensitive Content-Disposition

2015-10-18 Thread Johannes Schauer 
Hi,

Quoting Jani Nikula (2015-10-18 13:58:01)
> On Tue, 06 Oct 2015, David Bremner  wrote:
> > These broken now, but will be fixed in the next commit
> > ---
> >
> > The first test is OK, but the second one currently fails. It isn't
> > clear to me if content dispositions permit RFC2047 style
> > encoding. GMime does not decode them automatically (hence this test is
> > failing). What is true is that the RFC states "Unrecognized
> > disposition types should be treated as `attachment'". So maybe the
> > logic in patch 1 should be reversed to check != 'inline'.
> 
> > +Content-Type: text/plain
> > +Content-Disposition: 
> > =?utf-8?b?YXR0YWNobWVudDsgZmlsZW5hbWU9ImJlZ3LDvMOfdW5n?=
> > + =?utf-8?b?LnBkZiI=?=
> > +Content-Description: this is a very exciting file
> 
> Did you handcraft the example, or did some program actually produce
> this? I don't think this is [RFC 2231] compliant. IIUC only the content
> disposition parameter values may contain encoded words with
> charset/language specification. Like this,
> 
> Content-Disposition: attachment; filename="=?utf-8?B?cMOkw6RtaWVz?="

I'm using alot as my MUA and that produced the Content-Disposition line I
quoted.

Thanks!

cheers, josch


signature.asc
Description: signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: NEWS patches v2

2015-10-18 Thread Tomi Ollila 
On Sat, Oct 17 2015, David Bremner  wrote:

> I had a series in progress more or less at the same time as Jani, so
> of course there were all kinds of silly conflicts.
>
> I rebased the two series together, and tried to get most of Tomi's
> formatting comments.

From the formatting point of view this series looks good -- with luck
I don't have to do post-release NEWS formatting tunes this time(*) ;)

Jani: the tool to "check" formatting is devel/news2wiki.pl

(*) perhaps this time I have a chance (i.e. remember) to run
devel/news2wiki.pl *before* release.

Tomi

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch