Re: [PATCH] python: open messages in binary mode

2017-08-25 Thread Florian Klink
that function is only since python 3.2. I'm not sure if/when we'll drop python 2.7 support, but not without deprecating it for a few releases. Is there anyone still exclusively on Python 2.7? Perhaps the time is ripe for starting that process? Encoding compatability is an unholy mess to

Re: [PATCH 2/2] emacs: Add notmuch-update-search-tags

2017-08-25 Thread Vladimir Panteleev
On 2017-08-25 11:12, David Bremner wrote: One side effect of this seems to be a regression, namely that in the current buffer the "visual history" of tag changes is broken. Previously deletions were shown by red strike-through and additions by green underline. The deletions are now removed by

[PATCH v2] emacs: Add notmuch-update-search-tags

2017-08-25 Thread Vladimir Panteleev
From: Vladimir Panteleev Implement an option which, when enabled, causes any tag changes done from within notmuch-emacs to instantly update matching threads in open search buffers. * notmuch.el: Add notmuch-search-update-results. * notmuch-tag.el: Add

Re: [PATCH 0/8] notmuch on Windows (Cygwin) and AppVeyor

2017-08-25 Thread David Bremner
Vladimir Panteleev writes: > I will probably draw the line here, as it looks like actually fixing > some of the failing tests would take some non-trivial work (e.g. one > test failure I saw seems to point towards a bug in Xapian/Cygwin). I'm > also not convinced that,

Re: [PATCH 2/2] emacs: Add notmuch-update-search-tags

2017-08-25 Thread David Bremner
Vladimir Panteleev writes: > Implement an option which, when enabled, causes any tag changes done > from within notmuch-emacs to instantly update matching threads in open > search buffers. > --- One side effect of this seems to be a regression, namely that in the

Re: [PATCH] python: open messages in binary mode

2017-08-25 Thread Gaute Hope
David Bremner writes on august 25, 2017 0:11: Florian Klink writes: To fix this, read file in binary mode and pass to email.message_from_binary_file(fp). Thanks for the patch, but notmuch is not (yet) python3 only. Apparently that function is only since python 3.2. I'm

Re: [PATCH 0/8] notmuch on Windows (Cygwin) and AppVeyor

2017-08-25 Thread Vladimir Panteleev
On 2017-08-25 11:35, David Bremner wrote: If I understand correctly, then the series as a whole is mainly of potential interest to developers wishing to take the notmuch-on-cygwin project farther, rather than to end users. That's correct. It's possible that despite the test suite failures, a