[PATCH 0/2] emacs: allow message/rfc822 to be inserted in the mailstore

2017-08-28 Thread Mark Walters
Several people including id:87bmnlko2o.fsf@len have asked to be able to reply directly to message/rfc822 messages from the emacs frontend. Doing that in emacs would be likely to be a little fragile as all other replies are generated by the cli code. This pair of patches provide an alternative

[PATCH 1/2] emacs: maildir fcc make insert more flexible

2017-08-28 Thread Mark Walters
This changeset makes the function notmuch-maildir-fcc-with-notmuch-insert slightly more flexible by allowing some of the prompts to be controlled by the caller. --- emacs/notmuch-maildir-fcc.el | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git

[PATCH 2/2] emacs: show: allow user to insert rfc822 parts as messages

2017-08-28 Thread Mark Walters
This adds a part-handler function that uses notmuch-insert to insert an rfc822 part as a message in its own right. This allows the user to reply directly to that message. We use notmuch-maildir-fcc-with-notmuch-insert as that has builtin error handling/retry functionality, and it allows the user

[PATCH] python: deprecated add_message calls index_file correctly and returns result

2017-08-28 Thread Gaute Hope
The deprecated Database.add_message now calls the new index_file with correct number of arguments (without an extra `self`), and returns the tuple from index_file - as it used to do before. --- bindings/python/notmuch/database.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] emacs: maildir fcc make insert more flexible

2017-08-28 Thread David Edmondson
On Monday, 2017-08-28 at 08:32:21 +0100, Mark Walters wrote: > This changeset makes the function > notmuch-maildir-fcc-with-notmuch-insert slightly more flexible by > allowing some of the prompts to be controlled by the caller. > --- > emacs/notmuch-maildir-fcc.el | 16 ++-- > 1 file

Re: [PATCH 2/2] emacs: show: allow user to insert rfc822 parts as messages

2017-08-28 Thread David Edmondson
On Monday, 2017-08-28 at 08:32:22 +0100, Mark Walters wrote: > This adds a part-handler function that uses notmuch-insert to insert > an rfc822 part as a message in its own right. This allows the user to > reply directly to that message. > > We use notmuch-maildir-fcc-with-notmuch-insert as that

Re: [PATCH v1 1/1] test: Perform T170 tests that don't require dtach before any that do.

2017-08-28 Thread David Bremner
David Edmondson writes: > This avoids the later tests seeing different versions of the database > depending on whether dtach is available. pushed. I notice there still plenty of tests (in other files) that fail rather than skip if dtach is missing, if someone wants a project

Re: [PATCH 2/2] emacs: show: allow user to insert rfc822 parts as messages

2017-08-28 Thread Mark Walters
> >> + (let* ((folder >> + (read-from-minibuffer "Folder/tags to insert part to: " >> +notmuch-show-part-notmuch-insert-folder))) >> +(mm-with-unibyte-buffer >> + (mm-insert-part handle) >> + (notmuch-maildir-fcc-with-notmuch-insert folder nil

Re: [PATCH 1/2] emacs: maildir fcc make insert more flexible

2017-08-28 Thread Mark Walters
Hi Thanks for the review. On Mon, 28 Aug 2017, David Edmondson wrote: > On Monday, 2017-08-28 at 08:32:21 +0100, Mark Walters wrote: > >> This changeset makes the function >> notmuch-maildir-fcc-with-notmuch-insert slightly more flexible by >> allowing some of the prompts to be

Re: [PATCH 1/2] emacs: maildir fcc make insert more flexible

2017-08-28 Thread David Edmondson
On Monday, 2017-08-28 at 12:27:03 +0100, Mark Walters wrote: >>> The fcc-header should be of the form \"folder +tag1 -tag2\" where >> >> I realise that this patch set didn't add this string, but it is mildly >> ridiculous. There's no reason that we couldn't use a list, where a >> leading “+” or

Re: [PATCH v2] emacs: Add notmuch-update-search-tags

2017-08-28 Thread David Bremner
Vladimir Panteleev writes: > Speaking of which, I had a fun time trying to figure out why my test > didn't work before I discovered that notmuch-tag-deleted-formats is > reset in test-lib.el. That took quite a bit of debugging; I think it > would be good to fix