cleanups / fixes from olly betts

Olly passed me a patch on IRC today. I'm not sure when I'll have a chance to turn it into proper patches, so here it is so it doesn't get lost. diff --git a/gmime-filter-reply.c b/gmime-filter-reply.c index a1ba4b45..f673c0a2 100644 --- a/gmime-filter-reply.c +++ b/gmime-filter-reply.c @@ -113,7

Re: tip: how to not forget attachments

On 2018-03-19 17:40:40, Brian Sniffen wrote: > Throw your function name, catch it outside the save-excursion, and raise an > error there? You mean to catch/throw to have save-excursion save the point correctly? But my tests show the point is moved by something else in message-send anyways, so

Re: tip: how to not forget attachments

Throw your function name, catch it outside the save-excursion, and raise an error there? -- Brian Sniffen > On Mar 19, 2018, at 4:16 PM, Antoine Beaupré wrote: > >> On 2018-03-19 15:57:05, Brian Sniffen wrote: >> `error` doesn’t do any unwinding; it leaves the

Re: tip: how to not forget attachments

On 2018-03-19 15:57:05, Brian Sniffen wrote: > `error` doesn’t do any unwinding; it leaves the program state wherever it was > for analysis. You probably want throw/catch, as described at > https://www.gnu.org/software/emacs/manual/html_node/elisp/Catch-and-Throw.html#Catch-and-Throw Wait, but

Re: bug: "no top level messages" crash on Zen email loops

Antoine Beaupré writes: > On 2018-03-19 13:36:49, David Bremner wrote: >> >> I can't duplicate that part. > > That's very strange. I can reproduce this on my workstation here, but > taking the tarball I sent in the original message, I can't reproduce > anymore. So

Re: tip: how to not forget attachments

`error` doesn’t do any unwinding; it leaves the program state wherever it was for analysis. You probably want throw/catch, as described at https://www.gnu.org/software/emacs/manual/html_node/elisp/Catch-and-Throw.html#Catch-and-Throw -- Brian Sniffen > On Mar 19, 2018, at 3:25 PM, Antoine

tip: how to not forget attachments

On 2018-03-19 13:56:54, Antoine Beaupré wrote: > PS: don't we have a "you forgot to actually attach the damn file" plugin > when we detect the word "attachment" and there's no attach? :p So I figured that one out, I think. Before adding it to the wiki, I'd like a review of the code (attached)

Re: bug: "no top level messages" crash on Zen email loops

And obviously I forget the frigging attachment. zendesk-email-loop2.tgz Description: application/gtar-compressed PS: don't we have a "you forgot to actually attach the damn file" plugin when we detect the word "attachment" and there's no attach? :p

Re: bug: "no top level messages" crash on Zen email loops

On 2018-03-19 13:36:49, David Bremner wrote: > Antoine Beaupré writes: > >> Hi! >> >> Here's a fun bug for you Xapian tricksters. >> >> Two emails attached make notmuch crash when trying to display the >> folder. >> >> $ notmuch show thread:0001 >> Internal

Re: bug: "no top level messages" crash on Zen email loops

Antoine Beaupré writes: > Hi! > > Here's a fun bug for you Xapian tricksters. > > Two emails attached make notmuch crash when trying to display the > folder. > > $ notmuch show thread:0001 > Internal error: Thread 0001 has no toplevel messages. >

bug: "no top level messages" crash on Zen email loops

Hi! Here's a fun bug for you Xapian tricksters. Two emails attached make notmuch crash when trying to display the folder. $ notmuch show thread:0001 Internal error: Thread 0001 has no toplevel messages. (notmuch-show.c:1012) Those are the two messages: $ notmuch

Re: multilingual notmuch (and Content-Language)

On Sun 2018-03-18 21:32:35 +0200, Jani Nikula wrote: > On Sun, 18 Mar 2018, Daniel Kahn Gillmor wrote: >> * if we know our index expects english, and we have a message part that >>*is not* english (e.g. Content-Language: es), we could avoid indexing >>that part. >