Re: [PATCH 2/4] util/crypto: identify and repair "Mixed Up" mangled messages

2019-05-29 Thread Rollins, Jameson
On Tue, May 28 2019, Daniel Kahn Gillmor wrote: > This patch implements a functional identification and repair process > for "Mixed Up" MIME messages as described in > https://tools.ietf.org/html/draft-dkg-openpgp-pgpmime-message-mangling-00#section-4.1 > > The detection test is not entirely

Re: [PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages

2019-05-29 Thread Rollins, Jameson
On Tue, May 28 2019, Daniel Kahn Gillmor wrote: > When showing a message that has been mangled in transit by an MTA in > the "Mixed up" way, "notmuch show" should instead show the repaired > form of the message. Given that this fix is in mime-node.c it will apply to reply as well, not just show,

Re: [PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages

2019-05-29 Thread Rollins, Jameson
On Wed, May 29 2019, Jameson Graef Rollins wrote: > On Tue, May 28 2019, Daniel Kahn Gillmor wrote: >> When showing a message that has been mangled in transit by an MTA in >> the "Mixed up" way, "notmuch show" should instead show the repaired >> form of the message. > > Given that this fix is in

Re: Safe and useful handling of "Mixed Up" mangled messages

2019-05-29 Thread Rollins, Jameson
On Wed, May 29 2019, Daniel Kahn Gillmor wrote: > On Tue 2019-05-28 18:58:22 -0400, Daniel Kahn Gillmor wrote: >> I forgot to mention: this test case makes use of the test_json_nodes >> functionality introduced in 03/17 of the protected header series. >> >> So please only consider this after that

Re: Protected Headers (2nd major revision, more testing!)

2019-05-29 Thread David Bremner
Daniel Kahn Gillmor writes: > Hi all-- > > Way back in id:20180511055544.13676-1-...@fifthhorseman.net, i > proposed support for protected headers (in particular, for being able > to read and search for subject lines of encrypted messages which > protect the Subject). Although that series was

Re: Segfault on notmuch compiled using commit 73cebe6e7233f59ba26d9f7c05265b7776795818

2019-05-29 Thread David Bremner
rey-coyrehourcq writes: > Finally found my problem, > I install notmuch into custom dir, and the declared PATH point to an old > binary > in the wrong /bin folder. > I works now. > Sorry for that, and thanks David for your help. Great, glad it's working. And thanks for taking the time to

[PATCH] NEWS: add a note about protected headers

2019-05-29 Thread Daniel Kahn Gillmor
Signed-off-by: Daniel Kahn Gillmor --- NEWS | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8f250ab9..c08c564e 100644 --- a/NEWS +++ b/NEWS @@ -20,6 +20,10 @@ mboxes); e.g. `gzip -9 $MAIL/archive/giant-message && notmuch new` should work. Note that

Re: Protected Headers (2nd major revision, more testing!)

2019-05-29 Thread Daniel Kahn Gillmor
On Wed 2019-05-29 08:44:00 -0300, David Bremner wrote: > It's in. Thanks! > I did bodge things up slightly due to the threading of patch 14, but I > added the trivial patch with the one line change I missed. that's not a bodge at all compared to the several different bodges i did on that

Re: Safe and useful handling of "Mixed Up" mangled messages

2019-05-29 Thread Daniel Kahn Gillmor
On Tue 2019-05-28 18:58:22 -0400, Daniel Kahn Gillmor wrote: > I forgot to mention: this test case makes use of the test_json_nodes > functionality introduced in 03/17 of the protected header series. > > So please only consider this after that patch has been merged. It has been merged, so this

[PATCH] test: signature verification during decryption (session keys)

2019-05-29 Thread Daniel Kahn Gillmor
When the user knows the signer's key, we want "notmuch show" to be able to verify the signature of an encrypted and signed message regardless of whether we are using a stashed session key or not. I wrote this test because I was surprised to see signature verification failing when viewing some