[PATCH] configure: require python 3.5 for CFFI-based notmuch bindings
Also tell users what the consequences of a "No" answer is when python version is less than 3.5, cffi or setuptools is missing, or no pytest >= 3.0 is available. --- configure | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure b/configure index e4c738e5..f4b3c61a 100755 --- a/configure +++ b/configure @@ -713,14 +713,14 @@ fi have_python3_dev=0 if [ $have_python -eq 1 ]; then -printf "Checking for python3 dev..." +printf "Checking for python3 dev (>= 3.5)..." if "$python" -c 'import os, sys, sysconfig; -assert sys.version_info >= (3,0) +assert sys.version_info >= (3,5) assert os.path.isfile(sysconfig.get_config_h_filename())' >/dev/null 2>&1; then printf "Yes.\n" have_python3_dev=1 else -printf "No.\n" +printf "No (will not install CFFI-based python bindings).\n" fi fi @@ -732,7 +732,7 @@ if [ $have_python3_dev -eq 1 ]; then printf "Yes.\n" have_python3_cffi=1 else -printf "No.\n" +printf "No (will not install CFFI-based python bindings).\n" fi printf "Checking for python3 pytest (>= 3.0)... " @@ -742,7 +742,7 @@ if [ $have_python3_dev -eq 1 ]; then printf "Yes.\n" have_python3_pytest=1 else -printf "No.\n" +printf "No (will not test CFFI-based python bindings).\n" fi rm -f $conf fi -- 2.26.2 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: Python 3.x bindings support which versions, exactly?
On Tue 26 May 2020 at 00:41 +0300, Tomi Ollila wrote: > On Mon, May 25 2020, Floris Bruynooghe wrote: > >> In tox.ini the earliest version is 3.5 and if memory serves me right >> there's a reasonably good reason for that. I think the notmuch2 >> bindings use some features not yet present in 3.4. But anything >= 3.5 >> should be supported and if not a bug. I guess tox.ini should be updated >> with 3.8 sometime :) > > I've been long thinking whether our current python3 check is "strict" > enough, as it, in configure, is: > > if "$python" -c 'import sys; assert sys.version_info >= (3,0)' > /dev/null > 2>&1 > > Perhaps that should be updated to (3,5) ? If this check is only used to decide to build the python-cffi/notmuch2 bindings, then yes. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] devel: script to calculate a list of authors.
Tomi Ollila writes: > On Fri, Jun 05 2020, David Bremner wrote: > >> As an initial heuristic, report anyone with at least 15 lines of code >> in the current source tree. Test corpora are excluded, although >> probabably this doesn't change much about the list of authors >> produced. >> --- >> devel/author-scan.sh | 11 +++ >> 1 file changed, 11 insertions(+) >> create mode 100644 devel/author-scan.sh >> >> diff --git a/devel/author-scan.sh b/devel/author-scan.sh >> new file mode 100644 >> index ..2d9c4af8 >> --- /dev/null >> +++ b/devel/author-scan.sh >> @@ -0,0 +1,11 @@ >> +#!/bin/sh >> + >> +FILE_EXCLUDE='corpora' >> +AUTHOR_EXCLUDE='uncrustify' >> +# based on the FSF guideline, for want of a better idea. >> +THRESHOLD=15 >> + >> +git ls-files | grep -v -e "$FILE_EXCLUDE" | xargs -n 1 -d \\n \ >> + git blame -w >> --line-porcelain -- | \ > > It worked !? =D -- good -- this indentation in line above is interesting... I had to delete a | before git blame to get your version to work, so I accepeted Emacs' suggestion of how to indent since it emphasizes that git blame is an argument to xargs ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] devel: script to calculate a list of authors.
On Fri, Jun 05 2020, David Bremner wrote: > As an initial heuristic, report anyone with at least 15 lines of code > in the current source tree. Test corpora are excluded, although > probabably this doesn't change much about the list of authors > produced. > --- > devel/author-scan.sh | 11 +++ > 1 file changed, 11 insertions(+) > create mode 100644 devel/author-scan.sh > > diff --git a/devel/author-scan.sh b/devel/author-scan.sh > new file mode 100644 > index ..2d9c4af8 > --- /dev/null > +++ b/devel/author-scan.sh > @@ -0,0 +1,11 @@ > +#!/bin/sh > + > +FILE_EXCLUDE='corpora' > +AUTHOR_EXCLUDE='uncrustify' > +# based on the FSF guideline, for want of a better idea. > +THRESHOLD=15 > + > +git ls-files | grep -v -e "$FILE_EXCLUDE" | xargs -n 1 -d \\n \ > + git blame -w > --line-porcelain -- | \ It worked !? =D -- good -- this indentation in line above is interesting... Tomi > +sed -n "/$AUTHOR_EXCLUDE/d; s/^[aA][uU][tT][hH][Oo][rR] //p" | \ > +sort -fd | uniq -ic | awk "\$1 >= $THRESHOLD" | sort -nr > -- > 2.26.2 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] tweaks to NEWS suggest by Tomi
On Fri, Jun 05 2020, David Bremner wrote: > See id:m27dwp40sx@guru.guru-group.fi LGTM. Tomi > --- > this is on top of Tomi's NEWS patch re Xapian > NEWS | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/NEWS b/NEWS > index a16689ca..556172bb 100644 > --- a/NEWS > +++ b/NEWS > @@ -5,8 +5,8 @@ S/MIME > -- > > Handle S/MIME (PKCS#7) messages -- one-part signed messages, encrypted > -messages, and multilayer messages. Treat them symmetrically to > -OpenPGP messages. This includes handling protected headers > +messages, and multilayer messages. Treat them symmetrically to > +OpenPGP messages. This includes handling protected headers > gracefully. > > If you're using Notmuch with S/MIME, you currently need to configure > @@ -16,21 +16,21 @@ Mixed-up MIME Repair > > > Detect and automatically repair a common form of message mangling > -created by Microsoft Exchange. (see index.repaired=mixedup in > -notmuch-properties(7). > +created by Microsoft Exchange (see index.repaired=mixedup in > +notmuch-properties(7)). > > Protected Headers > - > > Avoid indexing the legacy-display part of an encrypted message that > -has protected headers. (see > +has protected headers (see > index.repaired=skip-protected-headers-legacy-display in > -notmuch-properties(7). > +notmuch-properties(7)). > > Python > -- > > -Drop compatibility with python2, focus on python3. > +Drop support for python2, focus on python3. > > Introduce new CFFI-based python bindings in the python module named > "notmuch2". Officially deprecate (but still support) the older > -- > 2.26.2 > > ___ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] devel: script to calculate a list of authors.
As an initial heuristic, report anyone with at least 15 lines of code in the current source tree. Test corpora are excluded, although probabably this doesn't change much about the list of authors produced. --- devel/author-scan.sh | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 devel/author-scan.sh diff --git a/devel/author-scan.sh b/devel/author-scan.sh new file mode 100644 index ..2d9c4af8 --- /dev/null +++ b/devel/author-scan.sh @@ -0,0 +1,11 @@ +#!/bin/sh + +FILE_EXCLUDE='corpora' +AUTHOR_EXCLUDE='uncrustify' +# based on the FSF guideline, for want of a better idea. +THRESHOLD=15 + +git ls-files | grep -v -e "$FILE_EXCLUDE" | xargs -n 1 -d \\n \ + git blame -w --line-porcelain -- | \ +sed -n "/$AUTHOR_EXCLUDE/d; s/^[aA][uU][tT][hH][Oo][rR] //p" | \ +sort -fd | uniq -ic | awk "\$1 >= $THRESHOLD" | sort -nr -- 2.26.2 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
[PATCH] tweaks to NEWS suggest by Tomi
See id:m27dwp40sx@guru.guru-group.fi --- this is on top of Tomi's NEWS patch re Xapian NEWS | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/NEWS b/NEWS index a16689ca..556172bb 100644 --- a/NEWS +++ b/NEWS @@ -5,8 +5,8 @@ S/MIME -- Handle S/MIME (PKCS#7) messages -- one-part signed messages, encrypted -messages, and multilayer messages. Treat them symmetrically to -OpenPGP messages. This includes handling protected headers +messages, and multilayer messages. Treat them symmetrically to +OpenPGP messages. This includes handling protected headers gracefully. If you're using Notmuch with S/MIME, you currently need to configure @@ -16,21 +16,21 @@ Mixed-up MIME Repair Detect and automatically repair a common form of message mangling -created by Microsoft Exchange. (see index.repaired=mixedup in -notmuch-properties(7). +created by Microsoft Exchange (see index.repaired=mixedup in +notmuch-properties(7)). Protected Headers - Avoid indexing the legacy-display part of an encrypted message that -has protected headers. (see +has protected headers (see index.repaired=skip-protected-headers-legacy-display in -notmuch-properties(7). +notmuch-properties(7)). Python -- -Drop compatibility with python2, focus on python3. +Drop support for python2, focus on python3. Introduce new CFFI-based python bindings in the python module named "notmuch2". Officially deprecate (but still support) the older -- 2.26.2 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
