Re: [PATCH] configure: replace multiple redirects with redirected block

David Bremner writes: > This belatedly implements Tomi's suggestion from > > id:m25zaukv6u@guru.guru-group.fi applied to master. d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to

[PATCH 06/10] test: add regression test for n_d_{begin,end}_atomic

Xapian currently succeeds to begin/end a transaction on a closed database, or at least does not throw an exception. Make the test robust against this changing. --- test/T562-lib-database.sh | 33 + 1 file changed, 33 insertions(+) diff --git

[PATCH 01/10] test: regression test for closing a closed database

This does not currently throw an error, and it should stay that way. --- test/T562-lib-database.sh | 15 +++ 1 file changed, 15 insertions(+) diff --git a/test/T562-lib-database.sh b/test/T562-lib-database.sh index c9705b13..0dae0096 100755 --- a/test/T562-lib-database.sh +++

[PATCH 08/10] test: add regression test for n_d_get_directory

At least this exception is already handled correctly. --- test/T562-lib-database.sh | 17 + 1 file changed, 17 insertions(+) diff --git a/test/T562-lib-database.sh b/test/T562-lib-database.sh index e9f00726..06569291 100755 --- a/test/T562-lib-database.sh +++

[PATCH 07/10] test: regression test for n_d_get_revision

This function only accesses data cached by notmuch, so being closed is not a problem. --- test/T562-lib-database.sh | 18 ++ 1 file changed, 18 insertions(+) diff --git a/test/T562-lib-database.sh b/test/T562-lib-database.sh index 94e0e06a..e9f00726 100755 ---

[PATCH 04/10] lib/n_d_needs_upgrade: handle error return from n_d_get_version

Also clarify documentation of error return from n_d_needs_upgrade. --- lib/database.cc | 14 +++--- lib/notmuch.h | 2 ++ test/T562-lib-database.sh | 1 - 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index

[PATCH 09/10] test: regression test for n_d_index_file closed db

Current exception handling seems OK, at least for this case. --- test/T562-lib-database.sh | 20 1 file changed, 20 insertions(+) diff --git a/test/T562-lib-database.sh b/test/T562-lib-database.sh index 06569291..6a51002a 100755 --- a/test/T562-lib-database.sh +++

[PATCH 03/10] test: add known broken test for n_d_needs_upgrade

It's a bit arbitrary which value to return for errors, but the same argument as for read only databases applies for errors. --- test/T562-lib-database.sh | 18 ++ 1 file changed, 18 insertions(+) diff --git a/test/T562-lib-database.sh b/test/T562-lib-database.sh index

[PATCH 10/10] test: add known broken test for indexing relative path

The current code seems to look for the path relative to the current working directory, rather than the mail store root. --- test/T562-lib-database.sh | 17 + 1 file changed, 17 insertions(+) diff --git a/test/T562-lib-database.sh b/test/T562-lib-database.sh index

[PATCH 05/10] test: regression test for n_d_upgrade

The logic is that if it's acceptable to return SUCCESS for read only database, it's acceptable for a closed one. --- test/T562-lib-database.sh | 17 + 1 file changed, 17 insertions(+) diff --git a/test/T562-lib-database.sh b/test/T562-lib-database.sh index 4bcbc805..d975f109

[PATCH 02/10] test: add regression tests for notmuch database destroy

Either an open or closed database should be ok to destroy --- test/T562-lib-database.sh | 31 +++ 1 file changed, 31 insertions(+) diff --git a/test/T562-lib-database.sh b/test/T562-lib-database.sh index 0dae0096..db7a34f3 100755 --- a/test/T562-lib-database.sh +++

batch 6, API exception handling cleanup.

These follow the series at id:20200714224119.717845-1-da...@tethera.net Probably most interesting is [PATCH 10/10] test: add known broken test for indexing relative path That test is also part of the bug report id:87sgdqo0rz@tethera.net

Re: fix deprecation warnings for notmuch_message_get_flag

David Bremner writes: > I decided before commiting to a style of error return for existing > Boolean API functions I should try it out. I eliminated all of the > deprecation warnings for notmuch_message_get_flag. Honestly the worst > part was dealing with interprocedural error propagation, I

Re: [PATCH 11/11] lib: catch exceptions in n_m_get_flag, provide n_m_get_flag_st

David Bremner writes: > It's not very nice to return FALSE for an error, so provide > notmuch_message_get_flag_st as a migration path. applied to master, before the several patches needed to remove deprecation warnings. ___ notmuch mailing list --