Re: [PATCH 2/3] test: Deal with Emacs 27 switching to lexical scope by default

2020-07-27 Thread David Bremner
Jonas Bernoulli writes: > > +(defvar notmuch-hello-mode-hook-counter -100) > +(defvar notmuch-hello-refresh-hook-counter -100) > + > (defadvice notmuch-search-process-filter (around pessimal activate disable) >"Feed notmuch-search-process-filter one character at a time." >(let

Re: [PATCH 08/13] test: regression test for n_directory_delete with closed db.

2020-07-27 Thread David Bremner
David Bremner writes: > To the best of my current understanding, it's a bug in Xapian that no > exception is thrown here. The test should pass in either case. > --- > test/T563-lib-directory.sh | 19 ++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git

Re: batch 7, API exception handline cleanup.

2020-07-27 Thread David Bremner
David Bremner writes: > These follow the series > > id:20200718150751.4106125-1-da...@tethera.net > > Probably the most interesting change is > > [PATCH 7/8] lib: fix error return bug with n_d_set_config. > batch applied to master. d

[PATCH v3 2/4] test: Deal with Emacs 27 switching to lexical scope by default

2020-07-27 Thread Jonas Bernoulli
Starting with Emacs 27 undeclared variables in evaluated interactive code uses lexical scope. This includes code passed with '--eval' as we do in the Emacs tests, which also happen to assume dynamic scope. - This can affect variables defined by libraries that we use. We let-bind such

[PATCH v3 3/4] test: Remove misguided emacs testing utilities

2020-07-27 Thread Jonas Bernoulli
The goal of this abstraction was to save space. But that failed as the result actually was that four trivial lines got replace with 15 fairly complicated lines. The opposite of what it was supposed to do. Also it made it harder to come up with the fix in the previous commit; simply grepping for

[PATCH v3 0/4] Adjust test for changes in Emacs 27

2020-07-27 Thread Jonas Bernoulli
This reroll explains why the variable's default value is -100. It also adds an additional commit, which removes a misguided abstraction that is related to those very same variables. Jonas Bernoulli (4): gitignore: Ignore generated sphinx.config test: Deal with Emacs 27 switching to lexical

[PATCH v3 4/4] test: Explicitly state that we want to sign with sender

2020-07-27 Thread Jonas Bernoulli
Since Emacs 27 'mml-secure-epg-sign' errors out if we don't opt-in to signing as the sender using 'mml-secure-openpgp-sign-with-sender'. --- test/test-lib.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index 8c331b88..31c858d1 100644

[PATCH v3 1/4] gitignore: Ignore generated sphinx.config

2020-07-27 Thread Jonas Bernoulli
--- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 1c8705ec..8f3ebec0 100644 --- a/.gitignore +++ b/.gitignore @@ -17,3 +17,4 @@ tags /.stamps *.stamp /bindings/python-cffi/build/ +/sphinx.config -- 2.26.0

[PATCH] T355: specify hash algorithm explicitly

2020-07-27 Thread Đoàn Trần Công Danh
On some systems (notably, the one shipped with LibreSSL), default fingerprint digest algorithm is SHA256. On other systems, users can change default digest algorithm by changing default_md in /etc/ssl/default_md. Let's ask openssl to provide us specific algorithm to make the test more

[PATCH] configure: detect version by compiler for build

2020-07-27 Thread Đoàn Trần Công Danh
We'll need to run the compiled binary to report our current version. With the same code base, we should have the same version information regardless of compiler and architecture. Let's use the compiler for building architecture to build the reporting binary. Which is usually reported under

[PATCH] configure: drop check for default xapian backend

2020-07-27 Thread Đoàn Trần Công Danh
Starting from xapian 1.3.5, xapian switched default backend to glass. From 00cdfe10 (build: drop support for xapian versions less than 1.4, 2020-04-22), we only support xapian 1.4.0+. Effectively, we don't need to check for default xapian backend anymore. Let's drop it. Signed-off-by: Đoàn Trần

[PATCH] configure: account for various name of pytest-3

2020-07-27 Thread Đoàn Trần Công Danh
On different distro, pytest is suffixed with different patterns. Try to account for them, now. Signed-off-by: Đoàn Trần Công Danh --- configure | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/configure b/configure index db3538b3..90bc9182 100755 --- a/configure

Re: [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters

2020-07-27 Thread Sean Whitton
Hello, On Mon 27 Jul 2020 at 12:02AM +02, Jonas Bernoulli wrote: > Sean Whitton writes: > >> On Sun 26 Jul 2020 at 06:58PM +02, Jonas Bernoulli wrote: >> >>> Also do so for some 'if' forms that lack an ELSE part. >>> Even go as far as using 'and' and 'not' instead of 'unless'. >> >> I don't

Re: [PATCH] T355: specify hash algorithm explicitly

2020-07-27 Thread Đoàn Trần Công Danh
On 2020-07-27 22:41:08+0700, Đoàn Trần Công Danh wrote: > On some systems (notably, the one shipped with LibreSSL), > default fingerprint digest algorithm is SHA256. > > On other systems, users can change default digest algorithm by changing > default_md in /etc/ssl/default_md.

Re: [PATCH 01/23] emacs: Shorten long lines

2020-07-27 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > --- > emacs/coolj.el | 2 +- > emacs/notmuch-address.el | 38 +++-- > emacs/notmuch-company.el | 17 -- > emacs/notmuch-crypto.el | 16 +++--- > emacs/notmuch-draft.el | 12 ++-- >

Re: [PATCH 1/3] gitignore: Ignore generated sphinx.config

2020-07-27 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 1c8705ec..8f3ebec0 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -17,3 +17,4 @@ tags > /.stamps > *.stamp > /bindings/python-cffi/build/

Re: [PATCH] T355: specify hash algorithm explicitly

2020-07-27 Thread Tomi Ollila
On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote: > On some systems (notably, the one shipped with LibreSSL), > default fingerprint digest algorithm is SHA256. > > On other systems, users can change default digest algorithm by changing > default_md in /etc/ssl/default_md. > > Let's ask openssl to

[PATCH] notmuch-mutt: replace shell pipeline with internal pipe processing

2020-07-27 Thread Tomi Ollila
The shell pipeline used to symlink files based in search results to "cache" directory for mutt(1) to use was prone to portability problems (due to /bin/sh differences). The replacement executes `notmuch search` without intermediate shell (so shell_quote was removed in this case), reads the

Re: simplify handling of writable database modes

2020-07-27 Thread Tomi Ollila
On Sun, Jul 26 2020, David Bremner wrote: > As the last commit message mentions, it is a bit hard to be sure one > is using static_cast correctly, so this series eliminates > the use of static_cast for Xapian database objects. > > As a bonus, it deletes more code than it adds. > > Based on a

Re: [PATCH] configure: detect version by compiler for build

2020-07-27 Thread Tomi Ollila
On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote: > We'll need to run the compiled binary to report our current version. > > With the same code base, we should have the same version information > regardless of compiler and architecture. > > Let's use the compiler for building architecture to build

Re: [PATCH] configure: account for various name of pytest-3

2020-07-27 Thread Tomi Ollila
On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote: > On different distro, pytest is suffixed with different patterns. > Try to account for them, now. > > Signed-off-by: Đoàn Trần Công Danh > --- > configure | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH 02/23] emacs: Remove excess empty lines

2020-07-27 Thread Tomi Ollila
On Sun, Jul 26 2020, Jonas Bernoulli wrote: > Most people who write lots of lisp tend to only sparsely use empty > "separator" lines within forms. In lisp they feel unnecessary and > since most files stick to this convention we get a bit confused > when there are extra empty lines. It feels

Re: [PATCH 02/23] emacs: Remove excess empty lines

2020-07-27 Thread Jonas Bernoulli
Tomi Ollila writes: > On Sun, Jul 26 2020, Jonas Bernoulli wrote: >> ;; Outer single and double quotes, which might be nested. >> (cl-loop with start-of-loop >> - do (setq start-of-loop p-name) >> - >> + do (setq start-of-loop p-name) >> when

Re: [PATCH 1/3] gitignore: Ignore generated sphinx.config

2020-07-27 Thread Jonas Bernoulli
Tomi Ollila writes: > On Sun, Jul 26 2020, Jonas Bernoulli wrote: > >> --- >> .gitignore | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/.gitignore b/.gitignore >> index 1c8705ec..8f3ebec0 100644 >> --- a/.gitignore >> +++ b/.gitignore >> @@ -17,3 +17,4 @@ tags >> /.stamps >>

Re: [PATCH 01/23] emacs: Shorten long lines

2020-07-27 Thread Jonas Bernoulli
Tomi Ollila writes: > On Sun, Jul 26 2020, Jonas Bernoulli wrote: >> (defun notmuch-maildir-add-file-style-fcc-header (subdir) >> @@ -249,9 +250,8 @@ (defun notmuch-maildir-fcc-with-notmuch-insert >> (fcc-header create) >>;; typo, or just the user want a new folder, let the user

Re: [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters

2020-07-27 Thread Jonas Bernoulli
Sean Whitton writes: > Hello, > > On Mon 27 Jul 2020 at 12:02AM +02, Jonas Bernoulli wrote: > >> Sean Whitton writes: >> >>> On Sun 26 Jul 2020 at 06:58PM +02, Jonas Bernoulli wrote: >>> Also do so for some 'if' forms that lack an ELSE part. Even go as far as using 'and' and 'not'

Re: [PATCH] T355: specify hash algorithm explicitly

2020-07-27 Thread Đoàn Trần Công Danh
On 2020-07-27 20:40:39+0300, Tomi Ollila wrote: > On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote: > > > On some systems (notably, the one shipped with LibreSSL), > > default fingerprint digest algorithm is SHA256. > > > > On other systems, users can change default digest algorithm by changing >

Looking for help re: inbox/thread/tree slowdown; misconfiguration?

2020-07-27 Thread jonathan
Hi all, I'm recently returning to notmuch after a few years of using mu4e. I'm thrilled to be back - the tag based workflow is fantastic! However, I'm hitting a problem with tree-mode/threading that I can't seem to solve. I am hoping the folks on this list might have some suggestions. I've

Re: Looking for help re: inbox/thread/tree slowdown; misconfiguration?

2020-07-27 Thread David Bremner
jonat...@teamwilner.com writes: > I've got about 52K items with the tag "inbox". Should be "notmuch" > right? :-) Here's the problem - if I want to view that in tree view, > it can take multiple minutes for notmuch to return a result. In general there should be some results right away, with the

Re: [PATCH] configure: detect version by compiler for build

2020-07-27 Thread Đoàn Trần Công Danh
On 2020-07-27 20:31:59+0300, Tomi Ollila wrote: > On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote: > > > We'll need to run the compiled binary to report our current version. > > > > With the same code base, we should have the same version information > > regardless of compiler and architecture. >

[PATCH v2] configure: check for pytest with python -m pytest

2020-07-27 Thread Đoàn Trần Công Danh
On 2020-07-27 20:37:10+0300, Tomi Ollila wrote: > On Mon, Jul 27 2020, Đoàn Trần Công Danh wrote: > > > On different distro, pytest is suffixed with different patterns. > > Try to account for them, now. > > > > Signed-off-by: Đoàn Trần Công Danh > > --- > > configure | 13 + > > 1