On Sunday, 2020-11-08 at 20:03:11 +01, Jonas Bernoulli wrote:
There were some places here where you capitalised comments (more
generally, turned them into English prose) when they were moving for
$reasons, and others where you left them alone. Was there a rationale
for the different treatment?
On Sunday, 2020-11-08 at 20:02:59 +01, Jonas Bernoulli wrote:
Minor suggestion below...
Reviewed-by: David Edmondson
> ---
> emacs/notmuch-address.el | 6 +++---
> emacs/notmuch-crypto.el | 4 ++--
> emacs/notmuch-mua.el | 7 ---
> 3 files changed, 9 insertions(+), 8 deletions(-)
>
>
On Sunday, 2020-11-08 at 20:02:57 +01, Jonas Bernoulli wrote:
With a suggested rewording below...
Reviewed-by: David Edmondson
> ---
> emacs/notmuch-crypto.el | 3 +--
> emacs/notmuch-hello.el | 3 +--
> emacs/notmuch-mua.el| 11 ---
> 3 files changed, 6 insertions(+), 11
On Sunday, 2020-11-08 at 20:02:50 +01, Jonas Bernoulli wrote:
> This fixes a regression introduced in [1: 7e20d264]. If the argument
> RETURN-ACTION was non-nil then we should pass along the value of that
> argument. Instead we passed along the constant symbol `return-action'.
>
> 1:
