[PATCH] emacs: escape quote in notmuch-search-result-format docstring

2022-02-16 Thread David Bremner
Prevent Emacs' mangling of quotes, which breaks the code sample. --- emacs/notmuch.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index 6abb17ff..c9cf80dc 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -93,7 +93,7 @@ Supported

Re: [BUG] Bad quote in help

2022-02-16 Thread Tomi Ollila
On Wed, Feb 16 2022, Rudolf Adamkovič wrote: > Repro steps: > > 1. C-h v > 2. notmuch-search-result-format > 3. RET > > See: > > For example: > (setq notmuch-search-result-format > ’(("authors" . "%-40s") > ("subject" . "%s"))) > > The quote ’ needs changed to ',

[PATCH] test: allow to use --full-sync

2022-02-16 Thread Michael J Gruber
Some build infrastructure appears to habe problems with mtime/stat, leading to spurious failures (noticed on s390x and aarch64 with epel8). Allow the test suite to be run with --full-sync so that release builds can use the test suite while avoiding spurious failures. Signed-off-by: Michael J

Re: [PATCH] test: allow to use --full-sync

2022-02-16 Thread David Bremner
Michael J Gruber writes: > Some build infrastructure appears to habe problems with mtime/stat, have > leading to spurious failures (noticed on s390x and aarch64 with epel8). > Allow the test suite to be run with --full-sync so that release builds > can use the test suite while avoiding

Re: [PATCH] test: allow to use --full-sync

2022-02-16 Thread Michael J Gruber
David Bremner venit, vidit, dixit 2022-02-16 14:04:17: > Michael J Gruber writes: > > > Some build infrastructure appears to habe problems with mtime/stat, > > have Huh, this looks as if my mother tongue slipped in, while it's just key proximity. > > leading to spurious failures (noticed on

Re: [PATCH] test: allow to use --full-sync

2022-02-16 Thread Tomi Ollila
On Wed, Feb 16 2022, Michael J. Gruber wrote: > David Bremner venit, vidit, dixit 2022-02-16 14:04:17: >> Michael J Gruber writes: >> >> > Some build infrastructure appears to habe problems with mtime/stat, >> >> have > > Huh, this looks as if my mother tongue slipped in, while it's just key >

Re: [PATCH] test: allow to use --full-sync

2022-02-16 Thread Tomi Ollila
On Wed, Feb 16 2022, Tomi Ollila wrote: > > I'd not merge this NOTMUCH_NEW_OPTIONS=--full-scan ;D too eagerly > ... I'd like we really knew the reason (which is then written in > commit message) I seem I did not get my message above (or why the ;D is there) expressed clear enough -- the idea

Re: Python binding SIGABRT/SIGSEGV

2022-02-16 Thread Floris Bruynooghe
On Thu 10 Feb 2022 at 13:16 +0100, Michael J Gruber wrote: > Austin Lund venit, vidit, dixit 2022-02-10 06:56:12: >> I'm clearly doing this python code wrong by not using the iterator correctly: >> >> > import notmuch2 >> > >> > d = notmuch2.Database() >> > m = list(d.messages("since:today"))

Re: [PATCH 2/2] python-cffi: use config_pairs API in ConfigIterator

2022-02-16 Thread Floris Bruynooghe
On Fri 11 Feb 2022 at 09:04 -0400, David Bremner wrote: > This returns all of the config keys with non-empty values, not just > those that happen to be stored in the database. > --- > bindings/python-cffi/notmuch2/_build.py | 16 +- > bindings/python-cffi/notmuch2/_config.py | 37

Re: [PATCH] emacs: escape quote in notmuch-search-result-format docstring

2022-02-16 Thread Tomi Ollila
On Wed, Feb 16 2022, David Bremner wrote: LGTM, now I remeber this syntax... Tomi > Prevent Emacs' mangling of quotes, which breaks the code sample. > --- > emacs/notmuch.el | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > index

Re: [PATCH] emacs: escape quote in notmuch-search-result-format docstring

2022-02-16 Thread David Bremner
Tomi Ollila writes: > On Wed, Feb 16 2022, David Bremner wrote: > > LGTM, now I remeber this syntax... > > Tomi > OK, the docstring is fixed in commit 6286b76a, which should be in the next major release (0.36). Thanks for the report, d ___ notmuch

[no subject]

2022-02-16 Thread David Bremner
Floris wrote: > FWIW having spaces between the function name and parentheses is rather >uncommon for python style. Though of course complaining about style >without using an auto-formatter is pretty meh these days :) > Yeah fair enough, it's the default in the C code, but we pretty clearly have

[PATCH v2 2/2] python-cffi: use config_pairs API in ConfigIterator

2022-02-16 Thread David Bremner
This returns all of the config keys with non-empty values, not just those that happen to be stored in the database. --- bindings/python-cffi/notmuch2/_build.py | 16 - bindings/python-cffi/notmuch2/_config.py | 40 +++ bindings/python-cffi/tests/test_config.py | 24

[PATCH v2 1/2] test: known broken test for list(db.config) in python-cffi bindings

2022-02-16 Thread David Bremner
As of notmuch 0.34.2 [1], the python-cffi bindings make available the configuration from both a config file and the database when accessing Database.config like a dictionary. It is therefore confusing that the iterator operations only work on the configuration information stored in the database.