[notmuch] pull request

2010-04-01 Thread David Bremner
On Thu, 01 Apr 2010 14:09:57 -0700, Carl Worth wrote: > More significantly, this level of documentation needs to be put into the > "notmuch help" output (instead of the placeholder that's there in the > current patch). It also needs to be added to the man page in notmuch.1. Allow me to

[notmuch] notmuch vs gmail filters

2010-04-01 Thread Anthony Towns
hony Towns -- next part -- A non-text attachment was scrubbed... Name: gmail2notmuch.py Type: text/x-python Size: 1980 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100401/63950a4b/attachment.py>

[notmuch] [PATCH] Setup the GMimeStream only when needed

2010-04-01 Thread Michal Sojka
On Thu, 01 Apr 2010, nstraz at redhat.com wrote: > I ran into this while looking at the vim plugin. Vim's system() call > redirects output to a file and it was missing many of the part{ lines. > > If stream_stdout is setup too early, it will overwrite the part start > when notmuch is redirected

[notmuch] pull request

2010-04-01 Thread David Edmondson
Carl, a couple of patches that I'd like you to consider. They are the first two on the `dme' branch of git://github.com/dme/notmuch.git. http://github.com/dme/notmuch/commit/f86254e4509ed02731aa3eaa8541df1f2d11e400 > notmuch-show: Add unix and pretty dates to the JSON output > > Include a

[notmuch] Notmuch shared library

2010-04-01 Thread Carl Worth
next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100401/a69ae2e5/attachment.pgp>

[notmuch] Notmuch shared library

2010-04-01 Thread Michal Sojka
On Thu, 01 Apr 2010, Carl Worth wrote: > On Thu, 1 Apr 2010 13:24:22 +0200, martin f krafft > wrote: > > also sprach Michal Sojka [2010.04.01.1310 +0200]: > > > this can be solved by the following patch, but I don't know how portable > > > it is. You can see the efect of this by > > > > Please

[notmuch] [PATCH] Setup the GMimeStream only when needed

2010-04-01 Thread Carl Worth
that to the GMime folks. -Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100401/480574fe/attachment.pgp>

[notmuch] pull request

2010-04-01 Thread Carl Worth
64 within a json string?) Looking forward to more, -Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100401/74bae8f6/attachment.pgp>

[notmuch] [PATCH] format_part_json: part_content->data is not null terminated

2010-04-01 Thread Gregor Hoffleit
Both of you Davids are indeed completely right. Even more since the next command in the patch after memcpy zeroes that byte. This is how it's meant to be: +content_data = talloc_size (ctx, part_content->len+1); +memcpy (content_data, (char *)part_content->data, part_content->len); +

[notmuch] [PATCH] format_part_json: part_content->data is not null terminated

2010-04-01 Thread Michal Sojka
On Thu, 04 Mar 2010, Gregor Hoffleit wrote: > - printf (", \"content\": %s", json_quote_str (ctx, (char *) > part_content->data)); > + content_data = talloc_size (ctx, part_content->len+1); > + memcpy (content_data, (char *)part_content->data, part_content->len+1); > +

[notmuch] [PATCH] Makefile: Create include directory when installing headers

2010-04-01 Thread Michal Sojka
When I wanted to create a debian package from the current master, make install failed because of non-existent include directory. This patch fixes this minor issue. --- lib/Makefile.local |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/Makefile.local

[notmuch] Notmuch shared library

2010-04-01 Thread martin f krafft
-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digital signature (see http://martin-krafft.net/gpg/) URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100401/bc9ae064/attachment-0001.pgp>

[notmuch] Notmuch shared library

2010-04-01 Thread martin f krafft
bytes Desc: Digital signature (see http://martin-krafft.net/gpg/) URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100401/ada2fe5b/attachment.pgp>

[notmuch] Notmuch shared library

2010-04-01 Thread Michal Sojka
On Thu, 01 Apr 2010, Carl Worth wrote: > Finally, I'm a tiny bit annoyed that now after a fresh checkout of > notmuch and "make" that one can't easily run ./notmuch without either > installing the library (or fiddling with LD_LIBRARY_PATH). I've got some > ideas on how to simplify that, but I'm

[notmuch] [PATCH] format_part_json: part_content->data is not null terminated

2010-04-01 Thread David Edmondson
On Thu, 01 Apr 2010 08:40:37 -0300, David Bremner wrote: > On Thu, 04 Mar 2010 11:49:48 +0100, Gregor Hoffleit > wrote: > > In format_part_json, part_content->data is not a null terminated > > string. > > I'd like to see this bug fixed, +1. > and the patch is pretty small, but... > > >

[notmuch] Notmuch shared library

2010-04-01 Thread Sebastian Spaeth
On Thu, 01 Apr 2010 00:54:16 -0700, Carl Worth wrote: > Finally, I'm a tiny bit annoyed that now after a fresh checkout of > notmuch and "make" that one can't easily run ./notmuch without either > installing the library (or fiddling with LD_LIBRARY_PATH). I've got some > ideas on how to simplify

[notmuch] [PATCH] Setup the GMimeStream only when needed

2010-04-01 Thread nst...@redhat.com
On Apr 1 16:21, Michal Sojka wrote: > On Thu, 01 Apr 2010, nstraz at redhat.com wrote: > > I ran into this while looking at the vim plugin. Vim's system() call > > redirects output to a file and it was missing many of the part{ lines. > > > > If stream_stdout is setup too early, it will

[notmuch] [PATCH] Setup the GMimeStream only when needed

2010-04-01 Thread nst...@redhat.com
I ran into this while looking at the vim plugin. Vim's system() call redirects output to a file and it was missing many of the part{ lines. If stream_stdout is setup too early, it will overwrite the part start when notmuch is redirected to a file. --- notmuch-show.c | 15 ++- 1

[notmuch] [PATCH] format_part_json: part_content->data is not null terminated

2010-04-01 Thread David Bremner
On Thu, 04 Mar 2010 11:49:48 +0100, Gregor Hoffleit wrote: > In format_part_json, part_content->data is not a null terminated > string. I'd like to see this bug fixed, and the patch is pretty small, but... > Instead, we have to use part_content->len. > + content_data = talloc_size (ctx,

[notmuch] [PATCH] Makefile: Create include directory when installing headers

2010-04-01 Thread Carl Worth
next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100401/11f564f2/attachment.pgp>

[notmuch] Notmuch shared library

2010-04-01 Thread Carl Worth
n see advantages and disadvantages to each approach. -Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100401/1c7bedaf/attachment.pgp>

[notmuch] Notmuch shared library

2010-04-01 Thread Carl Worth
-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100401/3d8c50ba/attachment.pgp>

Re: [notmuch] Notmuch shared library

2010-04-01 Thread Carl Worth
On Fri, 12 Mar 2010 14:47:33 +0100, Ingmar Vanhassel ing...@exherbo.org wrote: I'd very much like to see this upstream. Me too. ;-) Sorry for the long delay. I amended your first patch to make it install the notmuch.h header too. A very nice addition. The second patch fixed some parallel

Re: [notmuch] Notmuch shared library

2010-04-01 Thread Sebastian Spaeth
On Thu, 01 Apr 2010 00:54:16 -0700, Carl Worth cwo...@cworth.org wrote: Finally, I'm a tiny bit annoyed that now after a fresh checkout of notmuch and make that one can't easily run ./notmuch without either installing the library (or fiddling with LD_LIBRARY_PATH). I've got some ideas on how

Re: [notmuch] Notmuch shared library

2010-04-01 Thread Michal Sojka
On Thu, 01 Apr 2010, Carl Worth wrote: Finally, I'm a tiny bit annoyed that now after a fresh checkout of notmuch and make that one can't easily run ./notmuch without either installing the library (or fiddling with LD_LIBRARY_PATH). I've got some ideas on how to simplify that, but I'm not sure

Re: [notmuch] Notmuch shared library

2010-04-01 Thread martin f krafft
also sprach Michal Sojka sojk...@fel.cvut.cz [2010.04.01.1310 +0200]: this can be solved by the following patch, but I don't know how portable it is. You can see the efect of this by Please avoid rpath. The better solution is probably to create a wrapper for notmuch, which prepends to

Re: [notmuch] [PATCH] format_part_json: part_content-data is not null terminated

2010-04-01 Thread David Bremner
On Thu, 04 Mar 2010 11:49:48 +0100, Gregor Hoffleit gre...@hoffleit.de wrote: In format_part_json, part_content-data is not a null terminated string. I'd like to see this bug fixed, and the patch is pretty small, but... Instead, we have to use part_content-len. + content_data =

Re: [notmuch] Notmuch shared library

2010-04-01 Thread martin f krafft
also sprach martin f krafft madd...@madduck.net [2010.04.01.1324 +0200]: Please avoid rpath. The better solution is probably to create a wrapper for notmuch, which prepends to LD_LIBRARY_PATH. E.g. http://wiki.debian.org/RpathIssue -- martin | http://madduck.net/ | http://two.sentenc.es/ a

[notmuch] [PATCH] Makefile: Create include directory when installing headers

2010-04-01 Thread Michal Sojka
When I wanted to create a debian package from the current master, make install failed because of non-existent include directory. This patch fixes this minor issue. --- lib/Makefile.local |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/Makefile.local

Re: [notmuch] [PATCH] format_part_json: part_content-data is not null terminated

2010-04-01 Thread Gregor Hoffleit
Both of you Davids are indeed completely right. Even more since the next command in the patch after memcpy zeroes that byte. This is how it's meant to be: +content_data = talloc_size (ctx, part_content-len+1); +memcpy (content_data, (char *)part_content-data, part_content-len); +

Re: [notmuch] Notmuch shared library

2010-04-01 Thread Carl Worth
On Thu, 1 Apr 2010 13:24:22 +0200, martin f krafft madd...@madduck.net wrote: also sprach Michal Sojka sojk...@fel.cvut.cz [2010.04.01.1310 +0200]: this can be solved by the following patch, but I don't know how portable it is. You can see the efect of this by Please avoid rpath. The

Re: [notmuch] [PATCH] Makefile: Create include directory when installing headers

2010-04-01 Thread Carl Worth
On Thu, 1 Apr 2010 13:47:45 +0200, Michal Sojka sojk...@fel.cvut.cz wrote: When I wanted to create a debian package from the current master, make install failed because of non-existent include directory. This patch fixes this minor issue. Thanks. This is merged now. -Carl pgpfOxRgc30OY.pgp

Re: [notmuch] Notmuch shared library

2010-04-01 Thread Michal Sojka
On Thu, 01 Apr 2010, Carl Worth wrote: On Thu, 1 Apr 2010 13:24:22 +0200, martin f krafft madd...@madduck.net wrote: also sprach Michal Sojka sojk...@fel.cvut.cz [2010.04.01.1310 +0200]: this can be solved by the following patch, but I don't know how portable it is. You can see the

[notmuch] [PATCH] Setup the GMimeStream only when needed

2010-04-01 Thread nstraz
I ran into this while looking at the vim plugin. Vim's system() call redirects output to a file and it was missing many of the part{ lines. If stream_stdout is setup too early, it will overwrite the part start when notmuch is redirected to a file. --- notmuch-show.c | 15 ++- 1

Re: [notmuch] [PATCH] Setup the GMimeStream only when needed

2010-04-01 Thread nstraz
On Apr 1 16:21, Michal Sojka wrote: On Thu, 01 Apr 2010, nst...@redhat.com wrote: I ran into this while looking at the vim plugin. Vim's system() call redirects output to a file and it was missing many of the part{ lines. If stream_stdout is setup too early, it will overwrite the part

Re: [notmuch] Notmuch shared library

2010-04-01 Thread Carl Worth
On Thu, 01 Apr 2010 14:44:36 +0200, Michal Sojka sojk...@fel.cvut.cz wrote: On Thu, 01 Apr 2010, Carl Worth wrote: 1. Use rpath for the local notmuch, (and use chrpath to remove it at the time of make install). 3. Create a static program locally, but install a shared version. 4.

Re: [notmuch] pull request

2010-04-01 Thread David Bremner
On Thu, 01 Apr 2010 14:09:57 -0700, Carl Worth cwo...@cworth.org wrote: More significantly, this level of documentation needs to be put into the notmuch help output (instead of the placeholder that's there in the current patch). It also needs to be added to the man page in notmuch.1. Allow me