[PATCH 2/2] Remove the pipe symbol in the author list when the last author matches

2010-04-22 Thread Dirk Hohndel
this fixes the bug exposed by the tests for this feature Signed-off-by: Dirk Hohndel --- lib/thread.cc |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/lib/thread.cc b/lib/thread.cc index 4e389c5..1dda220 100644 --- a/lib/thread.cc +++ b/lib/thread.cc @@ -140,6

[PATCH 1/2] Add tests for author reordering

2010-04-22 Thread Dirk Hohndel
Test the different permutation of which authors match the search; This exposes a bug in the existing reordering code Signed-off-by: Dirk Hohndel --- test/notmuch-test | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/test/notmuch-test

Add tests (and fix bug exposed by test) for author reordering

2010-04-22 Thread Dirk Hohndel
I want Carl to enforce the adding of tests. Once again writing the test exposed a bug that I hadn't noticed before. So here's the test plus the patch that fixes the bug. /D

[PATCH] removed unused variables

2010-04-22 Thread Dirk Hohndel
trivial compiler warning fix Signed-off-by: Dirk Hohndel --- notmuch-search.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index 25c9cfc..8a1cdca 100644 --- a/notmuch-search.c +++ b/notmuch-search.c @@ -104,8 +104,6 @@

[PATCH] Fix linker error from insufficient LDFLAGS

2010-04-22 Thread Ben Gamari
It seems that LDFLAGS have recently been reorganized, along with the introduction of a notmuch-shared rule. Unfortunately, the LDFLAGS used in notmuch-shared don't include CONFIGURE_LDFLAGS. This caused linking to fail with the following, $ make V=1 gcc debugger.o gmime-filter-reply.o

Recent linker errors for notmuch-shared

2010-04-22 Thread Ben Gamari
Hey all, When I pulled a few days ago I noticed that notmuch-shared failed to link due to missing LDFLAGS. In particular, it seems that the linker flags don't include CONFIGURE_LDFLAGS, meaning that all of the required external shared libraries depedencies aren't linked against. Here is a patch

problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread David Edmondson
On Thu, 22 Apr 2010 11:20:33 -0400, Jameson Rollins wrote: > On Thu, 22 Apr 2010 15:38:55 +0100, David Edmondson wrote: > > The `defcustom' does nothing if the variable already has a value. > > But the defcustom is always going to be called before any customization > value, since my personal

[PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-22 Thread Carl Worth
t that was straightforward). Thanks again for the tests. -Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100422/f4b7174f/attachment.pgp>

[notmuch] Fcc, Maildir, and Emacs message-mode -- a bit of code

2010-04-22 Thread Dirk Hohndel
On Thu, 22 Apr 2010 11:06:04 +0200, "Sebastian Spaeth" wrote: > As Carl stated that he would probably merge this one if someone tested > it, here it comes: I tested it and it works great. When I define a > non-existing directory as maildir it aborts with an error message that > is visible to the

sort order regression

2010-04-22 Thread Sebastian Spaeth
jkr and I noticed that patch series are shown in reverse order now, in fact threads seem to display messages at the same depth in reverse chronological order now. Here is my monologue from IRC: Is that supposed to show the whole thread in reverse chronological order?: notmuch show

pull request

2010-04-22 Thread David Edmondson
On Thu, 22 Apr 2010 10:10:15 -0400, Servilio Afre Puentes wrote: > > Showing only one (with a variable allowing you to express preference) is > > my intention. Any non-shown parts will appear as attachments - you can > > save them using the button (and perhaps later view them). > > Why not see

problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread David Edmondson
On Thu, 22 Apr 2010 10:12:59 -0400, Jameson Rollins wrote: > On Thu, 22 Apr 2010 15:04:45 +0100, David Edmondson wrote: > > Ah, when you set `notmuch-search-authors-width' the expression which > > creates `notmuch-search-result-format' is not re-evaluated. > > > > Do things get better if you

[PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)

2010-04-22 Thread Sebastian Spaeth
On 2010-04-22, Sebastian Spaeth wrote: > From: Jesse Rosenthal This patch must have slipped in the patch series of the 6 other patches (which are all correct). Please ignore it. Note to myself, never do "git send-email 00*" Sebastian

[PATCH] Add 'G' keybinding to folder and search view that triggers external poll

2010-04-22 Thread Dirk Hohndel
On Thu, 22 Apr 2010 14:50:33 -0700, Carl Worth wrote: > On Fri, 09 Apr 2010 12:53:26 -0700, Dirk Hohndel > wrote: > > The new functions first check if an external poll script has been defined in > > the variable 'notmuch-external-refresh-script and if yes, runs that script > > before executing

problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread David Edmondson
On Thu, 22 Apr 2010 09:22:32 -0400, Jameson Rollins wrote: > > Can you show any explicit settings you have for > > `notmuch-search-authors-width' and `notmuch-search-result-format'? Where > > do you set them? > > Changing notmuch-search-authors-width to anything longer than 20 (which > is the

[PATCH] json: Replace `date_unix' with `timestamp' in show output

2010-04-22 Thread Carl Worth
-Carl -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100422/7ad2cd7e/attachment.pgp>

[PATCH] Add 'G' keybinding to folder and search view that triggers external poll

2010-04-22 Thread Carl Worth
available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100422/706bc78f/attachment.pgp>

bug tracking

2010-04-22 Thread David Bremner
On Thu, 22 Apr 2010 11:47:13 -0400, Jameson Rollins wrote: > I now think it is essential that we put together a bug tracker for > notmuch. Things are moving pretty quickly now, which is great, but as > the UI is frequently changing, I'm stumbling upon lots of little bugs. > As I don't have the

sort order regression

2010-04-22 Thread Carl Worth
-- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100422/71398637/attachment.pgp>

pull request

2010-04-22 Thread David Edmondson
On Thu, 22 Apr 2010 04:58:16 -0400, Servilio Afre Puentes wrote: > On 21 April 2010 17:03, Carl Worth wrote: > > On Mon, 19 Apr 2010 09:27:39 +0100, David Edmondson wrote: > [...] > > Meanwhile, another issue with the result of this series is that I now > > seem to get rendering for both the

[PATCH] emacs: Add more functions to clean up text/plain parts

2010-04-22 Thread David Edmondson
Add: - notmuch-wash-wrap-long-lines: Wrap lines longer than the width of the current window whilst maintaining any citation prefix. - notmuch-wash-tidy-citations: Tidy up citations by: - compress repeated otherwise blank citation lines, - remove otherwise blank citation lines at the head and

[PATCH 1/2] Add 'cat' subcommand

2010-04-22 Thread Anthony Towns
On Thu, Apr 22, 2010 at 12:37, Dirk Hohndel wrote: > On Wed, 21 Apr 2010 17:44:03 -0700, Carl Worth wrote: >> So I'd prefer to have this command behave just like all others and use >> the same naming. >> ? ? ? filename:/complete/path/to/file Would "notmuch cat" be any different to "notmuch

[PATCH] emacs: Add notmuch-address.el for address completion using notmuch

2010-04-22 Thread Sebastian Spaeth
On 2010-04-22, David Edmondson wrote: > A tool `notmuch-addresses' is required to produce addresses which > match a query string. An example of a suitable script can be found in > the git repository at > http://jkr.acm.jhu.edu/git/notmuch_addresses.git > There are no doubt others. no doubt

[PATCH] emacs: Re-arrange message sending code

2010-04-22 Thread Sebastian Spaeth
On 2010-04-22, David Edmondson wrote: > Define a new `mail-user-agent' (`notmuch-user-agent') and use it by > default. Re-arrange various routines that send mail to use this > (compose, reply, forward). Insert a `User-Agent:' header by default. I've been using this or a slightly earlier version

python cnotmuch -> notmuch

2010-04-22 Thread Sebastian Spaeth
My "reply-to-sender-only" works too well, resending this to the notmuch list. -- next part -- An embedded message was scrubbed... From: unknown sender Subject: no subject Date: no date Size: 930 URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2010

[notmuch] auto-tagging replied messages

2010-04-22 Thread Sebastian Spaeth
On 2010-03-05, Jesse Rosenthal wrote: > One element of traditional clients that I've missed in notmuch is the > ability to easily see which messages have been replied to. A look at the > thread structure will often make that clear, but for both searching and > syncing, an "answered" tag would be

[PATCH] emacs: Push the cursor to point-max on `n' or `N' at the end of a thread

2010-04-22 Thread David Edmondson
Sebastian pointed out that the pre-JSON UI would move the cursor to the end of the buffer if `n' or `N' is hit when on the last (unread) message. Mimic that behaviour in the new UI. --- emacs/notmuch-show.el | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) diff

bug tracking

2010-04-22 Thread Jameson Rollins
nts/20100422/ba5184ea/attachment.pgp>

problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread Jameson Rollins
uld ever apply. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100422/e2ce0469/attachment.pgp>

[PATCH 6/6] notmuch-maildir-fcc: replace caddr with (car (cdr (cdr)))

2010-04-22 Thread Sebastian Spaeth
The former requires 'cl to be loaded and during make install emacs complained about not knowing it. Signed-off-by: Sebastian Spaeth --- emacs/notmuch-maildir-fcc.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-maildir-fcc.el

[PATCH 5/6] notmuch-maildir-fcc: use insert-buffer-substring

2010-04-22 Thread Sebastian Spaeth
Rather than the insert-buffer. Emacs complains that it is for interactive use and not for use within elisp. So use insert-buffer-substring which does the same thing when not handed any 'begin' 'end' parameters. Signed-off-by: Sebastian Spaeth --- emacs/notmuch-maildir-fcc.el |2 +- 1 files

[PATCH 4/6] add documentation example

2010-04-22 Thread Sebastian Spaeth
Show how to set up an FCC header hook. Some minor indentation fixes Signed-off-by: Sebastian Spaeth --- emacs/notmuch-maildir-fcc.el | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el index

[PATCH 3/6] notmuch-maildir-fcc: rename all jkr/* functions to notmuch-maildir-fcc-*

2010-04-22 Thread Sebastian Spaeth
Signed-off-by: Sebastian Spaeth --- emacs/notmuch-maildir-fcc.el | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el index f18ccc8..c91095d 100644 ---

[PATCH 2/6] Integrate notmuch-maildir-fcc into notmuch

2010-04-22 Thread Sebastian Spaeth
Require notmuch-maildir-fcc and also install it. Signed-off-by: Sebastian Spaeth --- emacs/Makefile.local |3 ++- emacs/notmuch-maildir-fcc.el |4 +++- emacs/notmuch.el |1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/emacs/Makefile.local

[PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)

2010-04-22 Thread Sebastian Spaeth
From: Jesse Rosenthal (Embarassing -- this should be the last fix.) Change the buffer name to a uniquified subject of the thread (i.e. the subject of the first message in the thread) instead of the thread-id. This is more meaningful to the user, and will make it easier to

[PATCH 1/6] Add elisp file for FCC to maildir solution

2010-04-22 Thread Sebastian Spaeth
From: Jesse Rosenthal File grabbed from http://jkr.acm.jhu.edu/jkr-maildir.el but not integrated yet. Signed-off-by: Sebastian Spaeth --- emacs/notmuch-maildir-fcc.el | 115 ++ 1 files changed, 115 insertions(+), 0 deletions(-)

[notmuch] Fcc, Maildir, and Emacs message-mode -- a bit of code

2010-04-22 Thread Sebastian Spaeth
As Carl stated that he would probably merge this one if someone tested it, here it comes: I tested it and it works great. When I define a non-existing directory as maildir it aborts with an error message that is visible to the user. I put this in a branch based on cworth/master and with Jesse's

sort order regression

2010-04-22 Thread Jesse Rosenthal
On Thu, 22 Apr 2010 10:21:11 -0400, Jesse Rosenthal wrote: > My suggestion would be to revert both the simplification and the fix to > enable the simplification to pass: (36e4459a3, 2a1a4f0551). Sorry, got that slightly wrong. The following commits need to be reverted:

sort order regression

2010-04-22 Thread Jesse Rosenthal
On Thu, 22 Apr 2010 10:14:16 -0400, Jesse Rosenthal wrote: > Just to follow up on this, it seems that the regression comes from the > fix Carl introduced in 2a1a4f0551 to make his simplification of my patch > (simplification = 36e4459a3 , my patch = 4971b85641) pass tests. The > question is

sort order regression

2010-04-22 Thread Jesse Rosenthal
On Thu, 22 Apr 2010 16:06:27 +0200, Sebastian Spaeth wrote: > > jkr and I noticed that patch series are shown in reverse order now, in > fact threads seem to display messages at the same depth in reverse > chronological order now. Just to follow up on this, it seems that the regression comes

problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread Jameson Rollins
application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100422/11397e56/attachment.pgp>

pull request

2010-04-22 Thread Servilio Afre Puentes
On 22 April 2010 08:30, David Edmondson wrote: > On Thu, 22 Apr 2010 04:58:16 -0400, Servilio Afre Puentes gmail.com> wrote: >> On 21 April 2010 17:03, Carl Worth wrote: >> > On Mon, 19 Apr 2010 09:27:39 +0100, David Edmondson wrote: >> [...] >> > Meanwhile, another issue with the result of

[PATCH] emacs: Add notmuch-address.el for address completion using notmuch

2010-04-22 Thread David Edmondson
A tool `notmuch-addresses' is required to produce addresses which match a query string. An example of a suitable script can be found in the git repository at http://jkr.acm.jhu.edu/git/notmuch_addresses.git There are no doubt others. --- emacs/Makefile.local |3 +-

[PATCH] emacs: Re-arrange message sending code

2010-04-22 Thread David Edmondson
Define a new `mail-user-agent' (`notmuch-user-agent') and use it by default. Re-arrange various routines that send mail to use this (compose, reply, forward). Insert a `User-Agent:' header by default. --- emacs/Makefile.local |5 +- emacs/notmuch-hello.el |2 + emacs/notmuch-lib.el |

[PATCH] json: Replace `date_unix' with `timestamp' in show output

2010-04-22 Thread David Edmondson
On Fri, 16 Apr 2010 12:47:49 +0100, David Edmondson wrote: > Search output was already using `timestamp' for a very similar field, > so follow that. Carl, this seems low-risk and easy to include for 0.3. dme. -- David Edmondson, http://dme.org

[PATCH] json: Replace `date_unix' with `timestamp' in show output

2010-04-22 Thread David Edmondson
Search output was already using `timestamp' for a very similar field, so follow that. --- notmuch-show.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 76873a1..26449fa 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -145,7

[PATCH] emacs: Add notmuch-hello.el, a friendly frontend to notmuch

2010-04-22 Thread David Edmondson
--- emacs/Makefile.local |5 + emacs/notmuch-hello.el | 359 emacs/notmuch-lib.el |9 ++ emacs/notmuch-logo.png | Bin 0 -> 1671 bytes emacs/notmuch.el | 28 +++-- 5 files changed, 390 insertions(+), 11 deletions(-) create

[PATCH] emacs/notmuch-show.el: Add `notmuch-show-toggle-all' bound to M-RET

2010-04-22 Thread David Edmondson
`notmuch-show-toggle-all' changes the visibility all of the messages in the current thread. By default it makes all of the messages visible. With a prefix argument, it makes them all not visible. --- emacs/notmuch-show.el | 13 + 1 files changed, 13 insertions(+), 0 deletions(-)

problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread Jameson Rollins
and see the result. I have not modified notmuch-search-result-format. See my previous email on tracking down the issue. Thanks for the help. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100422/9bec72c1/attachment.pgp>

[PATCH 1/2] Add 'cat' subcommand

2010-04-22 Thread Michal Sojka
On Thu, 22 Apr 2010, Anthony Towns wrote: > On Thu, Apr 22, 2010 at 12:37, Dirk Hohndel wrote: > > On Wed, 21 Apr 2010 17:44:03 -0700, Carl Worth wrote: > >> So I'd prefer to have this command behave just like all others and use > >> the same naming. > >> ? ? ? filename:/complete/path/to/file >

problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread David Edmondson
On Thu, 22 Apr 2010 00:37:25 -0400, Jameson Rollins wrote: > On Wed, 21 Apr 2010 19:09:35 -0400, Jameson Rollins finestructure.net> wrote: > > Hey, folks. I just build from Carl's HEAD which includes the new emacs > > JSON interface and I'm noticing a problem with the > >

[PATCH 1/2] Add 'cat' subcommand

2010-04-22 Thread Michal Sojka
On Thu, 22 Apr 2010, Carl Worth wrote: > On Tue, 20 Apr 2010 12:14:56 +0200, Michal Sojka > wrote: > > On 20.4.2010 09:21, David Edmondson wrote: > > > I'm puzzled why you chose to pass a filename as the argument to 'cat' > > > rather than a message id (id:foo at bar.com)? > > > > The reason

pull request

2010-04-22 Thread David Edmondson
On Wed, 21 Apr 2010 14:03:03 -0700, Carl Worth wrote: > > commit 2b6201fbf9209a875f216d48c30b95a6f583c575 > > > > emacs: Add more functions to clean up text/plain parts > > > > Add: > > - notmuch-wash-wrap-long-lines: Wrap lines longer than the width of > > the current

[PATCH] emacs: Add notmuch-address.el for address completion using notmuch

2010-04-22 Thread Dirk Hohndel
On Thu, 22 Apr 2010 10:03:43 +0100, David Edmondson wrote: > A tool `notmuch-addresses' is required to produce addresses which > match a query string. An example of a suitable script can be found in > the git repository at > http://jkr.acm.jhu.edu/git/notmuch_addresses.git > There are no

Notmuch success: Xapian database corrupt

2010-04-22 Thread John Fremlin
After the encouraging message from Sebastian. I deleted the .notmuch/xapian dir and started again. It went off a good rate (300+ files/sec) and here was the final score Processed 494764 total files in 2h 54m 41s (47 files/sec.). Added 226817 new messages to the database. This

pull request

2010-04-22 Thread David Edmondson
On Wed, 21 Apr 2010 12:15:48 -0700, Carl Worth wrote: > Sure. Hiding a message with 'b' is visually identical to hiding it with > RET. That's not quite true. `b' will (would) hide only the body. If the header is visible `b' will not hide it. > Except that the internal mechanism is distinct, so

pull request

2010-04-22 Thread Servilio Afre Puentes
On 21 April 2010 17:03, Carl Worth wrote: > On Mon, 19 Apr 2010 09:27:39 +0100, David Edmondson wrote: [...] > Meanwhile, another issue with the result of this series is that I now > seem to get rendering for both the text/plain and the text/html > alternatives when a message has both. For now,

[PATCH] Add 'd'elete keybinding to search and show views

2010-04-22 Thread Jameson Rollins
message. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20100422/02dcc175/attachment.pgp>

problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread Jameson Rollins
runcate the authors field with something like '%-.40s', I think, which would make the code a little simpler, but might not be as nice. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not avai

Re: pull request

2010-04-22 Thread David Edmondson
On Wed, 21 Apr 2010 12:15:48 -0700, Carl Worth cwo...@cworth.org wrote: Sure. Hiding a message with 'b' is visually identical to hiding it with RET. That's not quite true. `b' will (would) hide only the body. If the header is visible `b' will not hide it. Except that the internal mechanism is

Re: Update on 0.3 progress

2010-04-22 Thread Jesse Rosenthal
On Wed, 21 Apr 2010 18:11:14 -0700, Carl Worth cwo...@cworth.org wrote: Most of what came in in response to this request has now been merged. Notable things that made the merge window but have not been merged yet include... Hi Carl, Just wanted to call one more thing to your attention: the

Re: [PATCH 1/2] Add 'cat' subcommand

2010-04-22 Thread Michal Sojka
On Thu, 22 Apr 2010, Carl Worth wrote: On Tue, 20 Apr 2010 12:14:56 +0200, Michal Sojka sojk...@fel.cvut.cz wrote: On 20.4.2010 09:21, David Edmondson wrote: I'm puzzled why you chose to pass a filename as the argument to 'cat' rather than a message id (id:f...@bar.com)? The reason

Re: [PATCH 1/2] Add 'cat' subcommand

2010-04-22 Thread Michal Sojka
On Thu, 22 Apr 2010, Anthony Towns wrote: On Thu, Apr 22, 2010 at 12:37, Dirk Hohndel hohn...@infradead.org wrote: On Wed, 21 Apr 2010 17:44:03 -0700, Carl Worth cwo...@cworth.org wrote: So I'd prefer to have this command behave just like all others and use the same naming.      

Re: pull request

2010-04-22 Thread David Edmondson
On Wed, 21 Apr 2010 14:03:03 -0700, Carl Worth cwo...@cworth.org wrote: commit 2b6201fbf9209a875f216d48c30b95a6f583c575 emacs: Add more functions to clean up text/plain parts Add: - notmuch-wash-wrap-long-lines: Wrap lines longer than the width of the current

Re: Notmuch success: Xapian database corrupt

2010-04-22 Thread John Fremlin
After the encouraging message from Sebastian. I deleted the .notmuch/xapian dir and started again. It went off a good rate (300+ files/sec) and here was the final score Processed 494764 total files in 2h 54m 41s (47 files/sec.). Added 226817 new messages to the database. This

Re: problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread David Edmondson
On Thu, 22 Apr 2010 00:37:25 -0400, Jameson Rollins jroll...@finestructure.net wrote: On Wed, 21 Apr 2010 19:09:35 -0400, Jameson Rollins jroll...@finestructure.net wrote: Hey, folks. I just build from Carl's HEAD which includes the new emacs JSON interface and I'm noticing a problem with

[PATCH] emacs/notmuch-show.el: Add `notmuch-show-toggle-all' bound to M-RET

2010-04-22 Thread David Edmondson
`notmuch-show-toggle-all' changes the visibility all of the messages in the current thread. By default it makes all of the messages visible. With a prefix argument, it makes them all not visible. --- emacs/notmuch-show.el | 13 + 1 files changed, 13 insertions(+), 0 deletions(-)

[PATCH] json: Replace `date_unix' with `timestamp' in show output

2010-04-22 Thread David Edmondson
Search output was already using `timestamp' for a very similar field, so follow that. --- notmuch-show.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/notmuch-show.c b/notmuch-show.c index 76873a1..26449fa 100644 --- a/notmuch-show.c +++ b/notmuch-show.c @@ -145,7

[PATCH] emacs: Re-arrange message sending code

2010-04-22 Thread David Edmondson
Define a new `mail-user-agent' (`notmuch-user-agent') and use it by default. Re-arrange various routines that send mail to use this (compose, reply, forward). Insert a `User-Agent:' header by default. --- emacs/Makefile.local |5 +- emacs/notmuch-hello.el |2 + emacs/notmuch-lib.el |

[PATCH] emacs: Add notmuch-address.el for address completion using notmuch

2010-04-22 Thread David Edmondson
A tool `notmuch-addresses' is required to produce addresses which match a query string. An example of a suitable script can be found in the git repository at http://jkr.acm.jhu.edu/git/notmuch_addresses.git There are no doubt others. --- emacs/Makefile.local |3 +-

[PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)

2010-04-22 Thread Sebastian Spaeth
From: Jesse Rosenthal jrosent...@jhu.edu (Embarassing -- this should be the last fix.) Change the buffer name to a uniquified subject of the thread (i.e. the subject of the first message in the thread) instead of the thread-id. This is more meaningful to the user, and will make it easier to

[PATCH 2/6] Integrate notmuch-maildir-fcc into notmuch

2010-04-22 Thread Sebastian Spaeth
Require notmuch-maildir-fcc and also install it. Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de --- emacs/Makefile.local |3 ++- emacs/notmuch-maildir-fcc.el |4 +++- emacs/notmuch.el |1 + 3 files changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH 5/6] notmuch-maildir-fcc: use insert-buffer-substring

2010-04-22 Thread Sebastian Spaeth
Rather than the insert-buffer. Emacs complains that it is for interactive use and not for use within elisp. So use insert-buffer-substring which does the same thing when not handed any 'begin' 'end' parameters. Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de --- emacs/notmuch-maildir-fcc.el

[PATCH 6/6] notmuch-maildir-fcc: replace caddr with (car (cdr (cdr)))

2010-04-22 Thread Sebastian Spaeth
The former requires 'cl to be loaded and during make install emacs complained about not knowing it. Signed-off-by: Sebastian Spaeth sebast...@sspaeth.de --- emacs/notmuch-maildir-fcc.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-maildir-fcc.el

Re: [notmuch] auto-tagging replied messages

2010-04-22 Thread Sebastian Spaeth
On 2010-03-05, Jesse Rosenthal wrote: One element of traditional clients that I've missed in notmuch is the ability to easily see which messages have been replied to. A look at the thread structure will often make that clear, but for both searching and syncing, an answered tag would be nice.

Re: [PATCH] emacs: Add notmuch-address.el for address completion using notmuch

2010-04-22 Thread Sebastian Spaeth
On 2010-04-22, David Edmondson wrote: A tool `notmuch-addresses' is required to produce addresses which match a query string. An example of a suitable script can be found in the git repository at http://jkr.acm.jhu.edu/git/notmuch_addresses.git There are no doubt others. no doubt :-).

[PATCH] emacs: Add more functions to clean up text/plain parts

2010-04-22 Thread David Edmondson
Add: - notmuch-wash-wrap-long-lines: Wrap lines longer than the width of the current window whilst maintaining any citation prefix. - notmuch-wash-tidy-citations: Tidy up citations by: - compress repeated otherwise blank citation lines, - remove otherwise blank citation lines at the head and

Re: pull request

2010-04-22 Thread David Edmondson
On Thu, 22 Apr 2010 04:58:16 -0400, Servilio Afre Puentes servi...@gmail.com wrote: On 21 April 2010 17:03, Carl Worth cwo...@cworth.org wrote: On Mon, 19 Apr 2010 09:27:39 +0100, David Edmondson d...@dme.org wrote: [...] Meanwhile, another issue with the result of this series is that I now

Re: problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread Jameson Rollins
On Thu, 22 Apr 2010 08:52:59 +0100, David Edmondson d...@dme.org wrote: On Thu, 22 Apr 2010 00:37:25 -0400, Jameson Rollins jroll...@finestructure.net wrote: On Wed, 21 Apr 2010 19:09:35 -0400, Jameson Rollins jroll...@finestructure.net wrote: Hey, folks. I just build from Carl's HEAD

Re: [PATCH] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id (supersedes V1--3)

2010-04-22 Thread Sebastian Spaeth
On 2010-04-22, Sebastian Spaeth wrote: From: Jesse Rosenthal jrosent...@jhu.edu This patch must have slipped in the patch series of the 6 other patches (which are all correct). Please ignore it. Note to myself, never do git send-email 00* Sebastian

Re: problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread David Edmondson
On Thu, 22 Apr 2010 09:22:32 -0400, Jameson Rollins jroll...@finestructure.net wrote: Can you show any explicit settings you have for `notmuch-search-authors-width' and `notmuch-search-result-format'? Where do you set them? Changing notmuch-search-authors-width to anything longer than 20

sort order regression

2010-04-22 Thread Sebastian Spaeth
jkr and I noticed that patch series are shown in reverse order now, in fact threads seem to display messages at the same depth in reverse chronological order now. Here is my monologue from IRC: Is that supposed to show the whole thread in reverse chronological order?: notmuch show

Re: pull request

2010-04-22 Thread Servilio Afre Puentes
On 22 April 2010 08:30, David Edmondson d...@dme.org wrote: On Thu, 22 Apr 2010 04:58:16 -0400, Servilio Afre Puentes servi...@gmail.com wrote: On 21 April 2010 17:03, Carl Worth cwo...@cworth.org wrote: On Mon, 19 Apr 2010 09:27:39 +0100, David Edmondson d...@dme.org wrote: [...]

Re: sort order regression

2010-04-22 Thread Jesse Rosenthal
On Thu, 22 Apr 2010 16:06:27 +0200, Sebastian Spaeth sebast...@sspaeth.de wrote: jkr and I noticed that patch series are shown in reverse order now, in fact threads seem to display messages at the same depth in reverse chronological order now. Just to follow up on this, it seems that the

Re: sort order regression

2010-04-22 Thread Jesse Rosenthal
On Thu, 22 Apr 2010 10:14:16 -0400, Jesse Rosenthal jrosent...@jhu.edu wrote: Just to follow up on this, it seems that the regression comes from the fix Carl introduced in 2a1a4f0551 to make his simplification of my patch (simplification = 36e4459a3 , my patch = 4971b85641) pass tests. The

Re: sort order regression

2010-04-22 Thread Jesse Rosenthal
On Thu, 22 Apr 2010 10:21:11 -0400, Jesse Rosenthal jrosent...@jhu.edu wrote: My suggestion would be to revert both the simplification and the fix to enable the simplification to pass: (36e4459a3, 2a1a4f0551). Sorry, got that slightly wrong. The following commits need to be reverted:

Re: problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread David Edmondson
On Thu, 22 Apr 2010 10:12:59 -0400, Jameson Rollins jroll...@finestructure.net wrote: On Thu, 22 Apr 2010 15:04:45 +0100, David Edmondson d...@dme.org wrote: Ah, when you set `notmuch-search-authors-width' the expression which creates `notmuch-search-result-format' is not re-evaluated.

Re: pull request

2010-04-22 Thread David Edmondson
On Thu, 22 Apr 2010 10:10:15 -0400, Servilio Afre Puentes servi...@gmail.com wrote: Showing only one (with a variable allowing you to express preference) is my intention. Any non-shown parts will appear as attachments - you can save them using the button (and perhaps later view them).

Re: [PATCH] emacs: Add notmuch-address.el for address completion using notmuch

2010-04-22 Thread Dirk Hohndel
On Thu, 22 Apr 2010 10:03:43 +0100, David Edmondson d...@dme.org wrote: A tool `notmuch-addresses' is required to produce addresses which match a query string. An example of a suitable script can be found in the git repository at http://jkr.acm.jhu.edu/git/notmuch_addresses.git There are

bug tracking

2010-04-22 Thread Jameson Rollins
I now think it is essential that we put together a bug tracker for notmuch. Things are moving pretty quickly now, which is great, but as the UI is frequently changing, I'm stumbling upon lots of little bugs. As I don't have the time to stop what I'm doing and figure out patches for them all, we

Re: problem with notmuch-search-authors-width in JSON emacs implementation

2010-04-22 Thread David Edmondson
On Thu, 22 Apr 2010 11:20:33 -0400, Jameson Rollins jroll...@finestructure.net wrote: On Thu, 22 Apr 2010 15:38:55 +0100, David Edmondson d...@dme.org wrote: The `defcustom' does nothing if the variable already has a value. But the defcustom is always going to be called before any

Re: bug tracking

2010-04-22 Thread David Bremner
On Thu, 22 Apr 2010 11:47:13 -0400, Jameson Rollins jroll...@finestructure.net wrote: I now think it is essential that we put together a bug tracker for notmuch. Things are moving pretty quickly now, which is great, but as the UI is frequently changing, I'm stumbling upon lots of little bugs.

Improved diff-based failure reports from the test suite

2010-04-22 Thread Carl Worth
On Fri, 16 Apr 2010 10:17:15 +0200, Michal Sojka sojk...@fel.cvut.cz wrote: It's definitely better than before. The current implementation of pass_if_equal has IMHO one drawback - if it compares multiline text and there is a difference, it is quite hard to see where. In my tests for maildir

Re: [PATCH] Add 'G' keybinding to folder and search view that triggers external poll

2010-04-22 Thread Carl Worth
On Fri, 09 Apr 2010 12:53:26 -0700, Dirk Hohndel hohn...@infradead.org wrote: The new functions first check if an external poll script has been defined in the variable 'notmuch-external-refresh-script and if yes, runs that script before executing the existing refresh function (which is bound to

Re: [PATCH] json: Replace `date_unix' with `timestamp' in show output

2010-04-22 Thread Carl Worth
On Fri, 16 Apr 2010 12:47:49 +0100, David Edmondson d...@dme.org wrote: Search output was already using `timestamp' for a very similar field, so follow that. Thanks. I've just pushed this. I didn't find any other occurrence of date_unix in the notmuch repository (or else I would have updated

Re: [PATCH] Add 'G' keybinding to folder and search view that triggers external poll

2010-04-22 Thread Dirk Hohndel
On Thu, 22 Apr 2010 14:50:33 -0700, Carl Worth cwo...@cworth.org wrote: On Fri, 09 Apr 2010 12:53:26 -0700, Dirk Hohndel hohn...@infradead.org wrote: The new functions first check if an external poll script has been defined in the variable 'notmuch-external-refresh-script and if yes, runs

Recent linker errors for notmuch-shared

2010-04-22 Thread Ben Gamari
Hey all, When I pulled a few days ago I noticed that notmuch-shared failed to link due to missing LDFLAGS. In particular, it seems that the linker flags don't include CONFIGURE_LDFLAGS, meaning that all of the required external shared libraries depedencies aren't linked against. Here is a patch

[PATCH] Fix linker error from insufficient LDFLAGS

2010-04-22 Thread Ben Gamari
It seems that LDFLAGS have recently been reorganized, along with the introduction of a notmuch-shared rule. Unfortunately, the LDFLAGS used in notmuch-shared don't include CONFIGURE_LDFLAGS. This caused linking to fail with the following, $ make V=1 gcc debugger.o gmime-filter-reply.o

Re: [PATCH] First tests for JSON output and UTF-8 in mail body and subject

2010-04-22 Thread Carl Worth
On Wed, 14 Apr 2010 17:35:44 -0700, Carl Worth cwo...@cworth.org wrote: On Tue, 13 Apr 2010 18:37:57 +0200, Gregor Hoffleit gre...@hoffleit.de wrote: The test suite doesn't yet cover --format=json output nor UTF-8 in subject or body. This patch starts with test cases for 'search

[PATCH] Makefile.local: Fix LDFLAGS for notmuch-shared

2010-04-22 Thread Adrien Bustany
This commit adds GMIME_LDFLAGS and TALLOC_LDFLAGS to the linker flags when linking notmuch-shared. Without these flags, linking fails because of undefined symbols. --- Makefile.local |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.local b/Makefile.local index

  1   2   >