[Review] Re: new "crypto" branch providing full PGP/MIME support

2011-02-27 Thread Darren McGuicken
notmuchmail.org/pipermail/notmuch/attachments/20110227/6909badb/attachment.pgp>

[PATCH] new: read db_files and db_subdirs if mtime changed

2011-02-27 Thread Austin Clements
Looks good (faster than, but provably equivalent to the original code! notmuch_directory_get_child_* are side-effect free, db_files/db_subdirs aren't used between where they were set in the old code and where they are set in the new code, and db_files/db_subdirs are initialized to NULL when

[PATCH] Return error status from notmuch_message_tags_to_maildir_flags().

2011-02-27 Thread Austin Clements
Looks good to me, but it appears that both callers of notmuch_message_tags_to_maildir_flags ignore the return value. Both callers synchronize maildir flags immediately after thawing the tag changes on a message. Perhaps they should instead synchronize *before* thawing and abort if the sync

Hiding HTML mime-parts and/or scrubbing (gmail's) HTML-based citation

2011-02-27 Thread Xavier Maillard
Hi, On Wed, 23 Feb 2011 11:01:27 -0800, Jameson Rollins wrote: > On Wed, 23 Feb 2011 15:10:22 +0100, Albin Stjerna wrote: > > On Tue, 22 Feb 2011 14:59:03 -0500, Daniel Kahn Gillmor > fifthhorseman.net> wrote: > > > > > I'm running the crypto branch (from jrollins, available at > > >

Hiding HTML mime-parts and/or scrubbing (gmail's) HTML-based citation

2011-02-27 Thread Xavier Maillard
Hi Rob, On Tue, 22 Feb 2011 19:13:26 -0600, Rob Browning wrote: > The "Display Customization" section in the emacs/mime info pages might > also be interesting. i.e. at the moment I use > mm-discouraged-alternatives like this (via Gnus): > > (setq mm-discouraged-alternatives >

RFC: Dovecot locking

2011-02-27 Thread Xavier Maillard
Hi Rob, On Wed, 16 Feb 2011 20:59:09 -0600, Rob Browning wrote: > For now, I'm interested in general comments, i.e. is this desirable, is > it a reasonable approach, etc. As you can see, there's no config > handling yet, so -llockfile is added unconditionally. I need this since I can't

Re: [PATCH] new: read db_files and db_subdirs if mtime changed

2011-02-27 Thread Austin Clements
Looks good (faster than, but provably equivalent to the original code! notmuch_directory_get_child_* are side-effect free, db_files/db_subdirs aren't used between where they were set in the old code and where they are set in the new code, and db_files/db_subdirs are initialized to NULL when