storing From and Subject in xapian

2011-05-08 Thread Istvan Marko
Jameson Graef Rollins writes: > Unless I hear a strong positive response I'll hold off on considering it > for 0.6, and suggest instead targeting it for 0.7. I would say wait until 0.7 at least. An important thing missing is fallback to the old method for messages where the Subject/From VALUE

[PATCH 1/1] emacs: Use "message-cited-text" instead of "message-cited-text-face"

2011-05-08 Thread Jameson Graef Rollins
: <http://notmuchmail.org/pipermail/notmuch/attachments/20110508/5e49a4fa/attachment.pgp>

storing From and Subject in xapian

2011-05-08 Thread Jameson Graef Rollins
ame: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110508/53077df9/attachment.pgp>

release-candidate/0.6

2011-05-08 Thread Daniel Kahn Gillmor
ignature Size: 1030 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110508/c8722d51/attachment.pgp>

release-candidate/0.6

2011-05-08 Thread Jameson Graef Rollins
auto-encrypt replies to encrypted messages... jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110508/cb6edf43/attachment.pgp>

release-candidate/0.6

2011-05-08 Thread Jameson Graef Rollins
ail/notmuch/attachments/20110508/0154722e/attachment-0001.pgp>

[PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search

2011-05-08 Thread Austin Clements
On Sun, May 8, 2011 at 5:54 PM, Florian Friesdorf wrote: > On Sun, 8 May 2011 17:40:54 -0400, Austin Clements > wrote: >> Also, existing code conventionally uses a variable named "local" >> for function-level talloc contexts such as your ctx_quote. > > In notmuch-search.c there is no variable

release-candidate/0.6

2011-05-08 Thread Jameson Graef Rollins
application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110508/d131916c/attachment.pgp>

[PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search

2011-05-08 Thread Austin Clements
Cool. This seems very reasonable. Just some style nits: The three places where you have "sanitize_string(", there should be a space between the function name and the paren. Relatedly, "for(;*loop;loop++){" should be spaced out like "for (; *loop; loop++) {". (Curiously, there seems to be

[PATCH] Sanitize "Subject:" and "Author:" fields to not contain control characters in notmuch-search

2011-05-08 Thread Jameson Graef Rollins
-- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110508/037c2b99/attachment.pgp>

[PATCH] Add part filename in notmuch show output if available.

2011-05-08 Thread Jameson Graef Rollins
on-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110508/c7e290cf/attachment.pgp>

release-candidate/0.6

2011-05-08 Thread Jameson Graef Rollins
applying cleanly against the current head of that branch). Thanks. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachme

[PATCH] Add part filename in notmuch show output if available.

2011-05-08 Thread Dmitry Kurochkin
Forgot to note, this patch is for release-candidate/0.6 branch. Regards, Dmitry

[PATCH] Add part filename in notmuch show output if available.

2011-05-08 Thread Dmitry Kurochkin
Before the change, notmuch show output had filename only for parts with "Content-Disposition: attachment". But parts with inline disposition may have filename as well. The patch makes notmuch show always output filename if available, independent of Content-Disposition. Both JSON and text output

release-candidate/0.6

2011-05-08 Thread Dmitry Kurochkin
Hi Jameson. First of all, thank you for your effort on notmuch. It is a great project and I am happy to see it going forward (again)! Can we include FCC fix in the 0.6 please? It was broken in 0.5 (IIRC) because of old configuration check. There are two patches on the ML to address it. The

[PATCH] sanitize notmuch-search output - rewrapped

2011-05-08 Thread Florian Friesdorf
patch applies to current rc (ed6d3b8bb727b3acaa913945d6edf29843ab0864) and works for me. It's the Andreas' patch just sent, that the commit message will make it when applied with 'git am'. Andreas Amann (1): Sanitize Subject: and Author: fields to not contain control characters in

[PATCH] Sanitize Subject: and Author: fields to not contain control characters in notmuch-search

2011-05-08 Thread Florian Friesdorf
From: Andreas Amann a.am...@ucc.ie When a Subject field contained encoded CRLF sequences, these sequences would appear unfiltered in the output of notmuch search. This confused the notmuch emacs interface leading to Unexpected Output messages. This is now fixed by replacing all characters with

Re: [PATCH] Sanitize Subject: and Author: fields to not contain control characters in notmuch-search

2011-05-08 Thread Austin Clements
Cool. This seems very reasonable. Just some style nits: The three places where you have sanitize_string(, there should be a space between the function name and the paren. Relatedly, for(;*loop;loop++){ should be spaced out like for (; *loop; loop++) {. (Curiously, there seems to be

Re: [PATCH] Sanitize Subject: and Author: fields to not contain control characters in notmuch-search

2011-05-08 Thread Florian Friesdorf
On Sun, 8 May 2011 17:40:54 -0400, Austin Clements amdra...@mit.edu wrote: Cool. This seems very reasonable. Just some style nits: The three places where you have sanitize_string(, there should be a space between the function name and the paren. fixed Relatedly, for(;*loop;loop++){

[PATCH] sanitize notmuch-search output - rewrapped

2011-05-08 Thread Florian Friesdorf
patch applies to current rc (ed6d3b8bb727b3acaa913945d6edf29843ab0864) and works for me. It's the Andreas' patch just sent, that the commit message will make it when applied with 'git am'. Andreas Amann (1): Sanitize Subject: and Author: fields to not contain control characters in

[PATCH 2/2] test for sanitized notmuch-search output

2011-05-08 Thread Florian Friesdorf
--- test/corpus.ccs/cur/1:2, |8 test/search-output |8 test/test-lib.sh | 12 3 files changed, 28 insertions(+), 0 deletions(-) create mode 100644 test/corpus.ccs/cur/1:2, diff --git a/test/corpus.ccs/cur/1:2, b/test/corpus.ccs/cur/1:2,

Re: [PATCH] sanitize notmuch-search output - rewrapped

2011-05-08 Thread Florian Friesdorf
this went out erroneously. On Mon, 9 May 2011 01:12:19 +0200, Florian Friesdorf f...@chaoflow.net wrote: patch applies to current rc (ed6d3b8bb727b3acaa913945d6edf29843ab0864) and works for me. It's the Andreas' patch just sent, that the commit message will make it when applied with 'git

Re: release-candidate/0.6

2011-05-08 Thread Florian Friesdorf
On Sat, 07 May 2011 01:51:25 +0200, Florian Friesdorf f...@chaoflow.net wrote: (..) An open issue (also with gmime 2.4.24) is the extraction of a PDF from an encrypted message via emacs (discussed on irc before, mentioned here for completeness of the In the current release candidate this got

Re: [PATCH] Sanitize Subject: and Author: fields to not contain control characters in notmuch-search

2011-05-08 Thread Jameson Graef Rollins
Hey, Florian. I applied this patch to release-candidate/0.6, manually adding in the formatting fixes in the same patch. I also applied the test patch, modified to use the add_message test suite function, which makes the patch a bit simpler. Thanks for the fixes. jamie. pgpSo56tz6dHL.pgp

Re: release-candidate/0.6

2011-05-08 Thread Jameson Graef Rollins
On Fri, 06 May 2011 19:56:30 -0400, James Vasile ja...@hackervisions.org wrote: I sent two patches to the list on March 16. They were a bug fix to allow notmuch to correctly handle some poorly formatted email. Nobody ever replied, but I'd like to see the bug fixed nonetheless, as it results

Re: release-candidate/0.6

2011-05-08 Thread Jameson Graef Rollins
Hi, folks. I've pushed some more patches to the release-candidate/0.6 branch [0] (which should now be at commit id 89ca01b6104dd732903104e50777a7b4a211e1f4): * support for decryption of parts with notmuch show --format=part * emacs support for retrieving parts (like attachments) from encrypted

Re: release-candidate/0.6

2011-05-08 Thread Daniel Kahn Gillmor
On 05/08/2011 09:03 PM, Jameson Graef Rollins wrote: Hi, folks. I've pushed some more patches to the release-candidate/0.6 branch [0] (which should now be at commit id 89ca01b6104dd732903104e50777a7b4a211e1f4): * support for decryption of parts with notmuch show --format=part * emacs

Re: release-candidate/0.6

2011-05-08 Thread Jameson Graef Rollins
On Sun, 08 May 2011 21:24:52 -0400, Daniel Kahn Gillmor d...@fifthhorseman.net wrote: One new feature that you didn't mention is that --decrypt is passed through to notmuch reply based on the state of the current buffer. That is: it used to be that you had to remember whether you'd viewed a

Re: storing From and Subject in xapian

2011-05-08 Thread Jameson Graef Rollins
On Wed, 4 May 2011 21:48:39 -0400, Austin Clements amdra...@mit.edu wrote: This is awesome. What was your machine configuration? Does anyone else have an opinions about this patch? It seems reasonable to me (other than a couple errant comments that were left in and should be removed). It