[PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-06-15 Thread Dmitry Kurochkin
On Wed, 15 Jun 2011 10:00:36 -0700, Carl Worth wrote: > On Wed, 15 Jun 2011 18:25:14 +0400, Dmitry Kurochkin gmail.com> wrote: > > I know you prefer tests to go before patches and I agree with that. > > Great! > > > But most of the time I do tests after coding. > > Yes, I do that order almost

[PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-06-15 Thread Dmitry Kurochkin
On Wed, 15 Jun 2011 07:06:40 -0700, Carl Worth wrote: > On Fri, 27 May 2011 01:42:22 +0400, Dmitry Kurochkin gmail.com> wrote: > > I have just send two more patches to this thread. One with new tests. > > Another with a workaround for the bug. The workaround should not break > > anything since

[PATCH 3/3] Fix indentation in guess_from_received_header().

2011-06-15 Thread Dmitry Kurochkin
--- notmuch-reply.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index 64f70bf..27ef37b 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -427,13 +427,13 @@ guess_from_received_header (notmuch_config_t *config,

[PATCH 2/3] Fix memory leak in guess_from_received_header().

2011-06-15 Thread Dmitry Kurochkin
Mta variable was not free()d in one case. --- notmuch-reply.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index dab69e6..64f70bf 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -401,8 +401,10 @@ guess_from_received_header

[PATCH 1/3] Fix double free in guess_from_received_header().

2011-06-15 Thread Dmitry Kurochkin
Before the change, the last loop in guess_from_received_header() did not reset domain and tld variables to NULL. This leads to double free error in some cases and possibly other bugs. --- notmuch-reply.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/notmuch-reply.c

[PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-06-15 Thread Carl Worth
lease keep it up! -Carl -- carl.d.worth at intel.com -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110615/49ba95ec/attachment.pgp>

[PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-06-15 Thread Jameson Graef Rollins
, etc.). jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110615/ba05a100/attachment.pgp>

[PATCH 1/3] Fix double free in guess_from_received_header().

2011-06-15 Thread Carl Worth
ll pushed now. -Carl -- carl.d.worth at intel.com -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110615/628ecd30/attachment.pgp>

[PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-06-15 Thread Carl Worth
Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110615/ebf7d689/attachment.pgp>

[PATCH] emacs: Add callback functions to crypto sigstatus button.

2011-06-15 Thread Jameson Graef Rollins
On Tue, 31 May 2011 10:07:13 -0700, Jameson Graef Rollins wrote: > This adds two callback functions to the sigstatus button. If the sig > status is "good", then clicking the button displays the output of "gpg > --list-keys" on the key fingerprint. If the sigstatus is "bad", then > clicking the

Re: [PATCH] emacs: Add callback functions to crypto sigstatus button.

2011-06-15 Thread Jameson Graef Rollins
On Tue, 31 May 2011 10:07:13 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: This adds two callback functions to the sigstatus button. If the sig status is good, then clicking the button displays the output of gpg --list-keys on the key fingerprint. If the sigstatus is bad,

[PATCH 2/3] Fix memory leak in guess_from_received_header().

2011-06-15 Thread Dmitry Kurochkin
Mta variable was not free()d in one case. --- notmuch-reply.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index dab69e6..64f70bf 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -401,8 +401,10 @@ guess_from_received_header

[PATCH 3/3] Fix indentation in guess_from_received_header().

2011-06-15 Thread Dmitry Kurochkin
--- notmuch-reply.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index 64f70bf..27ef37b 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -427,13 +427,13 @@ guess_from_received_header (notmuch_config_t *config,

Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-06-15 Thread Carl Worth
On Fri, 27 May 2011 01:42:22 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I have just send two more patches to this thread. One with new tests. Another with a workaround for the bug. The workaround should not break anything since it affects only notmuch-show mode. Thanks! I

Re: [PATCH 1/3] Fix double free in guess_from_received_header().

2011-06-15 Thread Carl Worth
On Wed, 15 Jun 2011 15:12:12 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Before the change, the last loop in guess_from_received_header() did not reset domain and tld variables to NULL. This leads to double free error in some cases and possibly other bugs. Thanks for the fixes.

Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-06-15 Thread Dmitry Kurochkin
On Wed, 15 Jun 2011 07:06:40 -0700, Carl Worth cwo...@cworth.org wrote: On Fri, 27 May 2011 01:42:22 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I have just send two more patches to this thread. One with new tests. Another with a workaround for the bug. The workaround should

Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-06-15 Thread Jameson Graef Rollins
On Wed, 15 Jun 2011 18:25:14 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I know you prefer tests to go before patches and I agree with that. But most of the time I do tests after coding. I do not know an easy way to reorder patches in git. (Also I do not know how to amend an

Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-06-15 Thread Carl Worth
On Wed, 15 Jun 2011 18:25:14 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I know you prefer tests to go before patches and I agree with that. Great! But most of the time I do tests after coding. Yes, I do that order almost exclusively as well. I do not know an easy way to

Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

2011-06-15 Thread Dmitry Kurochkin
On Wed, 15 Jun 2011 10:00:36 -0700, Carl Worth cwo...@cworth.org wrote: On Wed, 15 Jun 2011 18:25:14 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: I know you prefer tests to go before patches and I agree with that. Great! But most of the time I do tests after coding.