On Wed, 15 Jun 2011 10:00:36 -0700, Carl Worth wrote:
> On Wed, 15 Jun 2011 18:25:14 +0400, Dmitry Kurochkin gmail.com> wrote:
> > I know you prefer tests to go before patches and I agree with that.
>
> Great!
>
> > But most of the time I do tests after coding.
>
> Yes, I do that order almost
On Wed, 15 Jun 2011 07:06:40 -0700, Carl Worth wrote:
> On Fri, 27 May 2011 01:42:22 +0400, Dmitry Kurochkin gmail.com> wrote:
> > I have just send two more patches to this thread. One with new tests.
> > Another with a workaround for the bug. The workaround should not break
> > anything since
---
notmuch-reply.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/notmuch-reply.c b/notmuch-reply.c
index 64f70bf..27ef37b 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -427,13 +427,13 @@ guess_from_received_header (notmuch_config_t *config,
notmuch_m
Mta variable was not free()d in one case.
---
notmuch-reply.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/notmuch-reply.c b/notmuch-reply.c
index dab69e6..64f70bf 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -401,8 +401,10 @@ guess_from_received_header (not
Before the change, the last loop in guess_from_received_header()
did not reset domain and tld variables to NULL. This leads to
double free error in some cases and possibly other bugs.
---
notmuch-reply.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/notmuch-reply.c b/no
On Wed, 15 Jun 2011 10:00:36 -0700, Carl Worth wrote:
> On Wed, 15 Jun 2011 18:25:14 +0400, Dmitry Kurochkin
> wrote:
> > I know you prefer tests to go before patches and I agree with that.
>
> Great!
>
> > But most of the time I do tests after coding.
>
> Yes, I do that order almost exclusiv
On Wed, 15 Jun 2011 18:25:14 +0400, Dmitry Kurochkin
wrote:
> I know you prefer tests to go before patches and I agree with that.
Great!
> But most of the time I do tests after coding.
Yes, I do that order almost exclusively as well.
> I do not know an easy way to reorder patches in git. (Al
elcome. Thanks for all the great work. Please keep it up!
-Carl
--
carl.d.worth at intel.com
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20110615/49ba95ec/attachment.pgp>
On Wed, 15 Jun 2011 18:25:14 +0400, Dmitry Kurochkin
wrote:
> I know you prefer tests to go before patches and I agree with that. But
> most of the time I do tests after coding. I do not know an easy way to
> reorder patches in git. (Also I do not know how to amend an old patch,
> wish more da
, etc.).
jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20110615/ba05a100/attachment.pgp>
On Wed, 15 Jun 2011 07:06:40 -0700, Carl Worth wrote:
> On Fri, 27 May 2011 01:42:22 +0400, Dmitry Kurochkin
> wrote:
> > I have just send two more patches to this thread. One with new tests.
> > Another with a workaround for the bug. The workaround should not break
> > anything since it affec
On Wed, 15 Jun 2011 15:12:12 +0400, Dmitry Kurochkin
wrote:
> Before the change, the last loop in guess_from_received_header()
> did not reset domain and tld variables to NULL. This leads to
> double free error in some cases and possibly other bugs.
Thanks for the fixes. These are all pushed no
ll pushed now.
-Carl
--
carl.d.worth at intel.com
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20110615/628ecd30/attachment.pgp>
On Fri, 27 May 2011 01:42:22 +0400, Dmitry Kurochkin
wrote:
> I have just send two more patches to this thread. One with new tests.
> Another with a workaround for the bug. The workaround should not break
> anything since it affects only notmuch-show mode.
Thanks!
I love committing tests that
ture
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20110615/ebf7d689/attachment.pgp>
---
notmuch-reply.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/notmuch-reply.c b/notmuch-reply.c
index 64f70bf..27ef37b 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -427,13 +427,13 @@ guess_from_received_header (notmuch_config_t *config,
notmuch_m
Mta variable was not free()d in one case.
---
notmuch-reply.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/notmuch-reply.c b/notmuch-reply.c
index dab69e6..64f70bf 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -401,8 +401,10 @@ guess_from_received_header (not
Before the change, the last loop in guess_from_received_header()
did not reset domain and tld variables to NULL. This leads to
double free error in some cases and possibly other bugs.
---
notmuch-reply.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/notmuch-reply.c b/no
18 matches
Mail list logo
