Patch: Flush and Reopen

2011-09-08 Thread Martin Owens
Hey Austin, Thanks for the review :-) I'll attempt to fix some of the style guidelines, but see below. On Thu, 2011-09-08 at 22:42 -0400, Austin Clements wrote: > Did you mean to change this? This fails to build on Ubuntu maverick with the extra .3 and I see no reason to have that sub-minor

Patch: Flush and Reopen

2011-09-08 Thread Austin Clements
On Wed, Sep 7, 2011 at 9:34 PM, Martin Owens wrote: > Hello, > > Per discussions on irc, I've attached a patch for your consideration > which allows the developer to run two new database commands; > > notmuch_database_flush - used on read_write databases to commit changes > to disk >

Memory management practices

2011-09-08 Thread Sebastian Spaeth
;http://notmuchmail.org/pipermail/notmuch/attachments/20110908/20edc030/attachment.pgp>

Not much database creation error

2011-09-08 Thread Sebastian Spaeth
- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110908/52d76044/attachment.pgp>

Memory management practices

2011-09-08 Thread Austin Clements
Quoth Sebastian Spaeth on Sep 08 at 3:50 pm: > On Wed, 7 Sep 2011 23:05:19 -0400, Austin Clements > wrote: > > Sorry, I went back and re-read your earlier messages and now I see why > > your references were the way they were. I stand by the rest of my > > previous message though. I think the

Not much database creation error

2011-09-08 Thread Martin Owens
On Thu, 2011-09-08 at 15:45 +0200, Sebastian Spaeth wrote: > An open database connection provides you only with a snapshot, and you > need to reopen it after content has been modified. You are correct and I have submitted a patch for libnotmuch and the python bindings to add reopen and flush to

RFC/PATCH emacs attachment handling

2011-09-08 Thread Mark Walters
>> To user that is: >> >> Pressing Enter on top of an attachment will either show the attachment on >> buffer (in case there is 'converter' defined) or offer to save the >> attachment. Pressing 'o' on top of an attachment will always offer to save >> the attachment. > > I really do not like it

RFC/PATCH emacs attachment handling

2011-09-08 Thread Mark Walters
(Re-sent since accidentally didn't include list in reply) > This is great! In particular many people send PDF attachments to me with > mime-type attachment/octet-stream, and notmuch could not view them and > only offered to save them... I have wanted this functionality for long! In fact in most

Memory management practices

2011-09-08 Thread Austin Clements
On Wed, Sep 7, 2011 at 10:48 PM, Austin Clements wrote: > *snip* > > I'm a bit confused by the reference tree you drew. ?The references in > the underlying libnotmuch objects are the other way around. > notmuch_query_t holds a talloc reference to every notmuch_messages_t > it produces, not the

Re: Memory management practices

2011-09-08 Thread Austin Clements
Quoth Sebastian Spaeth on Sep 08 at 3:50 pm: On Wed, 7 Sep 2011 23:05:19 -0400, Austin Clements amdra...@mit.edu wrote: Sorry, I went back and re-read your earlier messages and now I see why your references were the way they were. I stand by the rest of my previous message though. I

Re: Bug in GC's ordering of ForeignPtr finalization?

2011-09-08 Thread Antoine Latter
On Sun, Aug 28, 2011 at 4:27 PM, Ben Gamari bgamari.f...@gmail.com wrote: On Tue, 16 Aug 2011 12:32:13 -0400, Ben Gamari bgamari.f...@gmail.com wrote: It seems that the notmuch-haskell bindings (version 0.2.2 built against notmuch from git master; passes notmuch-test) aren't dealing with memory

Re: Bug in GC's ordering of ForeignPtr finalization?

2011-09-08 Thread Antoine Latter
On Sun, Aug 28, 2011 at 10:47 PM, Ben Gamari bgamari.f...@gmail.com wrote: On Sun, 28 Aug 2011 22:26:05 -0500, Antoine Latter aslat...@gmail.com wrote: One problem you might be running in to is that the optimization passes can notice that a function isn't using all of its arguments, and then

Re: [PATCH] emacs: Sort saved searches

2011-09-08 Thread Adam Wolfe Gordon
Jani Nikula wrote: Display saved searches sorted, like tags are displayed. This only affects the display of the saved searches, not the order in which they are stored in .emacs. I think there should be an option for this behavior. Personally, I have my saved searches in a specific

Re: RFC/PATCH emacs attachment handling

2011-09-08 Thread Matthieu Lemerre
Finally, I have also mapped the key o (other/open with) on a button to open with user chosen program. This could be split out into a separate patch if preferred. This is great! In particular many people send PDF attachments to me with mime-type attachment/octet-stream, and notmuch could not

Patch: Flush and Reopen

2011-09-08 Thread Martin Owens
Hello, Per discussions on irc, I've attached a patch for your consideration which allows the developer to run two new database commands; notmuch_database_flush - used on read_write databases to commit changes to disk notmuch_database_reopen - used on read_only databases to reload from the disk

Re: Patch: Flush and Reopen

2011-09-08 Thread Austin Clements
On Wed, Sep 7, 2011 at 9:34 PM, Martin Owens docto...@gmail.com wrote: Hello, Per discussions on irc, I've attached a patch for your consideration which allows the developer to run two new database commands; notmuch_database_flush - used on read_write databases to commit changes to disk