set test prereqs (Emacs, GDB, GPG) v4

2011-11-01 Thread Ali Polatel
lip -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2001/bfaa19ca/attachment-0001.pgp>

[PATCH 03/13] test: add 'Emacs' prereq to dependent 'crypto' tests

2011-11-01 Thread Pieter Praet
On Tue, 01 Nov 2011 20:56:17 +0100, Pieter Praet wrote: > On Mon, 3 Oct 2011 18:47:17 +0200, Thomas Jost > wrote: > [...] > > Also, you appear to have given *every* test the EMACS+GPG prereq, > while only the ones using `emacs_deliver_message' require EMACS. > > [...] Again, my mistake. All

[PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests

2011-11-01 Thread Pieter Praet
On Tue, 01 Nov 2011 20:57:59 +0100, Pieter Praet wrote: > On Mon, 3 Oct 2011 18:47:18 +0200, Thomas Jost > wrote: > [...] > - @ "Verify that sent messages are saved/searchable (via FCC)": > > This doesn't need an EMACS prereq. > [...] My mistake, scrap this one. Without Emacs, there

[PATCH] emacs: logically group def{custom,face}s

2011-11-01 Thread Pieter Praet
On Tue, 18 Oct 2011 08:18:18 -0700, Jameson Graef Rollins wrote: > On Mon, 10 Oct 2011 15:49:03 +0200, Daniel Schoepe > wrote: > > On Tue, 5 Jul 2011 20:33:00 +0200, Pieter Praet > > wrote: > > > To allow for expansion whilst keeping everything tidy and organized, > > > move all

[PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests

2011-11-01 Thread Pieter Praet
On Mon, 3 Oct 2011 18:47:18 +0200, Thomas Jost wrote: > [...] Nice catches @ - "Sending a message via (fake) SMTP" - "Hiding message following HTML part" (though I think the latter test wasn't there yet when I submitted my patch series) New "issues": - The SCREEN prereq would

[PATCH 03/13] test: add 'Emacs' prereq to dependent 'crypto' tests

2011-11-01 Thread Pieter Praet
On Mon, 3 Oct 2011 18:47:17 +0200, Thomas Jost wrote: > [...] The SCREEN prereq would preferrably be added in a separate commit. Also, you appear to have given *every* test the EMACS+GPG prereq, while only the ones using `emacs_deliver_message' require EMACS. Peace -- Pieter

[PATCH 00/13] Test prereqs and screen-based Emacs tests

2011-11-01 Thread Pieter Praet
On Mon, 3 Oct 2011 18:47:14 +0200, Thomas Jost wrote: > Here it is: a rebased version of Pieter's patch series adding prereqs for the > emacs and crypto tests [1], and Dmitry's patches for running emacs inside > screen > in the test suite [2]. (Please note that this one also includes fixes to

[PATCH 4/4] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests

2011-11-01 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. --- test/emacs-large-search-buffer |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-)

[PATCH 3/4] test: add 'Emacs' prereq to dependent 'emacs' tests

2011-11-01 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. --- test/emacs | 65 --- 1 files changed, 35

[PATCH 2/4] test: add 'Emacs' prereq to dependent 'crypto' tests

2011-11-01 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. --- test/crypto | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git

[PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests

2011-11-01 Thread Pieter Praet
Adds a new test that checks for the presence of 'gpg', and adds that test as a prereq to all subsequent tests that rely on GnuPG. This causes tests with unmet dependencies to be skipped. --- test/crypto | 33 +++-- 1 files changed, 19 insertions(+), 14 deletions(-)

set test prereqs (Emacs, GDB, GPG) v4

2011-11-01 Thread Pieter Praet
Rebased to current master. Previous version: id:"1307016220-17509-1-git-send-email-pieter at praet.org" Discussion: id:"1317660447-27520-1-git-send-email-schnouki at schnouki.net"

Patch review/application process

2011-11-01 Thread David Bremner
ion of the issue. Here I think we agree. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 315 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2001/b42c4053/attachment.pgp>

Patch review/application process

2011-11-01 Thread David Bremner
g:notmuch::todo and tag:notmuch::reviewed to get an "integrators queue" (Well, the more like an unordered pile than a queue. One problem at a time). David -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 315 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2001/02ba5282/attachment.pgp>

Patch review/application process

2011-11-01 Thread Jameson Graef Rollins
eral) but I still think we should try. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2001/543f2f66/attachment.pgp>

Displaying tags with many messages very slow in Emacs

2011-11-01 Thread bnt
On 2011, Oct 31, at 19:25 , Daniel Schoepe wrote: > On Mon, 31 Oct 2011 16:43:22 +0100, bnt wrote: >> I am not too proficient with the patch utility. Is there some kind of >> scheduled git commits timeline? > > Unfortunately, there's a huge number of outstanding patches at the > moment, so

Patch review/application process

2011-11-01 Thread Jameson Graef Rollins
On Tue, 01 Nov 2011 16:55:03 -0300, David Bremner wrote: > One thing I think we need to clarify a bit is are we tagging whole > threads or individual messages in the database. Because of the way > notmuch search works, I had been tagging whole threads with > notmuch::pushed (effectively to

[PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests

2011-11-01 Thread Jameson Graef Rollins
nction? jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2001/5b88e7b1/attachment.pgp>

Patch review/application process

2011-11-01 Thread David Bremner
mething like "cd $HOME/.nmbug && git log -- tags/$(echo $id | sha1sum -)" -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 315 bytes Desc: not available URL: <http://notmuchmail.o

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-01 Thread David Bremner
On Mon, 31 Oct 2011 23:18:07 +0200, Jani Nikula wrote: > > I'm still marking it as RFC. It works for me, but patch 1 might be deemed > unacceptable. > Hi Jani; Is just because it add a function to the library that you think this might be problematic? I don't think we are super-dogmatic about

Patch review/application process

2011-11-01 Thread Jameson Graef Rollins
--- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/2001/7b32ebeb/attachment.pgp>

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-01 Thread Jani Nikula
On Mon, 31 Oct 2011 14:44:29 -0700, Jameson Graef Rollins wrote: > Hi, Jani. Thanks for working on this. This should also be valuable for > vim users. Thanks for your interest! :) > In order to push forward with this, though, I think we really need to > have a complete unit test for this new

[PATCH] Repeatability when copying a whole directory into a new one.

2011-11-01 Thread David Bremner
On Fri, 30 Sep 2011 01:26:46 +0200, Thomas Schwinge wrote: > This new test currently fails -- but it shouldn't. > --- > > Hi! > > I found this while manually copying directories and running notmuch new. > > Am I just too sleepy at this time, or is it another DB vs. directory > mtime issue? >

[RFC PATCH v2 3/3] emacs: support limiting the number of results shown in search results

2011-11-01 Thread Jani Nikula
Add support for limiting the maximum number of results initially displayed in search results. When enabled, the search results will contain push buttons to double the number of results displayed or to show unlimited results. The approach is inspired by vc-print-log in Emacs vc.el. Signed-off-by:

[RFC PATCH v2 2/3] cli: add options --first and --maxitems to notmuch search

2011-11-01 Thread Jani Nikula
Add options --first=[-]N and --maxitems=M to notmuch search to determine the first result and maximum number of results to display. Option --maxitems=M limits the maximum number of results to display to M. Option --first=[-]N skips the first N results; with the leading '-' skip until the Nth

[RFC PATCH v2 1/3] lib: add function to get the number of threads matching a search

2011-11-01 Thread Jani Nikula
Add function notmuch_query_count_threads() to get the number of threads matching a search. This is done by performing a search and figuring out the number of unique thread IDs in the matching messages, a significantly heavier operation than notmuch_query_count_messages(). Signed-off-by: Jani

[RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-01 Thread Jani Nikula
Hi, this is an iteration of id:"cover.1319833617.git.jani at nikula.org" addressing comments on the list and IRC. Main changes: * Results are now limited based on threads (not messages) for thread and summary output. This is accomplished with a new lib function to count the number of threads

Re: [RFC PATCH v2 0/3] lib/cli/emacs: limit number of messages in search results

2011-11-01 Thread David Bremner
On Mon, 31 Oct 2011 23:18:07 +0200, Jani Nikula j...@nikula.org wrote: I'm still marking it as RFC. It works for me, but patch 1 might be deemed unacceptable. Hi Jani; Is just because it add a function to the library that you think this might be problematic? I don't think we are

Re: Displaying tags with many messages very slow in Emacs

2011-11-01 Thread bnt
On 2011, Oct 31, at 19:25 , Daniel Schoepe wrote: On Mon, 31 Oct 2011 16:43:22 +0100, bnt webserv...@bontempi.net wrote: I am not too proficient with the patch utility. Is there some kind of scheduled git commits timeline? Unfortunately, there's a huge number of outstanding patches at the

Re: Patch review/application process

2011-11-01 Thread Jameson Graef Rollins
On Tue, 01 Nov 2011 11:28:45 -0300, David Bremner da...@tethera.net wrote: Maybe you can tag those patches as notmuch::reviewed using nmbug? [1] My idea is that notmuch search tag:notmuch::patch and tag:notmuch::reviewed should give a kind of consensus set of ready to go patch sets.

set test prereqs (Emacs, GDB, GPG) v4

2011-11-01 Thread Pieter Praet
Rebased to current master. Previous version: id:1307016220-17509-1-git-send-email-pie...@praet.org Discussion: id:1317660447-27520-1-git-send-email-schno...@schnouki.net ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests

2011-11-01 Thread Pieter Praet
Adds a new test that checks for the presence of 'gpg', and adds that test as a prereq to all subsequent tests that rely on GnuPG. This causes tests with unmet dependencies to be skipped. --- test/crypto | 33 +++-- 1 files changed, 19 insertions(+), 14 deletions(-)

[PATCH 2/4] test: add 'Emacs' prereq to dependent 'crypto' tests

2011-11-01 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. --- test/crypto | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git

[PATCH 3/4] test: add 'Emacs' prereq to dependent 'emacs' tests

2011-11-01 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. --- test/emacs | 65 --- 1 files changed, 35

[PATCH 4/4] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests

2011-11-01 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. --- test/emacs-large-search-buffer |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-)

Re: [PATCH 00/13] Test prereqs and screen-based Emacs tests

2011-11-01 Thread Pieter Praet
On Mon, 3 Oct 2011 18:47:14 +0200, Thomas Jost schno...@schnouki.net wrote: Here it is: a rebased version of Pieter's patch series adding prereqs for the emacs and crypto tests [1], and Dmitry's patches for running emacs inside screen in the test suite [2]. (Please note that this one also

Re: Patch review/application process

2011-11-01 Thread David Bremner
On Tue, 01 Nov 2011 08:55:09 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: On Tue, 01 Nov 2011 11:28:45 -0300, David Bremner da...@tethera.net wrote: Maybe you can tag those patches as notmuch::reviewed using nmbug? [1] My idea is that notmuch search

Re: [PATCH 03/13] test: add 'Emacs' prereq to dependent 'crypto' tests

2011-11-01 Thread Pieter Praet
On Mon, 3 Oct 2011 18:47:17 +0200, Thomas Jost schno...@schnouki.net wrote: [...] The SCREEN prereq would preferrably be added in a separate commit. Also, you appear to have given *every* test the EMACS+GPG prereq, while only the ones using `emacs_deliver_message' require EMACS. Peace --

Re: [PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests

2011-11-01 Thread Pieter Praet
On Mon, 3 Oct 2011 18:47:18 +0200, Thomas Jost schno...@schnouki.net wrote: [...] Nice catches @ - Sending a message via (fake) SMTP - Hiding message following HTML part (though I think the latter test wasn't there yet when I submitted my patch series) New issues: - The SCREEN prereq

Re: [PATCH] emacs: logically group def{custom,face}s

2011-11-01 Thread Pieter Praet
On Tue, 18 Oct 2011 08:18:18 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: On Mon, 10 Oct 2011 15:49:03 +0200, Daniel Schoepe dan...@schoepe.org wrote: On Tue, 5 Jul 2011 20:33:00 +0200, Pieter Praet pie...@praet.org wrote: To allow for expansion whilst keeping everything

Re: [PATCH 04/13] test: add 'Emacs' prereq to dependent 'emacs' tests

2011-11-01 Thread Pieter Praet
On Tue, 01 Nov 2011 20:57:59 +0100, Pieter Praet pie...@praet.org wrote: On Mon, 3 Oct 2011 18:47:18 +0200, Thomas Jost schno...@schnouki.net wrote: [...] - @ Verify that sent messages are saved/searchable (via FCC): This doesn't need an EMACS prereq. [...] My mistake, scrap this

Re: [PATCH 03/13] test: add 'Emacs' prereq to dependent 'crypto' tests

2011-11-01 Thread Pieter Praet
On Tue, 01 Nov 2011 20:56:17 +0100, Pieter Praet pie...@praet.org wrote: On Mon, 3 Oct 2011 18:47:17 +0200, Thomas Jost schno...@schnouki.net wrote: [...] Also, you appear to have given *every* test the EMACS+GPG prereq, while only the ones using `emacs_deliver_message' require EMACS.

Re: set test prereqs (Emacs, GDB, GPG) v4

2011-11-01 Thread Ali Polatel
On Tue, Nov 01, 2011 at 08:49:10PM +0100, Pieter Praet wrote: Rebased to current master. Previous version: id:1307016220-17509-1-git-send-email-pie...@praet.org Discussion: id:1317660447-27520-1-git-send-email-schno...@schnouki.net Thanks for the nice work! I want to share one thing which

Re: [PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests

2011-11-01 Thread Jameson Graef Rollins
On Tue, 1 Nov 2011 20:49:11 +0100, Pieter Praet pie...@praet.org wrote: -test_expect_success 'emacs delivery of signed message' \ +test_expect_success GPG 'emacs delivery of signed message' \ Hi, Pieter and Thomas. Thanks for all the work on this, but I have one issue. Is there a way we can

Re: Patch review/application process

2011-11-01 Thread Jameson Graef Rollins
On Tue, 01 Nov 2011 16:55:03 -0300, David Bremner da...@tethera.net wrote: One thing I think we need to clarify a bit is are we tagging whole threads or individual messages in the database. Because of the way notmuch search works, I had been tagging whole threads with notmuch::pushed

Re: Patch review/application process

2011-11-01 Thread David Bremner
On Tue, 01 Nov 2011 14:27:53 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: I'm not sure why this is needed, since it seems to me that the whole argument for tagging entire threads is that the individual messages are *not* distinguishable from the thread. The problem is that

Re: Patch review/application process

2011-11-01 Thread Jameson Graef Rollins
On Tue, 01 Nov 2011 20:22:58 -0300, David Bremner da...@tethera.net wrote: The problem is that notmuch search foo and not bar will return all threads containing a message satisfying foo and a message satisfying not bar. This makes notmuch search tag:notmuch::patch and not