[PATCH] Output unmodified Content-Type header value for JSON format.

2011-11-18 Thread Austin Clements
Quoth Dmitry Kurochkin on Nov 19 at 6:42 am: > Hi Jamie. > > On Fri, 18 Nov 2011 17:58:52 -0800, Jameson Graef Rollins finestructure.net> wrote: > > On Sat, 19 Nov 2011 03:45:05 +0400, Dmitry Kurochkin > gmail.com> wrote: > > > Before the change, notmuch used g_mime_content_type_to_string(3) >

[PATCH] emacs: fix `mm-make-handle' content-type parameter

2011-11-18 Thread Dmitry Kurochkin
`notmuch-show-mm-display-part-inline' uses undocumented `mm-make-handle' function. One of the parameters for `mm-make-handle' is charset. Before the change, an unparsed content-type was given to `mm-make-handle' (this was probably copied from Gnus source which uses simple hard-coded values in a s

Re: [PATCH] Output unmodified Content-Type header value for JSON format.

2011-11-18 Thread Dmitry Kurochkin
On Fri, 18 Nov 2011 23:59:57 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Nov 19 at 6:42 am: > > Hi Jamie. > > > > On Fri, 18 Nov 2011 17:58:52 -0800, Jameson Graef Rollins > > wrote: > > > On Sat, 19 Nov 2011 03:45:05 +0400, Dmitry Kurochkin > > > wrote: > > > > Before the chan

Re: [PATCH] Output unmodified Content-Type header value for JSON format.

2011-11-18 Thread Austin Clements
Quoth Dmitry Kurochkin on Nov 19 at 6:42 am: > Hi Jamie. > > On Fri, 18 Nov 2011 17:58:52 -0800, Jameson Graef Rollins > wrote: > > On Sat, 19 Nov 2011 03:45:05 +0400, Dmitry Kurochkin > > wrote: > > > Before the change, notmuch used g_mime_content_type_to_string(3) > > > function to output C

[PATCH] test: fix sed error in basic tests

2011-11-18 Thread Dmitry Kurochkin
The error is easy to miss, because the test passes and stderr is not printed. But if you run basic tests in verbose mode (./basic --verbose), you get: sed: can't read notmuch-test: No such file or directory The issue is that sed command is given two files: notmuch-test and $TEST_DIRECTORY/notm

Re: [PATCH] Output unmodified Content-Type header value for JSON format.

2011-11-18 Thread Dmitry Kurochkin
Hi Jamie. On Fri, 18 Nov 2011 17:58:52 -0800, Jameson Graef Rollins wrote: > On Sat, 19 Nov 2011 03:45:05 +0400, Dmitry Kurochkin > wrote: > > Before the change, notmuch used g_mime_content_type_to_string(3) > > function to output Content-Type header value. Turns out it outputs > > only "type

Re: [PATCH] Output unmodified Content-Type header value for JSON format.

2011-11-18 Thread Jameson Graef Rollins
On Sat, 19 Nov 2011 03:45:05 +0400, Dmitry Kurochkin wrote: > Before the change, notmuch used g_mime_content_type_to_string(3) > function to output Content-Type header value. Turns out it outputs > only "type/subtype" part and ignores all parameters. Also, if there > is no Content-Type header,

[PATCH] Output unmodified Content-Type header value for JSON format.

2011-11-18 Thread Jameson Graef Rollins
ithout figuring out what's going on, I notice that some of the tests have been modified to remove the content-type fields on a bunch of parts. I think that is probably not right. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type:

Re: [PATCH] emacs: fix `mm-make-handle' content-type parameter

2011-11-18 Thread Dmitry Kurochkin
Please ignore this patch. Apparently, it is not enough to fix the issue. A proper fix is available in [1]. Regards, Dmitry [1] id:"1321659905-24367-1-git-send-email-dmitry.kuroch...@gmail.com" ___ notmuch mailing list notmuch@notmuchmail.org http://

[PATCH] test: make all tests terminable with Ctrl-c

2011-11-18 Thread David Bremner
On Tue, 08 Nov 2011 18:02:25 +0200, Tomi Ollila wrote: > Some tests don't break when HUP signal is sent tho those (by > pressing ctrl-c on the terminal). Therefore, the top-level > test script catches the HUP and sends TERM signal to the > started test script. Pushed to master d

[PATCH] test: emacs: tidy up "Stashing in notmuch-show" test

2011-11-18 Thread David Bremner
On Wed, 16 Nov 2011 12:38:19 +0100, Pieter Praet wrote: > Merge expected output into the actual test, so we can verify the stashed > filename using ${gen_msg_filename} instead of doing sed tricks. pushed to master d

[PATCH] emacs: create patch filename from subject for inline patch fake parts

2011-11-18 Thread Jani Nikula
Use the mail subject line for creating a descriptive filename for the wash generated inline patch fake parts. The names are similar to the ones created by 'git format-patch', just without the leading numbers. Signed-off-by: Jani Nikula --- I know notmuch-subject-to-patch-filename is totally un-

Re: [PATCH] test: make all tests terminable with Ctrl-c

2011-11-18 Thread David Bremner
On Tue, 08 Nov 2011 18:02:25 +0200, Tomi Ollila wrote: > Some tests don't break when HUP signal is sent tho those (by > pressing ctrl-c on the terminal). Therefore, the top-level > test script catches the HUP and sends TERM signal to the > started test script. Pushed to master d

Re: [PATCH] test: emacs: tidy up "Stashing in notmuch-show" test

2011-11-18 Thread David Bremner
On Wed, 16 Nov 2011 12:38:19 +0100, Pieter Praet wrote: > Merge expected output into the actual test, so we can verify the stashed > filename using ${gen_msg_filename} instead of doing sed tricks. pushed to master d ___ notmuch mailing list notmuch@not

[PATCH v2] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-18 Thread David Bremner
On Wed, 16 Nov 2011 23:25:19 +0200, Tomi Ollila wrote: > If mail sending from emacs fails before it has chance to connect > to the smtp-dummy mail server, the opportunistic QUIT message > sending makes smtp-dummy to exit. Pushed. d

[PATCH 0/9] test: (hopefully) better test prerequisites

2011-11-18 Thread Tomi Ollila
On Thu, 17 Nov 2011 19:17:16 +0400, Dmitry Kurochkin wrote: > > If we follow this pattern than all code like: > > f() { > if (!done_once) > do_once > > do_more > } > > Should be rewritten using dynamic functions. I do not think I agree with > this :) > > Anyway, all above

[PATCH] emacs: fix `mm-make-handle' content-type parameter

2011-11-18 Thread Dmitry Kurochkin
`notmuch-show-mm-display-part-inline' uses undocumented `mm-make-handle' function. One of the parameters for `mm-make-handle' is charset. Before the change, an unparsed content-type was given to `mm-make-handle' (this was probably copied from Gnus source which uses simple hard-coded values in a s

[PATCH] test: fix sed error in basic tests

2011-11-18 Thread Dmitry Kurochkin
The error is easy to miss, because the test passes and stderr is not printed. But if you run basic tests in verbose mode (./basic --verbose), you get: sed: can't read notmuch-test: No such file or directory The issue is that sed command is given two files: notmuch-test and $TEST_DIRECTORY/notm

Re: [PATCH v2] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-18 Thread David Bremner
On Wed, 16 Nov 2011 23:25:19 +0200, Tomi Ollila wrote: > If mail sending from emacs fails before it has chance to connect > to the smtp-dummy mail server, the opportunistic QUIT message > sending makes smtp-dummy to exit. Pushed. d ___ notmuch mailing

Re: [PATCH 0/9] test: (hopefully) better test prerequisites

2011-11-18 Thread Dmitry Kurochkin
On Thu, 17 Nov 2011 16:02:46 +0200, Tomi Ollila wrote: > On Thu, 17 Nov 2011 17:22:41 +0400, Dmitry Kurochkin > wrote: > > Hi Tomi. > > > > On Thu, 17 Nov 2011 14:20:19 +0200, Tomi Ollila wrote: > > > > > > I.e. dynamically, at run-time, re-create test_emacs function... > > > > > > > Could

FYI: gmail contacts as notmuch emacs addressbook

2011-11-18 Thread Jani Nikula
This is a really simple read-only setup for using gmail contacts as notmuch addressbook, but perhaps there are people who find this useful: 1) Install goobook http://code.google.com/p/goobook/. On a Debian based system you might be able do it with: $ sudo apt-get install python-pip $ sudo pip in

Re: [PATCH 0/9] test: (hopefully) better test prerequisites

2011-11-18 Thread Tomi Ollila
On Thu, 17 Nov 2011 19:17:16 +0400, Dmitry Kurochkin wrote: > > If we follow this pattern than all code like: > > f() { > if (!done_once) > do_once > > do_more > } > > Should be rewritten using dynamic functions. I do not think I agree with > this :) > > Anyway, all above

[PATCH 3/3] RELEASING: document the semi-automated version propagation.

2011-11-18 Thread David Bremner
From: David Bremner The instructions are purposely a bit coy about what files are updated, so we don't have to update immediately when something else is plugged into the make recipe. --- RELEASING |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/RELEASING b/RELEASING

[DRAFT PATCH] emacs: support limiting the number of results shown in search results

2011-11-18 Thread Jani Nikula
Add support for limiting the maximum number of results initially displayed in search results. When enabled, the search results will contain push buttons to double the number of results displayed or to show unlimited results. The approach is inspired by vc-print-log in Emacs vc.el. Signed-off-by:

[PATCH 2/3] build system: add target update-versions to propagate version

2011-11-18 Thread David Bremner
From: David Bremner The version from file "version" is propagated to the man page and the python bindings via sed. Note that the git version is ignored because of the check for MAKECMDGOALS. --- Makefile.local | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a

[PATCH 1/3] build system: use $(filter ...) to test MAKECMDGOALS

2011-11-18 Thread David Bremner
From: David Bremner This makes the test easier to extend to more targets. It also corrects a bug where "special" targets were only detected when given alone. --- Makefile.local |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/Makefile.local b/Makefile.local index 8b4

Re: [PATCH v2] test: attempt to send QUIT to smtp-dummy in case mail send failed

2011-11-18 Thread Austin Clements
LGTM. Quoth Tomi Ollila on Nov 16 at 11:25 pm: > If mail sending from emacs fails before it has chance to connect > to the smtp-dummy mail server, the opportunistic QUIT message > sending makes smtp-dummy to exit. ___ notmuch mailing list notmuch@notmuch