Exporting a single email as JSON

2011-12-10 Thread Austin Clements
Just to add to Jameson's email... Quoth Ciprian Dorin Craciun on Dec 11 at 12:46 am: > On Sat, Dec 10, 2011 at 22:15, Jameson Graef Rollins > wrote: > > On Sat, 10 Dec 2011 20:32:22 +0200, Ciprian Dorin Craciun > at gmail.com> wrote: > >> ? ? Quick question: why isn't it reasonable to export a

Exporting a single email as JSON

2011-12-10 Thread Ciprian Dorin Craciun
Hello all! Quick question: why isn't it reasonable to export a **single** email in JSON format (by using the `show` sub-command)? (I mean I understand that in order to be able to correctly parse the output we need only one "object" (i.e. a list of threads, containing a list of emails,

[RFC PATCH] cli: factor out config handling code to get/set lists.

2011-12-10 Thread David Bremner
On Sat, 10 Dec 2011 13:24:36 -0500, Austin Clements wrote: > What about something like > > const char ** > notmuch_config_get_user_other_email (notmuch_config_t *config, > size_t *length) > { > return _config_get_list (config, "user", "other_email", >

[PATCH 3/4] Utility function to seek in MIME trees in depth-first order.

2011-12-10 Thread Dmitry Kurochkin
On Fri, 9 Dec 2011 14:54:27 -0500, Austin Clements wrote: > This function matches how we number parts for the --part argument to > show. It will allow us to jump directly to the desired part, rather > than traversing the entire tree and carefully tracking whether or not > we're "in the zone". >

Exporting a single email as JSON

2011-12-10 Thread Jameson Graef Rollins
ot available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111210/4f968d6e/attachment.pgp>

[PATCH v4 0/3] notmuch hooks

2011-12-10 Thread Jameson Graef Rollins
ttp://notmuchmail.org/pipermail/notmuch/attachments/20111210/840b1d54/attachment.pgp>

[RFC PATCH] cli: factor out config handling code to get/set lists.

2011-12-10 Thread David Bremner
From: David Bremner The code is already duplicated once, and I want to add a third configuration item that is also a list. --- Mainly I am curious if people think using macros to declare these "getters" and "setters" makes the code less maintainable. notmuch-config.c |

[RFC PATCH] cli: factor out config handling code to get/set lists.

2011-12-10 Thread Austin Clements
Deduplicating this code seems like a great idea, but I don't think macros are the way to do it; especially not one that expands to an important top-level construct like a function definition. What about something like const char ** notmuch_config_get_user_other_email (notmuch_config_t *config,

[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-10 Thread Jameson Graef Rollins
lly been meaning to overhaul this stuff for gmime 2.6. Hopefully I'll start looking at that after these patches go through. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111210/5d5b4372/attachment.pgp>

[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-10 Thread Jameson Graef Rollins
ly should. We can probably fix this in followup patches, since Austin is just working off of what dkg and I put in there originally. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not

[PATCH v3 0/4] First step of 'show' rewrite

2011-12-10 Thread Jameson Graef Rollins
(or maybe a v3 of it) into master. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111210/7c656

[PATCH v3] Release memory allocated by internet_address_list_parse_string()

2011-12-10 Thread Tomi Ollila
g_object_unref() releases the memory of the InternetAddressList object returned by internet_address_list_parse_string() -- when last (only) reference is released, internet_address_list_finalize() will do cleanup. --- hmm, have to agree amdragon's "suggested alternative" is more robust (in

Exporting a single email as JSON

2011-12-10 Thread Jameson Graef Rollins
of single-message output going. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111210/ba9c91ce/attachment.pgp>

[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-10 Thread Dmitry Kurochkin
Hi Austin. +/* The number of children of this part. */ +int children; Consider renaming to children_count or similar to make it clear that it is a counter and not the actual children. +notmuch_bool_t decrypt_success; Perhaps s/decrypt_success/is_decrypted/ for consistency with

[PATCH v3] Release memory allocated by internet_address_list_parse_string()

2011-12-10 Thread Tomi Ollila
g_object_unref() releases the memory of the InternetAddressList object returned by internet_address_list_parse_string() -- when last (only) reference is released, internet_address_list_finalize() will do cleanup. --- hmm, have to agree amdragon's suggested alternative is more robust (in

Re: [RFC PATCH] cli: factor out config handling code to get/set lists.

2011-12-10 Thread Austin Clements
Deduplicating this code seems like a great idea, but I don't think macros are the way to do it; especially not one that expands to an important top-level construct like a function definition. What about something like const char ** notmuch_config_get_user_other_email (notmuch_config_t *config,

Re: Exporting a single email as JSON

2011-12-10 Thread Jameson Graef Rollins
On Sat, 10 Dec 2011 20:32:22 +0200, Ciprian Dorin Craciun ciprian.crac...@gmail.com wrote: Quick question: why isn't it reasonable to export a **single** email in JSON format (by using the `show` sub-command)? (I mean I understand that in order to be able to correctly parse the output we

Re: [RFC PATCH] cli: factor out config handling code to get/set lists.

2011-12-10 Thread David Bremner
On Sat, 10 Dec 2011 13:24:36 -0500, Austin Clements amdra...@mit.edu wrote: What about something like const char ** notmuch_config_get_user_other_email (notmuch_config_t *config, size_t *length) { return _config_get_list (config, user, other_email,

Re: [PATCH v3 0/4] First step of 'show' rewrite

2011-12-10 Thread Jameson Graef Rollins
Hey, Austin. This is a really great rework of mime part handling. Your new solution is much more elegant, and makes things much cleaner. The patch series looks very good to me. I only have a couple of comments on the crypto processing stuff, to follow. I definitely support pushing this series

Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-10 Thread Jameson Graef Rollins
On Sat, 10 Dec 2011 03:25:48 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: +notmuch_bool_t decrypt_success; Perhaps s/decrypt_success/is_decrypted/ for consistency with is_encrypted? This difference doesn't seem so bad to me, since the is_ variables point to states of the

Re: [PATCH v4 0/3] notmuch hooks

2011-12-10 Thread Jameson Graef Rollins
Hi, Jani. This is a nice patch series. I've been using both the pre- and post-new hooks for a couple days now without any problems. It's a nice bit of new functionality. The patches have already had a good review, and it all looks good to me, so I definitely supporting pushing them. They

Re: Exporting a single email as JSON

2011-12-10 Thread Ciprian Dorin Craciun
On Sat, Dec 10, 2011 at 22:15, Jameson Graef Rollins jroll...@finestructure.net wrote: On Sat, 10 Dec 2011 20:32:22 +0200, Ciprian Dorin Craciun ciprian.crac...@gmail.com wrote:     Quick question: why isn't it reasonable to export a **single** email in JSON format (by using the `show`

Re: Exporting a single email as JSON

2011-12-10 Thread Jameson Graef Rollins
On Sun, 11 Dec 2011 00:46:51 +0200, Ciprian Dorin Craciun ciprian.crac...@gmail.com wrote: I've given a quick look into `notmuch-show.c` (commit from December 4) and indeed it seems quite trivial to add new formats. Thus I wonder: a) Is the code suitable for experimenting such a

Re: Exporting a single email as JSON

2011-12-10 Thread Ciprian Dorin Craciun
On Sun, Dec 11, 2011 at 01:19, Jameson Graef Rollins jroll...@finestructure.net wrote: On Sun, 11 Dec 2011 00:46:51 +0200, Ciprian Dorin Craciun ciprian.crac...@gmail.com wrote:     * in my use-case I would need each line of the output to be a standalone JSON object of an individual message;

experimental logging branch

2011-12-10 Thread David Bremner
I have pushed a branch jlog git://pivot.cs.unb.ca/notmuch.git This uses the jlog library (http://labs.omniti.com/labs/jlog) to atomically log messages in pub-sub model. On this branch you can enable logging of tagging operations by notmuch config set log.subscribers 'name1;name2;name3'

Re: Exporting a single email as JSON

2011-12-10 Thread Austin Clements
Just to add to Jameson's email... Quoth Ciprian Dorin Craciun on Dec 11 at 12:46 am: On Sat, Dec 10, 2011 at 22:15, Jameson Graef Rollins jroll...@finestructure.net wrote: On Sat, 10 Dec 2011 20:32:22 +0200, Ciprian Dorin Craciun ciprian.crac...@gmail.com wrote:     Quick question: why