I got some positive feedback for replacing notmuch-hello search input
with a button wich would call `notmuch-search' and read input from
minibuffer as usual. This way we do not have to maintain 2 search
interfaces and get history, tab completions and other minibuffer
features in notmuch-hello sear
---
test/emacs.expected-output/notmuch-hello |6 +++---
.../notmuch-hello-no-saved-searches|6 +++---
.../emacs.expected-output/notmuch-hello-with-empty |6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/test/emacs.expected-output/notmuc
---
emacs/notmuch-hello.el | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index fa33500..6015af4 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -30,7 +30,10 @@
(declare-function notmuch-pol
Reindent `notmuch-hello' function after the search history changes.
---
emacs/notmuch-hello.el | 56
1 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index eb08a09..fa33500 100644
---
Before the change, there were two ways to do search in Emacs UI:
search widget in notmuch-hello buffer and `notmuch-search'
function bound to "s". Internally, notmuch-hello search widget
uses `notmuch-search' function. But it uses widget field input
instead of minibuffer. Such duplication is a m
Awesome. This looks significantly cleaner. I think this is worth
pushing for the comment you added to notmuch-show-advance alone.
This definitely changes the behavior of rewind, but other than one
case I point out below, I think what you have now is much closer to an
inverse of advance. It woul
Quoth Tomi Ollila on Dec 23 at 2:30 pm:
> On Fri, 23 Dec 2011 08:10:33 +, David Edmondson wrote:
> > Sorry for being slow.
> >
> > Can you describe the situation in which you expect a write to stderr to
> > be a short write? (Without error.)
>
> In the following hypothetical case (correct m
Quoth David Edmondson on Dec 23 at 8:10 am:
> Sorry for being slow.
>
> Can you describe the situation in which you expect a write to stderr to
> be a short write? (Without error.)
If the PTY buffer is nearly full because, say, my terminal emulator is
a little behind or my SSH session is slow, I
On Sat, 24 Dec 2011 00:40:34 +0400, Dmitry Kurochkin wrote:
> Examples in documentation for `notmuch-search-line-faces' had an extra
> quote, e.g.:
>
> '(\"unread\" . '(:foreground \"green\"))
>
Pushed.
d
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins wrote:
> Since message-ids necessarily match just a single message, there's no
> reason to do a search for the id before viewing the actual message;
> the search just becomes an extra screen to click through. Clicking on
> an id: links now
Awesome. This looks significantly cleaner. I think this is worth
pushing for the comment you added to notmuch-show-advance alone.
This definitely changes the behavior of rewind, but other than one
case I point out below, I think what you have now is much closer to an
inverse of advance. It woul
Quoth Tomi Ollila on Dec 23 at 2:30 pm:
> On Fri, 23 Dec 2011 08:10:33 +, David Edmondson wrote:
> > Sorry for being slow.
> >
> > Can you describe the situation in which you expect a write to stderr to
> > be a short write? (Without error.)
>
> In the following hypothetical case (correct m
Quoth David Edmondson on Dec 23 at 8:10 am:
> Sorry for being slow.
>
> Can you describe the situation in which you expect a write to stderr to
> be a short write? (Without error.)
If the PTY buffer is nearly full because, say, my terminal emulator is
a little behind or my SSH session is slow, I
This function matches how we number parts for the --part argument to
show. It will allow us to jump directly to the desired part, rather
than traversing the entire tree and carefully tracking whether or not
we're "in the zone".
---
mime-node.c | 27 +++
notmuch-clie
In addition to simplifying the code, we'll need the notmuch_message_t*
in show_message_body shortly.
---
notmuch-client.h |2 +-
notmuch-reply.c |3 +--
notmuch-show.c |3 +--
show-message.c |3 ++-
4 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/notmuch-client.
Rename sig_attempted to verify_attempted.
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
This removes all of the MIME traversal logic from show_message_body
and leaves only its interaction with the format callbacks.
Besides isolating concerns, since traversal happens behind a trivial
interface, there is now much less code duplication in
show_message_part. Also, this uses mime_node_se
This wraps all of the complex MIME part handling in a single, simple
function that gets part N from *any* MIME object, so traversing a MIME
part tree becomes a two-line for loop. Furthermore, the MIME node
structure provides easy access to envelopes for message parts as well
as cryptographic infor
Quoth Jameson Graef Rollins on Dec 23 at 11:55 pm:
> On Fri, 23 Dec 2011 22:45:46 -0500, Austin Clements
> wrote:
> > +/* True if decryption of this part was attempted. */
> > +notmuch_bool_t decrypt_attempted;
> > +/* True if decryption of this part's child succeeded. In this
> > +
On Sat, 24 Dec 2011 00:40:34 +0400, Dmitry Kurochkin
wrote:
> Examples in documentation for `notmuch-search-line-faces' had an extra
> quote, e.g.:
>
> '(\"unread\" . '(:foreground \"green\"))
>
Pushed.
d
___
notmuch mailing list
notmuch@notmuchm
This removes all of the MIME traversal logic from show_message_body
and leaves only its interaction with the format callbacks.
Besides isolating concerns, since traversal happens behind a trivial
interface, there is now much less code duplication in
show_message_part. Also, this uses mime_node_se
This function matches how we number parts for the --part argument to
show. It will allow us to jump directly to the desired part, rather
than traversing the entire tree and carefully tracking whether or not
we're "in the zone".
---
mime-node.c | 27 +++
notmuch-clie
This wraps all of the complex MIME part handling in a single, simple
function that gets part N from *any* MIME object, so traversing a MIME
part tree becomes a two-line for loop. Furthermore, the MIME node
structure provides easy access to envelopes for message parts as well
as cryptographic infor
In addition to simplifying the code, we'll need the notmuch_message_t*
in show_message_body shortly.
---
notmuch-client.h |2 +-
notmuch-reply.c |3 +--
notmuch-show.c |3 +--
show-message.c |3 ++-
4 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/notmuch-client.
Rename sig_attempted to verify_attempted.
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins
wrote:
> Since message-ids necessarily match just a single message, there's no
> reason to do a search for the id before viewing the actual message;
> the search just becomes an extra screen to click through. Clicking on
> an id: links no
On Wed, 21 Dec 2011 23:06:50 +0100, Thomas Jost
wrote:
Non-text part: multipart/mixed
Non-text part: multipart/signed
> On Tue, 20 Dec 2011 15:20:04 +, David Edmondson wrote:
> > Cast away the result of various *write functions. Provide a default
> > value for some variables to avoid "use be
On Fri, 23 Dec 2011 23:55:34 -0800, Jameson Graef Rollins wrote:
> On Fri, 23 Dec 2011 22:45:46 -0500, Austin Clements
> wrote:
> > +/* True if decryption of this part was attempted. */
> > +notmuch_bool_t decrypt_attempted;
> > +/* True if decryption of this part's child succeeded.
On Wed, 21 Dec 2011 23:06:50 +0100, Thomas Jost wrote:
Non-text part: multipart/mixed
Non-text part: multipart/signed
> On Tue, 20 Dec 2011 15:20:04 +, David Edmondson wrote:
> > Cast away the result of various *write functions. Provide a default
> > value for some variables to avoid "use bef
Quoth Jameson Graef Rollins on Dec 23 at 11:55 pm:
> On Fri, 23 Dec 2011 22:45:46 -0500, Austin Clements wrote:
> > +/* True if decryption of this part was attempted. */
> > +notmuch_bool_t decrypt_attempted;
> > +/* True if decryption of this part's child succeeded. In this
> > +
I got some positive feedback for replacing notmuch-hello search input
with a button wich would call `notmuch-search' and read input from
minibuffer as usual. This way we do not have to maintain 2 search
interfaces and get history, tab completions and other minibuffer
features in notmuch-hello sear
Hi,
I noticed some inconsistencies in the way the bindings
treat Threads and Messages
which in my opinion should look and behave alike.
1. There is no Query.count_threads as an equivalent to
Query.count_messages, although there seems to be a function
`notmuch_query_count_threads` offered by
On Fri, 23 Dec 2011 22:45:44 -0500, Austin Clements wrote:
> This addresses Dmitry's and Jameson's review comments from
> id:"87k46572f7.fsf at gmail.com"
> id:"87liqk5dly.fsf at servo.finestructure.net"
> id:"87hb187iu6.fsf at gmail.com"
> and rebases to current master.
>
> I'd like a quic
---
emacs/notmuch-hello.el | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 0922821..821ef22 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -36,7 +36,10 @@
"Variable to store history
Reindent `notmuch-hello' function after the search history changes.
---
emacs/notmuch-hello.el | 56
1 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index ba34ac5..0922821 100644
---
There are two ways to do search in Emacs UI: search widget in
notmuch-hello buffer and `notmuch-search' function bound to "s".
Before the change, these search mechanisms used different history
lists. The patch makes notmuch-hello search use the same history list
as `notmuch-search' function.
---
Hi Ivy.
The patch looks good to me. But I think it would be very nice to have a
test for it, which would be broken at first and fixed by this patch.
Can you add it please?
Regards,
Dmitry
Hi,
I noticed some inconsistencies in the way the bindings
treat Threads and Messages
which in my opinion should look and behave alike.
1. There is no Query.count_threads as an equivalent to
Query.count_messages, although there seems to be a function
`notmuch_query_count_threads` offered by
Examples in documentation for `notmuch-search-line-faces' had an extra
quote, e.g.:
'(\"unread\" . '(:foreground \"green\"))
Which resulted in values like:
(\"unread\" quote (:foreground \"green\"))
And tons of "Invalid face reference: quote" errors in the messages
buffer.
---
emacs/notmuc
On Fri, 23 Dec 2011 23:55:34 -0800, Jameson Graef Rollins
wrote:
> On Fri, 23 Dec 2011 22:45:46 -0500, Austin Clements wrote:
> > +/* True if decryption of this part was attempted. */
> > +notmuch_bool_t decrypt_attempted;
> > +/* True if decryption of this part's child succeeded. I
40 matches
Mail list logo
