Adjusted some uncrustify variables to get closer to prevailing style:
* Label indent (for goto) relative to current indentation.
* Eegistered GMimeObject and mime_node_t being as types.
* Space after ! (not) operator.
* No space after 'stringify' (#) preprosessor token.
* No spacing change around
On Tue, 24 Jan 2012 16:14:03 +, David Edmondson wrote:
> Small changes as per Dmitry's last comments.
>
> David Edmondson (4):
> test: Don't return the result of checking for running emacs to the
> tester.
> test: Add `test_emacs_expect_t'.
> test: Add more helpers for emacs tests.
On Tue, 24 Jan 2012 12:53:40 +, David Edmondson wrote:
> Previously this logic applied only to text/plain. Allow it for other
> text/* parts as well.
> ---
LGTM.
On Tue, 24 Jan 2012 12:53:39 +, David Edmondson wrote:
> Add a regexp, `notmuch-show-part-headers-hidden' and if the
> content-type of a part matches, don't show the part header.
> ---
LGTM... (I wonder ow easy is it to write regexps in custimization
interface)
On Tue, 24 Jan 2012 12:53:38 +, David Edmondson wrote:
> Instead, allow the caller to specify some parameters for the
> button. Rework `notmuch-show-insert-part-multipart/signed' and
> `notmuch-show-insert-part-multipart/encrypted' accordingly.
> ---
LGTM.
On Mon, 23 Jan 2012 20:08:59 +0100, Xavier Maillard
wrote:
>
> I really like this too.
>
> +1
>
I appreciate your enthusiasm, but, it seems like both of these old
patches are applied to master some time ago.
You can use e.g. git shortlog --author=Dmitry to have a look.
d
On Mon, 23 Jan 2012 00:34:25 -0800, Jameson Graef Rollins wrote:
> This changes the default key bindings for the 'a' key in notmuch-show
> mode. Instead of archiving the entire thread, it now just archives
> the current message, and then advance to the next open message
>
On Mon, 23 Jan 2012 00:34:22 -0800, Jameson Graef Rollins wrote:
> This adds two new message archiving functions that parallel the thread
> archiving functions: notmuch-show-archive-message{,-then-next}. The
> former also takes a prefix argument to unarchive the message (ie. put
> back in
On Mon, 23 Jan 2012 18:33:10 -0500, Austin Clements wrote:
> This callback is the gateway to the new mime_node_t-based formatters.
> This maintains backwards compatibility so the formatters can be
> transitioned one at a time. Once all formatters are converted, the
> formatter structure can be
On Tue, 24 Jan 2012 16:14:03 +, David Edmondson wrote:
> Small changes as per Dmitry's last comments.
>
LGTM
Regards,
Dmitry
> David Edmondson (4):
> test: Don't return the result of checking for running emacs to the
> tester.
> test: Add `test_emacs_expect_t'.
> test: Add
I just received an email in RTL script and it was rendered incorrectly
in the emacs interface. Does anyone know what to do about this?
On Mon, 23 Jan 2012 18:05:46 +, David Edmondson wrote:
> ---
>
> Split out from the tests and re-factored.
>
> test/test-lib.el | 22 ++
> 1 files changed, 22 insertions(+), 0 deletions(-)
>
> diff --git a/test/test-lib.el b/test/test-lib.el
> index 96752f0..c4a5db4
On Mon, 23 Jan 2012 18:05:47 +, David Edmondson wrote:
> ---
>
> Anticipate the failure of test 3.
>
LGTM
Regards,
Dmitry
> test/emacs-address-cleaning.el | 29 +
> test/emacs-address-cleaning.sh | 19 +++
> test/notmuch-test
nature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120124/1d9e0cd5/attachment.pgp>
On Mon, 23 Jan 2012 18:05:45 +, David Edmondson wrote:
> Add a new test function to allow simpler testing of emacs
> functionality.
>
> `test_emacs_expect_t' takes one argument - a lisp expression to
> evaluate. The test passes if the expression returns `t', otherwise it
> fails and the
On Mon, 23 Jan 2012 18:05:44 +, David Edmondson wrote:
> When checking for a running emacs, test_emacs evaluates the empty list
> '()'. This returns 'nil' when emacs is running, which is then
> prepended to the actual test result. Given that it is not part of the
> actual test output the test
e-start cite-end 'face 'message-cited-text)
> > + ;; Ensure that the next line doesn't inherit our face.
> > + (put-text-property (1- cite-end) cite-end 'rear-nonsticky '(face))
> > (when (> cite-lines (+ notmuch-wash-citation-lines-prefix
> > notmuch-wash-citation-lines-suffix
> > 1))
> > @@ -205,7 +207,9 @@ insert before the button, probably for indentation."
> > (sig-end-marker (make-marker)))
> > (set-marker sig-start-marker sig-start)
> > (set-marker sig-end-marker (point-max))
> > - (overlay-put (make-overlay sig-start-marker sig-end-marker) 'face
> > 'message-cited-text)
> > + (put-text-property sig-start-marker sig-end-marker 'face
> > 'message-cited-text)
> > + ;; Ensure that the next line doesn't inherit our face.
> > + (put-text-property (1- sig-end-marker) sig-end-marker
> > 'rear-nonsticky '(face))
> > (notmuch-wash-region-to-button
> >msg sig-start-marker sig-end-marker
> >"signature" "\n"))
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120124/9f6b2e82/attachment-0001.pgp>
nctionality, so I'm dying to see
the patch!)
micah
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120124/6f2676b0/attachment.pgp>
---
test/emacs-address-cleaning.el | 29 +
test/emacs-address-cleaning.sh | 19 +++
test/notmuch-test |1 +
3 files changed, 49 insertions(+), 0 deletions(-)
create mode 100644 test/emacs-address-cleaning.el
create mode 100755
---
test/test-lib.el | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.el b/test/test-lib.el
index 96752f0..bc75f06 100644
--- a/test/test-lib.el
+++ b/test/test-lib.el
@@ -20,6 +20,8 @@
;;
;; Authors: Dmitry Kurochkin
+(require
When checking for a running emacs, test_emacs evaluates the empty list
'()'. This returns 'nil' when emacs is running, which is then
prepended to the actual test result. Given that it is not part of the
actual test output the test harness can incorrectly report test
failure (or success).
---
Small changes as per Dmitry's last comments.
David Edmondson (4):
test: Don't return the result of checking for running emacs to the
tester.
test: Add `test_emacs_expect_t'.
test: Add more helpers for emacs tests.
test: Add address cleaning tests.
test/README|
- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120124/cc43b39a/attachment.pgp>
---
emacs/notmuch-show.el |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 4de552d..a4f83ee 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -1399,7 +1399,7 @@ buffer."
(goto-char
This changes the default key bindings for the 'a' key in notmuch-show
mode. Instead of archiving the entire thread, it now just archives
the current message, and then advance to the next open message
(archive-message-then-next). 'A' is now bound to the previous
archive-thread-then-next function.
This will allow for keybindings that achieve a smoother message
processing flow by reducing the number of key presses needed for most
common operations.
---
emacs/notmuch-show.el | 27 +++
1 files changed, 19 insertions(+), 8 deletions(-)
diff --git
This adds two new message archiving functions that parallel the thread
archiving functions: notmuch-show-archive-message{,-then-next}. The
former also takes a prefix argument to unarchive the message (ie. put
back in inbox).
---
emacs/notmuch-show.el | 17 +
1 files changed, 17
This function is now just for archiving the current thread. A new
function is created to archive-then-next. The 'a' key binding is
updated accordingly.
This will allow people to bind to the simple thread archiving function
without the extra navigation. The archive-thread function now also
Brake up notmuch-show-archive-thread-internal into two new functions:
notmuch-show-tag-thread-internal: applies a tag to all messages in
thread. If option remove flag is t, tags will be removed instead of
added.
notmuch-show-next-thread: moves to the next thread in the search
result. If given
We should always use the dedicated search mode navigation functions,
in case navigation mechanics change down the line.
---
emacs/notmuch-show.el |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index e6a5b31..a0045fc 100644
Final v3 rework of this patch series:
* reworked pop-at-end patch to be much simpler (which also happens to
get around other issues with this patch that dme had)
* added pop-at-end function to both show-next-...message functions
* fixed call to search-next-thread in show-next-thread function
*
id, can you please check for
> trailing white spaces and clean them?
Yes.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch
.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120124/6b3b9edc/attachment.pgp>
Previously this logic applied only to text/plain. Allow it for other
text/* parts as well.
---
emacs/notmuch-show.el |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index a0a2873..23bf1f4 100644
---
Add a regexp, `notmuch-show-part-headers-hidden' and if the
content-type of a part matches, don't show the part header.
---
emacs/notmuch-show.el | 43 ---
1 files changed, 28 insertions(+), 15 deletions(-)
diff --git a/emacs/notmuch-show.el
Instead, allow the caller to specify some parameters for the
button. Rework `notmuch-show-insert-part-multipart/signed' and
`notmuch-show-insert-part-multipart/encrypted' accordingly.
---
emacs/notmuch-show.el | 86 +---
1 files changed, 45
Rebased on top of the recent button related changes from Mark.
[PATCH 1/3] emacs: Don't return the button from
[PATCH 2/3] emacs: Optionally hide some part headers.
[PATCH 3/3] emacs: Don't insert a part header if it's the first part
L:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120124/3ab2fc6b/attachment-0001.pgp>
Indentation now uses tabs where possible.
---
...hread-maildir-storage-with-fourfold-indentation |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git
a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation
Except for where invisibility is involved, replace the use of overlays
in `notmuch-show-mode' with text properties, which are more efficient
and can be merged together more effectively.
---
emacs/notmuch-show.el | 66 +++-
emacs/notmuch-wash.el |8
In preparation for changes to support showing and hiding MIME parts on
the fly (general parts, choosing amongst multipart/alternative and
show updated signing/encryption status without redisplay) I'm trying
to clean up some of the `notmuch-show-mode' code. This patch is part
of that, though it
On Mon, 23 Jan 2012 21:45:21 -0500, Austin Clements wrote:
> The overall structure of this series looks great. There's obviously a
> lot of clean up to do, but I'll reply with a few high-level comments.
>
> Quoth Mark Walters on Jan 24 at 1:18 am:
> > Form excluded doc_ids set and use that to
LGTM other than one very minor nit, though I pretty reliably make
fence post errors when dealing with text properties, so perhaps
somebody else should check that.
Quoth David Edmondson on Jan 24 at 11:36 am:
> Except for where invisibility is involved, replace the use of overlays
> in
On Mon, 23 Jan 2012 18:33:10 -0500, Austin Clements wrote:
> This callback is the gateway to the new mime_node_t-based formatters.
> This maintains backwards compatibility so the formatters can be
> transitioned one at a time. Once all formatters are converted, the
> formatter structure can be
On Mon, 23 Jan 2012 18:33:09 -0500, Austin Clements wrote:
> This makes the part numbers readily accessible to formatters.
> Hierarchical part numbering would be a more natural and efficient fit
> for MIME and may be the way to go in the future, but depth-first
> numbering maintains compatibility
---
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120124/16b80592/attachment.pgp>
Quoth Dmitry Kurochkin on Jan 24 at 3:48 am:
> Changes:
>
> v3:
>
> * rebased on current master
LGTM.
`notmuch-show-stash-gmane' stashes a URI for the current message at
Gmane, presuming that Gmane has a copy of the message with the same
Message-Id.
`notmuch-show-stash-gmane-and-go' both stashes the message and opens
the relevant page in the configured browser.
Add the relevant test for
On Wed, 11 Jan 2012 20:49:33 -0500, Austin Clements wrote:
> This makes the text formatter take advantage of the new code
> structure. The previously duplicated header logic is now unified,
> several things that we used to compute repeatedly across different
> callbacks are now computed once,
On Wed, 11 Jan 2012 20:49:32 -0500, Austin Clements wrote:
> This is all code movement and a smidgen of glue. This moves the
> existing text formatter code into one self-recursive function, but
> doesn't change any of the logic. The next patch will actually take
> advantage of what the new
`notmuch-hello-search' uses `notmuch-search' function but refreshes
notmuch-hello buffer when the search buffer is closed.
---
emacs/notmuch-hello.el |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 004287a..64011d4
There are two ways to do search in Emacs UI: search widget in
notmuch-hello buffer and `notmuch-search' function bound to "s".
Before the change, these search mechanisms used different history
lists. The patch makes notmuch-hello search use the same history list
as `notmuch-search' function.
---
Before the change, "s" in notmuch-hello buffer would jump to the
search box. The patch changes the binding to `notmuch-search' which
is consistent with all other notmuch buffers.
---
emacs/notmuch-hello.el | 19 ++-
Changes:
v3:
* rebased on current master
v2:
* expected results changes for tests moved from patch 2 to 1 where it belong
Regards,
Dmitry
On Mon, 23 Jan 2012 18:33:10 -0500, Austin Clements wrote:
> This callback is the gateway to the new mime_node_t-based formatters.
> This maintains backwards compatibility so the formatters can be
> transitioned one at a time. Once all formatters are converted, the
> formatter structure can be
On Mon, 23 Jan 2012 18:33:09 -0500, Austin Clements wrote:
> This makes the part numbers readily accessible to formatters.
> Hierarchical part numbering would be a more natural and efficient fit
> for MIME and may be the way to go in the future, but depth-first
> numbering maintains compatibility
Hi Daniel.
There are some trailing whitespaces in the tests.
Also, please consider moving the hello sections tests to a separate file
(emacs-hello-sections, perhaps?). I am worried that test/emacs file
becomes too big. And we will probably add more notmuch-hello
section-related tests in the
On Sun, 22 Jan 2012 21:31:13 -0500, Austin Clements wrote:
> This callback is the gateway to the new mime_node_t-based formatters.
> This maintains backwards compatibility so the formatters can be
> transitioned one at a time. Once all formatters are converted, the
> formatter structure can be
On Sun, 22 Jan 2012 21:31:11 -0500, Austin Clements wrote:
> This makes the part numbers readily accessible to formatters.
> Hierarchical part numbering would be a more natural and efficient fit
> for MIME and may be the way to go in the future, but depth-first
> numbering maintains compatibility
Make notmuch-search.c respect the NOTMUCH_MESSAGE_FLAG_EXCLUDED. All tests
should pass: i.e., the behaviour should be the same as before the
series.
---
notmuch-search.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/notmuch-search.c b/notmuch-search.c
index
Add the actual NOTMUCH_MESSAGE_FLAG_EXCLUDED flag.
---
lib/notmuch-private.h |1 +
lib/notmuch.h |3 ++-
lib/query.cc | 11 +++
lib/thread.cc | 14 ++
4 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/lib/notmuch-private.h
Form excluded doc_ids set and use that to exclude messages.
Should be no functional change.
---
lib/notmuch-private.h |1 +
lib/query.cc | 28 ++--
2 files changed, 27 insertions(+), 2 deletions(-)
diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
Slightly refactor the exclude code to give the callers access to the
exclude query itself. There should be no functional change.
---
lib/query.cc | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/lib/query.cc b/lib/query.cc
index
On Sun, 22 Jan 2012 20:52:22 -0500, Austin Clements wrote:
> Quoth Mark Walters on Jan 23 at 1:13 am:
> > On Sun, 22 Jan 2012 13:16:09 -0500, Austin Clements
> > wrote:
> > > Quoth myself on Jan 20 at 12:18 pm:
> > > > Quoth Mark Walters on Jan 20 at 12:10 am:
> > > > >
> > > > > Ok Having
On Mon, 23 Jan 2012 15:26:20 +0100, Florian Friesdorf f...@chaoflow.net wrote:
On Tue, 17 Jan 2012 23:44:40 +0100, Rodney Lorrimar d...@rodney.id.au wrote:
Debugger entered--Lisp error: (void-variable gnus-inhibit-images)
mm-shr((#buffer *temp* (text/html) nil nil nil nil nil nil))
On Mon, 19 Dec 2011 23:38:36 -0700, Chris Gray chrismg...@gmail.com wrote:
+;; Nonsense required to have the new gnus `shr' HTML display code
+;; work.
+(defvar gnus-summary-buffer)
+(defvar gnus-inhibit-images)
I believe that gnus-inhibit-images is defined in gnus-art.el. Perhaps
Series LGTM.
Quoth Pieter Praet on Jan 23 at 6:41 am:
---
Added note re new configurations, as suggested by Austin:
id:20120123044108.gs16...@mit.edu
NEWS | 19 +++
1 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
index 2c2d9e9..2acdce5
LGTM.
Regards,
Dmitry
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
On Thu, 19 Jan 2012 12:54:02 +, David Edmondson d...@dme.org wrote:
Add a new test function to allow simpler testing of emacs
functionality.
`test_emacs_expect_t' takes one argument - a list expression to
evaluate. The test passes if the expression returns `t', otherwise it
fails and
On Thu, 19 Jan 2012 12:54:03 +, David Edmondson d...@dme.org wrote:
Including some more test framework in test-lib.el.
IMO test-lib.el changes should be in a separate patch.
---
test/emacs-address-cleaning.el | 29 +
test/emacs-address-cleaning.sh | 12
On Mon, 23 Jan 2012 11:02:04 +, David Edmondson d...@dme.org wrote:
On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
-(defun notmuch-show-next-open-message ()
+(defun notmuch-show-next-open-message (optional pop-at-end)
Show the next
---
Split out from the tests and re-factored.
test/test-lib.el | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.el b/test/test-lib.el
index 96752f0..c4a5db4 100644
--- a/test/test-lib.el
+++ b/test/test-lib.el
@@ -20,6 +20,8 @@
;;
;;
On Mon, 23 Jan 2012 09:39:30 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
On Mon, 23 Jan 2012 11:02:04 +, David Edmondson d...@dme.org wrote:
On Mon, 23 Jan 2012 00:34:23 -0800, Jameson Graef Rollins
jroll...@finestructure.net wrote:
-(defun
When checking for a running emacs, test_emacs evaluates the empty list
'()'. This returns 'nil' when emacs is running, which is then
prepended to the actual test result. Given that it is not part of the
actual test output the test harness can incorrectly report test
failure (or success).
---
---
Anticipate the failure of test 3.
test/emacs-address-cleaning.el | 29 +
test/emacs-address-cleaning.sh | 19 +++
test/notmuch-test |1 +
3 files changed, 49 insertions(+), 0 deletions(-)
create mode 100644
On Sun, 22 Jan 2012 21:31:11 -0500, Austin Clements amdra...@mit.edu wrote:
This makes the part numbers readily accessible to formatters.
Hierarchical part numbering would be a more natural and efficient fit
for MIME and may be the way to go in the future, but depth-first
numbering maintains
On Mon, 23 Jan 2012 17:55:14 +, David Edmondson d...@dme.org wrote:
On that basis, I hope no-one will complain if I fix them as a 'drive by'
during another change...
Hrm. I don't think that follows. Unless the patch is already touching
that code, I would really prefer we continue to
On Tue, 28 Jun 2011 08:45:09 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
Using `setq' for setting variables in Emacs tests affect other
tests that may run in the same Emacs environment. Currently it
works because each test is run in a separate Emacs instance. But
in the future
On Tue, 28 Jun 2011 08:45:11 +0400, Dmitry Kurochkin
dmitry.kuroch...@gmail.com wrote:
Before the change, every Emacs test ran in a separate Emacs
instance. Starting Emacs many times wastes considerable time and
it gets worse as the test suite grows. The patch solves this by
using a single
This makes the part numbers readily accessible to formatters.
Hierarchical part numbering would be a more natural and efficient fit
for MIME and may be the way to go in the future, but depth-first
numbering maintains compatibility with what we currently do.
---
mime-node.c | 36
Fix a silly comment mistake pointed out by Jani
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
This callback is the gateway to the new mime_node_t-based formatters.
This maintains backwards compatibility so the formatters can be
transitioned one at a time. Once all formatters are converted, the
formatter structure can be reduced to only message_set_{start,sep,end}
and part, most of
On Mon, 23 Jan 2012 18:33:09 -0500, Austin Clements amdra...@mit.edu wrote:
This makes the part numbers readily accessible to formatters.
Hierarchical part numbering would be a more natural and efficient fit
for MIME and may be the way to go in the future, but depth-first
numbering maintains
On Mon, 23 Jan 2012 18:33:10 -0500, Austin Clements amdra...@mit.edu wrote:
This callback is the gateway to the new mime_node_t-based formatters.
This maintains backwards compatibility so the formatters can be
transitioned one at a time. Once all formatters are converted, the
formatter
Changes:
v3:
* rebased on current master
v2:
* expected results changes for tests moved from patch 2 to 1 where it belong
Regards,
Dmitry
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Before the change, s in notmuch-hello buffer would jump to the
search box. The patch changes the binding to `notmuch-search' which
is consistent with all other notmuch buffers.
---
emacs/notmuch-hello.el | 19 ++-
There are two ways to do search in Emacs UI: search widget in
notmuch-hello buffer and `notmuch-search' function bound to s.
Before the change, these search mechanisms used different history
lists. The patch makes notmuch-hello search use the same history list
as `notmuch-search' function.
---
`notmuch-hello-search' uses `notmuch-search' function but refreshes
notmuch-hello buffer when the search buffer is closed.
---
emacs/notmuch-hello.el |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 004287a..64011d4
On Sun, 22 Jan 2012 20:52:22 -0500, Austin Clements amdra...@mit.edu wrote:
Quoth Mark Walters on Jan 23 at 1:13 am:
On Sun, 22 Jan 2012 13:16:09 -0500, Austin Clements amdra...@mit.edu
wrote:
Quoth myself on Jan 20 at 12:18 pm:
Quoth Mark Walters on Jan 20 at 12:10 am:
Quoth Mark Walters on Jan 24 at 1:05 am:
On Sun, 22 Jan 2012 20:52:22 -0500, Austin Clements amdra...@mit.edu wrote:
Quoth Mark Walters on Jan 23 at 1:13 am:
On Sun, 22 Jan 2012 13:16:09 -0500, Austin Clements amdra...@mit.edu
wrote:
Quoth myself on Jan 20 at 12:18 pm:
Quoth
Slightly refactor the exclude code to give the callers access to the
exclude query itself. There should be no functional change.
---
lib/query.cc | 29 +++--
1 files changed, 19 insertions(+), 10 deletions(-)
diff --git a/lib/query.cc b/lib/query.cc
index
Form excluded doc_ids set and use that to exclude messages.
Should be no functional change.
---
lib/notmuch-private.h |1 +
lib/query.cc | 28 ++--
2 files changed, 27 insertions(+), 2 deletions(-)
diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
Add the actual NOTMUCH_MESSAGE_FLAG_EXCLUDED flag.
---
lib/notmuch-private.h |1 +
lib/notmuch.h |3 ++-
lib/query.cc | 11 +++
lib/thread.cc | 14 ++
4 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/lib/notmuch-private.h
On Wed, 11 Jan 2012 20:49:32 -0500, Austin Clements amdra...@mit.edu wrote:
This is all code movement and a smidgen of glue. This moves the
existing text formatter code into one self-recursive function, but
doesn't change any of the logic. The next patch will actually take
advantage of what
On Wed, 11 Jan 2012 20:49:33 -0500, Austin Clements amdra...@mit.edu wrote:
This makes the text formatter take advantage of the new code
structure. The previously duplicated header logic is now unified,
several things that we used to compute repeatedly across different
callbacks are now
The overall structure of this series looks great. There's obviously a
lot of clean up to do, but I'll reply with a few high-level comments.
Quoth Mark Walters on Jan 24 at 1:18 am:
Form excluded doc_ids set and use that to exclude messages.
Should be no functional change.
---
Quoth Mark Walters on Jan 24 at 1:18 am:
Add the actual NOTMUCH_MESSAGE_FLAG_EXCLUDED flag.
---
lib/notmuch-private.h |1 +
lib/notmuch.h |3 ++-
lib/query.cc | 11 +++
lib/thread.cc | 14 ++
4 files changed, 20 insertions(+), 9
On Mon, 23 Jan 2012 18:33:09 -0500, Austin Clements amdra...@mit.edu wrote:
This makes the part numbers readily accessible to formatters.
Hierarchical part numbering would be a more natural and efficient fit
for MIME and may be the way to go in the future, but depth-first
numbering maintains
On Mon, 23 Jan 2012 18:33:10 -0500, Austin Clements amdra...@mit.edu wrote:
This callback is the gateway to the new mime_node_t-based formatters.
This maintains backwards compatibility so the formatters can be
transitioned one at a time. Once all formatters are converted, the
formatter
`notmuch-show-stash-gmane' stashes a URI for the current message at
Gmane, presuming that Gmane has a copy of the message with the same
Message-Id.
`notmuch-show-stash-gmane-and-go' both stashes the message and opens
the relevant page in the configured browser.
Add the relevant test for
1 - 100 of 146 matches
Mail list logo
