[PATCH] emacs: get rid of trailing spaces in notmuch-hello view

2012-03-09 Thread Dmitry Kurochkin
This patch removes trailing spaces in notmuch-hello view. A side effect of this change is that tag/query buttons no longer include a space at the end. This means that pressing RET when the point is at the first character after the tag/query button no longer works (note that this is the standard b

[PATCH v2 2/2] test: use subtest name for generated message subject by default

2012-03-09 Thread Dmitry Kurochkin
Before the change, messages generated by generate_message() used "Test message #N" for default subject where N is the generated messages counter. Since message subject is commonly present in expected results, there is a chance of breaking other tests when a new generate_message() call is added. T

[PATCH v2 1/2] test: remove "Generate some messages" test from raw

2012-03-09 Thread Dmitry Kurochkin
Before the change, the first subtest in raw format tests just generated messages and checked that they are added successfully. This is not really a raw format test, it is creating of environment required for other subtests to run. The patch removes the first subtest from raw and replaces it with

[PATCH v2 0/2] test: use subtest name for generated message subject

2012-03-09 Thread Dmitry Kurochkin
Changes in v2: * rebase on master Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v6] emacs: Use the new JSON reply format and message-cite-original

2012-03-09 Thread Jani Nikula
On Tue, 21 Feb 2012 23:46:39 -0700, Adam Wolfe Gordon wrote: > Use the new JSON reply format to create replies in emacs. Quote HTML > parts nicely by using mm-display-part to turn them into displayable > text, then quoting them with message-cite-original. This is very > useful for users who regul

Re: [PATCH v6 05/10] reply: Add a JSON reply format.

2012-03-09 Thread Jani Nikula
On Tue, 21 Feb 2012 23:46:34 -0700, Adam Wolfe Gordon wrote: > This new JSON format for replies includes headers generated for a > reply message as well as the headers of the original message. Using > this data, a client can intelligently create a reply. For example, the > emacs client will be a

Re: [PATCH v6 03/10] reply: Require that only one message is returned

2012-03-09 Thread Jani Nikula
On Tue, 21 Feb 2012 23:46:32 -0700, Adam Wolfe Gordon wrote: > As the semantics of replying to multiple messages have not yet been > defined well, make notmuch reply require that the search given returns > only a single message. Is there any real reason, apart from consistency between --format=d

[PATCH 3/3] cli: allow switching off entire thread mode in notmuch show json format

2012-03-09 Thread Jani Nikula
Previously --format=json implied --entire-thread with no way to switch it off. Add support for --entire-thread=false usable with json format. Signed-off-by: Jani Nikula --- notmuch-show.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/notmuch-show.c b/notmuc

[PATCH 2/3] command-line-arguments: support keyword arguments with default value

2012-03-09 Thread Jani Nikula
Add NOTMUCH_OPT_KEYWORD_DEFAULT to support plain --arg in addition to --arg=value. The value to use is the first in the list of keywords. Signed-off-by: Jani Nikula --- command-line-arguments.c | 11 ++- command-line-arguments.h |1 + 2 files changed, 11 insertions(+), 1 deletions(

[PATCH 1/3] command-line-arguments: allow true and false keywords for booleans

2012-03-09 Thread Jani Nikula
Add support for --arg=true and --arg=false for NOTMUCH_OPT_BOOLEAN arguments to be able to disable a boolean argument. Plain --arg remains unchanged, meaning true. Signed-off-by: Jani Nikula --- command-line-arguments.c | 36 ++-- 1 files changed, 30 insertions(

[PATCH 0/3] argument parsing additions

2012-03-09 Thread Jani Nikula
Hi Mark - I'm not sure which is worse, criticizing or rewriting other people's patches. I already did the former, and now I'm doing the latter. Apologies for both. I didn't really mean to write these patches, but it turned out to be more fun writing a proper reply in C than in English. Patch 1 ad

[PATCH] mime_node_open: check if the file is in mbox format, and inform gmime.

2012-03-09 Thread Tomi Ollila
On Thu, 8 Mar 2012 17:48:15 -0400, David Bremner wrote: > From: David Bremner > > It seems that it has always been an error to try to parse an mbox > format file with gmime without calling g_mime_parser_set_scan_from. At least for the time being I think we should apply http://en.wikipedia.org/

[PATCH 2/2] emacs: fix off-by-one error in notmuch-hello column alignment

2012-03-09 Thread Dmitry Kurochkin
Expected results for few tests are fixed, the relevant test is unmarked broken. --- emacs/notmuch-hello.el |2 +- test/emacs-hello |1 - .../notmuch-hello-new-section |2 +- .../notmuch-hello-section-wit

[PATCH 1/2] test: add broken test for long names in Emacs notmuch-hello view

2012-03-09 Thread Dmitry Kurochkin
Currently, the column alignment in Emacs notmuch-hello is broken for tags/queries with long names. --- test/emacs-hello |9 + .../emacs.expected-output/notmuch-hello-long-names | 18 ++ 2 files changed, 27 insertions(+), 0 deletions(-

[PATCH] mime_node_open: skip envelope from lines at the start of messages

2012-03-09 Thread Daniel Kahn Gillmor
On 03/09/2012 08:56 AM, David Bremner wrote: > Some MDAs such as procmail (in MH mode), and exim (doing local > delivery in some configurations of the appendfile transport) add a > line to the front of a message with "From " followed by envelope > sender. Since this is not a proper RFC822 header f

[PATCH 2/2] test: use subtest name for generated message subject by default

2012-03-09 Thread Jani Nikula
Hi Dmitry, I tagged this notmuch::stale as it no longer cleanly applies to master. BR, Jani. On Tue, 31 Jan 2012 02:06:35 +0400, Dmitry Kurochkin wrote: > Before the change, messages generated by generate_message() used "Test > message #N" for default subject where N is the generated messages >

[PATCH] mime_node_open: skip envelope from lines at the start of messages

2012-03-09 Thread David Bremner
From: David Bremner Some MDAs such as procmail (in MH mode), and exim (doing local delivery in some configurations of the appendfile transport) add a line to the front of a message with "From " followed by envelope sender. Since this is not a proper RFC822 header field, gmime (at least since ver

[PATCH] mime_node_open: skip envelope from lines at the start of messages

2012-03-09 Thread David Bremner
From: David Bremner Some MDAs such as procmail (in MH mode), and exim (doing local delivery in some configurations of the appendfile transport) add a line to the front of a message with "From " followed by envelope sender. Since this is not a proper RFC822 header field, gmime (at least since ver

Re: [PATCH] mime_node_open: skip envelope from lines at the start of messages

2012-03-09 Thread Daniel Kahn Gillmor
On 03/09/2012 08:56 AM, David Bremner wrote: Some MDAs such as procmail (in MH mode), and exim (doing local delivery in some configurations of the appendfile transport) add a line to the front of a message with "From " followed by envelope sender. Since this is not a proper RFC822 header field,

[PATCH] mime_node_open: skip envelope from lines at the start of messages

2012-03-09 Thread David Bremner
From: David Bremner Some MDAs such as procmail (in MH mode), and exim (doing local delivery in some configurations of the appendfile transport) add a line to the front of a message with "From " followed by envelope sender. Since this is not a proper RFC822 header field, gmime (at least since ver

[PATCH] mime_node_open: skip envelope from lines at the start of messages

2012-03-09 Thread David Bremner
From: David Bremner Some MDAs such as procmail (in MH mode), and exim (doing local delivery in some configurations of the appendfile transport) add a line to the front of a message with "From " followed by envelope sender. Since this is not a proper RFC822 header field, gmime (at least since ver

[PATCH 0/2] cli: Parsing. Add option NOTMUCH_OPT_INT_OR_BOOLEAN

2012-03-09 Thread Mark Walters
Hi On Fri, 09 Mar 2012 02:48:35 +0200, Jani Nikula wrote: > On Thu, 8 Mar 2012 22:15:42 +, Mark Walters gmail.com> wrote: > > The first patch adds a new command line parsing option > > NOTMUCH_OPT_INT_OR_BOOLEAN for command line parsing which accepts > > --verbose=3 and --verbose with the

Re: [PATCH] mime_node_open: check if the file is in mbox format, and inform gmime.

2012-03-09 Thread Tomi Ollila
On Thu, 8 Mar 2012 17:48:15 -0400, David Bremner wrote: > From: David Bremner > > It seems that it has always been an error to try to parse an mbox > format file with gmime without calling g_mime_parser_set_scan_from. At least for the time being I think we should apply http://en.wikipedia.org/

[PATCH 0/2] cli: Parsing. Add option NOTMUCH_OPT_INT_OR_BOOLEAN

2012-03-09 Thread Jani Nikula
On Thu, 8 Mar 2012 22:15:42 +, Mark Walters wrote: > The first patch adds a new command line parsing option > NOTMUCH_OPT_INT_OR_BOOLEAN for command line parsing which accepts > --verbose=3 and --verbose with the latter setting verbose to 1. It > also allows --verbose=0 so (with a little cal

Re: [PATCH 2/2] test: use subtest name for generated message subject by default

2012-03-09 Thread Jani Nikula
Hi Dmitry, I tagged this notmuch::stale as it no longer cleanly applies to master. BR, Jani. On Tue, 31 Jan 2012 02:06:35 +0400, Dmitry Kurochkin wrote: > Before the change, messages generated by generate_message() used "Test > message #N" for default subject where N is the generated messages

[PATCH v6 02/10] reply: Factor out reply creation

2012-03-09 Thread Jani Nikula
On Tue, 21 Feb 2012 23:46:31 -0700, Adam Wolfe Gordon wrote: > Factor out the creation of a reply message based on an original > message so it can be shared by different reply formats. > --- > notmuch-reply.c | 101 +++--- > 1 files changed, 58 in