Dreaming of tag-based e-mailing

2012-04-06 Thread Fernando H. F. Botelho
Hi everyone, I use F123, which is an Ubuntu-based distribution developed for use by the blind. I have been researching SugarCRM and other applications looking for tag-based mailing without success and when I heard of Mutt and NotMuch I became hopeful again. Please tell me if this would be poss

Dreaming of tag-based e-mailing

2012-04-06 Thread Fernando H. F. Botelho
Hi everyone, I use F123, which is an Ubuntu-based distribution developed for use by the blind. I have been researching SugarCRM and other applications looking for tag-based mailing without success and when I heard of Mutt and NotMuch I became hopeful again. Please tell me if this would be po

[PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)

2012-04-06 Thread Mark Walters
On Fri, 06 Apr 2012, Jameson Graef Rollins wrote: > On Fri, Apr 06 2012, Mark Walters wrote: >> This is the latest version of the patch series (previous version at [1]). >> I think this version fixes all the problems raised by Austin in his review. > > Tested and reviewed and LGTM. > > Unfortuna

Message deletion wisdom

2012-04-06 Thread Mark Anderson
On Thu, 5 Apr 2012 12:20:43 -0400, Antoine Beaupr? wrote: > Finally, I want to voice that I feel a "delete" key, even if it doesn't > delete mails, seems like an important part of a mail user > agent. Archiving mail is one thing, but for the love and respect of > sysadmins and the infrastructure

[PATCH v3 6/6] emacs: make show set --exclude=false

2012-04-06 Thread Mark Walters
Show has to set --exclude=false to deal with cases where it is asked to show a single excluded message. It uses JSON so it can easily pass the exclude information to the user. --- emacs/notmuch-show.el |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-show

[PATCH v3 5/6] cli: move show to the new --exclude= option naming scheme.

2012-04-06 Thread Mark Walters
This moves notmuch show to the --exclude=(true|false) naming scheme. When exclude=false show returns all threads that match including those that only match in an excluded message. The excluded messages are flagged. When exclude=true the behaviour depends on whether --entire-thread is set. If it is

[PATCH v3 4/6] test: add some exclude tests

2012-04-06 Thread Mark Walters
Systematically test the exclude options for search. Also move the search existing exclude tests into the new test. There is some overlap between the two sets of tests but many of the existing ones are there because they triggered bugs in the past so I have kept them to ensure coverage. --- test/no

[PATCH v3 3/6] cli: move search to the new --exclude= naming scheme.

2012-04-06 Thread Mark Walters
This commit replaces the --no-exclude option with a --exclude=(true|false|flag) option. The default is to omit the excluded messages. The flag option only makes sense if output=summary (as otherwise there is nowhere to print the flag). In summary output exclude=false and exclude=flag give almost i

[PATCH v3 2/6] cli: move count to the new --exclude=(true|false|flag) naming scheme.

2012-04-06 Thread Mark Walters
Move the option --no-exclude to the --exclude= scheme. Since there is no way to flag messages only true and false are implemented. Note that, for consistency with other commands, this is implemented as a keyword option rather than a boolean option. --- man/man1/notmuch-count.1 |5 +++-- notmuc

[PATCH v3 1/6] lib: change default for notmuch_query_set_omit_excluded

2012-04-06 Thread Mark Walters
--- lib/notmuch.h | 23 ++- lib/query.cc | 10 +- 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/lib/notmuch.h b/lib/notmuch.h index babd208..673c423 100644 --- a/lib/notmuch.h +++ b/lib/notmuch.h @@ -449,12 +449,25 @@ typedef enum { const char *

[PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)

2012-04-06 Thread Mark Walters
This is the latest version of the patch series (previous version at [1]). I think this version fixes all the problems raised by Austin in his review. In particular it rephrases the documentation comment for notmuch_query_set_omit_excluded_messages in notmuch.h, and renames the function t

Re: Message deletion wisdom

2012-04-06 Thread Mark Anderson
On Thu, 5 Apr 2012 12:20:43 -0400, Antoine Beaupré wrote: > Finally, I want to voice that I feel a "delete" key, even if it doesn't > delete mails, seems like an important part of a mail user > agent. Archiving mail is one thing, but for the love and respect of > sysadmins and the infrastructure

[PATCH] emacs: do not modify the alist passed to notmuch-sort-saved-searches

2012-04-06 Thread David Bremner
Jani Nikula writes: > Sort modifies its input as a side effect. Pass it a copy in > notmuch-sort-saved-searches to not modify the notmuch-saved-searches > alist. Pushed. d

[PATCH] configure: change gmime version in help message to 2.6

2012-04-06 Thread David Bremner
David Bremner writes: > > Tomi's second patch looks fine to me, and I promoted it to pushable. I > also noticed this minor issue with the help message. I have pushed Tomi's two patches, and my 1 followup. d

[PATCH v3 5/5] man: Document 'config list' command

2012-04-06 Thread Peter Wang
Document the 'config list' command and its output. --- man/man1/notmuch-config.1 | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/man/man1/notmuch-config.1 b/man/man1/notmuch-config.1 index 395cb9c..a55dbef 100644 --- a/man/man1/notmuch-config.1 +++ b/man/man1

[PATCH v3 4/5] config: Add 'config list' command

2012-04-06 Thread Peter Wang
Add a command to list all configuration items with their associated values. One use is as follows: a MUA may prefer to store data in a central notmuch configuration file so that the data is accessible across different machines, e.g. an addressbook. The list command helps to implement features suc

[PATCH v3 3/5] test: Add broken test for 'config list'

2012-04-06 Thread Peter Wang
Proposed functionality. --- test/config | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/test/config b/test/config index 75f662d..cce2abc 100755 --- a/test/config +++ b/test/config @@ -22,4 +22,20 @@ xxx yyy yyy zzz zzz" +test_begin_subtest "List all item

[PATCH v3 2/5] test: Add tests for 'config' command

2012-04-06 Thread Peter Wang
Start a new test script. --- test/config | 25 + test/notmuch-test |1 + 2 files changed, 26 insertions(+), 0 deletions(-) create mode 100755 test/config diff --git a/test/config b/test/config new file mode 100755 index 000..75f662d --- /dev/null +++ b/tes

[PATCH v3 1/5] config: Fix free in 'config get' implementation.

2012-04-06 Thread Peter Wang
The array returned by g_key_file_get_string_list() should be freed with g_strfreev(), not free(). --- notmuch-config.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/notmuch-config.c b/notmuch-config.c index e9b2750..85fc774 100644 --- a/notmuch-config.c +++ b/notmuch-co

[PATCH v3 0/5] Add 'config list' command

2012-04-06 Thread Peter Wang
This version tests 'config set' by reading back the set value, as suggested. Peter Wang (5): config: Fix free in 'config get' implementation. test: Add tests for 'config' command test: Add broken test for 'config list' config: Add 'config list' command man: Document 'config list' comman

Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)

2012-04-06 Thread Jameson Graef Rollins
On Fri, Apr 06 2012, Mark Walters wrote: > There are some exclude tests for count in test/count. Do you think it > needs to be a full test everything like in test/search-exclude? Ah yes. Somehow I missed that. I might prefer to keep all exclude tests in one test script. In which case it would

[PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)

2012-04-06 Thread Jameson Graef Rollins
d... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120406/aa11aa6b/attachment.pgp>

Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)

2012-04-06 Thread Mark Walters
On Fri, 06 Apr 2012, Jameson Graef Rollins wrote: > On Fri, Apr 06 2012, Mark Walters wrote: >> This is the latest version of the patch series (previous version at [1]). >> I think this version fixes all the problems raised by Austin in his review. > > Tested and reviewed and LGTM. > > Unfortunat

Re: [PATCH] emacs: do not modify the alist passed to notmuch-sort-saved-searches

2012-04-06 Thread David Bremner
Jani Nikula writes: > Sort modifies its input as a side effect. Pass it a copy in > notmuch-sort-saved-searches to not modify the notmuch-saved-searches > alist. Pushed. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman

Re: [PATCH] configure: change gmime version in help message to 2.6

2012-04-06 Thread David Bremner
David Bremner writes: > > Tomi's second patch looks fine to me, and I promoted it to pushable. I > also noticed this minor issue with the help message. I have pushed Tomi's two patches, and my 1 followup. d ___ notmuch mailing list notmuch@notmuchmail.

Re: [PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)

2012-04-06 Thread Jameson Graef Rollins
On Fri, Apr 06 2012, Mark Walters wrote: > This is the latest version of the patch series (previous version at [1]). > I think this version fixes all the problems raised by Austin in his review. Tested and reviewed and LGTM. Unfortunately, though, I just now noticed that the tests don't cover co

[PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)

2012-04-06 Thread Jameson Graef Rollins
uot;1333716551-29153-5-git-send-email-markwalters1009 at gmail.com" -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120406/93ed41a6/attachment.pgp>

[PATCH v3 4/6] test: add some exclude tests

2012-04-06 Thread Mark Walters
Systematically test the exclude options for search. Also move the search existing exclude tests into the new test. There is some overlap between the two sets of tests but many of the existing ones are there because they triggered bugs in the past so I have kept them to ensure coverage. --- test/no

[PATCH v3 6/6] emacs: make show set --exclude=false

2012-04-06 Thread Mark Walters
Show has to set --exclude=false to deal with cases where it is asked to show a single excluded message. It uses JSON so it can easily pass the exclude information to the user. --- emacs/notmuch-show.el |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-show

[PATCH v3 5/6] cli: move show to the new --exclude= option naming scheme.

2012-04-06 Thread Mark Walters
This moves notmuch show to the --exclude=(true|false) naming scheme. When exclude=false show returns all threads that match including those that only match in an excluded message. The excluded messages are flagged. When exclude=true the behaviour depends on whether --entire-thread is set. If it is

[PATCH v3 3/6] cli: move search to the new --exclude= naming scheme.

2012-04-06 Thread Mark Walters
This commit replaces the --no-exclude option with a --exclude=(true|false|flag) option. The default is to omit the excluded messages. The flag option only makes sense if output=summary (as otherwise there is nowhere to print the flag). In summary output exclude=false and exclude=flag give almost i

[PATCH v3 2/6] cli: move count to the new --exclude=(true|false|flag) naming scheme.

2012-04-06 Thread Mark Walters
Move the option --no-exclude to the --exclude= scheme. Since there is no way to flag messages only true and false are implemented. Note that, for consistency with other commands, this is implemented as a keyword option rather than a boolean option. --- man/man1/notmuch-count.1 |5 +++-- notmuc

[PATCH v3 1/6] lib: change default for notmuch_query_set_omit_excluded

2012-04-06 Thread Mark Walters
--- lib/notmuch.h | 23 ++- lib/query.cc | 10 +- 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/lib/notmuch.h b/lib/notmuch.h index babd208..673c423 100644 --- a/lib/notmuch.h +++ b/lib/notmuch.h @@ -449,12 +449,25 @@ typedef enum { const char *

[PATCH v3 0/6] Move --no-exclude to --exclude=(true|false|flag)

2012-04-06 Thread Mark Walters
This is the latest version of the patch series (previous version at [1]). I think this version fixes all the problems raised by Austin in his review. In particular it rephrases the documentation comment for notmuch_query_set_omit_excluded_messages in notmuch.h, and renames the function t