[PATCH 2/3] test: emacs: toggle eliding of non-matching messages in `notmuch-show'

2012-04-17 Thread Mark Walters
On Sun, 19 Feb 2012, Pieter Praet wrote: > See commits 44a544ed, 866ce8b1, 668b66ec. > --- > test/emacs | 38 ++ > .../notmuch-show-elide-non-matching-messages-off | 79 > >

[RFC PATCH 1/4] emacs: simplify point placement in notmuch-hello

2012-04-17 Thread Tomi Ollila
On Tue, Apr 17 2012, Jani Nikula wrote: > On Tue, 17 Apr 2012 13:04:39 +0400, Dmitry Kurochkin gmail.com> wrote: >> Hi Jani. >> >> Jani Nikula writes: [ stuff deleted ] > I don't oppose to your plan, but I don't think I'm up to implementing it > either. I just cooked up something together

[RFC PATCH 3/4] emacs: add notmuch hello refresh hook to display message count change

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula writes: > On Tue, 17 Apr 2012 13:13:15 +0400, Dmitry Kurochkin gmail.com> wrote: >> Jani Nikula writes: >> >> > Add a notmuch hello refresh hook to display a message about change in >> > message count in the database since the notmuch-hello buffer was last >> > refreshed manually

[RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula writes: > On Tue, 17 Apr 2012 13:06:13 +0400, Dmitry Kurochkin gmail.com> wrote: >> Can you please give some explanaition why is this needed? Would this >> change break custom hooks that do not expect any arguments? > > For patch 3/4. We don't want to display a message if someone

[RFC PATCH 4/4] emacs: add notmuch hello refresh hook to place point in a widget

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula writes: > Add support for putting point to a widget after refresh through a > hook. This approximates the old behaviour. I may be wrong, but this looks to me like a hack that cannot work well. See my first reply in the thread for ideas on how to better implement this functionality.

[RFC PATCH 3/4] emacs: add notmuch hello refresh hook to display message count change

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula writes: > Add a notmuch hello refresh hook to display a message about change in > message count in the database since the notmuch-hello buffer was last > refreshed manually (no-display is nil). I like this idea. But IMO we should avoid another call to notmuch count. Notmuch-hello

[RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-04-17 Thread Dmitry Kurochkin
Can you please give some explanaition why is this needed? Would this change break custom hooks that do not expect any arguments? Regards, Dmitry Jani Nikula writes: > --- > emacs/notmuch-hello.el |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git

[RFC PATCH 1/4] emacs: simplify point placement in notmuch-hello

2012-04-17 Thread Dmitry Kurochkin
Hi Jani. Jani Nikula writes: > notmuch-hello (called also through notmuch-hello-update, bound to '=' > by default) tries to find the widget under or following point before > refresh, and put the point back to the widget afterwards. The code has > gotten a bit complicated, and has at least the

[RFC PATCH 1/4] emacs: simplify point placement in notmuch-hello

2012-04-17 Thread Jani Nikula
On Tue, 17 Apr 2012 13:04:39 +0400, Dmitry Kurochkin wrote: > Hi Jani. > > Jani Nikula writes: > > > notmuch-hello (called also through notmuch-hello-update, bound to '=' > > by default) tries to find the widget under or following point before > > refresh, and put the point back to the widget

[RFC PATCH 4/4] emacs: add notmuch hello refresh hook to place point in a widget

2012-04-17 Thread Jani Nikula
On Tue, 17 Apr 2012 13:16:10 +0400, Dmitry Kurochkin wrote: > Jani Nikula writes: > > > Add support for putting point to a widget after refresh through a > > hook. This approximates the old behaviour. > > I may be wrong, but this looks to me like a hack that cannot work well. > See my first

[PATCH 1/7] Split notmuch_database_close into two functions

2012-04-17 Thread Mark Walters
On Mon, 16 Apr 2012, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > Quoting Mark Walters (2012-03-31 19:17:15) >> Secondly, I think the patch series could be made clearer and easier to >> review. If you do it in three steps >> >> 1) change of notmuch_database_close to

[RFC PATCH 3/4] emacs: add notmuch hello refresh hook to display message count change

2012-04-17 Thread Jani Nikula
On Tue, 17 Apr 2012 13:13:15 +0400, Dmitry Kurochkin wrote: > Jani Nikula writes: > > > Add a notmuch hello refresh hook to display a message about change in > > message count in the database since the notmuch-hello buffer was last > > refreshed manually (no-display is nil). > > I like this

[RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-04-17 Thread Jani Nikula
On Tue, 17 Apr 2012 13:06:13 +0400, Dmitry Kurochkin wrote: > Can you please give some explanaition why is this needed? Would this > change break custom hooks that do not expect any arguments? For patch 3/4. We don't want to display a message if someone calls (notmuch-hello-update t) from some

[PATCH] configure: test shell parameter substring processing and possibly exec one

2012-04-17 Thread Tomi Ollila
'configure' script uses parameter substring extensively. It is Posix shell feature. Original Bourne shell does not have such features. Some systems still ships such shells as /bin/sh (for compatibility reasons -- shell scripts written on those platforms are expected to work on 1990's systems...)

[RFC PATCH 4/4] emacs: add notmuch hello refresh hook to place point in a widget

2012-04-17 Thread Jani Nikula
Add support for putting point to a widget after refresh through a hook. This approximates the old behaviour. --- emacs/notmuch-hello.el |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 13da146..07e64d4 100644 ---

[RFC PATCH 3/4] emacs: add notmuch hello refresh hook to display message count change

2012-04-17 Thread Jani Nikula
Add a notmuch hello refresh hook to display a message about change in message count in the database since the notmuch-hello buffer was last refreshed manually (no-display is nil). --- emacs/notmuch-hello.el | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff

[RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-04-17 Thread Jani Nikula
--- emacs/notmuch-hello.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 9cd907a..0596bbe 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -776,7 +776,7 @@ following: (widget-setup)

[RFC PATCH 1/4] emacs: simplify point placement in notmuch-hello

2012-04-17 Thread Jani Nikula
notmuch-hello (called also through notmuch-hello-update, bound to '=' by default) tries to find the widget under or following point before refresh, and put the point back to the widget afterwards. The code has gotten a bit complicated, and has at least the following issues: 1) All the individual

[RFC] Split notmuch_database_close into two functions

2012-04-17 Thread Tomi Ollila
On Tue, Apr 17 2012, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > Hi everyone, > > Quoting Patrick Totzke (2012-04-13 10:33:58) >> Quoting Austin Clements (2012-04-01 04:23:23) >> >Maybe you could describe your use case in more detail? >> >> Quoting Austin Clements (2012-04-12

[PATCH 1/7] Split notmuch_database_close into two functions

2012-04-17 Thread Justus Winter
Quoting Mark Walters (2012-03-31 19:17:15) > Secondly, I think the patch series could be made clearer and easier to > review. If you do it in three steps > > 1) change of notmuch_database_close to notmuch_database_destroy (just >the function name change) > 2) split the new

[RFC] Split notmuch_database_close into two functions

2012-04-17 Thread Justus Winter
Hi everyone, Quoting Patrick Totzke (2012-04-13 10:33:58) > Quoting Austin Clements (2012-04-01 04:23:23) > >Maybe you could describe your use case in more detail? > > Quoting Austin Clements (2012-04-12 17:57:44) > >Quoth Justus Winter on Apr 12 at 11:05 am: > ... > >I see. TL;DR > > .. which

[RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-04-17 Thread Jani Nikula
--- emacs/notmuch-hello.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 9cd907a..0596bbe 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -776,7 +776,7 @@ following: (widget-setup)

[RFC PATCH 1/4] emacs: simplify point placement in notmuch-hello

2012-04-17 Thread Jani Nikula
notmuch-hello (called also through notmuch-hello-update, bound to '=' by default) tries to find the widget under or following point before refresh, and put the point back to the widget afterwards. The code has gotten a bit complicated, and has at least the following issues: 1) All the individual

[RFC PATCH 3/4] emacs: add notmuch hello refresh hook to display message count change

2012-04-17 Thread Jani Nikula
Add a notmuch hello refresh hook to display a message about change in message count in the database since the notmuch-hello buffer was last refreshed manually (no-display is nil). --- emacs/notmuch-hello.el | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff

[RFC PATCH 4/4] emacs: add notmuch hello refresh hook to place point in a widget

2012-04-17 Thread Jani Nikula
Add support for putting point to a widget after refresh through a hook. This approximates the old behaviour. --- emacs/notmuch-hello.el |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 13da146..07e64d4 100644 ---

Re: [PATCH 1/7] Split notmuch_database_close into two functions

2012-04-17 Thread Mark Walters
On Mon, 16 Apr 2012, Justus Winter 4win...@informatik.uni-hamburg.de wrote: Quoting Mark Walters (2012-03-31 19:17:15) Secondly, I think the patch series could be made clearer and easier to review. If you do it in three steps 1) change of notmuch_database_close to notmuch_database_destroy

Re: [RFC] Split notmuch_database_close into two functions

2012-04-17 Thread Mark Walters
On Thu, 12 Apr 2012, Austin Clements amdra...@mit.edu wrote: Quoth Justus Winter on Apr 12 at 11:05 am: Quoting Austin Clements (2012-04-01 05:23:23) Quoth Justus Winter on Mar 21 at 1:55 am: I propose to split the function notmuch_database_close into notmuch_database_close and

Re: [RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-04-17 Thread Dmitry Kurochkin
Can you please give some explanaition why is this needed? Would this change break custom hooks that do not expect any arguments? Regards, Dmitry Jani Nikula j...@nikula.org writes: --- emacs/notmuch-hello.el |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [RFC PATCH 3/4] emacs: add notmuch hello refresh hook to display message count change

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula j...@nikula.org writes: Add a notmuch hello refresh hook to display a message about change in message count in the database since the notmuch-hello buffer was last refreshed manually (no-display is nil). I like this idea. But IMO we should avoid another call to notmuch count.

Re: [RFC PATCH 4/4] emacs: add notmuch hello refresh hook to place point in a widget

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula j...@nikula.org writes: Add support for putting point to a widget after refresh through a hook. This approximates the old behaviour. I may be wrong, but this looks to me like a hack that cannot work well. See my first reply in the thread for ideas on how to better implement this

Re: [RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-04-17 Thread Jani Nikula
On Tue, 17 Apr 2012 13:06:13 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Can you please give some explanaition why is this needed? Would this change break custom hooks that do not expect any arguments? For patch 3/4. We don't want to display a message if someone calls

Re: [RFC PATCH 2/4] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula j...@nikula.org writes: On Tue, 17 Apr 2012 13:06:13 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Can you please give some explanaition why is this needed? Would this change break custom hooks that do not expect any arguments? For patch 3/4. We don't want to

Re: [RFC PATCH 3/4] emacs: add notmuch hello refresh hook to display message count change

2012-04-17 Thread Jani Nikula
On Tue, 17 Apr 2012 13:13:15 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Jani Nikula j...@nikula.org writes: Add a notmuch hello refresh hook to display a message about change in message count in the database since the notmuch-hello buffer was last refreshed manually

Re: [RFC PATCH 4/4] emacs: add notmuch hello refresh hook to place point in a widget

2012-04-17 Thread Jani Nikula
On Tue, 17 Apr 2012 13:16:10 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Jani Nikula j...@nikula.org writes: Add support for putting point to a widget after refresh through a hook. This approximates the old behaviour. I may be wrong, but this looks to me like a hack that

Re: [RFC PATCH 3/4] emacs: add notmuch hello refresh hook to display message count change

2012-04-17 Thread Dmitry Kurochkin
Jani Nikula j...@nikula.org writes: On Tue, 17 Apr 2012 13:13:15 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Jani Nikula j...@nikula.org writes: Add a notmuch hello refresh hook to display a message about change in message count in the database since the notmuch-hello

Re: [RFC PATCH 1/4] emacs: simplify point placement in notmuch-hello

2012-04-17 Thread Jani Nikula
On Tue, 17 Apr 2012 13:04:39 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi Jani. Jani Nikula j...@nikula.org writes: notmuch-hello (called also through notmuch-hello-update, bound to '=' by default) tries to find the widget under or following point before refresh, and

Re: [RFC PATCH 1/4] emacs: simplify point placement in notmuch-hello

2012-04-17 Thread Tomi Ollila
On Tue, Apr 17 2012, Jani Nikula j...@nikula.org wrote: On Tue, 17 Apr 2012 13:04:39 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Hi Jani. Jani Nikula j...@nikula.org writes: [ stuff deleted ] I don't oppose to your plan, but I don't think I'm up to implementing it either.

Re: [PATCH 2/3] test: emacs: toggle eliding of non-matching messages in `notmuch-show'

2012-04-17 Thread Mark Walters
On Sun, 19 Feb 2012, Pieter Praet pie...@praet.org wrote: See commits 44a544ed, 866ce8b1, 668b66ec. --- test/emacs | 38 ++ .../notmuch-show-elide-non-matching-messages-off | 79

Re: [PATCH] contrib/nmbug: use resolve merge strategy

2012-04-17 Thread Tomi Ollila
On Sat, Mar 31 2012, da...@tethera.net wrote: From: David Bremner brem...@debian.org The recursive merge strategy does rename detection, which yields false positives (and hence spurious merge conflicts) when merging trees of empty files. I attempted to search more info about 'recursive' vs