[PATCH] ruby: make sure the database is closed

Quoth Felipe Contreras on Apr 24 at 3:45 am: > On Tue, Apr 24, 2012 at 2:46 AM, Ali Polatel wrote: > > 2012/4/24 Felipe Contreras : > > >> Personally I don't see why an object, like say a query would remain > >> working correctly after the database is gone, either by calling > >> .close()

[PATCH] ruby: make sure the database is closed

2012/4/23 Felipe Contreras : > If the Ruby code does not manually close the database, we need to make > sure it's closed when garbage collected. > > In Ruby, users are not _required_ to close, the garbage collector should > take care of that. > > Signed-off-by: Felipe Contreras > --- >

ruby bindings on OS X are broken? (was Re: [ANN] New awesome vim plug-in using Ruby bindings)

On Mon, Apr 23, 2012 at 12:39 PM, Charlie Allom wrote: > /opt/local/bin/gcc-apple-4.2 -I. -I. -I/opt/local/lib/ruby/1.8/i686-darwin11 > -I. -I/opt/local/include -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE > ?-I/opt/local/include -fno-common -pipe -O2 -arch x86_64 ?-fno-common -pipe > -fno-common

[PATCH] ruby: make sure the database is closed

If the Ruby code does not manually close the database, we need to make sure it's closed when garbage collected. In Ruby, users are not _required_ to close, the garbage collector should take care of that. Signed-off-by: Felipe Contreras --- bindings/ruby/database.c |8 +++- 1 file

[PATCH] ruby: make sure the database is closed

If the Ruby code does not manually close the database, we need to make sure it's closed when garbage collected. In Ruby, users are not _required_ to close, the garbage collector should take care of that. Signed-off-by: Felipe Contreras --- bindings/ruby/database.c |8 +++- 1 file

[PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close

Hi, On Sun, Apr 22, 2012 at 3:07 PM, Justus Winter <4winter at informatik.uni-hamburg.de> wrote: > Adapt the ruby bindings to the notmuch_database_close split. > > Signed-off-by: Justus Winter <4winter at informatik.uni-hamburg.de> > --- > ?bindings/ruby/database.c | ? ?2 +- > ?1 file changed, 1

[ANN] New awesome vim plug-in using Ruby bindings

Hi, If you reply to all, remove Ryan Harper, as the address doesn't work. Or just reply here. Cheers. 2012/4/23 Felipe Contreras : > I've never been particularly happy with the code of the vim plug-in, > but it sort of did the job, after some fixes, and has been working > great so far for most

[ANN] New awesome vim plug-in using Ruby bindings

On Mon, Apr 23, 2012 at 6:41 AM, Adam Wolfe Gordon wrote: > Hi Felipe, > > This work sounds nice - it's good to have lots of interface choices. > One question below: > > On Sun, Apr 22, 2012 at 19:12, Felipe Contreras > wrote: >> doesn't have support for that), and even

ruby bindings on OS X are broken? (was Re: [ANN] New awesome vim plug-in using Ruby bindings)

Hello, Has anyone seen this on OS X? I can't see what the linker must be doing. 10:36 capslock:notmuch/bindings/ruby% ruby extconf.rb checking for notmuch.h in ../../lib... yes checking for notmuch_database_create() in -lnotmuch... yes creating Makefile 10:36 capslock:notmuch/bindings/ruby% make

[ANN] New awesome vim plug-in using Ruby bindings

On Mon, Apr 23, 2012 at 05:53, Felipe Contreras wrote: > I do have w3.el installed. I can read the HTML, but when scrolling and > selecting there are glitches, and when replying nothing gets quoted. Ah, I see. As I said before, reply will work soon. The other issues sound like emacs/w3 problems,

[ANN] New awesome vim plug-in using Ruby bindings

Hi, I've never been particularly happy with the code of the vim plug-in, but it sort of did the job, after some fixes, and has been working great so far for most of my needs even though it's clearly very rough on the edges. However, I'm recently in need of been able to read HTML mails, and just

[PATCH v3 1/4] emacs: Let the user choose where to compose new mails

lable URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120423/270ce479/attachment.pgp>

ruby bindings on OS X are broken? (was Re: [ANN] New awesome vim plug-in using Ruby bindings)

Hello, Has anyone seen this on OS X? I can't see what the linker must be doing. 10:36 capslock:notmuch/bindings/ruby% ruby extconf.rb checking for notmuch.h in ../../lib... yes checking for notmuch_database_create() in -lnotmuch... yes creating Makefile 10:36 capslock:notmuch/bindings/ruby% make

Re: [ANN] New awesome vim plug-in using Ruby bindings

On Mon, Apr 23, 2012 at 6:41 AM, Adam Wolfe Gordon awg+notm...@xvx.ca wrote: Hi Felipe, This work sounds nice - it's good to have lots of interface choices. One question below: On Sun, Apr 22, 2012 at 19:12, Felipe Contreras felipe.contre...@gmail.com wrote: doesn't have support for that),

Re: [ANN] New awesome vim plug-in using Ruby bindings

Hi, If you reply to all, remove Ryan Harper, as the address doesn't work. Or just reply here. Cheers. 2012/4/23 Felipe Contreras felipe.contre...@gmail.com: I've never been particularly happy with the code of the vim plug-in, but it sort of did the job, after some fixes, and has been working

Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close

Hi, On Sun, Apr 22, 2012 at 3:07 PM, Justus Winter 4win...@informatik.uni-hamburg.de wrote: Adapt the ruby bindings to the notmuch_database_close split. Signed-off-by: Justus Winter 4win...@informatik.uni-hamburg.de ---  bindings/ruby/database.c |    2 +-  1 file changed, 1 insertion(+), 1

[PATCH] ruby: make sure the database is closed

If the Ruby code does not manually close the database, we need to make sure it's closed when garbage collected. In Ruby, users are not _required_ to close, the garbage collector should take care of that. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- bindings/ruby/database.c |

Re: ruby bindings on OS X are broken? (was Re: [ANN] New awesome vim plug-in using Ruby bindings)

On Mon, Apr 23, 2012 at 12:39 PM, Charlie Allom char...@mediasp.com wrote: /opt/local/bin/gcc-apple-4.2 -I. -I. -I/opt/local/lib/ruby/1.8/i686-darwin11 -I. -I/opt/local/include -D_XOPEN_SOURCE -D_DARWIN_C_SOURCE   -I/opt/local/include -fno-common -pipe -O2 -arch x86_64  -fno-common -pipe

[PATCH] ruby: make sure the database is closed

If the Ruby code does not manually close the database, we need to make sure it's closed when garbage collected. In Ruby, users are not _required_ to close, the garbage collector should take care of that. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- bindings/ruby/database.c |

Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close

Quoting Felipe Contreras (2012-04-23 14:36:33) I don't think this is the right approach. If database_destroy truly destroys the object, then we would want to do it only at garbage collection, when it's not accessible any more. What if I want to re-use the database from the Ruby code? This

Re: ruby bindings on OS X are broken? (was Re: [ANN] New awesome vim plug-in using Ruby bindings)

On Mon, Apr 23, 2012 at 03:48:40PM +0300, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Apr 23, 2012 at 12:39 PM, Charlie Allom char...@mediasp.com wrote: /opt/local/bin/gcc-apple-4.2 -I. -I. -I/opt/local/lib/ruby/1.8/i686-darwin11 -I. -I/opt/local/include -D_XOPEN_SOURCE

Re: [ANN] New awesome vim plug-in using Ruby bindings

On Mon, Apr 23, 2012 at 05:53, Felipe Contreras felipe.contre...@gmail.com wrote: I do have w3.el installed. I can read the HTML, but when scrolling and selecting there are glitches, and when replying nothing gets quoted. Ah, I see. As I said before, reply will work soon. The other issues sound

Re: [PATCH] ruby: make sure the database is closed

2012/4/23 Felipe Contreras felipe.contre...@gmail.com: If the Ruby code does not manually close the database, we need to make sure it's closed when garbage collected. In Ruby, users are not _required_ to close, the garbage collector should take care of that. Signed-off-by: Felipe Contreras

Re: [PATCH] ruby: make sure the database is closed

On Mon, Apr 23, 2012 at 5:04 PM, Ali Polatel a...@exherbo.org wrote: I'd rather not do this. Please read: http://comments.gmane.org/gmane.comp.lang.ruby.general/320324 OK, I've read this.. So? The order in which Ruby's garbage-collector frees the database and other objects is irrelevant,

Re: [PATCH] ruby: make sure the database is closed

2012/4/23 Felipe Contreras felipe.contre...@gmail.com: On Mon, Apr 23, 2012 at 5:04 PM, Ali Polatel a...@exherbo.org wrote: I'd rather not do this. Please read: http://comments.gmane.org/gmane.comp.lang.ruby.general/320324 OK, I've read this.. So? You are one step close to what I thought

Re: [PATCH] ruby: make sure the database is closed

On Mon, Apr 23, 2012 at 11:43 PM, Ali Polatel a...@exherbo.org wrote: 2012/4/23 Felipe Contreras felipe.contre...@gmail.com: On Mon, Apr 23, 2012 at 5:04 PM, Ali Polatel a...@exherbo.org wrote: I'd rather not do this. Please read: http://comments.gmane.org/gmane.comp.lang.ruby.general/320324

Re: [PATCH] ruby: make sure the database is closed

2012/4/24 Felipe Contreras felipe.contre...@gmail.com: On Mon, Apr 23, 2012 at 11:43 PM, Ali Polatel a...@exherbo.org wrote: 2012/4/23 Felipe Contreras felipe.contre...@gmail.com: On Mon, Apr 23, 2012 at 5:04 PM, Ali Polatel a...@exherbo.org wrote: I'd rather not do this. Please read:

Re: [PATCH] ruby: make sure the database is closed

On Tue, Apr 24, 2012 at 2:46 AM, Ali Polatel a...@exherbo.org wrote: 2012/4/24 Felipe Contreras felipe.contre...@gmail.com: Personally I don't see why an object, like say a query would remain working correctly after the database is gone, either by calling .close() directly, or just loosing

Re: [PATCH] ruby: make sure the database is closed

Quoth Felipe Contreras on Apr 24 at 3:45 am: On Tue, Apr 24, 2012 at 2:46 AM, Ali Polatel a...@exherbo.org wrote: 2012/4/24 Felipe Contreras felipe.contre...@gmail.com: Personally I don't see why an object, like say a query would remain working correctly after the database is gone,

Re: [PATCH v3 1/2] cli: make --entire-thread=false work for format=json.

Quoth Mark Walters on Apr 21 at 10:15 am: The --entire-thread option in notmuch-show.c defaults to true when format=json. Previously there was no way to turn this off. This patch makes it respect --entire-thread=false. The one subtlety is that we initialise a notmuch_bool_t to -1 to