LGTM. I've been wanting this functionality for a while, but have been
too lazy to implement it myself.
I do have one request, though. Could we bind this to 'l' for "limit"?
Generally we've been quite good at making the shift key a modifier to
the functionality of the lower-case binding, which
Works-for-me, precisely as requested, thanks :)
On Tue, Apr 24, 2012 at 4:15 AM, Austin Clements wrote:
> Quoth Felipe Contreras on Apr 24 at ?3:45 am:
>> On Tue, Apr 24, 2012 at 2:46 AM, Ali Polatel wrote:
>> > 2012/4/24 Felipe Contreras :
>>
>> >> Personally I don't see why an object, like say a query would remain
>> >> working correctly
Previously the elide messages code got the entire-thread from
notmuch-show.c and then threw away all non-matching messages. This
version calls notmuch-show.c without the --entire-thread flag so
it never receives the non-matching messages in the first place.
This makes it substantially faster.
---
Also remove the Json --entire-thread item from devel/TODO.
---
devel/TODO |2 --
devel/schemata |2 +-
2 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/devel/TODO b/devel/TODO
index 7b750af..eb757af 100644
--- a/devel/TODO
+++ b/devel/TODO
@@ -92,8 +92,6 @@ and email
The --entire-thread option in notmuch-show.c defaults to true when
format=json. Previously there was no way to turn this off. This patch
makes it respect --entire-thread=false.
The one subtlety is that we initialise a notmuch_bool_t to -1 to
indicate that the option parsing has not set it. This
All formats except Json can output empty messages for non
entire-thread, but in Json format we output "null" to keep the other
elements (e.g. the replies to the omitted message) in the correct
place.
---
notmuch-client.h |1 +
notmuch-show.c | 20
2 files changed, 17
This is version 4 of this patch set (previous version at [1]) which
removes the --entire-thread constraint from json output in
notmuch-show, and then uses to implement the emacs elide
functionality.
Changes from the previous version:
split the cli patch
update devel/schemata
On Tue, Apr 24, 2012 at 2:46 AM, Ali Polatel wrote:
> 2012/4/24 Felipe Contreras :
>> Personally I don't see why an object, like say a query would remain
>> working correctly after the database is gone, either by calling
>> .close() directly, or just loosing the pointer to the original object.
2012/4/24 Felipe Contreras :
> On Mon, Apr 23, 2012 at 11:43 PM, Ali Polatel wrote:
>> 2012/4/23 Felipe Contreras :
>>> On Mon, Apr 23, 2012 at 5:04 PM, Ali Polatel wrote:
>>>
I'd rather not do this.
Please read: http://comments.gmane.org/gmane.comp.lang.ruby.general/320324
>>>
>>> OK,
On Mon, Apr 23, 2012 at 11:43 PM, Ali Polatel wrote:
> 2012/4/23 Felipe Contreras :
>> On Mon, Apr 23, 2012 at 5:04 PM, Ali Polatel wrote:
>>
>>> I'd rather not do this.
>>> Please read: http://comments.gmane.org/gmane.comp.lang.ruby.general/320324
>>
>> OK, I've read this.. So?
>
> You are one
All formats except Json can output empty messages for non
entire-thread, but in Json format we output null to keep the other
elements (e.g. the replies to the omitted message) in the correct
place.
---
notmuch-client.h |1 +
notmuch-show.c | 20
2 files changed, 17
Also remove the Json --entire-thread item from devel/TODO.
---
devel/TODO |2 --
devel/schemata |2 +-
2 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/devel/TODO b/devel/TODO
index 7b750af..eb757af 100644
--- a/devel/TODO
+++ b/devel/TODO
@@ -92,8 +92,6 @@ and email
Previously the elide messages code got the entire-thread from
notmuch-show.c and then threw away all non-matching messages. This
version calls notmuch-show.c without the --entire-thread flag so
it never receives the non-matching messages in the first place.
This makes it substantially faster.
---
On Tue, Apr 24, 2012 at 4:15 AM, Austin Clements amdra...@mit.edu wrote:
Quoth Felipe Contreras on Apr 24 at 3:45 am:
On Tue, Apr 24, 2012 at 2:46 AM, Ali Polatel a...@exherbo.org wrote:
2012/4/24 Felipe Contreras felipe.contre...@gmail.com:
Personally I don't see why an object, like say a
From: Tomi Ollila t...@iki.fi
Variable 'notmuch-hello-search-pos' was used to locate cursor to
the search bar in case no other location where to put it was known.
(In case search bar is shown -- if not cursor will be at the end
of buffer). More generic versatile way to locace cursor follows.
From: Tomi Ollila t...@iki.fi
The global defvar notmuch-hello-target was used to silence compiler
'free variable' warning. Actually the variable (when used) was always
defined in (let...), shadowing the global in when dynamically scoped.
Moving the defvar in function (possibly functions in
From: Tomi Ollila t...@iki.fi
In order to figure out cursor position on notmuch-hello buffer, whatever
sections there are inserted, a following method is introduced:
While inserting sections, notmuch-hello () holds up 2 variables;
final-target-pos-pri and final-target-pos, initial values -1 and
Show the current thread with a different filter (i.e., open messages
in the thread matching the new query).
Currently bound to 'F'.
Note that it is not the same as filter in search as it replaces the
existing query rather than ANDing with it (but it does keep the
threadid part of the query).
---
Austin Clements amdra...@mit.edu writes:
Previously, fatal errors in add_files_recursive were not treated as
fatal by its callers (including itself!). This makes
add_files_recursive errors consistently fatal and updates all callers
to treat them as fatal.
series pushed.
d
Pushed,
d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Pushed,
d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Peter Wang noval...@gmail.com writes:
The array returned by g_key_file_get_string_list() should be freed with
g_strfreev(), not free().
Pushed this one patch from the series.
d
___
notmuch mailing list
notmuch@notmuchmail.org
Jameson Graef Rollins jroll...@finestructure.net writes:
No functional change here. The help message previously referred to
the delete tag, but deleted is now preferred, so hopefully this
will reduce any potential confusion.
I pushed this one patch from the series.
d
Works-for-me, precisely as requested, thanks :)
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
LGTM. I've been wanting this functionality for a while, but have been
too lazy to implement it myself.
I do have one request, though. Could we bind this to 'l' for limit?
Generally we've been quite good at making the shift key a modifier to
the functionality of the lower-case binding, which
26 matches
Mail list logo
