[Patch v4 1/3] emacs: split notmuch-show-apply-state

2012-04-28 Thread Austin Clements
Hmm. I think this will wind up spuriously marking messages read. If notmuch-show-refresh-view is called with reset-state set to t, it will mark the first open message read, before you move to the previously current message. IMO, notmuch-show-refresh-view should not be marking messages read at

[ANN] New awesome vim plug-in using Ruby bindings

2012-04-28 Thread Alex Ghitza
Hi Felipe, On Thu, Apr 26, 2012 at 8:29 AM, Felipe Contreras wrote: > In case anybody is interested, here's a screencast showing some of the > features :) > http://youtu.be/JGD7IbZmnIs This looks great, but I can't seem to be able to get it to work on my machine. I have put notmuch-ruby.vim

priorities for 0.13

2012-04-28 Thread Austin Clements
Quoth David Bremner on Apr 25 at 9:31 am: > > Hi All; > > I'd like to have a feature freeze for 0.13 sometime in the first week of > May. What do people feel are priorities to try to get reviewed and > pushed for 0.13? I've posted the changes to notmuch_database_{open,create} that we've

[Patch v3 0/2] Add filter to emacs show mode

2012-04-28 Thread Austin Clements
LGTM. It's too bad limiting will loose point, but obviously that can be fixed later. Quoth Mark Walters on Apr 26 at 8:14 pm: > Version 3 of this patch set: previous version is at > id:"1335373954-4578-1-git-send-email-markwalters1009 at gmail.com". > > This is updated to use Tomi's much

[PATCH] lib: Bump SO version from 2.0.0 to 3.0.0

2012-04-28 Thread Austin Clements
We've changed the APIs of notmuch_database_open, notmuch_database_create, and notmuch_database_close. --- Some of this patch's context comes from id:"1335651473-19652-1-git-send-email-amdragon at mit.edu", so it won't apply cleanly without that. NEWS |3 +++ lib/Makefile.local

[PATCH 6/6] News for changes to notmuch_database_{open,create}

2012-04-28 Thread Austin Clements
--- NEWS | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index a2cd080..0f031f3 100644 --- a/NEWS +++ b/NEWS @@ -76,15 +76,20 @@ contrib/ from now on. Library changes --- -API changes - - The function notmuch_database_close has been

[PATCH 5/6] ruby: Update Ruby bindings for new notmuch_database_{open, create} signatures

2012-04-28 Thread Austin Clements
--- bindings/ruby/database.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/bindings/ruby/database.c b/bindings/ruby/database.c index ba9a139..409d54f 100644 --- a/bindings/ruby/database.c +++ b/bindings/ruby/database.c @@ -42,6 +42,8 @@

[PATCH 4/6] python: Update Python bindings for new notmuch_database_{open, create} signatures

2012-04-28 Thread Austin Clements
--- bindings/python/notmuch/database.py | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/bindings/python/notmuch/database.py b/bindings/python/notmuch/database.py index 268e952..adc0a3f 100644 --- a/bindings/python/notmuch/database.py +++

[PATCH 3/6] go: Update Go bindings for new notmuch_database_{open, create} signatures

2012-04-28 Thread Austin Clements
This requires changing the return types of NewDatabase and OpenDatabase to follow the standard Go convention for returning errors. --- bindings/go/pkg/notmuch.go | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/bindings/go/pkg/notmuch.go

[PATCH 2/6] lib/cli: Make notmuch_database_create return a status code

2012-04-28 Thread Austin Clements
This is the notmuch_database_create equivalent of the previous change. In this case, there were places where errors were not being propagated correctly in notmuch_database_create or in calls to it. These have been fixed, using the new status value. --- lib/database.cc | 26

[PATCH 1/6] lib/cli: Make notmuch_database_open return a status code

2012-04-28 Thread Austin Clements
It has been a long-standing issue that notmuch_database_open doesn't return any indication of why it failed. This patch changes its prototype to return a notmuch_status_t and set an out-argument to the database itself, like other functions that return both a status and an object. In the interest

[PATCH 0/6] Make notmuch_database_{open,create} return status codes

2012-04-28 Thread Austin Clements
Since we're breaking binary and source compatibility with the next release anyway, it's about time we fix notmuch_database_{open,create} to return status codes.

[PATCH] go: Update to the current notmuch_database_find_message API

2012-04-28 Thread Austin Clements
The signature of notmuch_database_find_message was changed in 02a30767 to report errors and the Go bindings were never updated. This brings the Go bindings in sync with that change and at least makes them compile with Go r60.3, the last release before Go 1. --- bindings/go/pkg/notmuch.go | 13

[ANN] New awesome vim plug-in using Ruby bindings

2012-04-28 Thread Felipe Contreras
On Sat, Apr 28, 2012 at 1:40 PM, Alex Ghitza wrote: > vim -c ':NotMuchR' > > all I get is an error message: > > Error detected while processing command line: > E492: Not an editor command: :NotMuchR I don't know if you did anything special to get the normal plug-in to work. Maybe you are doing

emacs tagging cleanup, v3

2012-04-28 Thread Tomi Ollila
On Sat, Apr 14 2012, Jameson Graef Rollins wrote: > This is a further cleaned up and simplified version of [0]. The scope > is slightly reduced, but we still end up with a simpler user > interface, with the primary tagging functions being: > > notmuch-search-tag > notmuch-show-tag > > In this

[PATCH v4 2/6] config: Check 'config get' arity exactly

2012-04-28 Thread David Bremner
Peter Wang writes: > Require that 'config get' is passed exactly one additional argument, > instead of silently ignoring extra arguments. As a side-effect, produce > more specific error messages for the 'config' command as a whole. Hi Peter; I pushed the rest of the series to master. Would you

[PATCH] emacs: Let the user choose where to compose new mails

2012-04-28 Thread Tomi Ollila
On Sat, Apr 14 2012, Jameson Graef Rollins wrote: > From: Thomas Jost > > Introduce a new defcustom notmuch-mua-compose-in that allows users to > specify where new mails are composed., either in the current window or > in a new window or frame. > > Signed-off-by: Jameson Rollins > --- > This

[PATCH 1/7] Split notmuch_database_close into two functions

2012-04-28 Thread David Bremner
Justus Winter <4winter at informatik.uni-hamburg.de> writes: > Formerly notmuch_database_close closed the xapian database and > destroyed the talloc structure associated with the notmuch database > object. Split notmuch_database_close into notmuch_database_close and > notmuch_database_destroy.

Re: [PATCH] emacs: Let the user choose where to compose new mails

2012-04-28 Thread Tomi Ollila
On Sat, Apr 14 2012, Jameson Graef Rollins jroll...@finestructure.net wrote: From: Thomas Jost schno...@schnouki.net Introduce a new defcustom notmuch-mua-compose-in that allows users to specify where new mails are composed., either in the current window or in a new window or frame.

Re: [ANN] New awesome vim plug-in using Ruby bindings

2012-04-28 Thread Alex Ghitza
Hi Felipe, On Thu, Apr 26, 2012 at 8:29 AM, Felipe Contreras felipe.contre...@gmail.com wrote: In case anybody is interested, here's a screencast showing some of the features :) http://youtu.be/JGD7IbZmnIs This looks great, but I can't seem to be able to get it to work on my machine. I have

Re: [PATCH 1/7] Split notmuch_database_close into two functions

2012-04-28 Thread David Bremner
Justus Winter 4win...@informatik.uni-hamburg.de writes: Formerly notmuch_database_close closed the xapian database and destroyed the talloc structure associated with the notmuch database object. Split notmuch_database_close into notmuch_database_close and notmuch_database_destroy. Series

Re: [PATCH v4 2/6] config: Check 'config get' arity exactly

2012-04-28 Thread David Bremner
Peter Wang noval...@gmail.com writes: Require that 'config get' is passed exactly one additional argument, instead of silently ignoring extra arguments. As a side-effect, produce more specific error messages for the 'config' command as a whole. Hi Peter; I pushed the rest of the series to

[PATCH] go: Update to the current notmuch_database_find_message API

2012-04-28 Thread Austin Clements
The signature of notmuch_database_find_message was changed in 02a30767 to report errors and the Go bindings were never updated. This brings the Go bindings in sync with that change and at least makes them compile with Go r60.3, the last release before Go 1. --- bindings/go/pkg/notmuch.go | 13

[PATCH 4/6] python: Update Python bindings for new notmuch_database_{open, create} signatures

2012-04-28 Thread Austin Clements
--- bindings/python/notmuch/database.py | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/bindings/python/notmuch/database.py b/bindings/python/notmuch/database.py index 268e952..adc0a3f 100644 --- a/bindings/python/notmuch/database.py +++

[PATCH 6/6] News for changes to notmuch_database_{open,create}

2012-04-28 Thread Austin Clements
--- NEWS | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index a2cd080..0f031f3 100644 --- a/NEWS +++ b/NEWS @@ -76,15 +76,20 @@ contrib/ from now on. Library changes --- -API changes - - The function notmuch_database_close has

[PATCH 3/6] go: Update Go bindings for new notmuch_database_{open, create} signatures

2012-04-28 Thread Austin Clements
This requires changing the return types of NewDatabase and OpenDatabase to follow the standard Go convention for returning errors. --- bindings/go/pkg/notmuch.go | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/bindings/go/pkg/notmuch.go

[PATCH 1/6] lib/cli: Make notmuch_database_open return a status code

2012-04-28 Thread Austin Clements
It has been a long-standing issue that notmuch_database_open doesn't return any indication of why it failed. This patch changes its prototype to return a notmuch_status_t and set an out-argument to the database itself, like other functions that return both a status and an object. In the interest

[PATCH 0/6] Make notmuch_database_{open,create} return status codes

2012-04-28 Thread Austin Clements
Since we're breaking binary and source compatibility with the next release anyway, it's about time we fix notmuch_database_{open,create} to return status codes. ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH] lib: Bump SO version from 2.0.0 to 3.0.0

2012-04-28 Thread Austin Clements
We've changed the APIs of notmuch_database_open, notmuch_database_create, and notmuch_database_close. --- Some of this patch's context comes from id:1335651473-19652-1-git-send-email-amdra...@mit.edu, so it won't apply cleanly without that. NEWS |3 +++ lib/Makefile.local |

Re: [Patch v3 0/2] Add filter to emacs show mode

2012-04-28 Thread Austin Clements
LGTM. It's too bad limiting will loose point, but obviously that can be fixed later. Quoth Mark Walters on Apr 26 at 8:14 pm: Version 3 of this patch set: previous version is at id:1335373954-4578-1-git-send-email-markwalters1...@gmail.com. This is updated to use Tomi's much cleaner

Re: priorities for 0.13

2012-04-28 Thread Austin Clements
Quoth David Bremner on Apr 25 at 9:31 am: Hi All; I'd like to have a feature freeze for 0.13 sometime in the first week of May. What do people feel are priorities to try to get reviewed and pushed for 0.13? I've posted the changes to notmuch_database_{open,create} that we've discussed

Re: [ANN] New awesome vim plug-in using Ruby bindings

2012-04-28 Thread Alex Ghitza
Felipe Contreras wrote: vim -c ':NotMuchR' all I get is an error message: Error detected while processing command line: E492: Not an editor command: :NotMuchR I don't know if you did anything special to get the normal plug-in to work. Maybe you are doing 'source

[Patch v4 0/3] Add filter to emacs show mode

2012-04-28 Thread Mark Walters
This is version 4 of the patch set allowing the user to filter which messages are open in emacs show mode. The previous version was at id:1335467689-6513-1-git-send-email-markwalters1...@gmail.com The change in this version is to keep position in the thread (at least to the same message). The

[Patch v4 1/3] emacs: split notmuch-show-apply-state

2012-04-28 Thread Mark Walters
Separate out a notmuch-show-goto-msg-id sub-function from notmuch-show-apply-state. There should be no functional change but the next patch will call the new function. --- emacs/notmuch-show.el | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git

[Patch v4 2/3] emacs: add a filter option to show

2012-04-28 Thread Mark Walters
Show the current thread with a different filter (i.e., open messages in the thread matching the new query). Bound to 'l' for limit. Note that it is not the same as filter in search mode as it replaces the existing query rather than ANDing with it (but it does keep the thread-id part of the

[Patch v4 3/3] emacs: Bind filter in search to 'l'

2012-04-28 Thread Mark Walters
Change the key binding for filter (or limit) in search-mode. This gives consistency with the new filter in show-mode, and frees 'f' for forward-thread in the future. --- emacs/notmuch.el |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch.el

Re: [Patch v4 1/3] emacs: split notmuch-show-apply-state

2012-04-28 Thread Austin Clements
Hmm. I think this will wind up spuriously marking messages read. If notmuch-show-refresh-view is called with reset-state set to t, it will mark the first open message read, before you move to the previously current message. IMO, notmuch-show-refresh-view should not be marking messages read at

[PATCH] NEWS: add news item for 'config list'

2012-04-28 Thread Peter Wang
--- NEWS |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index a2cd080..4f36dff 100644 --- a/NEWS +++ b/NEWS @@ -52,6 +52,11 @@ Raw show format changes encoded in the original message, including the part's headers. Leaf parts, as before, output the

Re: [PATCH v2] emacs: do not modify subject in search or show

2012-04-28 Thread David Bremner
Jameson Graef Rollins jroll...@finestructure.net writes: A previous patch [0] replaced blank subject lines with '[No Subject]' in search and show mode. pushed. d ___ notmuch mailing list notmuch@notmuchmail.org