[PATCH v2 2/2] new: Centralize file type stat-ing logic

This moves our logic to get a file's type into one function. This has several benefits: we can support OSes and file systems that do not provide dirent.d_type or always return DT_UNKNOWN, complex symlink-handling logic has been replaced by a simple stat fall-through in one place, and the error mes

[PATCH v2 1/2] test: Test notmuch new with a broken symlink

--- test/new | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/new b/test/new index 99f9913..26253db 100755 --- a/test/new +++ b/test/new @@ -136,6 +136,16 @@ output=$(NOTMUCH_NEW) test_expect_equal "$output" "Added 1 new message to the database." +test_begin_subtest "Broke

[PATCH v2 0/2] Better, more portable stat-ing logic for notmuch new

This version uses ARRAY_SIZE, fixes errno handling bugs, and corrects a spelling error.

[PATCH 2/2] new: Centralize file type stat-ing logic

Quoth Jani Nikula on May 08 at 12:08 am: >On May 7, 2012 9:10 PM, "Austin Clements" <[1]amdragon at mit.edu> wrote: >> >> This moves our logic to get a file's type into one function. ?This has >> several benefits: we can support OSes and file systems that do not >> provide diren

[PATCH 4/4] ruby: Add wrapper for notmuch_query_set_omit_excluded()

--- bindings/ruby/defs.h |3 +++ bindings/ruby/init.c |7 +++ bindings/ruby/query.c | 18 ++ 3 files changed, 28 insertions(+) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index 6fe5787..85d8205 100644 --- a/bindings/ruby/defs.h +++ b/bindings/ruby/defs

[PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one

- Make mkmf use the notmuch.h under ../../lib - Use libnotmuch.a instead of linking to the installed libnotmuch.so --- bindings/ruby/defs.h |4 ++-- bindings/ruby/extconf.rb | 26 ++ 2 files changed, 24 insertions(+), 6 deletions(-) diff --git a/bindings/ruby/def

[PATCH 2/4] ruby: Add wrapper for notmuch_query_add_tag_exclude

--- bindings/ruby/defs.h |3 +++ bindings/ruby/init.c |1 + bindings/ruby/query.c | 18 ++ 3 files changed, 22 insertions(+) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index 25222a6..a41cf10 100644 --- a/bindings/ruby/defs.h +++ b/bindings/ruby/defs.h @@

[PATCH 1/4] ruby: Add wrapper for notmuch_query_count_messages

--- bindings/ruby/defs.h |3 +++ bindings/ruby/init.c |3 ++- bindings/ruby/query.c | 21 - 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index 81f652f..25222a6 100644 --- a/bindings/ruby/defs.h +++ b/bin

[PATCH 0/4] ruby: quick update before the freeze!

Hey David, I've polished the small patch series I had lying around. I believe I've covered all the lacking API changes. In addition, the third patch fixes a long-standing bug about the build. I've decided to send these to you and the list instead of committing right away in case someone notices

[Patch v2] emacs: add pipe attachment command

On Mon, 07 May 2012, Jameson Graef Rollins wrote: > On Mon, May 07 2012, Mark Walters wrote: >> Here is a rebased to current master version of the previous patch: no >> other changes. > > Actually, what I sent was a rebase. Sorry somehow I missed that you had actually sent the rebase too: an

[PATCH v2 0/2] Better, more portable stat-ing logic for notmuch new

This version uses ARRAY_SIZE, fixes errno handling bugs, and corrects a spelling error. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v2 1/2] test: Test notmuch new with a broken symlink

--- test/new | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/new b/test/new index 99f9913..26253db 100755 --- a/test/new +++ b/test/new @@ -136,6 +136,16 @@ output=$(NOTMUCH_NEW) test_expect_equal "$output" "Added 1 new message to the database." +test_begin_subtest "Bro

[PATCH v2 2/2] new: Centralize file type stat-ing logic

This moves our logic to get a file's type into one function. This has several benefits: we can support OSes and file systems that do not provide dirent.d_type or always return DT_UNKNOWN, complex symlink-handling logic has been replaced by a simple stat fall-through in one place, and the error mes

Re: [PATCH 2/2] new: Centralize file type stat-ing logic

Quoth Jani Nikula on May 08 at 12:08 am: >On May 7, 2012 9:10 PM, "Austin Clements" <[1]amdra...@mit.edu> wrote: >> >> This moves our logic to get a file's type into one function.  This has >> several benefits: we can support OSes and file systems that do not >> provide dirent.d

Re: [PATCH 2/2] new: Centralize file type stat-ing logic

On May 8, 2012 12:08 AM, "Jani Nikula" wrote: > > > On May 7, 2012 9:10 PM, "Austin Clements" wrote: > > > > This moves our logic to get a file's type into one function. This has > > several benefits: we can support OSes and file systems that do not > > provide dirent.d_type or always return DT_

[PATCH 2/2] new: Centralize file type stat-ing logic

This moves our logic to get a file's type into one function. This has several benefits: we can support OSes and file systems that do not provide dirent.d_type or always return DT_UNKNOWN, complex symlink-handling logic has been replaced by a simple stat fall-through in one place, and the error mes

[PATCH 1/2] test: Test notmuch new with a broken symlink

--- test/new | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/new b/test/new index 99f9913..26253db 100755 --- a/test/new +++ b/test/new @@ -136,6 +136,16 @@ output=$(NOTMUCH_NEW) test_expect_equal "$output" "Added 1 new message to the database." +test_begin_subtest "Broke

[PATCH 0/2] Better, more portable stat-ing logic for notmuch new

This fully implements my suggestion from id:"20120411193609.GC13549 at mit.edu". Originally this was just meant to make the code more portable (since d_type is not portable), but it wound up also simplifying some of the notmuch new logic.

Re: [PATCH 2/2] new: Centralize file type stat-ing logic

On May 7, 2012 9:10 PM, "Austin Clements" wrote: > > This moves our logic to get a file's type into one function. This has > several benefits: we can support OSes and file systems that do not > provide dirent.d_type or always return DT_UNKNOWN, complex > symlink-handling logic has been replaced b

[PATCH 2/2] new: Centralize file type stat-ing logic

This moves our logic to get a file's type into one function. This has several benefits: we can support OSes and file systems that do not provide dirent.d_type or always return DT_UNKNOWN, complex symlink-handling logic has been replaced by a simple stat fall-through in one place, and the error mes

[PATCH 1/2] test: Test notmuch new with a broken symlink

--- test/new | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/new b/test/new index 99f9913..26253db 100755 --- a/test/new +++ b/test/new @@ -136,6 +136,16 @@ output=$(NOTMUCH_NEW) test_expect_equal "$output" "Added 1 new message to the database." +test_begin_subtest "Bro

[PATCH 0/2] Better, more portable stat-ing logic for notmuch new

This fully implements my suggestion from id:"20120411193609.gc13...@mit.edu". Originally this was just meant to make the code more portable (since d_type is not portable), but it wound up also simplifying some of the notmuch new logic. ___ notmuch mail

android 3.0 tablet and notmuch?

David Belohrad writes: > Dear All, > > i experience very weird problem: have samsung galaxy tab 10.1 without > any firmware tweaks. now, when I take a picture in the tablet and send > it via email to me, then I open this email in emacs, the picture is not > there. Only text part of the email is p

[PATCH] test: Force reply to use html2text for consistency

On Mon, May 07 2012, David Bremner wrote: > Adam Wolfe Gordon writes: > >> The output of the HTML reply test in the emacs suite can vary >> depending on which HTML renderers are installed on the machine running >> the tests. The renderer that is always available is emacs's builtin >> html2text f

Re: [Patch v2] emacs: add pipe attachment command

On Mon, May 07 2012, Mark Walters wrote: > Sorry somehow I missed that you had actually sent the rebase too: and > then I messed up my rebase. How embarrassing! > > Anyway many thanks for the correct rebase, and for spotting my stupid error. np ;) I've done plenty of things much more embarrassin

[Patch v2] emacs: add pipe attachment command

things much more embarrassing than that! jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120507/cf43f036/attachment.pgp>

Re: [Patch v2] emacs: add pipe attachment command

On Mon, 07 May 2012, Jameson Graef Rollins wrote: > On Mon, May 07 2012, Mark Walters wrote: >> Here is a rebased to current master version of the previous patch: no >> other changes. > > Actually, what I sent was a rebase. Sorry somehow I missed that you had actually sent the rebase too: and

[Patch v2] emacs: add pipe attachment command

Allow the user to pipe the attachment somewhere. Bound to '|' on the attachment button. --- Thanks for the review! Here is a rebased to current master version of the previous patch: no other changes. Best wishes Mark emacs/notmuch-show.el | 27 +++ 1 files changed, 2

Re: [Patch v2] emacs: add pipe attachment command

On Mon, May 07 2012, Mark Walters wrote: > Here is a rebased to current master version of the previous patch: no > other changes. Actually, what I sent was a rebase. And this rebase doesn't look correct. The notmuch-show-mm-display-part-inline function moved to notmuch-lib.el. It certainly has

[Patch v2] emacs: add pipe attachment command

g/pipermail/notmuch/attachments/20120507/d0040d05/attachment.pgp>

[PATCH 4/4] ruby: Add wrapper for notmuch_query_set_omit_excluded()

--- bindings/ruby/defs.h |3 +++ bindings/ruby/init.c |7 +++ bindings/ruby/query.c | 18 ++ 3 files changed, 28 insertions(+) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index 6fe5787..85d8205 100644 --- a/bindings/ruby/defs.h +++ b/bindings/ruby/defs

[PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one

- Make mkmf use the notmuch.h under ../../lib - Use libnotmuch.a instead of linking to the installed libnotmuch.so --- bindings/ruby/defs.h |4 ++-- bindings/ruby/extconf.rb | 26 ++ 2 files changed, 24 insertions(+), 6 deletions(-) diff --git a/bindings/ruby/def

[PATCH 2/4] ruby: Add wrapper for notmuch_query_add_tag_exclude

--- bindings/ruby/defs.h |3 +++ bindings/ruby/init.c |1 + bindings/ruby/query.c | 18 ++ 3 files changed, 22 insertions(+) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index 25222a6..a41cf10 100644 --- a/bindings/ruby/defs.h +++ b/bindings/ruby/defs.h @@

[PATCH 1/4] ruby: Add wrapper for notmuch_query_count_messages

--- bindings/ruby/defs.h |3 +++ bindings/ruby/init.c |3 ++- bindings/ruby/query.c | 21 - 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index 81f652f..25222a6 100644 --- a/bindings/ruby/defs.h +++ b/bin

[PATCH 0/4] ruby: quick update before the freeze!

Hey David, I've polished the small patch series I had lying around. I believe I've covered all the lacking API changes. In addition, the third patch fixes a long-standing bug about the build. I've decided to send these to you and the list instead of committing right away in case someone notices

Re: android 3.0 tablet and notmuch?

David Belohrad writes: > Dear All, > > i experience very weird problem: have samsung galaxy tab 10.1 without > any firmware tweaks. now, when I take a picture in the tablet and send > it via email to me, then I open this email in emacs, the picture is not > there. Only text part of the email is p

[Patch v2] emacs: add pipe attachment command

Allow the user to pipe the attachment somewhere. Bound to '|' on the attachment button. --- Thanks for the review! Here is a rebased to current master version of the previous patch: no other changes. Best wishes Mark emacs/notmuch-show.el | 27 +++ 1 files changed, 2

[PATCH] emacs: add pipe attachment command

From: Mark Walters Allow the user to pipe the attachment somewhere. Bound to '|' on the attachment button. Signed-off-by: Jameson Graef Rollins --- Nice missing feature. Tested and reviewed. It just needed to be rebased against the current master. emacs/notmuch-show.el | 10 ++ 1

[PATCH] emacs: add pipe attachment command

From: Mark Walters Allow the user to pipe the attachment somewhere. Bound to '|' on the attachment button. Signed-off-by: Jameson Graef Rollins --- Nice missing feature. Tested and reviewed. It just needed to be rebased against the current master. emacs/notmuch-show.el | 10 ++ 1