[PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Jani Nikula
On Thu, 24 May 2012, Austin Clements wrote: > Before XXX, add_files_recursive could have been called on a symlink to > a non-directory. Hence, calling it on a non-directory was not an > error, so a separate function, add_files, existed to fail loudly in > situations where the path had to be a dir

[PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Jani Nikula
On Thu, 24 May 2012, Austin Clements wrote: > Before XXX, add_files_recursive could have been called on a symlink to > a non-directory. Hence, calling it on a non-directory was not an > error, so a separate function, add_files, existed to fail loudly in > situations where the path had to be a dir

[PATCH v2 1/2] cli: also use Delivered-To header to figure out the reply from address

2012-05-24 Thread David Bremner
Jani Nikula writes: > Add another fallback header Delivered-To for guessing the user's from > address for notmuch reply before using the Received > headers. Apparently some MTAs use Delivered-To instead of > X-Original-To (which already exists as a fallback). series pushed to master. d

[PATCH] Recommend libgmime-2.6-dev in INSTALL

2012-05-24 Thread David Bremner
Austin Clements writes: > Given that everything prefers 2.6 over 2.4, it seems appropriate to > suggest that people install the 2.6 dev package instead of 2.4. pushed to master. d

[PATCH v4 1/4] test: Test notmuch new with a broken symlink

2012-05-24 Thread David Bremner
Austin Clements writes: > --- > test/new | 10 ++ > 1 file changed, 10 insertions(+) All 4 pushed to master. d

[PATCH] NEWS: started 0.13.1 stanza: fix decoding of text/plain parts in reply

2012-05-24 Thread David Bremner
Tomi Ollila writes: > NEWS item for forthcoming 0.13.1 bug fix release: UTF-8 characters were > incorrectly decoded when inserting reply content from text/plain parts. pushed to release, thanks. Hopefully I remember to fill in the date this time. d

[PATCH] NEWS for directory function fixes

2012-05-24 Thread Austin Clements
--- NEWS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NEWS b/NEWS index cac7c73..9fd1469 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,16 @@ Fix inserting of UTF-8 characters from *text/plain* parts in reply HTML-only emails), replying to mails that do have *text/plain* the

[PATCH] NEWS: started 0.13.1 stanza: fix decoding of text/plain parts in reply

2012-05-24 Thread Tomi Ollila
NEWS item for forthcoming 0.13.1 bug fix release: UTF-8 characters were incorrectly decoded when inserting reply content from text/plain parts. --- NEWS | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 668281c..067dcb7 100644 --- a/NEWS +++ b/

[PATCH] NEWS for directory function fixes

2012-05-24 Thread Austin Clements
--- NEWS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NEWS b/NEWS index cac7c73..9fd1469 100644 --- a/NEWS +++ b/NEWS @@ -11,6 +11,16 @@ Fix inserting of UTF-8 characters from *text/plain* parts in reply HTML-only emails), replying to mails that do have *text/plain* the

Re: [PATCH v2 1/2] cli: also use Delivered-To header to figure out the reply from address

2012-05-24 Thread David Bremner
Jani Nikula writes: > Add another fallback header Delivered-To for guessing the user's from > address for notmuch reply before using the Received > headers. Apparently some MTAs use Delivered-To instead of > X-Original-To (which already exists as a fallback). series pushed to master. d

Re: [PATCH] Recommend libgmime-2.6-dev in INSTALL

2012-05-24 Thread David Bremner
Austin Clements writes: > Given that everything prefers 2.6 over 2.4, it seems appropriate to > suggest that people install the 2.6 dev package instead of 2.4. pushed to master. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org

Re: [PATCH v4 1/4] test: Test notmuch new with a broken symlink

2012-05-24 Thread David Bremner
Austin Clements writes: > --- > test/new | 10 ++ > 1 file changed, 10 insertions(+) All 4 pushed to master. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v4 4/4] new: Unify add_files and add_files_recursive

2012-05-24 Thread Austin Clements
Since starting at the top of a directory tree and recursing within that tree are now identical operations, there's no need for both add_files and add_files_recursive. This eliminates add_files (which did nothing more than call add_files_recursive after the previous patch) and renames add_files_rec

[PATCH v4 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Austin Clements
Previously, add_files_recursive could have been called on a symlink to a non-directory. Hence, calling it on a non-directory was not an error, so a separate function, add_files, existed to fail loudly in situations where the path had to be a directory. With the new stat-ing logic, add_files_recur

[PATCH v4 2/4] new: Centralize file type stat-ing logic

2012-05-24 Thread Austin Clements
This moves our logic to get a file's type into one function. This has several benefits: we can support OSes and file systems that do not provide dirent.d_type or always return DT_UNKNOWN, complex symlink-handling logic has been replaced by a simple stat fall-through in one place, and the error mes

[PATCH v4 1/4] test: Test notmuch new with a broken symlink

2012-05-24 Thread Austin Clements
--- test/new | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/new b/test/new index 99f9913..a7bc146 100755 --- a/test/new +++ b/test/new @@ -136,6 +136,16 @@ output=$(NOTMUCH_NEW) test_expect_equal "$output" "Added 1 new message to the database." +test_begin_subtest "Broke

[PATCH v4 0/4] Better, more portable stat-ing logic for notmuch new

2012-05-24 Thread Austin Clements
This time for sure. v4 fixes a left-over XXX in the commit message of patch 3.

[PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Austin Clements
Quoth Jani Nikula on May 24 at 11:57 pm: > On Thu, 24 May 2012, Austin Clements wrote: > > Before XXX, add_files_recursive could have been called on a symlink to > > a non-directory. Hence, calling it on a non-directory was not an > > error, so a separate function, add_files, existed to fail loud

Re: [PATCH] NEWS: started 0.13.1 stanza: fix decoding of text/plain parts in reply

2012-05-24 Thread David Bremner
Tomi Ollila writes: > NEWS item for forthcoming 0.13.1 bug fix release: UTF-8 characters were > incorrectly decoded when inserting reply content from text/plain parts. pushed to release, thanks. Hopefully I remember to fill in the date this time. d __

[PATCH] Recommend libgmime-2.6-dev in INSTALL

2012-05-24 Thread Austin Clements
Given that everything prefers 2.6 over 2.4, it seems appropriate to suggest that people install the 2.6 dev package instead of 2.4. --- INSTALL |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INSTALL b/INSTALL index bc98f1d..fce9352 100644 --- a/INSTALL +++ b/INSTALL @@ -65,

[PATCH v3 4/4] new: Unify add_files and add_files_recursive

2012-05-24 Thread Austin Clements
Since starting at the top of a directory tree and recursing within that tree are now identical operations, there's no need for both add_files and add_files_recursive. This eliminates add_files (which did nothing more than call add_files_recursive after the previous patch) and renames add_files_rec

[PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Austin Clements
Before XXX, add_files_recursive could have been called on a symlink to a non-directory. Hence, calling it on a non-directory was not an error, so a separate function, add_files, existed to fail loudly in situations where the path had to be a directory. With the new stat-ing logic, add_files_recur

[PATCH v3 2/4] new: Centralize file type stat-ing logic

2012-05-24 Thread Austin Clements
This moves our logic to get a file's type into one function. This has several benefits: we can support OSes and file systems that do not provide dirent.d_type or always return DT_UNKNOWN, complex symlink-handling logic has been replaced by a simple stat fall-through in one place, and the error mes

[PATCH v3 1/4] test: Test notmuch new with a broken symlink

2012-05-24 Thread Austin Clements
--- test/new | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/new b/test/new index 99f9913..a7bc146 100755 --- a/test/new +++ b/test/new @@ -136,6 +136,16 @@ output=$(NOTMUCH_NEW) test_expect_equal "$output" "Added 1 new message to the database." +test_begin_subtest "Broke

[PATCH v3 0/4] Better, more portable stat-ing logic for notmuch new

2012-05-24 Thread Austin Clements
v3 is a rebase to current master that resolves one trivial conflict. This also fixes a bug in the broken symlink test where I had hard-coded the maildir path.

[PATCH v4 4/4] new: Unify add_files and add_files_recursive

2012-05-24 Thread Austin Clements
Since starting at the top of a directory tree and recursing within that tree are now identical operations, there's no need for both add_files and add_files_recursive. This eliminates add_files (which did nothing more than call add_files_recursive after the previous patch) and renames add_files_rec

[PATCH v4 2/4] new: Centralize file type stat-ing logic

2012-05-24 Thread Austin Clements
This moves our logic to get a file's type into one function. This has several benefits: we can support OSes and file systems that do not provide dirent.d_type or always return DT_UNKNOWN, complex symlink-handling logic has been replaced by a simple stat fall-through in one place, and the error mes

[PATCH v4 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Austin Clements
Previously, add_files_recursive could have been called on a symlink to a non-directory. Hence, calling it on a non-directory was not an error, so a separate function, add_files, existed to fail loudly in situations where the path had to be a directory. With the new stat-ing logic, add_files_recur

[PATCH v4 1/4] test: Test notmuch new with a broken symlink

2012-05-24 Thread Austin Clements
--- test/new | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/new b/test/new index 99f9913..a7bc146 100755 --- a/test/new +++ b/test/new @@ -136,6 +136,16 @@ output=$(NOTMUCH_NEW) test_expect_equal "$output" "Added 1 new message to the database." +test_begin_subtest "Bro

[PATCH v4 0/4] Better, more portable stat-ing logic for notmuch new

2012-05-24 Thread Austin Clements
This time for sure. v4 fixes a left-over XXX in the commit message of patch 3. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Austin Clements
Quoth Jani Nikula on May 24 at 11:57 pm: > On Thu, 24 May 2012, Austin Clements wrote: > > Before XXX, add_files_recursive could have been called on a symlink to > > a non-directory. Hence, calling it on a non-directory was not an > > error, so a separate function, add_files, existed to fail loud

Re: [PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Jameson Graef Rollins
On Thu, May 24 2012, Jani Nikula wrote: > Grrh, sorry for the spam. My favourite MUA told me: > > "Sending...failed to WARNING: gnome-keyring:: couldn't connect to: > /tmp/keyring-Ky8i5h/pkcs11: No such file or directory" > > but sent the message anyway. Apparently msmpt tries to chat with the > g

[PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Jameson Graef Rollins
On Thu, May 24 2012, Jani Nikula wrote: > Grrh, sorry for the spam. My favourite MUA told me: > > "Sending...failed to WARNING: gnome-keyring:: couldn't connect to: > /tmp/keyring-Ky8i5h/pkcs11: No such file or directory" > > but sent the message anyway. Apparently msmpt tries to chat with the > g

Re: [PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Jani Nikula
Grrh, sorry for the spam. My favourite MUA told me: "Sending...failed to WARNING: gnome-keyring:: couldn't connect to: /tmp/keyring-Ky8i5h/pkcs11: No such file or directory" but sent the message anyway. Apparently msmpt tries to chat with the gnome-keyring-daemon even though that should not happ

Re: [PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Jani Nikula
On Thu, 24 May 2012, Austin Clements wrote: > Before XXX, add_files_recursive could have been called on a symlink to > a non-directory. Hence, calling it on a non-directory was not an > error, so a separate function, add_files, existed to fail loudly in > situations where the path had to be a dir

Re: [PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Jani Nikula
On Thu, 24 May 2012, Austin Clements wrote: > Before XXX, add_files_recursive could have been called on a symlink to > a non-directory. Hence, calling it on a non-directory was not an > error, so a separate function, add_files, existed to fail loudly in > situations where the path had to be a dir

[PATCH] Recommend libgmime-2.6-dev in INSTALL

2012-05-24 Thread Austin Clements
Given that everything prefers 2.6 over 2.4, it seems appropriate to suggest that people install the 2.6 dev package instead of 2.4. --- INSTALL |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INSTALL b/INSTALL index bc98f1d..fce9352 100644 --- a/INSTALL +++ b/INSTALL @@ -65,

[PATCH v3 2/4] new: Centralize file type stat-ing logic

2012-05-24 Thread Austin Clements
This moves our logic to get a file's type into one function. This has several benefits: we can support OSes and file systems that do not provide dirent.d_type or always return DT_UNKNOWN, complex symlink-handling logic has been replaced by a simple stat fall-through in one place, and the error mes

[PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive

2012-05-24 Thread Austin Clements
Before XXX, add_files_recursive could have been called on a symlink to a non-directory. Hence, calling it on a non-directory was not an error, so a separate function, add_files, existed to fail loudly in situations where the path had to be a directory. With the new stat-ing logic, add_files_recur

[PATCH v3 0/4] Better, more portable stat-ing logic for notmuch new

2012-05-24 Thread Austin Clements
v3 is a rebase to current master that resolves one trivial conflict. This also fixes a bug in the broken symlink test where I had hard-coded the maildir path. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuc

[PATCH v3 4/4] new: Unify add_files and add_files_recursive

2012-05-24 Thread Austin Clements
Since starting at the top of a directory tree and recursing within that tree are now identical operations, there's no need for both add_files and add_files_recursive. This eliminates add_files (which did nothing more than call add_files_recursive after the previous patch) and renames add_files_rec

[PATCH v3 1/4] test: Test notmuch new with a broken symlink

2012-05-24 Thread Austin Clements
--- test/new | 10 ++ 1 file changed, 10 insertions(+) diff --git a/test/new b/test/new index 99f9913..a7bc146 100755 --- a/test/new +++ b/test/new @@ -136,6 +136,16 @@ output=$(NOTMUCH_NEW) test_expect_equal "$output" "Added 1 new message to the database." +test_begin_subtest "Bro

[PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one

2012-05-24 Thread Felipe Contreras
On Thu, May 24, 2012 at 3:22 AM, David Bremner wrote: > Felipe Contreras writes: > > >> I don't see how this patch could be fixed properly easily, and it was >> labeled as a hack, and I didn't like it in the first place anyway, so >> I'm going to revert it by tomorrow if I don't hear any good rea

[PATCH] NEWS: started 0.13.1 stanza: fix decoding of text/plain parts in reply

2012-05-24 Thread Tomi Ollila
NEWS item for forthcoming 0.13.1 bug fix release: UTF-8 characters were incorrectly decoded when inserting reply content from text/plain parts. --- NEWS | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 668281c..067dcb7 100644 --- a/NEWS +++ b/

Emacs notmuch-show consistently reports "End of file during parsing"

2012-05-24 Thread Tomi Ollila
On Wed, May 23 2012, Tellman wrote: > Thanks for the quick response. > > I have gmime 2.4 installed. Gmime 2.4.x -- what is the value if 'x' :D ? > I tried the search and show commands and the responses all looked OK to > me, although I wasn't quite sure what to look for. I didn't see any > er

[PATCH v2 2/2] test: add tests for notmuch reply From guessing

2012-05-24 Thread Jani Nikula
Add tests for picking up user's From address from fallback headers Envelope-To, X-Original-To, and Delivered-To. Signed-off-by: Jani Nikula --- test/reply | 55 +++ 1 file changed, 55 insertions(+) diff --git a/test/reply b/test/reply index

[PATCH v2 1/2] cli: also use Delivered-To header to figure out the reply from address

2012-05-24 Thread Jani Nikula
Add another fallback header Delivered-To for guessing the user's from address for notmuch reply before using the Received headers. Apparently some MTAs use Delivered-To instead of X-Original-To (which already exists as a fallback). Reported-by: Michael Hudson-Doyle Signed-off-by: Jani Nikula ---

[PATCH v2 0/2] delivered-to for reply address guessing

2012-05-24 Thread Jani Nikula
id:"21a946917c5c8dd63295b7c87b7c2d1ebcb6e71e.1336746160.git.jani at nikula.org" rebased against current master. No changes since v1. BR, Jani. Jani Nikula (2): cli: also use Delivered-To header to figure out the reply from address test: add tests for notmuch reply From guessing notmuch-

Re: [PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one

2012-05-24 Thread Felipe Contreras
On Thu, May 24, 2012 at 3:22 AM, David Bremner wrote: > Felipe Contreras writes: > > >> I don't see how this patch could be fixed properly easily, and it was >> labeled as a hack, and I didn't like it in the first place anyway, so >> I'm going to revert it by tomorrow if I don't hear any good rea

[ANN] New awesome vim plug-in using Ruby bindings

2012-05-24 Thread Felipe Contreras
On Tue, May 15, 2012 at 5:15 AM, Karl Harris wrote: > I am trying the notmuch-vim-ruby plugin for the first time.? Previously, I > had been using the vim plugin that comes with notmuch. > > If I type :NotMuchR in vim, I get the following error messages: > -- > Error detected while

[PATCH 3/4] ruby: Add workarounds to use in-tree build not the installed one

2012-05-24 Thread Felipe Contreras
On Mon, May 7, 2012 at 5:02 PM, Ali Polatel wrote: > - Make mkmf use the notmuch.h under ../../lib > - Use libnotmuch.a instead of linking to the installed libnotmuch.so How has this ever worked? libnotmuch.so links to many things, fortunately when linking Ruby's notmuch.so binding to libnotmuch