[PATCH 8/8] cli: use notmuch_exclude_t in option parser

2012-06-20 Thread Peter Wang
Use notmuch_exclude_t constants directly instead of a redundant enumeration while parsing search --exclude keyword arguments. --- notmuch-search.c | 28 +--- 1 files changed, 9 insertions(+), 19 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index 027923d.

[PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-06-20 Thread Peter Wang
Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can cover all four values of search --exclude in the cli. --- lib/notmuch.h|1 + lib/query.cc |6 -- notmuch-search.c |2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/notmuch.h b/lib/notmuch.h

[PATCH 6/8] man: document search --exclude=all

2012-06-20 Thread Peter Wang
Document the new search --exclude=all option. --- man/man1/notmuch-search.1 |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/man/man1/notmuch-search.1 b/man/man1/notmuch-search.1 index e23ca30..1d8d57a 100644 --- a/man/man1/notmuch-search.1 +++ b/man/man1/notmuch-searc

[PATCH 5/8] man: clarify search --exclude=flag

2012-06-20 Thread Peter Wang
Improve the description of the search --exclude=flag option, using text taken from the commit that introduced the option. --- man/man1/notmuch-search.1 |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/man/man1/notmuch-search.1 b/man/man1/notmuch-search.1 index 003b74

[PATCH 4/8] man: clarify search --exclude documentation

2012-06-20 Thread Peter Wang
Highlight "excluded messages" as a piece of jargon with a meaning that may not be obvious. Be explicit about the effects of search --exclude=true and --exclude=false. --- man/man1/notmuch-search.1 | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/man/man1/notm

[PATCH 3/8] test: add tests for search --exclude=all

2012-06-20 Thread Peter Wang
Test the new search --exclude=all option. --- test/excludes | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/test/excludes b/test/excludes index 24d653e..f1ae9ea 100755 --- a/test/excludes +++ b/test/excludes @@ -166,6 +166,16 @@ ${matching_message_ids

[PATCH 2/8] cli: add --exclude=all option to notmuch-search.c

2012-06-20 Thread Peter Wang
From: Mark Walters Add a --exclude=all option to notmuch search. --- notmuch-search.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index 3be296d..89b5bf9 100644 --- a/notmuch-search.c +++ b/notmuch-search.c @@ -420,6 +420,7 @

[PATCH 1/8] lib: add --exclude=all option

2012-06-20 Thread Peter Wang
From: Mark Walters Adds a exclude all option to the lib which means that excluded messages are completely ignored (as if they had actually been deleted). --- lib/notmuch-private.h |1 + lib/notmuch.h | 22 +++--- lib/query.cc | 10 ++ lib/thread.c

[PATCH 0/8] search --exclude=all

2012-06-20 Thread Peter Wang
Hi, This is Mark's change to add search --exclude=all. I mainly just updated a comment and added some documentation. Mark Walters (2): lib: add --exclude=all option cli: add --exclude=all option to notmuch-search.c Peter Wang (6): test: add tests for search --exclude=all man: clarify sea

miraculous from: field

2012-06-20 Thread Adam Wolfe Gordon
On Wed, Jun 20, 2012 at 5:33 AM, Jani Nikula wrote: > The reply template comes from 'notmuch reply' cli command, while the > forwarding is internal to the emacs ui. I don't have any quick solutions, > but perhaps in the long run we should do the forwarding template in the cli > too. I think this

[PATCH 4/8] man: clarify search --exclude documentation

2012-06-20 Thread Mark Walters
I have reviewed all the new parts of this series (judged as being patches 3-8) and the changes made to my two patches and they are all fine (with one small comment below). Patch 1/8 does need a proper review though as it ended up more intrusive than I would have liked. > +Messages matching search

Re: miraculous from: field

2012-06-20 Thread Adam Wolfe Gordon
On Wed, Jun 20, 2012 at 5:33 AM, Jani Nikula wrote: > The reply template comes from 'notmuch reply' cli command, while the > forwarding is internal to the emacs ui. I don't have any quick solutions, > but perhaps in the long run we should do the forwarding template in the cli > too. I think this

miraculous from: field

2012-06-20 Thread Austin Clements
Quoth David Belohrad on Jun 20 at 1:25 pm: > > Dear All, > > could someone give a hint? > > I have an opened mail message. When I press 'r' to reply, a new mail > buffer is opened and the 'From' field is correctly filled with > 'david at belohrad.ch'. > > When on the same message I press howev

miraculous from: field

2012-06-20 Thread Jani Nikula
ng template in the cli too. > thanks > > david > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120620/226efc55/attachment.html>

miraculous from: field

2012-06-20 Thread David Belohrad
Dear All, could someone give a hint? I have an opened mail message. When I press 'r' to reply, a new mail buffer is opened and the 'From' field is correctly filled with 'david at belohrad.ch'. When on the same message I press however 'f' to forward the message, new buffer opens, but this time t

Re: [PATCH 4/8] man: clarify search --exclude documentation

2012-06-20 Thread Mark Walters
I have reviewed all the new parts of this series (judged as being patches 3-8) and the changes made to my two patches and they are all fine (with one small comment below). Patch 1/8 does need a proper review though as it ended up more intrusive than I would have liked. > +Messages matching search

Re: miraculous from: field

2012-06-20 Thread Austin Clements
Quoth David Belohrad on Jun 20 at 1:25 pm: > > Dear All, > > could someone give a hint? > > I have an opened mail message. When I press 'r' to reply, a new mail > buffer is opened and the 'From' field is correctly filled with > 'da...@belohrad.ch'. > > When on the same message I press however

Notmuch Pick

2012-06-20 Thread Peter Wang
On Tue, 19 Jun 2012 11:52:01 -0700, Jameson Graef Rollins wrote: > > So I think it would be nice and clean if the default json output > included all the message headers and the message structure, and then > part contents could be retrieved individually. I imagine show mode > could be restructure

[PATCH 8/8] cli: use notmuch_exclude_t in option parser

2012-06-20 Thread Peter Wang
Use notmuch_exclude_t constants directly instead of a redundant enumeration while parsing search --exclude keyword arguments. --- notmuch-search.c | 28 +--- 1 files changed, 9 insertions(+), 19 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index 027923d.

[PATCH 7/8] lib: add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t

2012-06-20 Thread Peter Wang
Add NOTMUCH_EXCLUDE_FLAG to notmuch_exclude_t so that it can cover all four values of search --exclude in the cli. --- lib/notmuch.h|1 + lib/query.cc |6 -- notmuch-search.c |2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/notmuch.h b/lib/notmuch.h

[PATCH 6/8] man: document search --exclude=all

2012-06-20 Thread Peter Wang
Document the new search --exclude=all option. --- man/man1/notmuch-search.1 |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/man/man1/notmuch-search.1 b/man/man1/notmuch-search.1 index e23ca30..1d8d57a 100644 --- a/man/man1/notmuch-search.1 +++ b/man/man1/notmuch-searc

[PATCH 5/8] man: clarify search --exclude=flag

2012-06-20 Thread Peter Wang
Improve the description of the search --exclude=flag option, using text taken from the commit that introduced the option. --- man/man1/notmuch-search.1 |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/man/man1/notmuch-search.1 b/man/man1/notmuch-search.1 index 003b74

[PATCH 2/8] cli: add --exclude=all option to notmuch-search.c

2012-06-20 Thread Peter Wang
From: Mark Walters Add a --exclude=all option to notmuch search. --- notmuch-search.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index 3be296d..89b5bf9 100644 --- a/notmuch-search.c +++ b/notmuch-search.c @@ -420,6 +420,7 @

[PATCH 4/8] man: clarify search --exclude documentation

2012-06-20 Thread Peter Wang
Highlight "excluded messages" as a piece of jargon with a meaning that may not be obvious. Be explicit about the effects of search --exclude=true and --exclude=false. --- man/man1/notmuch-search.1 | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/man/man1/notm

[PATCH 3/8] test: add tests for search --exclude=all

2012-06-20 Thread Peter Wang
Test the new search --exclude=all option. --- test/excludes | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/test/excludes b/test/excludes index 24d653e..f1ae9ea 100755 --- a/test/excludes +++ b/test/excludes @@ -166,6 +166,16 @@ ${matching_message_ids

[PATCH 1/8] lib: add --exclude=all option

2012-06-20 Thread Peter Wang
From: Mark Walters Adds a exclude all option to the lib which means that excluded messages are completely ignored (as if they had actually been deleted). --- lib/notmuch-private.h |1 + lib/notmuch.h | 22 +++--- lib/query.cc | 10 ++ lib/thread.c

[PATCH 0/8] search --exclude=all

2012-06-20 Thread Peter Wang
Hi, This is Mark's change to add search --exclude=all. I mainly just updated a comment and added some documentation. Mark Walters (2): lib: add --exclude=all option cli: add --exclude=all option to notmuch-search.c Peter Wang (6): test: add tests for search --exclude=all man: clarify sea

Re: miraculous from: field

2012-06-20 Thread Jani Nikula
On Jun 20, 2012 2:25 PM, "David Belohrad" wrote: > > > Dear All, > > could someone give a hint? > > I have an opened mail message. When I press 'r' to reply, a new mail > buffer is opened and the 'From' field is correctly filled with > 'da...@belohrad.ch'. > > When on the same message I press howe

miraculous from: field

2012-06-20 Thread David Belohrad
Dear All, could someone give a hint? I have an opened mail message. When I press 'r' to reply, a new mail buffer is opened and the 'From' field is correctly filled with 'da...@belohrad.ch'. When on the same message I press however 'f' to forward the message, new buffer opens, but this time the