Re: [PATCH v3 0/9] JSON-based search-mode

2012-07-10 Thread Mark Walters
On Mon, 09 Jul 2012, Austin Clements wrote: > This fixes the docstings for notmuch-json-read and notmuch-json-eof as > suggested by Mark. No other changes. This is a definite +1 from me: It all seems to work perfectly, and fixes a definite bug (and makes it easy to fix some other bugs when cha

[PATCH v3 3/3] Use the structured format printer in notmuch search.

2012-07-10 Thread cra...@gmx.net
This patch uses the previously introduced structured format printer in notmuch-search. Most of this patch is necessary to keep the text output unchanged. All tests pass, both text and JSON are printed exactly the same as they were before. --- notmuch-search.c | 275 +

[PATCH v3 2/3] Adding structured output formatter for JSON.

2012-07-10 Thread cra...@gmx.net
This formatter prints exactly the same structure as the existing JSON formatter, but uses the newly introduced structured formatting primitives. --- structured-output.c | 159 +++ structured-output.h | 48 2 files changed, 207 in

[PATCH v3 1/3] Add support for structured output formatters.

2012-07-10 Thread cra...@gmx.net
This patch adds a new type structure_printer, which is used for structured formatting, e.g. JSON or S-Expressions. The structure contains the following function pointers: - initial_state: is called to create a state object, that is passed to all invocations. This should be used to keep track of

[PATCH] v2: Added better support for multiple structured output formats.

2012-07-10 Thread Mark Walters
On Tue, 10 Jul 2012, craven at gmx.net wrote: > As discussed in , this patch adds > support for new structured output formats (like s-expressions) by using > stateful structure_printers. An implementation of the JSON structure > printer that passes all tests is included. The output for JSON (and >

Tests

2012-07-10 Thread Mark Walters
I have been thinking a little bit about the current situation with regards to tests. There are quite a lot of tests in the review queue that have been there for quite some time without much interest, but I do think we are rather short of tests. (*) I wonder if we could have a sort of staging area

deprecating legacy text output

2012-07-10 Thread David Bremner
On Tue, 10 Jul 2012 10:04:10 -0700, Jameson Graef Rollins wrote: > On Tue, Jul 10 2012, Mark Walters wrote: > > I think I would also add something saying that the text format is just > > different (and that a significant chunk of the patch is just that). > > Can we not just dump this output form

post-new [was: Re: query on a subset of messages ?]

2012-07-10 Thread Jani Nikula
to run notmuch new on its own. If your tagging setup is really complicated, you could have some-tag in new.tags config, and bail out early if notmuch count tag:some-tag outputs 0 (and obviously notmuch tag -some-tag tag:some-tag later in the script). Just a thought. J. > > -s -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120710/c069b7cf/attachment.html>

notmuch-emacs and bbdb

2012-07-10 Thread Daniel Bergey
As far as I can tell, notmuch doesn't integrate as smoothly with bbdb as older emacs mailclients. I'm especially looking for a snarf function that distinguishes sender from recipient. How do other people use bbdb with notmuch? Does anyone have lisp code like that which ships with bbdb for other

notmuch-emacs and bbdb

2012-07-10 Thread Daniel Bergey
As far as I can tell, notmuch doesn't integrate as smoothly with bbdb as older emacs mailclients. I'm especially looking for a snarf function that distinguishes sender from recipient. How do other people use bbdb with notmuch? Does anyone have lisp code like that which ships with bbdb for other

deprecating legacy text output

2012-07-10 Thread David Bremner
On Tue, 10 Jul 2012 10:04:10 -0700, Jameson Graef Rollins wrote: > On Tue, Jul 10 2012, Mark Walters wrote: > > I think I would also add something saying that the text format is just > > different (and that a significant chunk of the patch is just that). > > Can we not just dump this output for

[PATCH] v2: Added better support for multiple structured output formats.

2012-07-10 Thread cra...@gmx.net
As discussed in , this patch adds support for new structured output formats (like s-expressions) by using stateful structure_printers. An implementation of the JSON structure printer that passes all tests is included. The output for JSON (and text) is identical to the current output. S-Expressions

[PATCH] contib/nmbug/nmbug-status: leftover whitespaces, indentation & quoting

2012-07-10 Thread Tomi Ollila
The initial nmbug-status was pretty consistent in it's whitespacing but a few lines had some leftover slips. Those are now "corrected". Also, most of the code used ' as quoting char. As in Python one can use ' and " interchangeably some code used " instead of '. However the usage of those were inc

[PATCH] v2: Added better support for multiple structured output formats.

2012-07-10 Thread Austin Clements
Since it would be great to use the structure printer for show as well, it would make sense to put it in its own source file, where it can easily be shared between commands. There are a few systematic code formatting problems in your patch. To be consistent with other notmuch code, there should be

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Mark Walters
> notmuch-search.c | 453 > +++ > 1 file changed, 326 insertions(+), 127 deletions(-) Hi for such a large patch this was surprisingly easy to follow (though I am not saying I have worked through all the details). However, there are some prelim

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Austin Clements
Quoth Jameson Graef Rollins on Jul 10 at 10:04 am: > On Tue, Jul 10 2012, Mark Walters wrote: > > I think I would also add something saying that the text format is just > > different (and that a significant chunk of the patch is just that). > > Can we not just dump this output format once and for

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread cra...@gmx.net
Sorry, the original patch I sent was missing a small part, here the full patch: As discussed in , this patch adds support for new structured output formats (like s-expressions) by using stateful structure_printers. An implementation of the JSON structure printer that passes all tests is included.

Re: [PATCH] v2: Added better support for multiple structured output formats.

2012-07-10 Thread Austin Clements
Since it would be great to use the structure printer for show as well, it would make sense to put it in its own source file, where it can easily be shared between commands. There are a few systematic code formatting problems in your patch. To be consistent with other notmuch code, there should be

ANN: Speedee, a web-based notmuch client

2012-07-10 Thread elf Pavlik
Hi, Sounds great! https://speedee.bugsplat.info/#search/ruby throws at me: NoMethodError at / undefined method `close' for nil:NilClass file: app.rb location: block in line: 16 Looking forward to play with you demo :) Thanks! ~ elf Pavlik ~ Excerpts from Peter Keen's message of

[PATCH] Added better support for multiple structured output formats.

2012-07-10 Thread cra...@gmx.net
As discussed in , this patch adds support for new structured output formats (like s-expressions) by using stateful structure_printers. An implementation of the JSON structure printer that passes all tests is included. Structure printers have functions for starting a map, a list, closing any number

post-new [was: Re: query on a subset of messages ?]

2012-07-10 Thread Sebastien Binet
was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120710/8e3e0334/attachment.pgp>

[PATCH v3 3/3] Use the structured format printer in notmuch search.

2012-07-10 Thread craven
This patch uses the previously introduced structured format printer in notmuch-search. Most of this patch is necessary to keep the text output unchanged. All tests pass, both text and JSON are printed exactly the same as they were before. --- notmuch-search.c | 275 +

[PATCH v3 2/3] Adding structured output formatter for JSON.

2012-07-10 Thread craven
This formatter prints exactly the same structure as the existing JSON formatter, but uses the newly introduced structured formatting primitives. --- structured-output.c | 159 +++ structured-output.h | 48 2 files changed, 207 in

[PATCH v3 1/3] Add support for structured output formatters.

2012-07-10 Thread craven
This patch adds a new type structure_printer, which is used for structured formatting, e.g. JSON or S-Expressions. The structure contains the following function pointers: - initial_state: is called to create a state object, that is passed to all invocations. This should be used to keep track of

Re: [PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Jameson Graef Rollins
On Tue, Jul 10 2012, Austin Clements wrote: > Quoth Jameson Graef Rollins on Jul 10 at 10:04 am: >> On Tue, Jul 10 2012, Mark Walters wrote: >> > I think I would also add something saying that the text format is just >> > different (and that a significant chunk of the patch is just that). >> >>

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Jameson Graef Rollins
ut. You're right that the text search output is more widely used. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120710/1889c9ec/attachment.pgp>

Re: [PATCH] v2: Added better support for multiple structured output formats.

2012-07-10 Thread Mark Walters
On Tue, 10 Jul 2012, cra...@gmx.net wrote: > As discussed in , this patch adds > support for new structured output formats (like s-expressions) by using > stateful structure_printers. An implementation of the JSON structure > printer that passes all tests is included. The output for JSON (and > tex

Re: [PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Austin Clements
Quoth Jameson Graef Rollins on Jul 10 at 10:04 am: > On Tue, Jul 10 2012, Mark Walters wrote: > > I think I would also add something saying that the text format is just > > different (and that a significant chunk of the patch is just that). > > Can we not just dump this output format once and for

ANN: Speedee, a web-based notmuch client

2012-07-10 Thread Christophe-Marie Duquesne
On Tue, Jul 10, 2012 at 7:14 AM, Peter Keen wrote: > let me know what you think! This is awesome, I love it!

Re: [PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Jameson Graef Rollins
On Tue, Jul 10 2012, Mark Walters wrote: > I think I would also add something saying that the text format is just > different (and that a significant chunk of the patch is just that). Can we not just dump this output format once and for all? Does anything use it? And if so can we just modify it

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Jameson Graef Rollins
modify it to use a more sensible format? jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120710/05948522/attachment.pgp>

Re: [PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Jameson Graef Rollins
On Tue, Jul 10 2012, cra...@gmx.net wrote: > Sorry, the original patch I sent was missing a small part, here the full > patch: > > As discussed in , this patch adds > support for new structured output formats (like s-expressions) by using > stateful structure_printers. An implementation of the JSON

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Jameson Graef Rollins
re Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120710/74c64ff7/attachment.pgp>

Tests

2012-07-10 Thread Mark Walters
I have been thinking a little bit about the current situation with regards to tests. There are quite a lot of tests in the review queue that have been there for quite some time without much interest, but I do think we are rather short of tests. (*) I wonder if we could have a sort of staging area

Re: post-new [was: Re: query on a subset of messages ?]

2012-07-10 Thread Jameson Graef Rollins
On Tue, Jul 10 2012, Sebastien Binet wrote: > ok. I thought using the post-new hook would have saved some i/o > resources over my current setup: > offlineimap.postsynchook = ~/emacs/notmuch-lib/notmuch-tag.sh > > where notmuch-tag.sh is (in pseudo-code): > ## > /usr/bin/notmuch new > > for tag,qu

post-new [was: Re: query on a subset of messages ?]

2012-07-10 Thread Jameson Graef Rollins
-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120710/f68c2784/attachment.pgp>

[PATCH 1/3] emacs: add no-display arg to notmuch-hello-refresh-hook

2012-07-10 Thread Jani Nikula
r when you switch to it. There's no point in displaying the refresh message when you don't also switch to the buffer, is there? And this way you'll get the diff between the manual (through user interaction) refreshes of the buffer, not between two cron jobs. J. ------ next part ---

Re: ANN: Speedee, a web-based notmuch client

2012-07-10 Thread Peter Keen
On Tue, Jul 10, 2012 at 5:08 AM, elf Pavlik wrote: > Hi, > > Sounds great! > > https://speedee.bugsplat.info/#search/ruby throws at me: > > NoMethodError at / > undefined method `close' for nil:NilClass > > file: app.rb > location: block in > line: 16 > > Looking forward to play with

ANN: Speedee, a web-based notmuch client

2012-07-10 Thread Peter Keen
scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120710/f0282786/attachment.html>

[PATCH] v2: Added better support for multiple structured output formats.

2012-07-10 Thread craven
As discussed in , this patch adds support for new structured output formats (like s-expressions) by using stateful structure_printers. An implementation of the JSON structure printer that passes all tests is included. The output for JSON (and text) is identical to the current output. S-Expressions

Re: post-new [was: Re: query on a subset of messages ?]

2012-07-10 Thread Jani Nikula
On Jul 10, 2012 12:59 PM, "Sebastien Binet" wrote: > > Jani Nikula writes: > > > On Jul 9, 2012 8:12 PM, "Jameson Graef Rollins" < jroll...@finestructure.net> > > wrote: > >> > >> On Mon, Jul 09 2012, Sebastien Binet wrote: > >> > hum... is post-new supposed to be run even if there is no new mes

Re: [PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread Mark Walters
> notmuch-search.c | 453 > +++ > 1 file changed, 326 insertions(+), 127 deletions(-) Hi for such a large patch this was surprisingly easy to follow (though I am not saying I have worked through all the details). However, there are some prelim

Re: ANN: Speedee, a web-based notmuch client

2012-07-10 Thread elf Pavlik
Hi, Sounds great! https://speedee.bugsplat.info/#search/ruby throws at me: NoMethodError at / undefined method `close' for nil:NilClass file: app.rb location: block in line: 16 Looking forward to play with you demo :) Thanks! ~ elf Pavlik ~ Excerpts from Peter Keen's message of

[PATCH] FIXED: Added better support for multiple structured output formats.

2012-07-10 Thread craven
Sorry, the original patch I sent was missing a small part, here the full patch: As discussed in , this patch adds support for new structured output formats (like s-expressions) by using stateful structure_printers. An implementation of the JSON structure printer that passes all tests is included.

[PATCH] Added better support for multiple structured output formats.

2012-07-10 Thread craven
As discussed in , this patch adds support for new structured output formats (like s-expressions) by using stateful structure_printers. An implementation of the JSON structure printer that passes all tests is included. Structure printers have functions for starting a map, a list, closing any number

Re: post-new [was: Re: query on a subset of messages ?]

2012-07-10 Thread Sebastien Binet
Jani Nikula writes: > On Jul 9, 2012 8:12 PM, "Jameson Graef Rollins" > wrote: >> >> On Mon, Jul 09 2012, Sebastien Binet wrote: >> > hum... is post-new supposed to be run even if there is no new message ? >> >> Hi, Sebastian. Yes, I think it runs regardless if there are any new >> messages or

Re: ANN: Speedee, a web-based notmuch client

2012-07-10 Thread Christophe-Marie Duquesne
On Tue, Jul 10, 2012 at 7:14 AM, Peter Keen wrote: > let me know what you think! This is awesome, I love it! ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: ANN: Speedee, a web-based notmuch client

2012-07-10 Thread Jameson Graef Rollins
On Mon, Jul 09 2012, Peter Keen wrote: > Over the weekend I threw together the prototype for a web-based notmuch > client named Speedee. It's a little Ruby webapp with a Backbone.js front > end, using Twitter Bootstrap and a free theme from Bootswatch. It doesn't > do much yet. Basically, it can l

ANN: Speedee, a web-based notmuch client

2012-07-10 Thread Jameson Graef Rollins
g and coloring in the show pages, but it's a really nice simple platform to start with. Very nice. Looking forward to watching it develop! jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes De

RE: S/MIME support

2012-07-10 Thread Jameson Graef Rollins
On Mon, Jul 09 2012, "Bryant, Daniel B." wrote: > I was able to get signature verification working with your patchset > (with a caveat) but not decryption. Hi, Daniel. I guess I'm only partially happy to hear that! I definitely do appreciate the feedback, though. > The caveat is that GMime is

S/MIME support

2012-07-10 Thread Jameson Graef Rollins
r some tests that include messages encrypted according to this RFC? I think adding some tests to the test/crypto script would be a great place to start. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120710/7606e81b/attachment-0001.pgp>