LGTM. Alternatively, the test could be
(null (notmuch-wash))
with the correct answer being 't'. That would avoid the awkward
detour through a string, but either way is good as long as this test
passes.
Quoth david at tethera.net on Aug 30 at 10:09 pm:
> From: David Bremner
>
> The behavi
LGTM.
Quoth david at tethera.net on Aug 30 at 8:24 pm:
> From: David Bremner
>
> The version of message.el in emacs24 omits the charset=us-ascii,
> causing the current version of this test to fail. With this patch, we
> accept either option. According to RFC 2046, they are semantically
> equiv
From: David Bremner
The behaviour of "emacsclient --eval nil" changed from emacs23 to
emacs24, and in emacs24 it prints 'nil' rather than an empty string.
(format "%S" foo) produces a sexpr form of foo, and is consistent
between the two versions.
---
This fixes another test failure on emacs24.
LGTM. Alternatively, the test could be
(null (notmuch-wash))
with the correct answer being 't'. That would avoid the awkward
detour through a string, but either way is good as long as this test
passes.
Quoth da...@tethera.net on Aug 30 at 10:09 pm:
> From: David Bremner
>
> The behaviour
LGTM.
Quoth da...@tethera.net on Aug 30 at 8:24 pm:
> From: David Bremner
>
> The version of message.el in emacs24 omits the charset=us-ascii,
> causing the current version of this test to fail. With this patch, we
> accept either option. According to RFC 2046, they are semantically
> equivale
From: David Bremner
The version of message.el in emacs24 omits the charset=us-ascii,
causing the current version of this test to fail. With this patch, we
accept either option. According to RFC 2046, they are semantically
equivalent.
---
as discussed on IRC, the $ is not quite as nice as \b, bu
From: David Bremner
The behaviour of "emacsclient --eval nil" changed from emacs23 to
emacs24, and in emacs24 it prints 'nil' rather than an empty string.
(format "%S" foo) produces a sexpr form of foo, and is consistent
between the two versions.
---
This fixes another test failure on emacs24.
Hi Jameson,
some comments below.
On Mon, Aug 20 2012, Jameson Graef Rollins wrote:
> This new structure holds addresses associated with a thread, both
> matched and unmatched. Initially this will be used to replace the
> existing infrastructure for storing the addresses of thread authors.
> Furt
From: David Bremner
The version of message.el in emacs24 omits the charset=us-ascii,
causing the current version of this test to fail. With this patch, we
accept either option. According to RFC 2046, they are semantically
equivalent.
---
as discussed on IRC, the $ is not quite as nice as \b, bu
On Tue, Aug 28 2012, Michal Nazarewicz wrote:
>> Quoth Michal Nazarewicz on Aug 28 at 2:51 am:
>>> I'm running Emacs compiled from a week old bzr head, emacs-version
>>> reports: ?GNU Emacs 24.2.50.1 (x86_64-unknown-linux-gnu) of 2012-08-21
>>> on mpn-glaptop?.
>>>
>>> I don't think I have any
Hey, Michal. Thanks for the review.
On Thu, Aug 30 2012, Michal Sojka wrote:
>> +/* Construct an addresses string from matched and unmatched addresses
>> + * in notmuch_thread_addresses_t. The string contains matched
>> + * addresses first, then non-matched addresses (with the two groups
>> + *
you might want to talloc_free the old address->string to not waste
> memory in the case of long lived notmuch_thread_addresses_t object. Or
> better use talloc_asprintf_append() function, which hopefully implements
> freeing internally.
This looks like a nice simplification, but see comment above.
I'll look into including these changes in the next version of the
series.
jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120830/ad38d224/attachment.pgp>
Hi Jameson,
some comments below.
On Mon, Aug 20 2012, Jameson Graef Rollins wrote:
> This new structure holds addresses associated with a thread, both
> matched and unmatched. Initially this will be used to replace the
> existing infrastructure for storing the addresses of thread authors.
> Furt
On Tue, Aug 28 2012, Michal Nazarewicz wrote:
>> Quoth Michal Nazarewicz on Aug 28 at 2:51 am:
>>> I'm running Emacs compiled from a week old bzr head, emacs-version
>>> reports: “GNU Emacs 24.2.50.1 (x86_64-unknown-linux-gnu) of 2012-08-21
>>> on mpn-glaptop”.
>>>
>>> I don't think I have any
14 matches
Mail list logo